wangpc-pp wrote:
These branches are created by `spr`, which is out of my control, and we can
merge it into `main` branch via `spr land`. These branches are just magics
behind `spr`, please don't obsess over this. `spr` is a tool that the community
suggests, I have used it for a long time and
https://github.com/wangpc-pp updated
https://github.com/llvm/llvm-project/pull/92871
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/wangpc-pp updated
https://github.com/llvm/llvm-project/pull/92871
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
dc03-work wrote:
> > > > Submit your PRs to `main` branch
> > >
> > >
> > > I used [spr](https://getcord.github.io/spr/) to create this PR, so I
> > > think it's OK.
> >
> >
> > No, your target branch is wrong. Either you should want to merge into
> > `main` or into a branch for another PR
wangpc-pp wrote:
> > > Submit your PRs to `main` branch
> >
> >
> > I used [spr](https://getcord.github.io/spr/) to create this PR, so I think
> > it's OK.
>
> No, your target branch is wrong. Either you should want to merge into `main`
> or into a branch for another PR created by `spr`.
dc03-work wrote:
> > Submit your PRs to `main` branch
>
> I used [spr](https://getcord.github.io/spr/) to create this PR, so I think
> it's OK.
No, your target branch is wrong. Either you should want to merge into `main` or
into a branch for another PR created by `spr`. However, in this case
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/92855
>From 73d456c632a1419c39316d38dcdc358b8e4f9636 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 20 May 2024 01:15:03 -0300
Subject: [PATCH] [clang] Implement CWG2398 provisional TTP matching to class
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/92855
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ldionne approved this pull request.
LGTM. After checking, I think this only impacts `add_lit_testsuites` since we
don't use many other things from `AddLLVM.cmake` in the runtimes.
https://github.com/llvm/llvm-project/pull/89755
___
aaupov wrote:
Please use [BOLT] in the title.
https://github.com/llvm/llvm-project/pull/89742
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/89750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -126,6 +126,7 @@ macro(libomp_test_touch_recipe test_touch_dir)
endmacro()
libomp_append(libomp_test_touch_env "KMP_VERSION=1")
add_custom_target(libomp-test-touch DEPENDS ${libomp_test_touch_targets})
+set_target_properties(libomp-test-touch PROPERTIES FOLDER
@@ -121,7 +123,7 @@ option(BOLT_BUILD_TOOLS
"Build the BOLT tools. If OFF, just generate build targets." ON)
add_custom_target(bolt)
-set_target_properties(bolt PROPERTIES FOLDER "BOLT")
+set_target_properties(bolt PROPERTIES FOLDER "BOLT/Meta")
ayermolo
https://github.com/jhuber6 approved this pull request.
https://github.com/llvm/llvm-project/pull/89755
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89755
>From 0ce849c6e5455577a77f4c25d08e8ec83115a290 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:29:28 +0200
Subject: [PATCH 1/2] Revise IDE folder structure
---
@@ -9,6 +9,7 @@ include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
include(${LLVM_COMMON_CMAKE_UTILS}/Modules/LLVMVersion.cmake)
project(Runtimes C CXX ASM)
+set(LLVM_SUBPROJECT_TITLE "Runtimes")
Meinersbur wrote:
Since LLVM is usually the
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89750
>From c3edd260d7a917e120d02253083eb472e0985844 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:27:20 +0200
Subject: [PATCH 1/3] [openmp] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89746
>From 61ffad5a99c584ddb05a32b5d5bf54ecbf6c774b Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 21 May 2024 22:32:39 +0200
Subject: [PATCH] [libclc] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89753
>From 19ef183fcfb44fa8b9bae34bdc8eafb8d2425722 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:15:38 +0200
Subject: [PATCH 1/5] [compiler-rt] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89753
>From 19ef183fcfb44fa8b9bae34bdc8eafb8d2425722 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:15:38 +0200
Subject: [PATCH 1/4] [compiler-rt] Revise IDE folder structure
---
llvmbot wrote:
@llvm/pr-subscribers-bolt
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the BOLT part. See #89153 for the entire series and
motivation.
Update the folder titles for targets in the
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89743
>From afadef1f53e03e2cf3a1695f3c693913b27382dd Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:03:11 +0200
Subject: [PATCH 1/3] [clang] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89748
>From e29002224ef168934ae414e75e765cf197f65bc0 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:21:43 +0200
Subject: [PATCH 1/3] [lldb] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89750
>From c3edd260d7a917e120d02253083eb472e0985844 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:27:20 +0200
Subject: [PATCH 1/2] [openmp] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89752
>From a85a17723d76371ccc8feb245c455d6aaf2c297f Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:19:16 +0200
Subject: [PATCH 1/2] [polly] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89755
>From 0ce849c6e5455577a77f4c25d08e8ec83115a290 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:29:28 +0200
Subject: [PATCH] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89742
>From 140a539c9e3248b128bdffdbc9ae5e2e8b4366c0 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:23:47 +0200
Subject: [PATCH 1/2] [bolt] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89745
>From 90d0d0f3bed2d826dc38e962a7a9140bf2ff3615 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:13:53 +0200
Subject: [PATCH 1/2] [flang] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89749
>From 82bac5ccd7d6d2b4e146ed4e383a8484e735606e Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:08:54 +0200
Subject: [PATCH 1/2] [mlir] Revise IDE folder structure
---
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89747
>From 6c3206c8100ed68ab77ceb98741bef42659bcfc1 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:12:03 +0200
Subject: [PATCH] [lld] Revise IDE folder structure
---
lld/CMakeLists.txt
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/89744
>From 937a7728542d880fd37c439bec6dca4ccd3f07d2 Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Tue, 23 Apr 2024 13:06:06 +0200
Subject: [PATCH] [clang-tools-extra] Revise IDE folder structure
---
https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/89749
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/89467
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/89467
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
wangpc-pp wrote:
> Submit your PRs to `main` branch
I used [spr](https://getcord.github.io/spr/) to create this PR, so I think it's
OK.
https://github.com/llvm/llvm-project/pull/92871
___
llvm-branch-commits mailing list
https://github.com/medismailben approved this pull request.
Nice! LGTM!
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/asl requested changes to this pull request.
Submit your PRs to `main` branch
https://github.com/llvm/llvm-project/pull/92871
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/92825
>From 0b9155faf2dc063f81091c8e78d14dd4446c2db5 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 21 May 2024 09:58:46 -0700
Subject: [PATCH] Fix fallthrough and update comment
Created using spr 1.3.4
---
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/92825
>From 0b9155faf2dc063f81091c8e78d14dd4446c2db5 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 21 May 2024 09:58:46 -0700
Subject: [PATCH] Fix fallthrough and update comment
Created using spr 1.3.4
---
@@ -5779,6 +5779,80 @@ class OMPReverseDirective final : public
OMPLoopTransformationDirective {
}
};
+/// Represents the '#pragma omp interchange' loop transformation directive.
+///
+/// \code{c}
+/// #pragma omp interchange
+/// for (int i = 0; i < m; ++i)
+///
@@ -5711,6 +5712,71 @@ class OMPUnrollDirective final : public
OMPLoopTransformationDirective {
}
};
+/// Represents the '#pragma omp reverse' loop transformation directive.
+///
+/// \code
+/// #pragma omp reverse
+/// for (int i = 0; i < n; ++i)
+/// ...
+/// \endcode
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/92825
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -51,6 +52,7 @@ add_clang_library(clangTidyMiscModule
genconfusable
ClangDriverOptions
)
+set_target_properties(clangTidyMiscModule PROPERTIES FOLDER "Clang Tools
Extra/Libraries")
PiotrZSL wrote:
why this is set for Misc module, but not for other
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/89744
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/PiotrZSL commented:
For me this entire change doesn't make sense.
https://github.com/llvm/llvm-project/pull/89744
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/92825
>From 0b9155faf2dc063f81091c8e78d14dd4446c2db5 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Tue, 21 May 2024 09:58:46 -0700
Subject: [PATCH] Fix fallthrough and update comment
Created using spr 1.3.4
---
@@ -9,6 +9,7 @@ include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
include(${LLVM_COMMON_CMAKE_UTILS}/Modules/LLVMVersion.cmake)
project(Runtimes C CXX ASM)
+set(LLVM_SUBPROJECT_TITLE "Runtimes")
jhuber6 wrote:
Is this needed? My understanding is
https://github.com/nickdesaulniers approved this pull request.
libc parts LGTM
https://github.com/llvm/llvm-project/pull/89755
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-libcxx
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the part for the remaining subprojects that have just one file
changed each. For the runtime subprojects this is
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the LLDB part. See #89153 for the entire series and
motivation.
Update the folder titles for targets in the
llvmbot wrote:
@llvm/pr-subscribers-offload
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the OpenMP part. See #89153 for the entire series and
motivation.
Update the folder titles for targets in the
llvmbot wrote:
@llvm/pr-subscribers-mlir
@llvm/pr-subscribers-mlir-core
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the MLIR part. See #89153 for the entire series and
motivation.
Update the folder
llvmbot wrote:
@llvm/pr-subscribers-lld
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the LLD part. See #89153 for the entire series and
motivation.
Update the folder titles for targets in the
llvmbot wrote:
@llvm/pr-subscribers-flang-fir-hlfir
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the Flang part. See #89153 for the entire series and
motivation.
Update the folder titles for targets
llvmbot wrote:
@llvm/pr-subscribers-pgo
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the Compiler-RT part. See #89153 for the entire series
and motivation.
Update the folder titles for targets in the
llvmbot wrote:
@llvm/pr-subscribers-flang-runtime
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the Flang part. See #89153 for the entire series and
motivation.
Update the folder titles for targets in
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89752
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Michael Kruse (Meinersbur)
Changes
Reviewers of #89153 suggested to break up the patch into per-subproject
patches. This is the Clang-tools-extra part. See #89153 for the entire
series and motivation.
Update the folder titles for
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89755
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89750
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89749
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89747
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89746
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89745
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89753
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/89744
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Meinersbur wrote:
> Oh the fun of PR numbers now lining up with Phabricator numbers. I thought
> you meant https://reviews.llvm.org/D89741 and was very confused until I saw
> #89741. :-D I'll take a look!
Well, seems I still have muscle memory from Phabricator times :-)
Thanks for the
@@ -5711,6 +5712,73 @@ class OMPUnrollDirective final : public
OMPLoopTransformationDirective {
}
};
+/// Represents the '#pragma omp reverse' loop transformation directive.
+///
+/// \code
+/// #pragma omp reverse
+/// for (int i = 0; i < n; ++i)
+/// ...
+/// \endcode
@@ -6546,6 +6547,10 @@ StmtResult SemaOpenMP::ActOnOpenMPExecutableDirective(
Res = ActOnOpenMPUnrollDirective(ClausesWithImplicit, AStmt, StartLoc,
EndLoc);
break;
+ case OMPD_reverse:
+Res =
mizvekov wrote:
> I don't quite get the justification for this, but also don't see any downside
> for it, so I think this is acceptable.
It's unfortunate GitHub does not show a PR stack like phab did.
This is needed for another patch you already reviewed:
https://github.com/Meinersbur edited
https://github.com/llvm/llvm-project/pull/92030
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Kruse (Meinersbur)
Changes
Add the reverse directive which will be introduced in the upcoming OpenMP 6.0
specification. A preview has been published in [Technical Report
llvmbot wrote:
@llvm/pr-subscribers-flang-openmp
@llvm/pr-subscribers-clang-modules
Author: Michael Kruse (Meinersbur)
Changes
Add the reverse directive which will be introduced in the upcoming OpenMP 6.0
specification. A preview has been published in [Technical Report
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/92916
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Meinersbur wrote:
Extracted out the reverse part into #92916
https://github.com/llvm/llvm-project/pull/92030
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur edited
https://github.com/llvm/llvm-project/pull/92030
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur edited
https://github.com/llvm/llvm-project/pull/92030
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur edited
https://github.com/llvm/llvm-project/pull/92030
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
I don't quite get the justification for this, but also don't see any downside
for it, so I think this is acceptable.
https://github.com/llvm/llvm-project/pull/92854
___
llvm-branch-commits
https://github.com/erichkeane approved this pull request.
Seems reasonable, lgtm.
https://github.com/llvm/llvm-project/pull/92855
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://github.com/AaronBallman approved this pull request.
I verified the layout seems reasonable in Visual Studio 2022; LGTM!
https://github.com/llvm/llvm-project/pull/89743
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
AaronBallman wrote:
> @AaronBallman Would you mind reviewing D89741 ? I was convinced a stakeholder
> there but they decided to drop out instead of approving it.
Oh the fun of PR numbers now lining up with Phabricator numbers. I thought you
meant https://reviews.llvm.org/D89741 and was very
Meinersbur wrote:
@AaronBallman Would you mind reviewing D89741 ? I was convinced a stakeholder
there but they decided to drop out instead of approving it.
https://github.com/llvm/llvm-project/pull/89743
___
llvm-branch-commits mailing list
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/92854
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Endilll commented:
LGTM, but you should wait for someone with more knowledge of our templates.
https://github.com/llvm/llvm-project/pull/92854
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Pengcheng Wang (wangpc-pp)
Changes
This doesn't take effect as we have overrided `enablePostRAScheduler`
and we should use the `FeaturePostRAScheduler` feature in processor
definitions.
---
Full diff:
https://github.com/wangpc-pp created
https://github.com/llvm/llvm-project/pull/92871
This doesn't take effect as we have overrided `enablePostRAScheduler`
and we should use the `FeaturePostRAScheduler` feature in processor
definitions.
___
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/92854
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -10082,7 +10082,9 @@ class Sema final : public SemaBase {
bool SubstTemplateArgument(const TemplateArgumentLoc ,
const MultiLevelTemplateArgumentList
,
- TemplateArgumentLoc );
+
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/92854
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -10082,7 +10082,9 @@ class Sema final : public SemaBase {
bool SubstTemplateArgument(const TemplateArgumentLoc ,
const MultiLevelTemplateArgumentList
,
- TemplateArgumentLoc );
+
https://github.com/Endilll commented:
It looks like you have two sets of changes here:
1) the ones related to `TemplateTypeParmDecl::getDefaultArgument()`
2) the ones related to `Sema::SubstTemplateArgument()`
You don't seem to touch the latter in PR description. It would be nice if you
can
@@ -10082,7 +10082,9 @@ class Sema final : public SemaBase {
bool SubstTemplateArgument(const TemplateArgumentLoc ,
const MultiLevelTemplateArgumentList
,
- TemplateArgumentLoc );
+
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/92854
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
97 matches
Mail list logo
