llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Igor Kudrin (igorkudrin)
Changes
For synchronous unwind tables, the call frame information can be slightly
reduced by bundling the `.cfi_negate_ra_state` instruction with other CFI
instructions in the prolog, saving 1 byte per f
https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/96377
For synchronous unwind tables, the call frame information can be slightly
reduced by bundling the `.cfi_negate_ra_state` instruction with other CFI
instructions in the prolog, saving 1 byte per function used
https://github.com/koachan updated
https://github.com/llvm/llvm-project/pull/96020
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/koachan updated
https://github.com/llvm/llvm-project/pull/96020
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
MaskRay wrote:
Due to ASLR and malloc non-determinism, `DenseMap` already introduces a
lot of non-determinism to release builds.
`DenseMap` issues are less pronounced compared with `DenseMap`.
> I'm a little concerned that doing this in release builds is going to lead to
> weird bug reports
I
Author: Kiran Chandramohan
Date: 2024-06-21T23:45:46+01:00
New Revision: 2a4add4de4d882fbf3e9d75b2a6a7609687a7890
URL:
https://github.com/llvm/llvm-project/commit/2a4add4de4d882fbf3e9d75b2a6a7609687a7890
DIFF:
https://github.com/llvm/llvm-project/commit/2a4add4de4d882fbf3e9d75b2a6a7609687a7890.
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95821
>From 92212c96ea169d26ac10bf8d750539bc5dd72c49 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Mon, 17 Jun 2024 15:39:02 -0700
Subject: [PATCH 01/18] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YA
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95821
>From 92212c96ea169d26ac10bf8d750539bc5dd72c49 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Mon, 17 Jun 2024 15:39:02 -0700
Subject: [PATCH 01/17] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YA
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95821
>From 92212c96ea169d26ac10bf8d750539bc5dd72c49 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Mon, 17 Jun 2024 15:39:02 -0700
Subject: [PATCH 01/16] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YA
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95821
>From 92212c96ea169d26ac10bf8d750539bc5dd72c49 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Mon, 17 Jun 2024 15:39:02 -0700
Subject: [PATCH 01/15] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YA
https://github.com/shawbyoung edited
https://github.com/llvm/llvm-project/pull/95821
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1161,4 +1165,4 @@
- `--print-options`
- Print non-default options after command line parsing
shawbyoung wrote:
Didn't touch this line - diff return nothing when applied to "added" and
"deleted" line - maybe it's some git corner case?
https://github.co
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95884
>From 34652b2eebc62218c50a23509ce99937385c30e6 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Thu, 20 Jun 2024 23:42:00 -0700
Subject: [PATCH 1/6] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YAML
efriedma-quic wrote:
We restricted reverse-iteration when we added it just to save time when we were
enabling it: we wanted to prioritize issues that were actually likely to cause
non-determinism (as opposed to relying on the hash algorithm, which is annoying
but not actually non-deterministic
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95884
>From 34652b2eebc62218c50a23509ce99937385c30e6 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Thu, 20 Jun 2024 23:42:00 -0700
Subject: [PATCH 1/5] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YAML
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95884
>From 34652b2eebc62218c50a23509ce99937385c30e6 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Thu, 20 Jun 2024 23:42:00 -0700
Subject: [PATCH 1/4] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YAML
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95884
>From 34652b2eebc62218c50a23509ce99937385c30e6 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Thu, 20 Jun 2024 23:42:00 -0700
Subject: [PATCH 1/3] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YAML
mizvekov wrote:
@ldionne I had to adjust the libcxx expectation change.
The simple regex won't work, as the error diagnostic is now produced in
different source locations.
I have changed it so it uses a preprocessor conditional, but that new solution
will still break if libcxx-CI is using an
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95884
>From 34652b2eebc62218c50a23509ce99937385c30e6 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Thu, 20 Jun 2024 23:42:00 -0700
Subject: [PATCH 1/3] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YAML
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/96023
>From e5df11098caf4500b6cb3e2de8f9c927b609955a Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 17 Jun 2024 21:39:08 -0300
Subject: [PATCH] [clang] Finish implementation of P0522
This finishes the clan
@@ -374,15 +393,34 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) {
// the profile.
Function.setExecutionCount(BinaryFunction::COUNT_NO_PROFILE);
-// Recompute hash once per function.
-if (!opts::IgnoreHash)
- Function.computeHash(YamlBP.Header
@@ -374,15 +393,34 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) {
// the profile.
Function.setExecutionCount(BinaryFunction::COUNT_NO_PROFILE);
-// Recompute hash once per function.
-if (!opts::IgnoreHash)
- Function.computeHash(YamlBP.Header
Author: Paul Kirth
Date: 2024-06-21T13:17:41-07:00
New Revision: d9075144100406eed753f1b7ca3df933a596bb3a
URL:
https://github.com/llvm/llvm-project/commit/d9075144100406eed753f1b7ca3df933a596bb3a
DIFF:
https://github.com/llvm/llvm-project/commit/d9075144100406eed753f1b7ca3df933a596bb3a.diff
LO
@@ -363,9 +364,27 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) {
return Profile.Hash == static_cast(BF.getHash());
};
- // We have to do 2 passes since LTO introduces an ambiguity in function
- // names. The first pass assigns profiles that match 100% by
@@ -2982,6 +2983,9 @@ void RewriteInstance::selectFunctionsToProcess() {
if (mustSkip(Function))
return false;
+if (opts::MatchingFunctionsWithHash)
+ return true;
aaupov wrote:
Since we're forcing the processing of all functions here to co
@@ -128,6 +128,11 @@ cl::opt
cl::desc("instrument code to generate accurate profile data"),
cl::cat(BoltOptCategory));
+cl::opt
+MatchingFunctionsWithHash("stale-matching-matching-functions-with-hash",
+ cl::desc("
@@ -1161,4 +1165,4 @@
- `--print-options`
- Print non-default options after command line parsing
aaupov wrote:
nit: please avoid unrelated changes
https://github.com/llvm/llvm-project/pull/95821
___
llvm-branch-c
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/95884
>From 34652b2eebc62218c50a23509ce99937385c30e6 Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Thu, 20 Jun 2024 23:42:00 -0700
Subject: [PATCH 1/3] spr amend
Created using spr 1.3.4
---
bolt/lib/Profile/YAML
https://github.com/ahmedbougacha reopened
https://github.com/llvm/llvm-project/pull/94056
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/shawbyoung deleted
https://github.com/llvm/llvm-project/pull/95884
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -415,6 +422,75 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) {
if (!YamlBF.Used && BF && !ProfiledFunctions.count(BF))
matchProfileToFunction(YamlBF, *BF);
+ // Uses name similarity to match functions that were not matched by name.
+ uint64_t Matche
https://github.com/ahatanak closed
https://github.com/llvm/llvm-project/pull/94056
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ahatanak closed
https://github.com/llvm/llvm-project/pull/95203
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-mlir-core
Author: Matthias Springer (matthias-springer)
Changes
This commit moves the argument materialization logic from
`legalizeConvertedArgumentTypes` to `legalizeUnresolvedMaterializations`.
Before this change:
- Argument materializations were cre
llvmbot wrote:
@llvm/pr-subscribers-mlir
Author: Matthias Springer (matthias-springer)
Changes
This commit moves the argument materialization logic from
`legalizeConvertedArgumentTypes` to `legalizeUnresolvedMaterializations`.
Before this change:
- Argument materializations were created
https://github.com/matthias-springer created
https://github.com/llvm/llvm-project/pull/96329
This commit moves the argument materialization logic from
`legalizeConvertedArgumentTypes` to `legalizeUnresolvedMaterializations`.
Before this change:
- Argument materializations were created in `lega
@@ -415,6 +422,75 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) {
if (!YamlBF.Used && BF && !ProfiledFunctions.count(BF))
matchProfileToFunction(YamlBF, *BF);
+ // Uses name similarity to match functions that were not matched by name.
+ uint64_t Matche
@@ -415,6 +422,75 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) {
if (!YamlBF.Used && BF && !ProfiledFunctions.count(BF))
matchProfileToFunction(YamlBF, *BF);
+ // Uses name similarity to match functions that were not matched by name.
+ uint64_t Matche
https://github.com/aaupov commented:
Can you please also note the runtime of the namespace-filtered pairwise checks?
This would guide us in whether to add a BB count filtering.
https://github.com/llvm/llvm-project/pull/95884
___
llvm-branch-commits ma
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/95884
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -415,6 +422,75 @@ Error YAMLProfileReader::readProfile(BinaryContext &BC) {
if (!YamlBF.Used && BF && !ProfiledFunctions.count(BF))
matchProfileToFunction(YamlBF, *BF);
+ // Uses name similarity to match functions that were not matched by name.
+ uint64_t Matche
@@ -1085,13 +1085,24 @@ ParseStatus SparcAsmParser::parseASITag(OperandVector
&Operands) {
SMLoc E = Parser.getTok().getEndLoc();
int64_t ASIVal = 0;
- if (is64Bit() && (getLexer().getKind() == AsmToken::Hash)) {
+ switch (getLexer().getKind()) {
+ case AsmToken::LPare
@@ -1085,13 +1085,24 @@ ParseStatus SparcAsmParser::parseASITag(OperandVector
&Operands) {
SMLoc E = Parser.getTok().getEndLoc();
int64_t ASIVal = 0;
- if (is64Bit() && (getLexer().getKind() == AsmToken::Hash)) {
+ switch (getLexer().getKind()) {
+ case AsmToken::LPare
agozillon wrote:
Hi, I believe in this case it is at the point of being minimal, I could reduce
it to 1 of the 4 test cases if you wish keeping the most complicated or if you
have any other suggestions on how to reduce it I would be more than happy to
adjust
@@ -3480,6 +3480,31 @@ DiagnosedSilenceableFailure
transform::MapCopyToThreadsOp::applyToOne(
return DiagnosedSilenceableFailure::success();
}
+//===--===//
+// WinogradConv2DOp
+//===--
@@ -2587,4 +2587,55 @@ def MapCopyToThreadsOp :
}];
}
+//===--===//
+// Winograd Conv2D
+//===--===//
+
+def WinogradConv2DOp : Op {
+ let
@@ -0,0 +1,88 @@
+// RUN: mlir-opt %s -transform-interpreter -canonicalize --split-input-file |
FileCheck %s
+
+func.func @conv2d(%arg0: tensor<2x10x10x5xf32>, %arg1: tensor<2x3x3x5xf32>,
%arg2: tensor<1xf32>) -> tensor<2x8x8x2xf32> {
+ %0 = tensor.empty() : tensor<2x8x8x2xf32>
@@ -0,0 +1,88 @@
+// RUN: mlir-opt %s -transform-interpreter -canonicalize --split-input-file |
FileCheck %s
+
+func.func @conv2d(%arg0: tensor<2x10x10x5xf32>, %arg1: tensor<2x3x3x5xf32>,
%arg2: tensor<1xf32>) -> tensor<2x8x8x2xf32> {
+ %0 = tensor.empty() : tensor<2x8x8x2xf32>
@@ -3480,6 +3480,31 @@ DiagnosedSilenceableFailure
transform::MapCopyToThreadsOp::applyToOne(
return DiagnosedSilenceableFailure::success();
}
+//===--===//
+// WinogradConv2DOp
+//===--
@@ -2587,4 +2587,55 @@ def MapCopyToThreadsOp :
}];
}
+//===--===//
+// Winograd Conv2D
+//===--===//
+
+def WinogradConv2DOp : Op {
+ let
https://github.com/arsenm commented:
Another strategy that might simplify the patterns is to always select the _ec
versions, and then later swap to the non-ec versions if xnack is disabled
https://github.com/llvm/llvm-project/pull/96163
___
llvm-bran
@@ -867,13 +867,104 @@ def SMRDBufferImm : ComplexPattern;
def SMRDBufferImm32 : ComplexPattern;
def SMRDBufferSgprImm : ComplexPattern;
+class SMRDAlignedLoadPat : PatFrag <(ops node:$ptr), (Op
node:$ptr), [{
+ // Returns true if it is a naturally aligned multi-dword load
@@ -886,26 +977,17 @@ multiclass SMRD_Pattern {
def : GCNPat <
(smrd_load (SMRDSgpr i64:$sbase, i32:$soffset)),
(vt (!cast(Instr#"_SGPR") $sbase, $soffset, 0))> {
-let OtherPredicates = [isNotGFX9Plus];
- }
- def : GCNPat <
-(smrd_load (SMRDSgpr i64:$sbase,
@@ -867,13 +867,104 @@ def SMRDBufferImm : ComplexPattern;
def SMRDBufferImm32 : ComplexPattern;
def SMRDBufferSgprImm : ComplexPattern;
+class SMRDAlignedLoadPat : PatFrag <(ops node:$ptr), (Op
node:$ptr), [{
+ // Returns true if it is a naturally aligned multi-dword load
@@ -867,13 +867,104 @@ def SMRDBufferImm : ComplexPattern;
def SMRDBufferImm32 : ComplexPattern;
def SMRDBufferSgprImm : ComplexPattern;
+class SMRDAlignedLoadPat : PatFrag <(ops node:$ptr), (Op
node:$ptr), [{
+ // Returns true if it is a naturally aligned multi-dword load
https://github.com/arsenm commented:
In a separate patch, we should add a verifier check that you used the correct
tied version depending on whether xnack is enabled or not
https://github.com/llvm/llvm-project/pull/96163
___
llvm-branch-commits maili
Dinistro wrote:
Please reduce this test to the absolute minimum that still tests your change.
The IR does not need to compute anything useful, but the test should fail when
you would revert only your C++ changes.
Additionally, try to reduce the `CHECK`s to a
MaskRay wrote:
> I like the idea, but I'm not sure this should be always enabled. This sounds
> like a lot of debugging fun when a seed-dependent case is not caught in
> testing.
>
> Can we have this part of LLVM_REVERSE_ITERATION instead, which is used to
> detect similar hash iteration stab
https://github.com/nikic commented:
I like the idea, but I'm not sure this should be always enabled. This sounds
like a lot of debugging fun when a seed-dependent case is not caught in testing.
Can we have this part of LLVM_REVERSE_ITERATION instead, which is used to
detect similar hash iterat
59 matches
Mail list logo
