@@ -85,67 +135,227 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -85,67 +135,227 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -219,6 +430,33 @@ class OMPMapInfoFinalizationPass
mapClauseOwner.getMapOperandsMutable().assign(newMapOps);
agozillon wrote:
It shouldn't (at least if I am understanding your comment correctly), I believe
this little snippet misses the preceding block o
https://github.com/agozillon edited
https://github.com/llvm/llvm-project/pull/96266
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/agozillon commented:
Answered a couple more of the review comments to hopefully help explain things
a little bit better! I'll try to update this PR stack on Friday to reflect all
the current review comments, thank you very much for your time and help @ergawy
:-)
https://g
Author: aaryanshukla
Date: 2024-07-17T17:16:43-07:00
New Revision: 472dfe7d8af66a2a0c9d9a83ffb26b4aacff17fd
URL:
https://github.com/llvm/llvm-project/commit/472dfe7d8af66a2a0c9d9a83ffb26b4aacff17fd
DIFF:
https://github.com/llvm/llvm-project/commit/472dfe7d8af66a2a0c9d9a83ffb26b4aacff17fd.diff
Author: aaryanshukla
Date: 2024-07-17T17:16:23-07:00
New Revision: aff9c628a0d9efab790186b5d683196b900318f6
URL:
https://github.com/llvm/llvm-project/commit/aff9c628a0d9efab790186b5d683196b900318f6
DIFF:
https://github.com/llvm/llvm-project/commit/aff9c628a0d9efab790186b5d683196b900318f6.diff
Author: aaryanshukla
Date: 2024-07-17T17:15:01-07:00
New Revision: d0b2fea44b78ef5f60ecfcaecee9d704d1cdea80
URL:
https://github.com/llvm/llvm-project/commit/d0b2fea44b78ef5f60ecfcaecee9d704d1cdea80
DIFF:
https://github.com/llvm/llvm-project/commit/d0b2fea44b78ef5f60ecfcaecee9d704d1cdea80.diff
Author: Teresa Johnson
Date: 2024-07-17T14:00:53-07:00
New Revision: 109ff32145687a96e7ef72f9d4f8f3bf45fe2b17
URL:
https://github.com/llvm/llvm-project/commit/109ff32145687a96e7ef72f9d4f8f3bf45fe2b17
DIFF:
https://github.com/llvm/llvm-project/commit/109ff32145687a96e7ef72f9d4f8f3bf45fe2b17.diff
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/99285
>From 08760faf31683e8372322305846465a810198ce3 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Mon, 15 Jul 2024 15:01:39 -0700
Subject: [PATCH] add CoroAnnotationElidePass
---
.../Coroutines/CoroAnnotat
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/99283
>From 7c14a807d0140c638b056a59a9c8c3f9fcf90e57 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Mon, 15 Jul 2024 15:01:39 -0700
Subject: [PATCH] Implement noalloc in CoroSplit
---
llvm/lib/Transforms/Cor
llvmbot wrote:
@llvm/pr-subscribers-libcxx
Author: Mark de Wever (mordante)
Changes
Implements parts of:
- P1902R1 Missing feature-test macros 2017-2019
Completes:
- P1614R2 The Mothership has Landed
---
Full diff: https://github.com/llvm/llvm-project/pull/99375.diff
9 Files Affected:
https://github.com/mordante milestoned
https://github.com/llvm/llvm-project/pull/99375
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/mordante created
https://github.com/llvm/llvm-project/pull/99375
Implements parts of:
- P1902R1 Missing feature-test macros 2017-2019
Completes:
- P1614R2 The Mothership has Landed
>From b71feb3626ccbda30d6ec8e2788c7442cf4679f9 Mon Sep 17 00:00:00 2001
From: Mark de Wever
D
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/98125
>From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Tue, 9 Jul 2024 10:04:25 -0700
Subject: [PATCH 01/15] Comments
Created using spr 1.3.4
---
bolt/lib/Profile/YAML
https://github.com/shawbyoung updated
https://github.com/llvm/llvm-project/pull/98125
>From cf32a43e7c2b04079c6123fe13df4fb7226d771f Mon Sep 17 00:00:00 2001
From: shawbyoung
Date: Tue, 9 Jul 2024 10:04:25 -0700
Subject: [PATCH 01/14] Comments
Created using spr 1.3.4
---
bolt/lib/Profile/YAML
@@ -43,6 +43,57 @@ class YAMLProfileReader : public ProfileReaderBase {
using ProfileLookupMap =
DenseMap;
+ /// A class for matching binary functions in functions in the YAML profile.
+ /// First, a call graph is constructed for both profiled and binary
functions.
https://github.com/aaupov approved this pull request.
LG with a couple of nits
https://github.com/llvm/llvm-project/pull/98125
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-
@@ -43,6 +43,57 @@ class YAMLProfileReader : public ProfileReaderBase {
using ProfileLookupMap =
DenseMap;
+ /// A class for matching binary functions in functions in the YAML profile.
+ /// First, a call graph is constructed for both profiled and binary
functions.
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/98125
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
cdevadas wrote:
> I still think it is terribly surprising all of the test diff shows up in this
> commit, and not the selection case
Because the selection support is done in the next PR of the review stack,
https://github.com/llvm/llvm-project/pull/96162. This patch takes care of
choosing the
https://github.com/arsenm approved this pull request.
I still think it is terribly surprising all of the test diff shows up in this
commit, and not the selection case
https://github.com/llvm/llvm-project/pull/96162
___
llvm-branch-commits mailing lis
@@ -85,67 +135,227 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -85,67 +135,227 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -219,6 +430,33 @@ class OMPMapInfoFinalizationPass
mapClauseOwner.getMapOperandsMutable().assign(newMapOps);
ergawy wrote:
Not part of the PR (sorry for the extra comments), but I have a feeling
something is not correct here. Doesn't this line overwrite
@@ -85,67 +135,227 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
@@ -85,67 +135,227 @@ class OMPMapInfoFinalizationPass
descriptor = alloca;
}
+return descriptor;
+ }
+
+ /// Simple function that will generate a FIR operation accessing
+ /// the descriptors base address (BoxOffsetOp) and then generate a
+ /// MapInfoOp for
https://github.com/yuxuanchen1997 created
https://github.com/llvm/llvm-project/pull/99283
This patch is the middle end implementation for the coroutine HALO improvement
project published on discourse:
https://discourse.llvm.org/t/language-extension-for-better-more-deterministic-halo-for-c-coro
28 matches
Mail list logo