[llvm-branch-commits] [llvm] release/19.x: [AMDGPU] Disable inline constants for pseudo scalar transcendentals (#104395) (PR #105472)

2024-08-20 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/105472 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [SPARC] Remove assertions in printOperand for inline asm operands (#104692) (PR #105096)

2024-08-20 Thread Sergei Barannikov via llvm-branch-commits
https://github.com/s-barannikov approved this pull request. https://github.com/llvm/llvm-project/pull/105096 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [SPARC] Remove assertions in printOperand for inline asm operands (#104692) (PR #105096)

2024-08-20 Thread Sergei Barannikov via llvm-branch-commits
s-barannikov wrote: > LGTM. This is the backport to 19 right? Yes https://github.com/llvm/llvm-project/pull/105096 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [llvm] release/19.x: [SPARC] Remove assertions in printOperand for inline asm operands (#104692) (PR #105096)

2024-08-20 Thread via llvm-branch-commits
https://github.com/koachan approved this pull request. LGTM. This is the backport to 19 right? https://github.com/llvm/llvm-project/pull/105096 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[llvm-branch-commits] [llvm] [DirectX] Register a few DXIL passes with the new PM (PR #104250)

2024-08-20 Thread Justin Bogner via llvm-branch-commits
@@ -46,14 +46,14 @@ define void @test_typedbuffer() { ; Buffer Buf[24] : register(t3, space5) %typed2 = call target("dx.TypedBuffer", <4 x i32>, 0, 0, 0) @llvm.dx.handle.fromBinding.tdx.TypedBuffer_i32_0_0t( - i32 2, i32 7, i32 24, i32 0, i1 false) +

[llvm-branch-commits] [llvm] use default intrinsic attrs for BPF packet loads (PR #105314)

2024-08-20 Thread Nikita Popov via llvm-branch-commits
https://github.com/nikic milestoned https://github.com/llvm/llvm-project/pull/105314 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] use default intrinsic attrs for BPF packet loads (PR #105314)

2024-08-20 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Bryce Kahle (brycekahle) Changes The BPF packet load intrinsics lost attribute WillReturn due to 0b20c30. The attribute loss causes excessive bitshifting, resulting in previously working programs failing the BPF verifier due to instruct

[llvm-branch-commits] [llvm] use default intrinsic attrs for BPF packet loads (PR #105314)

2024-08-20 Thread via llvm-branch-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[llvm-branch-commits] [llvm] use default intrinsic attrs for BPF packet loads (PR #105314)

2024-08-20 Thread Bryce Kahle via llvm-branch-commits
https://github.com/brycekahle created https://github.com/llvm/llvm-project/pull/105314 The BPF packet load intrinsics lost attribute WillReturn due to 0b20c30. The attribute loss causes excessive bitshifting, resulting in previously working programs failing the BPF verifier due to instruction/

[llvm-branch-commits] [llvm] AMDGPU/NewPM: Start filling out addIRPasses (PR #102884)

2024-08-20 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **Aug 20, 3:25 PM EDT**: @arsenm started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/102884). https://github.com/llvm/llvm-project/pull/102884

[llvm-branch-commits] [llvm] [MC][NFC] Reduce Address2ProbesMap size (PR #102904)

2024-08-20 Thread Amir Ayupov via llvm-branch-commits
aaupov wrote: > > For RSS, it's probably because in llvm-profgen, we decoded the pseudo-probe > > only for profiled function(https://reviews.llvm.org/D121643), so the > > baseline memory is decreased. > > > > @aaupov actually do we need to decode profile for functions without profile? > tha

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

2024-08-20 Thread David Peixotto via llvm-branch-commits
@@ -0,0 +1,102 @@ +; RUN: opt -S -dxil-op-lower %s | FileCheck %s + +target triple = "dxil-pc-shadermodel6.6-compute" + +declare void @scalar_user(float) +declare void @vector_user(<4 x float>) + +define void @loadfloats() { + ; CHECK: [[BIND:%.*]] = call %dx.types.Handle @dx.op.

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

2024-08-20 Thread David Peixotto via llvm-branch-commits
@@ -236,6 +236,59 @@ class OpLowerer { lowerToBindAndAnnotateHandle(F); } + void lowerTypedBufferLoad(Function &F) { +IRBuilder<> &IRB = OpBuilder.getIRB(); +Type *Int32Ty = IRB.getInt32Ty(); + +replaceFunction(F, [&](CallInst *CI) -> Error { + IRB.Se

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

2024-08-20 Thread David Peixotto via llvm-branch-commits
@@ -0,0 +1,102 @@ +; RUN: opt -S -dxil-op-lower %s | FileCheck %s + +target triple = "dxil-pc-shadermodel6.6-compute" + +declare void @scalar_user(float) +declare void @vector_user(<4 x float>) + +define void @loadfloats() { + ; CHECK: [[BIND:%.*]] = call %dx.types.Handle @dx.op.

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

2024-08-20 Thread David Peixotto via llvm-branch-commits
@@ -0,0 +1,102 @@ +; RUN: opt -S -dxil-op-lower %s | FileCheck %s + +target triple = "dxil-pc-shadermodel6.6-compute" + +declare void @scalar_user(float) +declare void @vector_user(<4 x float>) + +define void @loadfloats() { + ; CHECK: [[BIND:%.*]] = call %dx.types.Handle @dx.op.

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

2024-08-20 Thread David Peixotto via llvm-branch-commits
@@ -0,0 +1,102 @@ +; RUN: opt -S -dxil-op-lower %s | FileCheck %s + +target triple = "dxil-pc-shadermodel6.6-compute" + +declare void @scalar_user(float) +declare void @vector_user(<4 x float>) + +define void @loadfloats() { + ; CHECK: [[BIND:%.*]] = call %dx.types.Handle @dx.op.

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

2024-08-20 Thread David Peixotto via llvm-branch-commits
@@ -683,6 +686,17 @@ def CreateHandle : DXILOp<57, createHandle> { let stages = [Stages]; } +def BufferLoad : DXILOp<68, bufferLoad> { + let Doc = "reads from a TypedBuffer"; + // Handle, Coord0, Coord1 + let arguments = [HandleTy, Int32Ty, Int32Ty]; + let result = Overl

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

2024-08-20 Thread David Peixotto via llvm-branch-commits
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/104252 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

2024-08-20 Thread David Peixotto via llvm-branch-commits
https://github.com/dmpots approved this pull request. Overall, LGTM https://github.com/llvm/llvm-project/pull/104252 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com

[llvm-branch-commits] [clang] clang/AMDGPU: Emit atomicrmw from flat_atomic_{f32|f64} builtins (PR #96874)

2024-08-20 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **Aug 20, 2:53 PM EDT**: @arsenm started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/96874). https://github.com/llvm/llvm-project/pull/96874 __

[llvm-branch-commits] [clang] clang/AMDGPU: Emit atomicrmw for flat/global atomic min/max f64 builtins (PR #96876)

2024-08-20 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **Aug 20, 2:53 PM EDT**: @arsenm started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/96876). https://github.com/llvm/llvm-project/pull/96876 __

[llvm-branch-commits] [clang] clang/AMDGPU: Emit atomicrmw for global/flat fadd v2bf16 builtins (PR #96875)

2024-08-20 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **Aug 20, 2:53 PM EDT**: @arsenm started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/96875). https://github.com/llvm/llvm-project/pull/96875 __

[llvm-branch-commits] [llvm] [MC][NFC] Reduce Address2ProbesMap size (PR #102904)

2024-08-20 Thread via llvm-branch-commits
https://github.com/WenleiHe commented: > For RSS, it's probably because in llvm-profgen, we decoded the pseudo-probe > only for profiled function(https://reviews.llvm.org/D121643), so the baseline > memory is decreased. @aaupov actually do we need to decode profile for functions without profil

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.handle.fromBinding` to DXIL ops (PR #104251)

2024-08-20 Thread Justin Bogner via llvm-branch-commits
@@ -119,6 +123,119 @@ class OpLowerer { }); } + Value *createTmpHandleCast(Value *V, Type *Ty) { +Function *CastFn = Intrinsic::getDeclaration(&M, Intrinsic::dx_cast_handle, + {Ty, V->getType()}); +CallInst *Cast =

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.handle.fromBinding` to DXIL ops (PR #104251)

2024-08-20 Thread Justin Bogner via llvm-branch-commits
https://github.com/bogner updated https://github.com/llvm/llvm-project/pull/104251 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [DirectX] Lower `@llvm.dx.handle.fromBinding` to DXIL ops (PR #104251)

2024-08-20 Thread Justin Bogner via llvm-branch-commits
https://github.com/bogner updated https://github.com/llvm/llvm-project/pull/104251 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [DirectX] Encapsulate DXILOpLowering's state into a class. NFC (PR #104248)

2024-08-20 Thread Justin Bogner via llvm-branch-commits
https://github.com/bogner updated https://github.com/llvm/llvm-project/pull/104248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [DirectX] Encapsulate DXILOpLowering's state into a class. NFC (PR #104248)

2024-08-20 Thread Justin Bogner via llvm-branch-commits
https://github.com/bogner updated https://github.com/llvm/llvm-project/pull/104248 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ctx_prof] Profile flatterner (PR #104539)

2024-08-20 Thread Mircea Trofin via llvm-branch-commits
https://github.com/mtrofin updated https://github.com/llvm/llvm-project/pull/104539 >From c0eb05f775a88fdf343d52b7af7fcc5eb4b2497e Mon Sep 17 00:00:00 2001 From: Mircea Trofin Date: Thu, 15 Aug 2024 19:03:30 -0700 Subject: [PATCH] [ctx_prof] Profile flatterner --- llvm/include/llvm/Analysis/C

[llvm-branch-commits] [compiler-rt] 177a5c2 - Revert "[compiler-rt][fuzzer] implements SetThreadName for fuchsia. (#99953)"

2024-08-20 Thread via llvm-branch-commits
Author: David CARLIER Date: 2024-08-20T18:41:48+01:00 New Revision: 177a5c23c998699d93ecc64154b111a8adabb66e URL: https://github.com/llvm/llvm-project/commit/177a5c23c998699d93ecc64154b111a8adabb66e DIFF: https://github.com/llvm/llvm-project/commit/177a5c23c998699d93ecc64154b111a8adabb66e.diff

[llvm-branch-commits] [llvm] [MC][NFC] Reduce Address2ProbesMap size (PR #102904)

2024-08-20 Thread Lei Wang via llvm-branch-commits
wlei-llvm wrote: > > To double-check: did you test with or without dwarf-correlation? I tested > > once with it, expectedly pseudo probe parsing wasn't engaged, so there was > > no effect. > > Yes, I double-checked it's a pseudo-probed binary not dwarf-correlation. Note > that for end to end

[llvm-branch-commits] [llvm] [MC][NFC] Reduce Address2ProbesMap size (PR #102904)

2024-08-20 Thread Lei Wang via llvm-branch-commits
wlei-llvm wrote: > > Tested End-to-End on llvm-profgen on a heavy workload(ported all the > > stacked PR) : The running time is neutral, the maximum RSS is reduced by > > 3GB (from 70GB to 67GB) cc @WenleiHe > > To double-check: did you test with or without dwarf-correlation? I tested > onc

[llvm-branch-commits] [libcxx] [libc++][format][3/7] Improves std::format performance. (PR #101817)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -499,11 +652,78 @@ struct _LIBCPP_TEMPLATE_VIS __format_to_n_buffer final _LIBCPP_HIDE_FROM_ABI auto __make_output_iterator() { return this->__output_.__make_output_iterator(); } _LIBCPP_HIDE_FROM_ABI format_to_n_result<_OutIt> __result() && { -this->__output_.__fl

[llvm-branch-commits] [clang] release/19.x: [clang][modules] Built-in modules are not correctly enabled for Mac Catalyst (#104872) (PR #105093)

2024-08-20 Thread Cyndy Ishida via llvm-branch-commits
https://github.com/cyndyishida approved this pull request. https://github.com/llvm/llvm-project/pull/105093 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -722,6 +724,95 @@ class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_CharT> } }; +// A buffer that directly writes to the underlying buffer. +template ldionne wrote: ```suggestion template ``` That way, you don't need to `__unwr

[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -722,6 +724,95 @@ class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_CharT> } }; +// A buffer that directly writes to the underlying buffer. +template +class _LIBCPP_TEMPLATE_VIS __direct_iterator_buffer : public __output_buffer<_CharT> { +public:

[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -722,6 +724,95 @@ class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_CharT> } }; +// A buffer that directly writes to the underlying buffer. +template +class _LIBCPP_TEMPLATE_VIS __direct_iterator_buffer : public __output_buffer<_CharT> { +public:

[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/101823 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -722,6 +724,95 @@ class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_CharT> } }; +// A buffer that directly writes to the underlying buffer. +template +class _LIBCPP_TEMPLATE_VIS __direct_iterator_buffer : public __output_buffer<_CharT> { +public:

[llvm-branch-commits] [libcxx] [libc++][format][3/7] Improves std::format performance. (PR #101817)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -58,23 +59,156 @@ namespace __format { /// This helper is used together with the @ref back_insert_iterator to offer /// type-erasure for the formatting functions. This reduces the number to /// template instantiations. +/// +/// The design of the class is being changed to im

[llvm-branch-commits] [libcxx] [libc++][format][3/7] Improves std::format performance. (PR #101817)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -58,23 +59,156 @@ namespace __format { /// This helper is used together with the @ref back_insert_iterator to offer /// type-erasure for the formatting functions. This reduces the number to /// template instantiations. +/// +/// The design of the class is being changed to im

[llvm-branch-commits] [llvm] release/19.x: [SPARC] Remove assertions in printOperand for inline asm operands (#104692) (PR #105096)

2024-08-20 Thread via llvm-branch-commits
https://github.com/llvmbot updated https://github.com/llvm/llvm-project/pull/105096 >From 92740defcd22962d8f97fb9e2f0dc1e3b770531f Mon Sep 17 00:00:00 2001 From: Koakuma Date: Tue, 20 Aug 2024 20:05:06 +0700 Subject: [PATCH] [SPARC] Remove assertions in printOperand for inline asm operands (#1

[llvm-branch-commits] [clang] [llvm] Add AIX and PPC Clang/LLVM release notes for LLVM 19. (PR #105099)

2024-08-20 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amy Kwan (amy-kwan) Changes This PR adds AIX and PPC Clang/LLVM release notes for LLVM 19 to the `release/19.x` branch. --- Full diff: https://github.com/llvm/llvm-project/pull/105099.diff 2 Files Affected: - (modified) clang/docs/Rele

[llvm-branch-commits] [clang] [llvm] Add AIX and PPC Clang/LLVM release notes for LLVM 19. (PR #105099)

2024-08-20 Thread Amy Kwan via llvm-branch-commits
https://github.com/amy-kwan edited https://github.com/llvm/llvm-project/pull/105099 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] Add AIX and PPC Clang/LLVM release notes for LLVM 19. (PR #105099)

2024-08-20 Thread Amy Kwan via llvm-branch-commits
https://github.com/amy-kwan milestoned https://github.com/llvm/llvm-project/pull/105099 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] Add AIX and PPC Clang/LLVM release notes for LLVM 19. (PR #105099)

2024-08-20 Thread Amy Kwan via llvm-branch-commits
https://github.com/amy-kwan created https://github.com/llvm/llvm-project/pull/105099 This PR adds AIX and PPC Clang/LLVM release notes for LLVM 19 to the `release/19.x` branch. >From 1aa3221f169f8be0fbe6156d97543c326f6ef97a Mon Sep 17 00:00:00 2001 From: Amy Kwan Date: Tue, 20 Aug 2024 10:30:

[llvm-branch-commits] [llvm] release/19.x: [SPARC] Remove assertions in printOperand for inline asm operands (#104692) (PR #105096)

2024-08-20 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-sparc Author: None (llvmbot) Changes Backport 576b7a781aac6b1d60a72248894b50e565e9185a Requested by: @s-barannikov --- Full diff: https://github.com/llvm/llvm-project/pull/105096.diff 2 Files Affected: - (modified) llvm/lib/Target/Sparc/Spar

[llvm-branch-commits] [libcxx] [libc++][format][3/7] Improves std::format performance. (PR #101817)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -452,9 +452,9 @@ format_to(_OutIt __out_it, wformat_string<_Args...> __fmt, _Args&&... __args) { // fires too eagerly, see http://llvm.org/PR61563. template [[nodiscard]] _LIBCPP_ALWAYS_INLINE inline _LIBCPP_HIDE_FROM_ABI string vformat(string_view __fmt, format_args __ar

[llvm-branch-commits] [llvm] release/19.x: [SPARC] Remove assertions in printOperand for inline asm operands (#104692) (PR #105096)

2024-08-20 Thread via llvm-branch-commits
llvmbot wrote: @s-barannikov What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/105096 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[llvm-branch-commits] [llvm] release/19.x: [SPARC] Remove assertions in printOperand for inline asm operands (#104692) (PR #105096)

2024-08-20 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/105096 Backport 576b7a781aac6b1d60a72248894b50e565e9185a Requested by: @s-barannikov >From 7113e7dccfc2e326abd49919a3361266c6443fe2 Mon Sep 17 00:00:00 2001 From: Koakuma Date: Tue, 20 Aug 2024 20:05:06 +0700 Subject

[llvm-branch-commits] [llvm] release/19.x: [SPARC] Remove assertions in printOperand for inline asm operands (#104692) (PR #105096)

2024-08-20 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/105096 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/19.x: [clang][modules] Built-in modules are not correctly enabled for Mac Catalyst (#104872) (PR #105093)

2024-08-20 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: None (llvmbot) Changes Backport 4c5ef6690040383956461828457ac27f7f912edb b9864387d9d00e1d4888181460d05dbc92364d75 Requested by: @ian-twilightcoder --- Full diff: https://github.com/llvm/llvm-project/pull

[llvm-branch-commits] [clang] release/19.x: [clang][modules] Built-in modules are not correctly enabled for Mac Catalyst (#104872) (PR #105093)

2024-08-20 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/105093 Backport 4c5ef6690040383956461828457ac27f7f912edb b9864387d9d00e1d4888181460d05dbc92364d75 Requested by: @ian-twilightcoder >From 1c36e2afffa74d2c25e0c74d96c1a0ef84e70aa0 Mon Sep 17 00:00:00 2001 From: Ian And

[llvm-branch-commits] [clang] release/19.x: [clang][modules] Built-in modules are not correctly enabled for Mac Catalyst (#104872) (PR #105093)

2024-08-20 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/105093 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [mlir] [OpenMP]Update use_device_clause lowering (PR #101707)

2024-08-20 Thread Christian Ulmann via llvm-branch-commits
Dinistro wrote: As I'm not too familiar with these parts of MLIR, I'll not be able to review this properly. Does someone else have capacity to do a pass on the logic of this? https://github.com/llvm/llvm-project/pull/101707 ___ llvm-branch-commits ma

[llvm-branch-commits] [llvm] AMDGPU: Remove flat/global atomic fadd v2bf16 intrinsics (PR #97050)

2024-08-20 Thread Yaxun Liu via llvm-branch-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/97050 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format][4/7] Improves std::format_to performance. (PR #101823)

2024-08-20 Thread Louis Dionne via llvm-branch-commits
@@ -722,6 +724,95 @@ class _LIBCPP_TEMPLATE_VIS __allocating_buffer : public __output_buffer<_CharT> } }; +// A buffer that directly writes to the underlying buffer. +template +class _LIBCPP_TEMPLATE_VIS __direct_iterator_buffer : public __output_buffer<_CharT> { +public:

[llvm-branch-commits] [llvm] AMDGPU: Remove flat/global atomic fadd v2bf16 intrinsics (PR #97050)

2024-08-20 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ping https://github.com/llvm/llvm-project/pull/97050 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang][OpenMP] use reduction alloc region (PR #102525)

2024-08-20 Thread Mats Petersson via llvm-branch-commits
https://github.com/Leporacanthicus approved this pull request. LGTM. Probably good to have a second approval tho'. https://github.com/llvm/llvm-project/pull/102525 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.ll

[llvm-branch-commits] [mlir] [mlir][OpenMP] Convert reduction alloc region to LLVMIR (PR #102524)

2024-08-20 Thread Mats Petersson via llvm-branch-commits
https://github.com/Leporacanthicus edited https://github.com/llvm/llvm-project/pull/102524 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][OpenMP] Convert reduction alloc region to LLVMIR (PR #102524)

2024-08-20 Thread Mats Petersson via llvm-branch-commits
https://github.com/Leporacanthicus edited https://github.com/llvm/llvm-project/pull/102524 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][OpenMP] Convert reduction alloc region to LLVMIR (PR #102524)

2024-08-20 Thread Mats Petersson via llvm-branch-commits
@@ -594,45 +594,85 @@ convertOmpOrderedRegion(Operation &opInst, llvm::IRBuilderBase &builder, /// Allocate space for privatized reduction variables. template -static void allocByValReductionVars( -T loop, ArrayRef reductionArgs, llvm::IRBuilderBase &builder, -LLVM:

[llvm-branch-commits] [compiler-rt] [sanitizer_common] Make sanitizer_linux.cpp kernel_stat* handling Lin… (PR #104916)

2024-08-20 Thread Rainer Orth via llvm-branch-commits
rorth wrote: The Solaris/sparcv9 build just completed successfully: no regressions relative to rc2. https://github.com/llvm/llvm-project/pull/104916 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[llvm-branch-commits] [llvm] release/19.x: [AArch64] Don't replace dst of SWP instructions with (X|W)ZR (#102139) (PR #102316)

2024-08-20 Thread Luke Geeson via llvm-branch-commits
lukeg101 wrote: Prevents a concurrency-related compiler bug (a reordering bug introduced by LLVM) that arises when optimisations rewrite the destination register of SWP instructions to be the zero register when compiling an atomic exchange operation. For more information on this bug and how it

[llvm-branch-commits] [flang] [flang][OpenMP] use reduction alloc region (PR #102525)

2024-08-20 Thread Tom Eccles via llvm-branch-commits
tblah wrote: ping for review https://github.com/llvm/llvm-project/pull/102525 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][OpenMP] Convert reduction alloc region to LLVMIR (PR #102524)

2024-08-20 Thread Tom Eccles via llvm-branch-commits
tblah wrote: ping for review https://github.com/llvm/llvm-project/pull/102524 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [mlir] [OpenMP]Update use_device_clause lowering (PR #101707)

2024-08-20 Thread Akash Banerjee via llvm-branch-commits
TIFitis wrote: Thanks @Dinistro for the comments, I've addressed them in the latest revision. https://github.com/llvm/llvm-project/pull/101707 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[llvm-branch-commits] [llvm] [mlir] [OpenMP]Update use_device_clause lowering (PR #101707)

2024-08-20 Thread Akash Banerjee via llvm-branch-commits
https://github.com/TIFitis updated https://github.com/llvm/llvm-project/pull/101707 >From 3a2afe783bfd65c981424fb14d2b0f42ea0b6618 Mon Sep 17 00:00:00 2001 From: Akash Banerjee Date: Fri, 2 Aug 2024 17:11:21 +0100 Subject: [PATCH 1/2] [OpenMP]Update use_device_clause lowering This patch update

[llvm-branch-commits] [DirectX] Implement metadata lowering for resources (PR #104447)

2024-08-20 Thread Xiang Li via llvm-branch-commits
@@ -13,27 +13,52 @@ #include "DXILShaderFlags.h" #include "DirectX.h" #include "llvm/ADT/StringSet.h" +#include "llvm/Analysis/DXILResource.h" #include "llvm/IR/Constants.h" #include "llvm/IR/Metadata.h" #include "llvm/IR/Module.h" +#include "llvm/InitializePasses.h" #inclu

[llvm-branch-commits] [llvm] [MC][NFC] Reduce Address2ProbesMap size (PR #102904)

2024-08-20 Thread Amir Ayupov via llvm-branch-commits
aaupov wrote: > Tested End-to-End on llvm-profgen on a heavy workload(ported all the stacked > PR) : The running time is neutral, the maximum RSS is reduced by 3GB (from > 70GB to 67GB) cc @WenleiHe To double-check: did you test with or without dwarf-correlation? I tested once with it, exp

[llvm-branch-commits] [llvm] [WIP] AMDGPU: Handle v_add* in eliminateFrameIndex (PR #102346)

2024-08-20 Thread via llvm-branch-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b9a85cef41e26f6f468c87a00f2072ea798ec628 af30ca7d438747ce58dd79ef293a9914ceef592f --e

[llvm-branch-commits] [compiler-rt] [sanitizer_common] Fix internal_*stat on Linux/sparc64 (PR #101236)

2024-08-20 Thread Rainer Orth via llvm-branch-commits
rorth wrote: This can now be closed: one part (PR #101012) has already been merged and the necessary rest is now PR #104916. https://github.com/llvm/llvm-project/pull/101236 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https

[llvm-branch-commits] [compiler-rt] [sanitizer_common] Fix internal_*stat on Linux/sparc64 (PR #101236)

2024-08-20 Thread Rainer Orth via llvm-branch-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/101236 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [WIP][flang] Introduce HLFIR lowerings to omp.workshare_loop_nest (PR #104748)

2024-08-20 Thread Ivan R. Ivanov via llvm-branch-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/104748 >From a45ef32ecf6483bdb65954c4283ea493494cea77 Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Tue, 20 Aug 2024 16:57:25 +0900 Subject: [PATCH 1/6] Update test --- .../Transforms/OpenMP/lower-work

[llvm-branch-commits] [libunwind] release/19.x: [libunwind] Add GCS support for AArch64 (#99335) (PR #101888)

2024-08-20 Thread via llvm-branch-commits
github-actions[bot] wrote: @john-brawn-arm (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this

[llvm-branch-commits] [clang] release/19.x: Reland [C++20] [Modules] [Itanium ABI] Generate the vtable in the mod… (#102287) (PR #102561)

2024-08-20 Thread via llvm-branch-commits
github-actions[bot] wrote: @ChuanqiXu9 (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [clang] release/19.x: [C++23] Fix infinite recursion (Clang 19.x regression) (#104829) (PR #104858)

2024-08-20 Thread via llvm-branch-commits
github-actions[bot] wrote: @AaronBallman (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR

[llvm-branch-commits] [lld] release/19.x: [LLD] [MinGW] Recognize the -rpath option (#102886) (PR #104843)

2024-08-20 Thread via llvm-branch-commits
github-actions[bot] wrote: @mstorsjo (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [llvm] release/19.x: [GlobalISel] Bail out early for big-endian (#103310) (PR #104823)

2024-08-20 Thread via llvm-branch-commits
github-actions[bot] wrote: @davemgreen (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [clang] [llvm] [AArch64] Fix a bug where user could not disable certain architecture features (PR #104752)

2024-08-20 Thread via llvm-branch-commits
github-actions[bot] wrote: @tmatheson-arm (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this P

[llvm-branch-commits] [libunwind] release/19.x: [libunwind] Add GCS support for AArch64 (#99335) (PR #101888)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/101888 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libunwind] 72d2932 - [libunwind] Fix problems caused by combining BTI and GCS (#102322)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
Author: John Brawn Date: 2024-08-20T09:29:19+02:00 New Revision: 72d2932da5a7c70885a1fdfaa809ff1ede0984ff URL: https://github.com/llvm/llvm-project/commit/72d2932da5a7c70885a1fdfaa809ff1ede0984ff DIFF: https://github.com/llvm/llvm-project/commit/72d2932da5a7c70885a1fdfaa809ff1ede0984ff.diff LO

[llvm-branch-commits] [libunwind] c3da16b - [libunwind] Be more careful about enabling GCS (#101973)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
Author: John Brawn Date: 2024-08-20T09:29:19+02:00 New Revision: c3da16b094511e42022e534b5eb665dbc3f8db0f URL: https://github.com/llvm/llvm-project/commit/c3da16b094511e42022e534b5eb665dbc3f8db0f DIFF: https://github.com/llvm/llvm-project/commit/c3da16b094511e42022e534b5eb665dbc3f8db0f.diff LO

[llvm-branch-commits] [libunwind] 7e7e812 - [libunwind] Add GCS support for AArch64 (#99335)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
Author: John Brawn Date: 2024-08-20T09:29:19+02:00 New Revision: 7e7e8125cfabf7daf5de63612e6f2c646dd8cad3 URL: https://github.com/llvm/llvm-project/commit/7e7e8125cfabf7daf5de63612e6f2c646dd8cad3 DIFF: https://github.com/llvm/llvm-project/commit/7e7e8125cfabf7daf5de63612e6f2c646dd8cad3.diff LO

[llvm-branch-commits] [libunwind] release/19.x: [libunwind] Add GCS support for AArch64 (#99335) (PR #101888)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/101888 >From 7e7e8125cfabf7daf5de63612e6f2c646dd8cad3 Mon Sep 17 00:00:00 2001 From: John Brawn Date: Sun, 4 Aug 2024 13:27:12 +0100 Subject: [PATCH 1/3] [libunwind] Add GCS support for AArch64 (#99335) AArch64 GCS (Guarde

[llvm-branch-commits] [clang] release/19.x: Reland [C++20] [Modules] [Itanium ABI] Generate the vtable in the mod… (#102287) (PR #102561)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/102561 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] 64b8514 - Reland [C++20] [Modules] [Itanium ABI] Generate the vtable in the mod… (#102287)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
Author: Chuanqi Xu Date: 2024-08-20T09:28:20+02:00 New Revision: 64b8514e6c1a663660fbb93ec7f623b3e40a2020 URL: https://github.com/llvm/llvm-project/commit/64b8514e6c1a663660fbb93ec7f623b3e40a2020 DIFF: https://github.com/llvm/llvm-project/commit/64b8514e6c1a663660fbb93ec7f623b3e40a2020.diff LO

[llvm-branch-commits] [clang] release/19.x: Reland [C++20] [Modules] [Itanium ABI] Generate the vtable in the mod… (#102287) (PR #102561)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/102561 >From 64b8514e6c1a663660fbb93ec7f623b3e40a2020 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 8 Aug 2024 13:14:09 +0800 Subject: [PATCH] =?UTF-8?q?Reland=20[C++20]=20[Modules]=20[Itanium=20ABI]?= =?UTF-8?q?=20

[llvm-branch-commits] [llvm] release/19.x: [SLP]Fix PR104422: Wrong value truncation (PR #104747)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
tru wrote: @nikic who can review this? @fhahn ? https://github.com/llvm/llvm-project/pull/104747 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [AArch64][ARM] Add a release note about _BitInt (PR #101521)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
tru wrote: The conflict needs to be fixed. https://github.com/llvm/llvm-project/pull/101521 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [llvm][CodeGen] Address the issue discovered In window scheduling (#101665) (PR #102881)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
tru wrote: I can merge this PR as it is. But I need to have someone to review it, especially it will land in the last possible window before -final. This has to be solid and not cause issues after merge. Since this touches Hexagon I would like @SundeepKushwaha to chime in. https://github.com/

[llvm-branch-commits] [llvm] release/19.x: [llvm][CodeGen] Address the issue discovered In window scheduling (#101665) (PR #102881)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/102881 >From bee19707eb9154a84d6052beb056f62ad69637fc Mon Sep 17 00:00:00 2001 From: Kai Yan Date: Wed, 24 Jul 2024 12:06:35 +0800 Subject: [PATCH 1/5] [llvm][CodeGen] Added missing initialization failure information for w

[llvm-branch-commits] [clang] release/19.x: [C++23] Fix infinite recursion (Clang 19.x regression) (#104829) (PR #104858)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/104858 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] 3ffa542 - [C++23] Fix infinite recursion (Clang 19.x regression) (#104829)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
Author: Aaron Ballman Date: 2024-08-20T09:20:54+02:00 New Revision: 3ffa5421ca657c04d4df170307c1f9a3c6293003 URL: https://github.com/llvm/llvm-project/commit/3ffa5421ca657c04d4df170307c1f9a3c6293003 DIFF: https://github.com/llvm/llvm-project/commit/3ffa5421ca657c04d4df170307c1f9a3c6293003.diff

[llvm-branch-commits] [lld] release/19.x: [LLD] [MinGW] Recognize the -rpath option (#102886) (PR #104843)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/104843 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] 6dbc0e2 - [LLD] [MinGW] Recognize the -rpath option (#102886)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
Author: Martin Storsjö Date: 2024-08-20T09:20:29+02:00 New Revision: 6dbc0e236b3e3a651302d079d1c64934976bc0b3 URL: https://github.com/llvm/llvm-project/commit/6dbc0e236b3e3a651302d079d1c64934976bc0b3 DIFF: https://github.com/llvm/llvm-project/commit/6dbc0e236b3e3a651302d079d1c64934976bc0b3.diff

[llvm-branch-commits] [lld] release/19.x: [LLD] [MinGW] Recognize the -rpath option (#102886) (PR #104843)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/104843 >From 6dbc0e236b3e3a651302d079d1c64934976bc0b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sun, 18 Aug 2024 00:44:16 +0300 Subject: [PATCH] [LLD] [MinGW] Recognize the -rpath option (#10288

[llvm-branch-commits] [llvm] release/19.x: [GlobalISel] Bail out early for big-endian (#103310) (PR #104823)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/104823 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] c1336c9 - [GlobalISel] Bail out early for big-endian (#103310)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
Author: David Green Date: 2024-08-20T09:19:52+02:00 New Revision: c1336c9e3bd6c0887ead386043c547b3a3ed76a9 URL: https://github.com/llvm/llvm-project/commit/c1336c9e3bd6c0887ead386043c547b3a3ed76a9 DIFF: https://github.com/llvm/llvm-project/commit/c1336c9e3bd6c0887ead386043c547b3a3ed76a9.diff L

[llvm-branch-commits] [llvm] release/19.x: [GlobalISel] Bail out early for big-endian (#103310) (PR #104823)

2024-08-20 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/104823 >From c1336c9e3bd6c0887ead386043c547b3a3ed76a9 Mon Sep 17 00:00:00 2001 From: David Green Date: Mon, 19 Aug 2024 18:50:47 +0100 Subject: [PATCH] [GlobalISel] Bail out early for big-endian (#103310) If we continue th

  1   2   >