llvmbot wrote:
@llvm/pr-subscribers-pgo
Author: Vitaly Buka (vitalybuka)
Changes
Fixes asan,msan crash on check added in #108684.
The #108684 includes reproducer of the issue.
Change interface of `GetThreadStackAndTls` to
set `tls_begin` and `tls_end` at the same time.
---
Full diff: ht
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/108685
Fixes asan,msan crash on check added in #108684.
The #108684 includes reproducer of the issue.
Change interface of `GetThreadStackAndTls` to
set `tls_begin` and `tls_end` at the same time.
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/108684
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Vitaly Buka (vitalybuka)
Changes
There is possibility of
static_tls_begin is set and static_tls_end is not yet
The test reproduces the case.
Stack trace looks like this:
`MsanThread::Init`
`SetThreadStackAndTls`
`G
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/108684
There is possibility of
static_tls_begin is set and static_tls_end is not yet
The test reproduces the case.
Stack trace looks like this:
`MsanThread::Init`
`SetThreadStackAndTls`
`GetThreadStackAndTl
https://github.com/piggynl approved this pull request.
https://github.com/llvm/llvm-project/pull/108585
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/MaskRay approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/108661
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/108672
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/108672
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Vitaly Buka (vitalybuka)
Changes
I don't have reproducers, and don't know if this
branch is even possible but it looks like a typo
in 031c40dc3c71e1e08d0c459b81fc6b54184cec58.
Before the patch:
For order "stk_begin, tls_beg
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/108672
I don't have reproducers, and don't know if this
branch is even possible but it looks like a typo
in 031c40dc3c71e1e08d0c459b81fc6b54184cec58.
Before the patch:
For order "stk_begin, tls_begin, stk_end, tls_e
fmayer wrote:
The error is gone in the first buildbot build with this revert:
https://lab.llvm.org/buildbot/#/builders/169/builds/3191/steps/9/logs/stdio
https://github.com/llvm/llvm-project/pull/108645
___
llvm-branch-commits mailing list
llvm-branch
llvmbot wrote:
@llvm/pr-subscribers-lld-elf
Author: None (llvmbot)
Changes
Backport d1ba432533aafc52fc59158350af937a8b6b9538
Requested by: @androm3da
---
Full diff: https://github.com/llvm/llvm-project/pull/108661.diff
2 Files Affected:
- (modified) lld/ELF/Arch/Hexagon.cpp (+3-5)
-
llvmbot wrote:
@quic-akaryaki What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/108661
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/108661
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/108661
Backport d1ba432533aafc52fc59158350af937a8b6b9538
Requested by: @androm3da
>From c7dd9ed62e59f26057e86aa872ad9a166f9f645f Mon Sep 17 00:00:00 2001
From: Brian Cain
Date: Fri, 13 Sep 2024 17:10:03 -0500
Subject
https://github.com/fmayer closed
https://github.com/llvm/llvm-project/pull/108645
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
fmayer wrote:
I submitted this to get the buildbot back to green, happy to help if you have
more questions on how to reproduce!
https://github.com/llvm/llvm-project/pull/108645
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ht
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Florian Mayer (fmayer)
Changes
This reverts commit e7f782e7481cea23ef452a75607d3d61f5bd0d22.
This had UBSan failures:
[--] 1 test from ConfigCompileTests
[ RUN ] ConfigCompileTests.DiagnosticSuppression
Config fragmen
llvmbot wrote:
@llvm/pr-subscribers-flang-driver
@llvm/pr-subscribers-clangd
Author: Florian Mayer (fmayer)
Changes
This reverts commit e7f782e7481cea23ef452a75607d3d61f5bd0d22.
This had UBSan failures:
[--] 1 test from ConfigCompileTests
[ RUN ] ConfigCompileTests.Diagnosti
https://github.com/fmayer created
https://github.com/llvm/llvm-project/pull/108645
This reverts commit e7f782e7481cea23ef452a75607d3d61f5bd0d22.
This had UBSan failures:
[--] 1 test from ConfigCompileTests
[ RUN ] ConfigCompileTests.DiagnosticSuppression
Config fragment: compiling
Author: Rahul Joshi
Date: 2024-09-13T12:13:02-07:00
New Revision: 4e53d121f3f83f7ffe23a9dc835a0ffd68a5a1c9
URL:
https://github.com/llvm/llvm-project/commit/4e53d121f3f83f7ffe23a9dc835a0ffd68a5a1c9
DIFF:
https://github.com/llvm/llvm-project/commit/4e53d121f3f83f7ffe23a9dc835a0ffd68a5a1c9.diff
L
llvmbot wrote:
@llvm/pr-subscribers-llvm-adt
Author: Victor Campos (vhscampos)
Changes
This patch adds useful methods to the SmallSet API:
- Constructor that takes pair of iterators.
- Constructor that takes a range.
- Constructor that takes an initializer list.
- Copy constructor.
-
https://github.com/vhscampos created
https://github.com/llvm/llvm-project/pull/108601
This patch adds useful methods to the SmallSet API:
- Constructor that takes pair of iterators.
- Constructor that takes a range.
- Constructor that takes an initializer list.
- Copy constructor.
- Move c
@@ -231,6 +215,31 @@ class SmallSet {
private:
bool isSmall() const { return Set.empty(); }
+
+ template
+ std::pair insertImpl(ArgType &&V) {
+static_assert(std::is_convertible_v,
+ "ArgType must be convertible to T!");
+if (!isSmall()) {
+
@@ -231,6 +215,31 @@ class SmallSet {
private:
bool isSmall() const { return Set.empty(); }
+
+ template
+ std::pair insertImpl(ArgType &&V) {
+static_assert(std::is_convertible_v,
+ "ArgType must be convertible to T!");
+if (!isSmall()) {
+
@@ -231,6 +215,31 @@ class SmallSet {
private:
bool isSmall() const { return Set.empty(); }
+
+ template
+ std::pair insertImpl(ArgType &&V) {
+static_assert(std::is_convertible_v,
+ "ArgType must be convertible to T!");
+if (!isSmall()) {
+
@@ -231,6 +215,31 @@ class SmallSet {
private:
bool isSmall() const { return Set.empty(); }
+
+ template
+ std::pair insertImpl(ArgType &&V) {
+static_assert(std::is_convertible_v,
+ "ArgType must be convertible to T!");
+if (!isSmall()) {
+
@@ -231,6 +215,31 @@ class SmallSet {
private:
bool isSmall() const { return Set.empty(); }
+
+ template
+ std::pair insertImpl(ArgType &&V) {
+static_assert(std::is_convertible_v,
+ "ArgType must be convertible to T!");
+if (!isSmall()) {
+
https://github.com/kuhar commented:
Could you add a test showing the values are forwarded?
https://github.com/llvm/llvm-project/pull/108590
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/108590
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -206,11 +196,12 @@ class SmallSet {
bool erase(const T &V) {
if (!isSmall())
return Set.erase(V);
-for (mutable_iterator I = Vector.begin(), E = Vector.end(); I != E; ++I)
- if (*I == V) {
-Vector.erase(I);
-return true;
- }
+
+a
https://github.com/kuhar approved this pull request.
Nice
https://github.com/llvm/llvm-project/pull/108585
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/108585
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-adt
Author: Victor Campos (vhscampos)
Changes
Replace code that relies on iterators by LLVM helper functions that take
ranges. This makes the code simpler and more readable.
---
Full diff: https://github.com/llvm/llvm-project/pull/108585.diff
1
https://github.com/vhscampos created
https://github.com/llvm/llvm-project/pull/108585
Replace code that relies on iterators by LLVM helper functions that take
ranges. This makes the code simpler and more readable.
>From a2438ce9a61d8e80aa32fa58ca5368a64deacd52 Mon Sep 17 00:00:00 2001
From: Vi
https://github.com/skatrak updated
https://github.com/llvm/llvm-project/pull/107234
>From 47e8403d4adaba03696862ac3ea353fc0feb37d3 Mon Sep 17 00:00:00 2001
From: Sergio Afonso
Date: Tue, 3 Sep 2024 17:09:57 +0100
Subject: [PATCH 1/2] [MLIR][OpenMP] NFC: Document clause-based op
representation
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/108515
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
gbMattN wrote:
Documenting this here as its part of the same issue: the following reproducer
can be made (see the pull request above)
```
#include
#include
struct inner {
struct inner *n;
};
struct outer {
struct inner *i;
};
struct outer* getOuter(){
struct outer *
lenary wrote:
I believe the risk of bringing this in to be fairly small (we did the smallest
fix possible to make it more amenable to back-porting), but I also knew this
was fairly close to the 19.1.0 release date. If you think there will be a
19.1.1, then it can probably wait for that.
https
ilya-biryukov wrote:
I had to replicate what our build was doing very thoroughly, the exact PCMs
each build action receives were important.
Here's the repro:
[maps.tgz](https://github.com/user-attachments/files/16992332/maps.tgz). Just
like last time, it works without the patch and starts fail
llvmbot wrote:
@llvm/pr-subscribers-libcxx
Author: None (llvmbot)
Changes
Backport 127c34948bd54e92ef2ee544e8bc42acecf321ad
Requested by: @var-const
---
Full diff: https://github.com/llvm/llvm-project/pull/108515.diff
1 Files Affected:
- (modified) libcxx/include/chrono (+1-1)
llvmbot wrote:
@ldionne What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/108515
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/108515
Backport 127c34948bd54e92ef2ee544e8bc42acecf321ad
Requested by: @var-const
>From b240a4e402e2db9e096a8bb114616bad4f5a2ab3 Mon Sep 17 00:00:00 2001
From: Konstantin Varlamov
Date: Fri, 13 Sep 2024 01:26:57 -070
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/108515
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
cor3ntin wrote:
How about we deploy that in 19.0.2? It seems like the safest course of action
at this point.
https://github.com/llvm/llvm-project/pull/106043
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/108514
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Christudasan Devadasan (cdevadas)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/108514.diff
2 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp (+7)
- (modified) llvm/lib/Target/AM
https://github.com/cdevadas ready_for_review
https://github.com/llvm/llvm-project/pull/108514
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
cdevadas wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/108514?utm_source=stack-comment-downstack-mergeability-warning"
https://github.com/cdevadas created
https://github.com/llvm/llvm-project/pull/108514
None
>From 2941048b558ae43ff0c96a1cc301976435c95a7f Mon Sep 17 00:00:00 2001
From: Christudasan Devadasan
Date: Fri, 13 Sep 2024 13:53:01 +0530
Subject: [PATCH] [AMDGPU][NewPM] Fill out addILPOpts.
---
llvm/
Patryk27 wrote:
> Is this PR a fix for a regression or a critical issue?
It's a fix for critical issue within the AVR codegen which causes it to
generate invalid binaries and/or crash llvm (depending on which concrete code
path is taken).
It was spotted downstream in Rust, https://github.com/
@@ -102,19 +103,22 @@ class MachineTraceMetrics : public MachineFunctionPass {
TargetSchedModel SchedModel;
public:
+ friend class MachineTraceMetricsWrapperPass;
friend class Ensemble;
friend class Trace;
class Ensemble;
- static char ID;
+ // For legacy pas
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/108508
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/cdevadas updated
https://github.com/llvm/llvm-project/pull/108508
>From 8c819329488c087fce339d4fd65761bc986ed80e Mon Sep 17 00:00:00 2001
From: Christudasan Devadasan
Date: Fri, 13 Sep 2024 12:22:03 +0530
Subject: [PATCH 1/2] [CodeGen][NewPM] Port EarlyIfConversion pass to NP
@@ -39,41 +39,68 @@ using namespace llvm;
#define DEBUG_TYPE "machine-trace-metrics"
-char MachineTraceMetrics::ID = 0;
+AnalysisKey MachineTraceMetricsAnalysis::Key;
-char &llvm::MachineTraceMetricsID = MachineTraceMetrics::ID;
+MachineTraceMetricsAnalysis::Result
+Machine
nikic wrote:
This is a fix for a slow compilation issue, and it's not an LLVM 19 regression,
so it's fine if this doesn't go into the 19.1.0 release.
https://github.com/llvm/llvm-project/pull/108397
___
llvm-branch-commits mailing list
llvm-branch-com
DimitryAndric wrote:
> Is this PR a fix for a regression or a critical issue?
Regression (assertion/crash while building the chromium parts of qt webengine)
> What is the risk of accepting this into the release branch?
Very low. This only initializes a function parameter which was previously e
@@ -39,41 +39,68 @@ using namespace llvm;
#define DEBUG_TYPE "machine-trace-metrics"
-char MachineTraceMetrics::ID = 0;
+AnalysisKey MachineTraceMetricsAnalysis::Key;
-char &llvm::MachineTraceMetricsID = MachineTraceMetrics::ID;
+MachineTraceMetricsAnalysis::Result
+Machine
@@ -128,6 +128,7 @@ MACHINE_FUNCTION_ANALYSIS("slot-indexes",
SlotIndexesAnalysis())
#ifndef MACHINE_FUNCTION_PASS
#define MACHINE_FUNCTION_PASS(NAME, CREATE_PASS)
#endif
+MACHINE_FUNCTION_PASS("early-ifcvt", EarlyIfConverterPass())
MACHINE_FUNCTION_PASS("dead-mi-elimination"
h-vetinari wrote:
> I am unsure what ROCm is in this case
[Radeon Open Compute](https://github.com/ROCm), which is (very roughly) AMD's
CUDA.
https://github.com/llvm/llvm-project/pull/106977
___
llvm-branch-commits mailing list
llvm-branch-commits@li
61 matches
Mail list logo
