[llvm-branch-commits] [sanitizer] Add CHECK that static TLS info is ready (PR #108684)

2024-09-15 Thread Fangrui Song via llvm-branch-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/108684 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [sanitizer] Fix partially initialized static TLS range (PR #108685)

2024-09-15 Thread Fangrui Song via llvm-branch-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/108685 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [sanitizer] Add CHECK that static TLS info is ready (PR #108684)

2024-09-15 Thread Thurston Dang via llvm-branch-commits
https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/108684 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC][sanitizer] Switch to `gnu_get_libc_version` (PR #108724)

2024-09-15 Thread Thurston Dang via llvm-branch-commits
https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/108724 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC][sanitizer] Switch to `gnu_get_libc_version` (PR #108724)

2024-09-15 Thread Fangrui Song via llvm-branch-commits
@@ -198,17 +202,11 @@ bool SetEnv(const char *name, const char *value) { __attribute__((unused)) static bool GetLibcVersion(int *major, int *minor, int *patch) { -# ifdef _CS_GNU_LIBC_VERSION - char buf[64]; - uptr len = co

[llvm-branch-commits] [NFC][sanitizer] Switch to `gnu_get_libc_version` (PR #108724)

2024-09-15 Thread Fangrui Song via llvm-branch-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/108724 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC][sanitizer] Switch to `gnu_get_libc_version` (PR #108724)

2024-09-15 Thread Fangrui Song via llvm-branch-commits
MaskRay wrote: The header gnu/libc-version.h has been in glibc available since 1998. Nice! https://github.com/llvm/llvm-project/pull/108724 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[llvm-branch-commits] [lld] release/19.x: [lld] select a default eflags for hexagon (#108431) (PR #108661)

2024-09-15 Thread Alexey Karyakin via llvm-branch-commits
https://github.com/quic-akaryaki approved this pull request. https://github.com/llvm/llvm-project/pull/108661 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Attributor] Take the address space from addrspacecast directly (PR #108258)

2024-09-15 Thread Shilei Tian via llvm-branch-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/108258 >From f9d72576e5683154dbc67df051dbd117db539a33 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Wed, 11 Sep 2024 12:23:32 -0400 Subject: [PATCH] [Attributor] Take the address space from addrspacecast directly

[llvm-branch-commits] [llvm] [TargetTransformInfo] Remove `getFlatAddressSpace` (PR #108787)

2024-09-15 Thread Shilei Tian via llvm-branch-commits
shiltian wrote: RFC: https://discourse.llvm.org/t/nfc-remove-getflataddressspace-from-targettransforminfo/81263 https://github.com/llvm/llvm-project/pull/108787 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm

[llvm-branch-commits] [llvm] [Attributor] Take the address space from addrspacecast directly (PR #108258)

2024-09-15 Thread Shilei Tian via llvm-branch-commits
shiltian wrote: > > If the value to be analyzed is directly from addrspacecast, we take the > > source > > address space directly. > > I don't think this is valid in general. You are allow to speculatively > produce invalid addrspacecasts. For example: > > ``` > __generic int* g_ptr = ...; >

[llvm-branch-commits] [llvm] [Attributor] Take the address space from addrspacecast directly (PR #108258)

2024-09-15 Thread Shilei Tian via llvm-branch-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/108258 >From 20e76a5af6fa001617b5c1ebbad2b3965df922f5 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Wed, 11 Sep 2024 12:23:32 -0400 Subject: [PATCH] [Attributor] Take the address space from addrspacecast directly

[llvm-branch-commits] [llvm] [Attributor] Use more appropriate approach to check flat address space (PR #108713)

2024-09-15 Thread Shilei Tian via llvm-branch-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/108713 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [TargetTransformInfo] Remove `getFlatAddressSpace` (PR #108787)

2024-09-15 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: Needs RFC https://github.com/llvm/llvm-project/pull/108787 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [TargetTransformInfo] Remove `getFlatAddressSpace` (PR #108787)

2024-09-15 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-analysis @llvm/pr-subscribers-backend-nvptx Author: Shilei Tian (shiltian) Changes This has been moved to `DataLayout`. --- Full diff: https://github.com/llvm/llvm-project/pull/108787.diff 7 Files Affected: - (modified) llvm/include/llvm/Analysi

[llvm-branch-commits] [llvm] [TargetTransformInfo] Remove `getFlatAddressSpace` (PR #108787)

2024-09-15 Thread Shilei Tian via llvm-branch-commits
shiltian wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/108787?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [llvm] [TargetTransformInfo] Remove `getFlatAddressSpace` (PR #108787)

2024-09-15 Thread Shilei Tian via llvm-branch-commits
https://github.com/shiltian ready_for_review https://github.com/llvm/llvm-project/pull/108787 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [TargetTransformInfo] Remove `getFlatAddressSpace` (PR #108787)

2024-09-15 Thread Shilei Tian via llvm-branch-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/108787 This has been moved to `DataLayout`. >From 8db0d52053b0cde8be13ddb6c669b6b262eefdf8 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sun, 15 Sep 2024 23:06:14 -0400 Subject: [PATCH] [TargetTransformInfo] Remov

[llvm-branch-commits] [llvm] release/19.x: [X86] Fix missing check of rotate <-> shift equivilence (Issue 108722) (PR #108783)

2024-09-15 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (llvmbot) Changes Backport 1c378d2b145578948942512f9d6985e37659d013 81279bf97f187eee0446af00d8ae9ec32a22e878 Requested by: @goldsteinn --- Full diff: https://github.com/llvm/llvm-project/pull/108783.diff 2 Files Affected: -

[llvm-branch-commits] [llvm] release/19.x: [X86] Fix missing check of rotate <-> shift equivilence (Issue 108722) (PR #108783)

2024-09-15 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/108783 Backport 1c378d2b145578948942512f9d6985e37659d013 81279bf97f187eee0446af00d8ae9ec32a22e878 Requested by: @goldsteinn >From 4c558a8d535a48d0588671d1574bc5a70478adce Mon Sep 17 00:00:00 2001 From: Noah Goldstein

[llvm-branch-commits] [llvm] release/19.x: [X86] Fix missing check of rotate <-> shift equivilence (Issue 108722) (PR #108783)

2024-09-15 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/108783 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [MLIR][OpenMP][Docs] NFC: Document clause-based op representation (PR #107234)

2024-09-15 Thread Tom Eccles via llvm-branch-commits
https://github.com/tblah approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107234 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] f5d4293 - Revert "[HIP] Use original file path for CUID (#107734)"

2024-09-15 Thread via llvm-branch-commits
Author: dyung Date: 2024-09-15T09:37:28-07:00 New Revision: f5d42938f209cb1f814ef8db78c7755fe31e2c5c URL: https://github.com/llvm/llvm-project/commit/f5d42938f209cb1f814ef8db78c7755fe31e2c5c DIFF: https://github.com/llvm/llvm-project/commit/f5d42938f209cb1f814ef8db78c7755fe31e2c5c.diff LOG: Re

[llvm-branch-commits] [clang] Fix evaluation of the unsigned enumeration values, #108766 (PR #108768)

2024-09-15 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dmitry Fursov (fursov) Changes If the type of an enumeration is not native (e.g. uint8_t) but is unsigned then evaluation of the value might get wrong: for values bigger than half of type range the return value will be negative. This happ

[llvm-branch-commits] [clang] Fix evaluation of the unsigned enumeration values, #108766 (PR #108768)

2024-09-15 Thread via llvm-branch-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[llvm-branch-commits] [clang] Fix evaluation of the unsigned enumeration values, #108766 (PR #108768)

2024-09-15 Thread Dmitry Fursov via llvm-branch-commits
https://github.com/fursov created https://github.com/llvm/llvm-project/pull/108768 If the type of an enumeration is not native (e.g. uint8_t) but is unsigned then evaluation of the value might get wrong: for values bigger than half of type range the return value will be negative. This happens

[llvm-branch-commits] [llvm] [Attributor] Take the address space from addrspacecast directly (PR #108258)

2024-09-15 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > If the value to be analyzed is directly from addrspacecast, we take the source address space directly. I don't think this is valid in general. You are allow to speculatively produce invalid addrspacecasts. For example: ``` __generic int* g_ptr = ...; __local int* l_ptr = (__lo

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

2024-09-15 Thread Nikita Popov via llvm-branch-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/108585 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

2024-09-15 Thread Nikita Popov via llvm-branch-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/108585 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

2024-09-15 Thread Nikita Popov via llvm-branch-commits
@@ -234,19 +225,12 @@ class SmallSet { /// Check if the SmallSet contains the given element. bool contains(const T &V) const { if (isSmall()) - return vfind(V) != Vector.end(); -return Set.find(V) != Set.end(); + return llvm::is_contained(Vector, V); +