[llvm-branch-commits] [libcxx] [release/19.x][libc++] Follow-up to "Poison Pills are Too Toxic" (PR #109291)

2024-10-04 Thread A. Jiang via llvm-branch-commits
https://github.com/frederick-vs-ja approved this pull request. Looks like that we should merge this now. https://github.com/llvm/llvm-project/pull/109291 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi

[llvm-branch-commits] [compiler-rt] [llvm] [Coverage] Make SingleByteCoverage work consistent to merging (PR #110972)

2024-10-04 Thread NAKAMURA Takumi via llvm-branch-commits
https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/110972 >From aacb50ddf87d96b4a0644c7ef5d0a86dc94f069b Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Wed, 2 Oct 2024 23:25:52 +0900 Subject: [PATCH 1/2] [Coverage] Make SingleByteCoverage work consistent to merg

[llvm-branch-commits] [flang] [flang] Lower omp.workshare to other omp constructs (PR #101446)

2024-10-04 Thread Ivan R. Ivanov via llvm-branch-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/101446 >From e56dbd6a0625890fd9a3d6a62675e864ca94a8f5 Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Sun, 4 Aug 2024 22:06:55 +0900 Subject: [PATCH 01/12] [flang] Lower omp.workshare to other omp construc

[llvm-branch-commits] [flang] [WIP][flang] Introduce HLFIR lowerings to omp.workshare_loop_nest (PR #104748)

2024-10-04 Thread Ivan R. Ivanov via llvm-branch-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/104748 >From b11ddd76c7fa12b071e0e6b0afd4c3ebbc9ee363 Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Sat, 5 Oct 2024 12:57:48 +0900 Subject: [PATCH 1/6] Fix tests --- flang/lib/Optimizer/OpenMP/LowerWor

[llvm-branch-commits] [llvm] [x86][Windows] Fix chromium build break (PR #111218)

2024-10-04 Thread Eli Friedman via llvm-branch-commits
https://github.com/efriedma-quic milestoned https://github.com/llvm/llvm-project/pull/111218 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [x86][Windows] Fix chromium build break (PR #111218)

2024-10-04 Thread Eli Friedman via llvm-branch-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/111218 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [x86][Windows] Fix chromium build break (PR #111218)

2024-10-04 Thread Eli Friedman via llvm-branch-commits
@@ -177,6 +177,107 @@ define float @tan(float %x) #0 { ret float %result } +define float @acos(float %x) #0 { efriedma-quic wrote: Okay that's fine. https://github.com/llvm/llvm-project/pull/111218 ___ llvm-branc

[llvm-branch-commits] [llvm] [x86][Windows] Fix chromium build break (PR #111218)

2024-10-04 Thread Eli Friedman via llvm-branch-commits
https://github.com/efriedma-quic approved this pull request. LGTM. Fixes a regression, and should be low-risk (the fix only affects the exact functions on the exact target with the issue). https://github.com/llvm/llvm-project/pull/111218 ___ llvm-bra

[llvm-branch-commits] [llvm] [x86][Windows] Fix chromium build break (PR #111218)

2024-10-04 Thread Farzon Lotfi via llvm-branch-commits
@@ -177,6 +177,107 @@ define float @tan(float %x) #0 { ret float %result } +define float @acos(float %x) #0 { farzonl wrote: @efriedma-quic I'm looking at the commit history of this file: https://github.com/llvm/llvm-project/commits/release/19.x/llvm/test/C

[llvm-branch-commits] [llvm] [x86][Windows] Fix chromium build break (PR #111218)

2024-10-04 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Farzon Lotfi (farzonl) Changes Windows does not support float C89 math functions like: - acosf - asinf - atanf - coshf - sinhf - tanhf These 6 libfuncs need to be type promoted. This PR fixes the bug introduced by https://github.com

[llvm-branch-commits] [llvm] [x86][Windows] Fix chromium build break (PR #111218)

2024-10-04 Thread Farzon Lotfi via llvm-branch-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/111218 Windows does not support float C89 math functions like: - acosf - asinf - atanf - coshf - sinhf - tanhf These 6 libfuncs need to be type promoted. This PR fixes the bug introduced by https://github.com/llvm/llv

[llvm-branch-commits] [Flang][OpenMP] Derived type explicit allocatable member mapping (PR #111192)

2024-10-04 Thread via llvm-branch-commits
agozillon wrote: This portion of the PR stack underwent the most changes, as it's the most "complex" part of the PR stack, it's primarily underwent some additional complexity in the map lowering for member mapping which now attempts to incorporate bounds where possible amongst a some other thi

[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #111191)

2024-10-04 Thread via llvm-branch-commits
agozillon wrote: This portion of the PR stack has remained largely unchanged, the only alteration is incorporating the final set of comments from the last iteration of the PR stack. https://github.com/llvm/llvm-project/pull/91 ___ llvm-branch-co

[llvm-branch-commits] [Flang][OpenMP] Derived type explicit allocatable member mapping (PR #111192)

2024-10-04 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Author: None (agozillon) Changes This PR is one of 3 in a PR stack, this is the primary change set which seeks to extend the current derived type explicit member mapping support to handle descriptor member mapping at arbitrary levels of n

[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #111191)

2024-10-04 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm Author: None (agozillon) Changes This is one of 3 PRs in a PR stack that aims to add support for explicit mapping of allocatable members in derived types. The primary changes in this PR are the OpenMPToLLVMIRTranslation.cpp changes, which are

[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #111191)

2024-10-04 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-mlir @llvm/pr-subscribers-flang-openmp Author: None (agozillon) Changes This is one of 3 PRs in a PR stack that aims to add support for explicit mapping of allocatable members in derived types. The primary changes in this PR are the OpenMPToLLVMIRTrans

[llvm-branch-commits] [Flang][OpenMP] Derived type explicit allocatable member mapping (PR #111192)

2024-10-04 Thread via llvm-branch-commits
https://github.com/agozillon created https://github.com/llvm/llvm-project/pull/92 This PR is one of 3 in a PR stack, this is the primary change set which seeks to extend the current derived type explicit member mapping support to handle descriptor member mapping at arbitrary levels of nestin

[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #111191)

2024-10-04 Thread via llvm-branch-commits
https://github.com/agozillon created https://github.com/llvm/llvm-project/pull/91 This is one of 3 PRs in a PR stack that aims to add support for explicit mapping of allocatable members in derived types. The primary changes in this PR are the OpenMPToLLVMIRTranslation.cpp changes, which ar

[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #96265)

2024-10-04 Thread via llvm-branch-commits
agozillon wrote: Going to close this current version of the PR stack and open a new one with the changes requested incorporated alongside some newer additions to add support for indexing members at arbitrary depths and some other general fixes, unfortunately lost track of what is in the PR sta

[llvm-branch-commits] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #96265)

2024-10-04 Thread via llvm-branch-commits
https://github.com/agozillon closed https://github.com/llvm/llvm-project/pull/96265 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [Flang][OpenMP] Derived type explicit allocatable member mapping (PR #96266)

2024-10-04 Thread via llvm-branch-commits
agozillon wrote: Going to close this current version of the PR stack and open a new one with the changes requested incorporated alongside some newer additions to add support for indexing members at arbitrary depths and some other general fixes, unfortunately lost track of what is in the PR sta

[llvm-branch-commits] [flang] [Flang][OpenMP] Derived type explicit allocatable member mapping (PR #96266)

2024-10-04 Thread via llvm-branch-commits
https://github.com/agozillon closed https://github.com/llvm/llvm-project/pull/96266 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] 92b4baa - Revert "[CFIFixup] Factor CFI remember/restore insertion into a helper (NFC) …"

2024-10-04 Thread via llvm-branch-commits
Author: Daniel Hoekwater Date: 2024-10-04T10:32:49-04:00 New Revision: 92b4baaa5d8ce3aad74c070ae7f1bdc393fae751 URL: https://github.com/llvm/llvm-project/commit/92b4baaa5d8ce3aad74c070ae7f1bdc393fae751 DIFF: https://github.com/llvm/llvm-project/commit/92b4baaa5d8ce3aad74c070ae7f1bdc393fae751.di

[llvm-branch-commits] [flang] [flang] Lower omp.workshare to other omp constructs (PR #101446)

2024-10-04 Thread Ivan R. Ivanov via llvm-branch-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/101446 >From e56dbd6a0625890fd9a3d6a62675e864ca94a8f5 Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Sun, 4 Aug 2024 22:06:55 +0900 Subject: [PATCH 01/11] [flang] Lower omp.workshare to other omp construc

[llvm-branch-commits] [flang] [WIP][flang] Introduce HLFIR lowerings to omp.workshare_loop_nest (PR #104748)

2024-10-04 Thread Ivan R. Ivanov via llvm-branch-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/104748 >From 8d0651ff644fa6821e0d0fbc4c47fee36802a15c Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Fri, 4 Oct 2024 22:48:42 +0900 Subject: [PATCH 1/6] Fix message --- flang/lib/Optimizer/OpenMP/LowerW

[llvm-branch-commits] [flang] [WIP][flang] Introduce HLFIR lowerings to omp.workshare_loop_nest (PR #104748)

2024-10-04 Thread Ivan R. Ivanov via llvm-branch-commits
ivanradanov wrote: @Thirumalai-Shaktivel Thank you very much. Fixed. `forall` is actually a case which we do not handle yet. You can give it a shot if you would like. https://github.com/llvm/llvm-project/pull/104748 ___ llvm-branch-commits mailing l

[llvm-branch-commits] [flang] [flang] Lower omp.workshare to other omp constructs (PR #101446)

2024-10-04 Thread Ivan R. Ivanov via llvm-branch-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/101446 >From e56dbd6a0625890fd9a3d6a62675e864ca94a8f5 Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Sun, 4 Aug 2024 22:06:55 +0900 Subject: [PATCH 01/10] [flang] Lower omp.workshare to other omp construc

[llvm-branch-commits] [flang] [WIP][flang] Introduce HLFIR lowerings to omp.workshare_loop_nest (PR #104748)

2024-10-04 Thread Ivan R. Ivanov via llvm-branch-commits
https://github.com/ivanradanov updated https://github.com/llvm/llvm-project/pull/104748 >From c5b5369be3d0db31d9ded0eeeb8e28e03d25bd9e Mon Sep 17 00:00:00 2001 From: Ivan Radanov Ivanov Date: Fri, 4 Oct 2024 22:45:09 +0900 Subject: [PATCH 1/6] Fix bug and add better clarification comments ---

[llvm-branch-commits] [llvm] [AArch64][PAC] Move emission of LR checks in tail calls to AsmPrinter (PR #110705)

2024-10-04 Thread Daniil Kovalev via llvm-branch-commits
kovdan01 wrote: @atrosinenko With this patch applied, the following tests in test-suite compiled in Release mode become failed with segmentation fault: 1. SingleSource/Benchmarks/Misc-C++-EH/spirit.test 2. MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4.test 3. MultiSource/Benchmarks/Prolangs-C++/

[llvm-branch-commits] [flang] [flang] Lower omp.workshare to other omp constructs (PR #101446)

2024-10-04 Thread Tom Eccles via llvm-branch-commits
@@ -96,6 +94,12 @@ bool shouldUseWorkshareLowering(Operation *op) { if (isNestedIn(parentWorkshare, op)) return false; + if (parentWorkshare.getRegion().getBlocks().size() != 1) { +parentWorkshare->emitWarning( +"omp workshare with unstructured control flow

[llvm-branch-commits] [flang] [WIP][flang] Introduce HLFIR lowerings to omp.workshare_loop_nest (PR #104748)

2024-10-04 Thread Thirumalai Shaktivel via llvm-branch-commits
Thirumalai-Shaktivel wrote: Thanks for the quick fix. Yes, it works fine. Here is another MRE that crashes: ```fortran subroutine test_workshare_02() real :: x(10) integer :: i call random_number(x) x = 2 !$omp workshare forall(i=1: 10) x(i

[llvm-branch-commits] [llvm] [AMDGPU] Serialize WWM_REG vreg flag (PR #110229)

2024-10-04 Thread Matt Arsenault via llvm-branch-commits
@@ -578,3 +578,18 @@ body: | SI_RETURN ... +--- arsenm wrote: Should add an error test where the flag name is unrecognized https://github.com/llvm/llvm-project/pull/110229 ___ llvm-branch-commits m