[llvm-branch-commits] [clang] [clang] fix template argument conversion (PR #124386)

2025-01-26 Thread via llvm-branch-commits
cor3ntin wrote: This might be good enough for now. Maybe in the future we can - Merge IntegerLiteral/Nullptr/StructuralType - Keep Expressions around longer https://github.com/llvm/llvm-project/pull/124386 ___ llvm-branch-commits mailing list llvm-

[llvm-branch-commits] [llvm] PeepholeOpt: Remove check for reg_sequence def of subregister (PR #124512)

2025-01-26 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/124512?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] PeepholeOpt: Remove check for reg_sequence def of subregister (PR #124512)

2025-01-26 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/124512 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] PeepholeOpt: Remove check for reg_sequence def of subregister (PR #124512)

2025-01-26 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/124512 The verifier does not allow reg_sequence to have subregister defs, even if undef. >From 436cde08aff59b2bf77c31e0e65fdaac31f0e520 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Mon, 27 Jan 2025 13:57:08 +070

[llvm-branch-commits] [clang] [clang] fix template argument conversion (PR #124386)

2025-01-26 Thread via llvm-branch-commits
@@ -5252,63 +5253,73 @@ bool Sema::CheckTemplateArgument( return true; } -switch (Arg.getArgument().getKind()) { -case TemplateArgument::Null: - llvm_unreachable("Should never see a NULL template argument here"); - -case TemplateArgument::Expressio

[llvm-branch-commits] [clang] [clang] fix template argument conversion (PR #124386)

2025-01-26 Thread via llvm-branch-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/124386 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] llvm-cov: Introduce `--merge-instantiations=` (PR #121194)

2025-01-26 Thread NAKAMURA Takumi via llvm-branch-commits
chapuni wrote: @yhgu2000 Could you elaborate? I expect you could understand to see tests and run this. Note, this is incomplete for mcdc. See also #121196 to fill the gap. https://github.com/llvm/llvm-project/pull/121194 ___ llvm-branch-commits maili

[llvm-branch-commits] [clang] [clang] fix nondeduced mismatch with nullptr template arguments (PR #124498)

2025-01-26 Thread via llvm-branch-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/124498 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] fix nondeduced mismatch with nullptr template arguments (PR #124498)

2025-01-26 Thread via llvm-branch-commits
@@ -2559,6 +2558,8 @@ DeduceTemplateArguments(Sema &S, TemplateParameterList *TemplateParams, return TemplateDeductionResult::NonDeducedMismatch; case TemplateArgument::StructuralValue: +// FIXME: structural equality will also compare types, +// but they should

[llvm-branch-commits] [clang] [clang] fix nondeduced mismatch with nullptr template arguments (PR #124498)

2025-01-26 Thread via llvm-branch-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/124498 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] fix nondeduced mismatch with nullptr template arguments (PR #124498)

2025-01-26 Thread Younan Zhang via llvm-branch-commits
https://github.com/zyn0217 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/124498 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang] fix nondeduced mismatch with nullptr template arguments (PR #124498)

2025-01-26 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes In deduction, when comparing template arguments of value kind, we should check if the value matches. Values of different types can still match. For example, `short(0)` matches `int(0)`. Values of nullpt

[llvm-branch-commits] [clang] [clang] fix nondeduced mismatch with nullptr template arguments (PR #124498)

2025-01-26 Thread Matheus Izvekov via llvm-branch-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/124498 In deduction, when comparing template arguments of value kind, we should check if the value matches. Values of different types can still match. For example, `short(0)` matches `int(0)`. Values of nullptr kind

[llvm-branch-commits] [clang] [clang] fix template argument conversion (PR #124386)

2025-01-26 Thread Matheus Izvekov via llvm-branch-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/124386 >From 7b4befe667df321511fc75ea3a4ef8ab3067ced9 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Fri, 24 Jan 2025 19:25:38 -0300 Subject: [PATCH] [clang] fix template argument conversion Converted template