[llvm-branch-commits] [llvm] RegAllocFast: Fix verifier errors after assigning to reserved registers (PR #128281)

2025-02-22 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/128281 >From d93b45487feba452868706b31e6e59e0bb1a5d19 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Thu, 12 Dec 2024 10:53:41 +0900 Subject: [PATCH] RegAllocFast: Fix verifier errors after assigning to reserved r

[llvm-branch-commits] [flang] [flang][draft] update fir.coordinate_of to carry the fields (PR #127231)

2025-02-22 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
https://github.com/clementval approved this pull request. https://github.com/llvm/llvm-project/pull/127231 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Reapply "RegAlloc: Fix verifier error after failed allocation (#119690)" (PR #128400)

2025-02-22 Thread via llvm-branch-commits
github-actions[bot] wrote: :warning: undef deprecator found issues in your code. :warning: You can test this locally with the following command: ``bash git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' d93b45487feba452868706b31e6e59e0bb1a5d19

[llvm-branch-commits] [llvm] Reapply "RegAlloc: Fix verifier error after failed allocation (#119690)" (PR #128400)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes Reapply "RegAlloc: Fix verifier error after failed allocation (#119690)" This reverts commit 0c50054820799578be8f62b6fd2cc3fbc751c01e. Reapply with more fixes to avoid expensive_checks failures. Ma

[llvm-branch-commits] [llvm] Reapply "RegAlloc: Fix verifier error after failed allocation (#119690)" (PR #128400)

2025-02-22 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/128400 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Reapply "RegAlloc: Fix verifier error after failed allocation (#119690)" (PR #128400)

2025-02-22 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/128400?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] Reapply "RegAlloc: Fix verifier error after failed allocation (#119690)" (PR #128400)

2025-02-22 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/128400 Reapply "RegAlloc: Fix verifier error after failed allocation (#119690)" This reverts commit 0c50054820799578be8f62b6fd2cc3fbc751c01e. Reapply with more fixes to avoid expensive_checks failures. Make sure to cal

[llvm-branch-commits] [llvm] RegAllocFast: Fix verifier errors after assigning to reserved registers (PR #128281)

2025-02-22 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/128281 >From d93b45487feba452868706b31e6e59e0bb1a5d19 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Thu, 12 Dec 2024 10:53:41 +0900 Subject: [PATCH] RegAllocFast: Fix verifier errors after assigning to reserved r

[llvm-branch-commits] [clang] [clang][NFC] Remove CXXRecordDecl::lookupDependentName() and its helpers (PR #128392)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Ridge (HighCommander4) Changes This function has been superseded by HeuristicResolver::lookupDependentName(), which implements the same heuristics and more. Porting note for any out-of-tree callers: ``` RD->lookupDependentName(Nam

[llvm-branch-commits] [clang] [clang][NFC] Remove CXXRecordDecl::lookupDependentName() and its helpers (PR #128392)

2025-02-22 Thread Nathan Ridge via llvm-branch-commits
HighCommander4 wrote: For reference, the callers of `CXXRecordDecl::lookupDependentName()` have been ported over to `HeuristicResolver` over the following series of patches: https://github.com/llvm/llvm-project/pull/124888 https://github.com/llvm/llvm-project/pull/125153 https://github.com/llvm

[llvm-branch-commits] [clang] [clang][NFC] Remove CXXRecordDecl::lookupDependentName() and its helpers (PR #128392)

2025-02-22 Thread Nathan Ridge via llvm-branch-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/128392 This function has been superseded by HeuristicResolver::lookupDependentName(), which implements the same heuristics and more. Porting note for any out-of-tree callers: ``` RD->lookupDependentName(Name,

[llvm-branch-commits] [llvm] release/20.x: Reland "[LV]: Teach LV to recursively (de)interleave." (#125094) (PR #128389)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-vectorizers Author: None (llvmbot) Changes Backport e9a20f77ee2117b4a6eb40826b7280e29ad29e1e Requested by: @hassnaaHamdi --- Patch is 194.18 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/128389.diff 6 Fi

[llvm-branch-commits] [llvm] release/20.x: Reland "[LV]: Teach LV to recursively (de)interleave." (#125094) (PR #128389)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: None (llvmbot) Changes Backport e9a20f77ee2117b4a6eb40826b7280e29ad29e1e Requested by: @hassnaaHamdi --- Patch is 194.18 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/128389.diff

[llvm-branch-commits] [llvm] release/20.x: Reland "[LV]: Teach LV to recursively (de)interleave." (#125094) (PR #128389)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @fhahn What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/128389 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[llvm-branch-commits] [llvm] release/20.x: Reland "[LV]: Teach LV to recursively (de)interleave." (#125094) (PR #128389)

2025-02-22 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/128389 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AMDGPU][Attributor] Rework update of `AAAMDWavesPerEU` (PR #123995)

2025-02-22 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > Out of curiosity: I believe this is case three, why would we not want to use > the user-provided values? A library use does not have the usage context. It may have specified a bounds to avoid negatively impacting occupancy of some unknown calling kernel. If we know the bounds

[llvm-branch-commits] [llvm] dde78a2 - Revert "Revert "[X86] combineBROADCAST_LOAD - merge across chains" (#128380)"

2025-02-22 Thread via llvm-branch-commits
Author: Vitaly Buka Date: 2025-02-22T16:15:48-08:00 New Revision: dde78a2e84edc0fe987266a7fcae774dd36532c3 URL: https://github.com/llvm/llvm-project/commit/dde78a2e84edc0fe987266a7fcae774dd36532c3 DIFF: https://github.com/llvm/llvm-project/commit/dde78a2e84edc0fe987266a7fcae774dd36532c3.diff L

[llvm-branch-commits] [llvm] 1aacd31 - Revert "[X86] combineBROADCAST_LOAD - merge across chains (#128209)"

2025-02-22 Thread via llvm-branch-commits
Author: Vitaly Buka Date: 2025-02-22T16:02:11-08:00 New Revision: 1aacd3108d3fb66c1f2483e973b52a97006eba9b URL: https://github.com/llvm/llvm-project/commit/1aacd3108d3fb66c1f2483e973b52a97006eba9b DIFF: https://github.com/llvm/llvm-project/commit/1aacd3108d3fb66c1f2483e973b52a97006eba9b.diff L

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies (PR #127294)

2025-02-22 Thread Nikita Popov via llvm-branch-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/127294 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies: Backport Attempt 3 (PR #128371)

2025-02-22 Thread Nikita Popov via llvm-branch-commits
https://github.com/nikic milestoned https://github.com/llvm/llvm-project/pull/128371 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies: Backport Attempt 3 (PR #128371)

2025-02-22 Thread Alexey Bataev via llvm-branch-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/128371 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies (PR #127294)

2025-02-22 Thread Nikita Popov via llvm-branch-commits
nikic wrote: Closing in favor of https://github.com/llvm/llvm-project/pull/128371. https://github.com/llvm/llvm-project/pull/127294 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies: Backport Attempt 3 (PR #128371)

2025-02-22 Thread via llvm-branch-commits
Zentrik wrote: I suspect I don't have permissions to add this to the milestone. https://github.com/llvm/llvm-project/pull/128371 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llv

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies: Backport Attempt 3 (PR #128371)

2025-02-22 Thread via llvm-branch-commits
https://github.com/Zentrik updated https://github.com/llvm/llvm-project/pull/128371 >From 976a97097c645a4d861e4a36c142b30c33a5e575 Mon Sep 17 00:00:00 2001 From: Alexey Bataev Date: Thu, 13 Feb 2025 14:19:51 -0800 Subject: [PATCH 1/2] [SLP] Check for PHI nodes (potentially cycles!) when checki

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies: Backport Attempt 3 (PR #128371)

2025-02-22 Thread via llvm-branch-commits
https://github.com/Zentrik edited https://github.com/llvm/llvm-project/pull/128371 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies: Backport Attempt 3 (PR #128371)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: None (Zentrik) Changes Backport https://github.com/llvm/llvm-project/commit/ac217ee389d63124432e5e6890851a678f7a676b This fixes https://github.com/llvm/llvm-project/pull/127294 by updating the test at `llvm/test/Transforms/SLPV

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies: Backport Attempt 3 (PR #128371)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-vectorizers Author: None (Zentrik) Changes Backport https://github.com/llvm/llvm-project/commit/ac217ee389d63124432e5e6890851a678f7a676b This fixes https://github.com/llvm/llvm-project/pull/127294 by updating the test at `llvm/test/Transforms/SLPVecto

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies (PR #128371)

2025-02-22 Thread via llvm-branch-commits
https://github.com/Zentrik created https://github.com/llvm/llvm-project/pull/128371 Backport https://github.com/llvm/llvm-project/commit/ac217ee389d63124432e5e6890851a678f7a676b This fixes https://github.com/llvm/llvm-project/pull/127294 by updating the test at `llvm/test/Transforms/SLPVector

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies (PR #127294)

2025-02-22 Thread Alexey Bataev via llvm-branch-commits
alexey-bataev wrote: Yes, updating should be enough https://github.com/llvm/llvm-project/pull/127294 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/20.x: [SLP] Check for PHI nodes (potentially cycles!) when checking dependencies (PR #127294)

2025-02-22 Thread via llvm-branch-commits
Zentrik wrote: @alexey-bataev Am I correct in thinking that the `Transforms/SLPVectorizer/X86/perfect-matched-reused-bv.ll` test just needs to be updated to reflect that vectorization fails. It looks like the test is there to make sure there's no crash when compiling. https://github.com/llvm/

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

2025-02-22 Thread Mark de Wever via llvm-branch-commits
https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/128366 >From ab09f9dfbc3ee01af586b8a5285ac72b4f35e2f9 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 16 Feb 2025 12:07:44 +0100 Subject: [PATCH] [libc++] Clang-tidy operator& hijacker. Guards against introdu

[llvm-branch-commits] [llvm] [AMDGPU][Attributor] Rework update of `AAAMDWavesPerEU` (PR #123995)

2025-02-22 Thread Jan Patrick Lehr via llvm-branch-commits
jplehr wrote: Out of curiosity: I believe this is case three, why would we not want to use the user-provided values? https://github.com/llvm/llvm-project/pull/123995 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

2025-02-22 Thread Mark de Wever via llvm-branch-commits
https://github.com/mordante created https://github.com/llvm/llvm-project/pull/128366 Guards against introducing new places where operator& depends on a template type. >From 5a96aadb54b757812dc48f07e753477164d8062a Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 16 Feb 2025 12:07:44 +0

[llvm-branch-commits] [libcxx] [libc++] Clang-tidy operator& hijacker. (PR #128366)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) Changes Guards against introducing new places where operator& depends on a template type. --- Full diff: https://github.com/llvm/llvm-project/pull/128366.diff 4 Files Affected: - (modified) libcxx/test/tools/c

[llvm-branch-commits] [flang] [flang][draft] update fir.coordinate_of to carry the fields (PR #127231)

2025-02-22 Thread Razvan Lupusoru via llvm-branch-commits
razvanlupusoru wrote: Nice work! https://github.com/llvm/llvm-project/pull/127231 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] RegAllocFast: Fix verifier errors after assigning to reserved registers (PR #128281)

2025-02-22 Thread Christudasan Devadasan via llvm-branch-commits
@@ -1005,7 +1007,8 @@ void RegAllocFastImpl::allocVirtRegUndef(MachineOperand &MO) { MO.setSubReg(0); } MO.setReg(PhysReg); - MO.setIsRenamable(true); + if (!LRI->Error) +MO.setIsRenamable(true); cdevadas wrote: ```suggestion MO.setIsRenamable

[llvm-branch-commits] [llvm] RegAllocFast: Fix verifier errors after assigning to reserved registers (PR #128281)

2025-02-22 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/128281 >From 8d9b1ee1f1e67bd5f946a9e88e14fc7e0a34248f Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Thu, 12 Dec 2024 10:53:41 +0900 Subject: [PATCH] RegAllocFast: Fix verifier errors after assigning to reserved r

[llvm-branch-commits] [llvm] RegAllocFast: Fix verifier errors after assigning to reserved registers (PR #128281)

2025-02-22 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/128281 >From 8d9b1ee1f1e67bd5f946a9e88e14fc7e0a34248f Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Thu, 12 Dec 2024 10:53:41 +0900 Subject: [PATCH] RegAllocFast: Fix verifier errors after assigning to reserved r

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard agains operator& hijacking. (PR #128351)

2025-02-22 Thread Mark de Wever via llvm-branch-commits
https://github.com/mordante created https://github.com/llvm/llvm-project/pull/128351 This set usage of operator& instead of std::addressof seems not be easy to "abuse". Some seem easy to misuse, like basic_ostream::operator<<, trying to do that results in compilation errors since the `widen` f

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard against operator& hijacking. (PR #128351)

2025-02-22 Thread Mark de Wever via llvm-branch-commits
https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/128351 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard agains operator& hijacking. (PR #128351)

2025-02-22 Thread Mark de Wever via llvm-branch-commits
https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/128351 >From 05c33c80b15e9f1cd27206f31ff69add583f72af Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 16 Feb 2025 13:25:15 +0100 Subject: [PATCH] [NFC][libc++] Guard agains operator& hijacking. This set usage

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard agains operator& hijacking. (PR #128351)

2025-02-22 Thread Mark de Wever via llvm-branch-commits
https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/128351 >From 921a76f2275b2bde219a9f0a7a434da1f22294f9 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 16 Feb 2025 13:25:15 +0100 Subject: [PATCH] [NFC][libc++] Guard agains operator& hijacking. This set usage

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard agains operator& hijacking. (PR #128351)

2025-02-22 Thread via llvm-branch-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0e79268c4ac3b91dd5742bc04d8d5658bf587b0e 6614bf3ed9221cf47baeede6d06f2c9f2455dfe1 --e

[llvm-branch-commits] [libcxx] [NFC][libc++] Guard agains operator& hijacking. (PR #128351)

2025-02-22 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Mark de Wever (mordante) Changes This set usage of operator& instead of std::addressof seems not be easy to "abuse". Some seem easy to misuse, like basic_ostream::operator<<, trying to do that results in compilation errors since the `wid

[llvm-branch-commits] [clang] c47780a - Revert "[analyzer] Delay the checker constructions after parsing (#127409)"

2025-02-22 Thread via llvm-branch-commits
Author: Balazs Benics Date: 2025-02-22T11:42:41+01:00 New Revision: c47780aa45385a617e9beeb032896beebb2f3411 URL: https://github.com/llvm/llvm-project/commit/c47780aa45385a617e9beeb032896beebb2f3411 DIFF: https://github.com/llvm/llvm-project/commit/c47780aa45385a617e9beeb032896beebb2f3411.diff

[llvm-branch-commits] [llvm] release/20.x: [DAGCombiner] visitFREEZE: Early exit when N is deleted (#128161) (PR #128283)

2025-02-22 Thread Simon Pilgrim via llvm-branch-commits
https://github.com/RKSimon approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/128283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits