https://github.com/arsenm updated
https://github.com/llvm/llvm-project/pull/128469
>From 399d5d603c7127e8480b665860cc0a8073e0a503 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Sun, 23 Feb 2025 11:21:34 +0700
Subject: [PATCH 1/2] RegAlloc: Use new approach to handling failed allocations
T
serge-sans-paille wrote:
@vitalybuka if I understand @MaskRay advice correctly, we just want to finish
the command line argument parsing before exiting because of errors.
https://github.com/llvm/llvm-project/pull/128447
___
llvm-branch-commits mailing
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8cfd2db29c5079a02dab713c59cfa8a5674d6ea3
936ef337f1c3cd0b94fd494dcb81e6e09ed0e284 --e
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
Author: Vitaly Buka (vitalybuka)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/128474.diff
1 Files Affected:
- (modified) llvm/lib/Support/Unix/DynamicLibrary.inc (+7-2)
``diff
diff --git a/llvm/lib/Support
https://github.com/vitalybuka converted_to_draft
https://github.com/llvm/llvm-project/pull/128474
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/128474
None
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
This fixes an assert after allocation failure.
Rather than collecting failed virtual registers and hacking
on the uses after the fact, directly hack on the uses and rewrite
the registers to the dumm
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/128469
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/128469?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/128469
This fixes an assert after allocation failure.
Rather than collecting failed virtual registers and hacking
on the uses after the fact, directly hack on the uses and rewrite
the registers to the dummy assignment i
quic-garvgupt wrote:
It's been a few weeks since this patch was last reviewed. If everything looks
good, could someone please provide an LGTM? I'd like to merge this patch soon.
https://github.com/llvm/llvm-project/pull/121830
___
llvm-branch-commits
Author: Chris Apple
Date: 2025-02-24T14:20:18+09:00
New Revision: cbe1fac154be42b8b4cad2f25df0642726098bdf
URL:
https://github.com/llvm/llvm-project/commit/cbe1fac154be42b8b4cad2f25df0642726098bdf
DIFF:
https://github.com/llvm/llvm-project/commit/cbe1fac154be42b8b4cad2f25df0642726098bdf.diff
L
@@ -189,30 +198,19 @@ class MachineSinking : public MachineFunctionPass {
bool EnableSinkAndFold;
public:
- static char ID; // Pass identification
-
- MachineSinking() : MachineFunctionPass(ID) {
-initializeMachineSinkingPass(*PassRegistry::getPassRegistry());
- }
-
-
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/128447
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/128447
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/128447
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/128447
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
vitalybuka wrote:
> > What the motivation behind this change?
>
> Bad printf format string, when radix is not one of enum.
>
> If you realy think recovery is important, I'll change fallback to default on
> error.
Done
https://github.com/llvm/llvm-project/pull/128447
_
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/128447
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
vitalybuka wrote:
> What the motivation behind this change?
Bad printf spec, when radix is not one of enum.
If you realy think recovery is important, I'll change fallback to default on
error.
https://github.com/llvm/llvm-project/pull/128447
___
llvm
https://github.com/zyn0217 approved this pull request.
https://github.com/llvm/llvm-project/pull/128392
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
MaskRay wrote:
A lot of utilities using LLVMOption, including clang and lld, are able to
report multiple unknown option errors or other parsing errors before exiting.
What the motivation behind this change?
https://github.com/llvm/llvm-project/pull/128447
__
hassnaaHamdi wrote:
> There is a test failure.
>
> Why is it important for this change to be part of the LLVM 20 release?
This patch was supposed to be included in the release, but it exposed an issue
(missing implementation) somewhere else (not related to it), so it got delayed
until that is
llvmbot wrote:
@llvm/pr-subscribers-llvm-binary-utilities
Author: Vitaly Buka (vitalybuka)
Changes
This is very uncommon to recover from such errors.
It's especially bad or Radix, which affect format
specifiers.
---
Full diff: https://github.com/llvm/llvm-project/pull/128447.diff
1 Fil
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/128447
This is very uncommon to recover from such errors.
It's especially bad or Radix, which affect format
specifiers.
___
llvm-branch-commits mailing list
llvm-branch-
Author: Robert Imschweiler
Date: 2025-02-23T21:24:30+01:00
New Revision: 54f13182cb208abd397347a63953d4b75f112e63
URL:
https://github.com/llvm/llvm-project/commit/54f13182cb208abd397347a63953d4b75f112e63
DIFF:
https://github.com/llvm/llvm-project/commit/54f13182cb208abd397347a63953d4b75f112e63.
HighCommander4 wrote:
> LGTM in general, but my concern would be that we're less clear about the
> number of uses of this function out-of-tree (and how hard it could be to
> migrate them to HeuristicResolver), so as an alternative, can we turn the
> implementation to use HeuristicResolver and
nikic wrote:
There is a test failure.
Why is it important for this change to be part of the LLVM 20 release?
https://github.com/llvm/llvm-project/pull/128389
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/128392
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/zyn0217 commented:
LGTM in general, but my concern would be that we're less clear if there's any
use of this function out-of-tree, so as an alternative, can we turn the
implementation to use HeuristicResolver and explicitly deprecate it for a while
before eventually removing
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/128392
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
31 matches
Mail list logo
