llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: None (llvmbot)
Changes
Backport 4c2d1b4c53de d4ab3df320f9
Requested by: @davemgreen
---
Full diff: https://github.com/llvm/llvm-project/pull/129997.diff
2 Files Affected:
- (modified) llvm/lib/Target/AArch64/AArch64ISelLoweri
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: None (llvmbot)
Changes
Backport b673a59c9ae5 ab811e75734a
Requested by: @davemgreen
---
Full diff: https://github.com/llvm/llvm-project/pull/129996.diff
4 Files Affected:
- (modified) llvm/lib/Target/AArch64/AArch64ISelLoweri
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/129997
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@alexrp What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/129996
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/129996
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/129996
Backport b673a59c9ae5 ab811e75734a
Requested by: @davemgreen
>From e0f31d9f2345b4ddf4ac96e8275524aac5e827d4 Mon Sep 17 00:00:00 2001
From: David Green
Date: Wed, 5 Mar 2025 11:23:33 +
Subject: [PATCH 1/2]
jmciver wrote:
@dtcxzyw I was not aware I should be using a fuzzer. What tool would you
recommend?
>From a correctness standpoint the match is relatively narrow and I have
>discussed with @nlopes extensively. The patch has been tested with bootstrap
>build of LLVM running all regressions. Add
@@ -4813,15 +4813,22 @@ Instruction *InstCombinerImpl::visitFreeze(FreezeInst
&I) {
// TODO: This could use getBinopAbsorber() / getBinopIdentity() to avoid
// duplicating logic for binops at least.
auto getUndefReplacement = [&I](Type *Ty) {
-Constant *BestVal
@@ -3124,6 +3124,19 @@ inline auto m_c_LogicalOp(const LHS &L, const RHS &R) {
return m_LogicalOp(L, R);
}
+struct GuaranteedNotToBeUndefOrPoison_match {
+ template bool match(ITy *V) {
+if (auto *AsValue = dyn_cast(V))
+ return isGuaranteedNotToBeUndefOrPoison(As
@@ -3124,6 +3124,19 @@ inline auto m_c_LogicalOp(const LHS &L, const RHS &R) {
return m_LogicalOp(L, R);
}
+struct GuaranteedNotToBeUndefOrPoison_match {
+ template bool match(ITy *V) {
+if (auto *AsValue = dyn_cast(V))
+ return isGuaranteedNotToBeUndefOrPoison(As
@@ -4813,15 +4813,22 @@ Instruction *InstCombinerImpl::visitFreeze(FreezeInst
&I) {
// TODO: This could use getBinopAbsorber() / getBinopIdentity() to avoid
// duplicating logic for binops at least.
auto getUndefReplacement = [&I](Type *Ty) {
-Constant *BestVal
Author: Vitaly Buka
Date: 2025-03-05T18:40:30-08:00
New Revision: 56f8d690f4d0c812c6e7b4173d4be940dfa1bf36
URL:
https://github.com/llvm/llvm-project/commit/56f8d690f4d0c812c6e7b4173d4be940dfa1bf36
DIFF:
https://github.com/llvm/llvm-project/commit/56f8d690f4d0c812c6e7b4173d4be940dfa1bf36.diff
L
dtcxzyw wrote:
> I would like to incorporate this and then once freeze poison -> null
> canonicalization is removed from InstCombine refactor appropriately. Would
> this be acceptable?
I don't mean to block this patch. I just worry that these patches may not be
well tested (fuzzers/compile-ti
arsenm wrote:
### Merge activity
* **Mar 5, 9:11 PM EST**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/129893).
https://github.com/llvm/llvm-project/pull/129893
__
@@ -603,11 +601,7 @@ SIRegisterInfo::getMaxNumVectorRegs(const MachineFunction
&MF) const {
if (MinNumAGPRs == DefaultNumAGPR.first) {
// Default to splitting half the registers if AGPRs are required.
-
- if (MFI->mayNeedAGPRs())
-MinNumAGPRs = MaxNumAG
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/129893
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/129893
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -603,11 +601,7 @@ SIRegisterInfo::getMaxNumVectorRegs(const MachineFunction
&MF) const {
if (MinNumAGPRs == DefaultNumAGPR.first) {
// Default to splitting half the registers if AGPRs are required.
-
- if (MFI->mayNeedAGPRs())
-MinNumAGPRs = MaxNumAG
jmciver wrote:
@nikic and @dtcxzyw thanks for the feedback.
This patch does bypasses the need for freeze poison -> null canonicalization
removal in InstCombine. To provide context I am seeing the lack of store of
select freeze poison folding in uninitialized memory semantics work that I am
do
https://github.com/mingmingl-llvm updated
https://github.com/llvm/llvm-project/pull/129781
>From 072c44f0f9272682480cc2837196a906bd694276 Mon Sep 17 00:00:00 2001
From: mingmingl
Date: Fri, 28 Feb 2025 14:41:56 -0800
Subject: [PATCH 1/2] [CodeGen][StaticDataSplitter]Support constant pool
parti
@@ -386,6 +386,16 @@ MCSection *TargetLoweringObjectFile::getSectionForConstant(
return DataSection;
}
+MCSection *TargetLoweringObjectFile::getSectionForConstant(
+const DataLayout &DL, SectionKind Kind, const Constant *C, Align
&Alignment,
+StringRef SectionPrefix
@@ -203,17 +218,34 @@ void StaticDataSplitter::updateStatsWithProfiles(const
MachineFunction &MF) {
void StaticDataSplitter::annotateStaticDataWithoutProfiles(
const MachineFunction &MF) {
+ const MachineConstantPool *MCP = MF.getConstantPool();
for (const auto &MBB :
@@ -1072,6 +1072,41 @@ MCSection
*TargetLoweringObjectFileELF::getSectionForConstant(
return DataRelROSection;
}
+MCSection *TargetLoweringObjectFileELF::getSectionForConstant(
+const DataLayout &DL, SectionKind Kind, const Constant *C, Align
&Alignment,
+StringRef
@@ -2791,8 +2791,26 @@ void AsmPrinter::emitConstantPool() {
if (!CPE.isMachineConstantPoolEntry())
C = CPE.Val.ConstVal;
-MCSection *S = getObjFileLowering().getSectionForConstant(
-getDataLayout(), Kind, C, Alignment);
+MCSection *S = nullptr;
-
https://github.com/delcypher edited
https://github.com/llvm/llvm-project/pull/128977
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -635,6 +635,13 @@ class CGDebugInfo {
llvm::DILocation *CreateTrapFailureMessageFor(llvm::DebugLoc TrapLocation,
StringRef Category,
StringRef FailureMsg);
+ /// Create a debug
https://github.com/delcypher edited
https://github.com/llvm/llvm-project/pull/128977
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -3598,6 +3598,14 @@ llvm::DIMacroFile
*CGDebugInfo::CreateTempMacroFile(llvm::DIMacroFile *Parent,
return DBuilder.createTempMacroFile(Parent, Line, FName);
}
+llvm::DILocation *CGDebugInfo::CreateSyntheticInline(llvm::DebugLoc Location,
+
https://github.com/delcypher approved this pull request.
Thanks for explaining the purpose.
Regarding the "more easily see why we crashed." please be aware [I have a GSoC
proposal to basically do
this](https://discourse.llvm.org/t/clang-gsoc-2025-usability-improvements-for-trapping-undefined-b
https://github.com/joaosaffran updated
https://github.com/llvm/llvm-project/pull/129759
>From b390cd27d2b32f0e3b3d13c8ef3020cbd6af1fa9 Mon Sep 17 00:00:00 2001
From: joaosaffran <126493771+joaosaff...@users.noreply.github.com>
Date: Tue, 4 Mar 2025 10:30:07 -0800
Subject: [PATCH 1/5] Adding root
https://github.com/fmayer edited
https://github.com/llvm/llvm-project/pull/128977
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
fmayer wrote:
> @fmayer The usual approach for indicating instrumentation in Clang is to use
> opt-remarks. This is the approach we use for `-fbounds-safety`.
>
> In `-fbounds-safety` we embed "trap reasons" in debug info so that debuggers
> and symbolication tools can better understand the re
delcypher wrote:
@fmayer The usual approach for indicating instrumentation in Clang is to use
opt-remarks. This is the approach we use for `-fbounds-safety`.
In `-fbounds-safety` we embed "trap reasons" in debug info so that debuggers
and symbolication tools can better understand the reason f
https://github.com/bob80905 approved this pull request.
Just a nit but this looks good to me
https://github.com/llvm/llvm-project/pull/125131
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -0,0 +1,108 @@
+//===- HLSLRootSignature.cpp - HLSL Root Signature helper objects
+//--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,108 @@
+//===- HLSLRootSignature.cpp - HLSL Root Signature helper objects
+//--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/rampitec approved this pull request.
https://github.com/llvm/llvm-project/pull/129893
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/125131
>From abe7e6703a008608e19ce3f9bdcbd1b613fab60d Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Wed, 29 Jan 2025 19:40:08 +
Subject: [PATCH 1/7] add basic empty root signature
---
clang/lib/CodeGen/CGHLSL
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/125131
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/125131
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,29 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -emit-llvm -o - %s |
FileCheck %s
+
+// CHECK-DAG: ![[#EMPTY:]] = !{}
+[shader("compute"), RootSignature("")]
+[numthreads(1,1,1)]
+void FirstEntry() {}
+
+// CHECK-DAG: ![[#CBV:]] = !{!"CBV", i32 1, i32
nikic wrote:
> We can do this fold in InstSimplify: https://alive2.llvm.org/ce/z/Dm53TP
The transform is only valid if the freeze(poison) is one-use. And I don't think
that InstSimplify should be doing any use-based checks. So I think InstCombine
is the right place for it.
https://github.com/
llvmbot wrote:
@shafik What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/129836
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
This performs the minimal replacment of amdgpu-no-agpr to
amdgpu-num-agpr=0. Most of the test diffs are due to the new
attribute sorting later alphabetically.
We could do better by trying to perform
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/129893
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/129893?utm_source=stack-comment-downstack-mergeability-warning";
optimisan wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/129853?utm_source=stack-comment-downstack-mergeability-warning
Author: Benjamin Maxwell
Date: 2025-03-05T13:48:07Z
New Revision: f414ee456de732da99ae6a4c88304a6d82a7ff18
URL:
https://github.com/llvm/llvm-project/commit/f414ee456de732da99ae6a4c88304a6d82a7ff18
DIFF:
https://github.com/llvm/llvm-project/commit/f414ee456de732da99ae6a4c88304a6d82a7ff18.diff
L
arsenm wrote:
psdb fails on some atomic tests with these, so they need some debugging
https://github.com/llvm/llvm-project/pull/122138
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
Michael137 wrote:
Could you elaborate on how this will be used/the motivation for this?
https://github.com/llvm/llvm-project/pull/128977
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/129836
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
optimisan wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/129857?utm_source=stack-comment-downstack-mergeability-warning
optimisan wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/129865?utm_source=stack-comment-downstack-mergeability-warning
https://github.com/optimisan created
https://github.com/llvm/llvm-project/pull/129865
None
>From 32a8bd59f64750fb3c2e72a7e26ba7a81ff86210 Mon Sep 17 00:00:00 2001
From: Akshat Oke
Date: Wed, 5 Mar 2025 10:11:27 +
Subject: [PATCH] [CodeGen][NPM] Port XRayInstrumentation to NPM
---
.../llv
optimisan wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/129866?utm_source=stack-comment-downstack-mergeability-warning
https://github.com/optimisan created
https://github.com/llvm/llvm-project/pull/129866
None
>From c9386f19d4a87f9fd88bb96aa0c23eba638e96da Mon Sep 17 00:00:00 2001
From: Akshat Oke
Date: Wed, 5 Mar 2025 10:34:25 +
Subject: [PATCH] [CodeGen][NPM] Port PatchableFunction to NPM
---
llvm/incl
https://github.com/optimisan updated
https://github.com/llvm/llvm-project/pull/129857
>From 0ba6ca6ef0172f61f23cfee8d20a59e1138d5dfc Mon Sep 17 00:00:00 2001
From: Akshat Oke
Date: Wed, 5 Mar 2025 09:19:08 +
Subject: [PATCH] [CodeGen][NPM] Port FEntryInserter to NPM
---
llvm/include/llvm/
https://github.com/hassnaaHamdi closed
https://github.com/llvm/llvm-project/pull/128389
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/optimisan created
https://github.com/llvm/llvm-project/pull/129857
None
>From 2a78a73afa6bd50b0c9a71da41993917eba14587 Mon Sep 17 00:00:00 2001
From: Akshat Oke
Date: Wed, 5 Mar 2025 09:19:08 +
Subject: [PATCH] [CodeGen][NPM] Port FEntryInserter to NPM
---
llvm/include
https://github.com/optimisan created
https://github.com/llvm/llvm-project/pull/129853
None
>From a01bc11d08290eab70e8e48858791cfbeb4123e6 Mon Sep 17 00:00:00 2001
From: Akshat Oke
Date: Wed, 5 Mar 2025 08:59:23 +
Subject: [PATCH] [CodeGen][NPM] Port MachineBlockPlacementStats to NPM
---
https://github.com/optimisan ready_for_review
https://github.com/llvm/llvm-project/pull/129853
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/129836
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
62 matches
Mail list logo
