[llvm-branch-commits] [llvm] [DirectX] Implement DXILResourceImplicitBinding pass (PR #138043)

2025-05-08 Thread Helena Kotas via llvm-branch-commits
@@ -0,0 +1,182 @@ +//===- DXILResourceImplicitBinding.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[llvm-branch-commits] [llvm] [DirectX] Implement DXILResourceImplicitBinding pass (PR #138043)

2025-05-08 Thread Helena Kotas via llvm-branch-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/138043 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [GOFF] Add writing of text records (PR #137235)

2025-05-08 Thread Ulrich Weigand via llvm-branch-commits
uweigand wrote: Huh. Looks like the new test case now fails ... https://github.com/llvm/llvm-project/pull/137235 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit

[llvm-branch-commits] [llvm] AMDGPU: Test more subtargets in minimumnum/maximumnum tests (PR #139144)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **May 9, 2:00 AM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/139144). https://github.com/llvm/llvm-project/pull/139144 __

[llvm-branch-commits] [llvm] AMDGPU: Add minimumnum/maximumnum tests with amdgpu-ieee=0 (PR #139145)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **May 9, 2:00 AM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/139145). https://github.com/llvm/llvm-project/pull/139145 __

[llvm-branch-commits] [llvm] AMDGPU: Form min3/max3 from minimumnum/maximumnum (PR #139137)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **May 9, 2:00 AM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/139137). https://github.com/llvm/llvm-project/pull/139137 __

[llvm-branch-commits] [llvm] AMDGPU: Add baseline tests for min3/max3 from minimumnum/maximumnum (PR #139136)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **May 9, 2:00 AM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/139136). https://github.com/llvm/llvm-project/pull/139136 __

[llvm-branch-commits] MC: Emit symbols for R_X86_64_PLT32 relocation pointing to symbols with non-zero values. (PR #138795)

2025-05-08 Thread Peter Collingbourne via llvm-branch-commits
https://github.com/pcc closed https://github.com/llvm/llvm-project/pull/138795 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] MC: Emit symbols for R_X86_64_PLT32 relocation pointing to symbols with non-zero values. (PR #138795)

2025-05-08 Thread Peter Collingbourne via llvm-branch-commits
pcc wrote: Abandoning this and will address in the linker change (#138366) instead. https://github.com/llvm/llvm-project/pull/138795 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[llvm-branch-commits] [BOLT] Print .text scores in perf2bolt (PR #139194)

2025-05-08 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-bolt Author: Amir Ayupov (aaupov) Changes Expose heatmap functionality of profile score computation for text section under a new option `--print-heatmap-stats`. This option collects and prints the following stats: - hotness is the percentage of samples

[llvm-branch-commits] [BOLT] Compute section utilization in heatmap (PR #139193)

2025-05-08 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-bolt Author: Amir Ayupov (aaupov) Changes Heatmap collects samples grouped by buckets. The size is configurable via `--block-size`, with 64 bytes as the default (X86 cache line size). Define section utilization as the number of buckets mapped to the sec

[llvm-branch-commits] [BOLT] Compute section utilization in heatmap (PR #139193)

2025-05-08 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov created https://github.com/llvm/llvm-project/pull/139193 Heatmap collects samples grouped by buckets. The size is configurable via `--block-size`, with 64 bytes as the default (X86 cache line size). Define section utilization as the number of buckets mapped to the sect

[llvm-branch-commits] [BOLT] Print .text scores in perf2bolt (PR #139194)

2025-05-08 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov created https://github.com/llvm/llvm-project/pull/139194 Expose heatmap functionality of profile score computation for text section under a new option `--print-heatmap-stats`. This option collects and prints the following stats: - hotness is the percentage of samples a

[llvm-branch-commits] [llvm] [X86] Manage atomic load of fp -> int promotion in DAG (PR #120386)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120386 >From 0219785c33a0d05bddd76b1059ca2d62950ffb4d Mon Sep 17 00:00:00 2001 From: jofrn Date: Wed, 18 Dec 2024 03:38:23 -0500 Subject: [PATCH] [X86] Manage atomic load of fp -> int promotion in DAG When lowering atom

[llvm-branch-commits] [llvm] [AMDGPU][Fake16] Support OPSEL for `v_cvt_f16_f32` and `v_cvt_f32_f16` (PR #139185)

2025-05-08 Thread Shilei Tian via llvm-branch-commits
shiltian wrote: This is still a work in progress, as three test cases are currently crashing. I'd like to get some early feedback on whether this is the right approach to support `opsel` for fake16. https://github.com/llvm/llvm-project/pull/139185 __

[llvm-branch-commits] [llvm] [AMDGPU][Fake16] Support OPSEL for `v_cvt_f16_f32` and `v_cvt_f32_f16` (PR #139185)

2025-05-08 Thread Shilei Tian via llvm-branch-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/139185 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AMDGPU][Fake16] Support OPSEL for `v_cvt_f16_f32` and `v_cvt_f32_f16` (PR #139185)

2025-05-08 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Shilei Tian (shiltian) Changes --- Patch is 31.76 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/139185.diff 13 Files Affected: - (modified) llvm/lib/Target/AMDGPU/VOP1Instructions

[llvm-branch-commits] [llvm] [AMDGPU][Fake16] Support OPSEL for `v_cvt_f16_f32` and `v_cvt_f32_f16` (PR #139185)

2025-05-08 Thread Shilei Tian via llvm-branch-commits
shiltian wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/139185?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [llvm] [AMDGPU][Fake16] Support OPSEL for `v_cvt_f16_f32` and `v_cvt_f32_f16` (PR #139185)

2025-05-08 Thread Shilei Tian via llvm-branch-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/139185 None >From 810682aeeaa305de0a36145770016f7364404908 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Thu, 8 May 2025 19:26:31 -0400 Subject: [PATCH] [AMDGPU][Fake16] Support OPSEL for `v_cvt_f16_f32` and `v_c

[llvm-branch-commits] [llvm] [SelectionDAG] Legalize <1 x T> vector types for atomic load (PR #120385)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120385 >From f5cd42bd4eb8290415b33368862485fa904f3699 Mon Sep 17 00:00:00 2001 From: jofrn Date: Wed, 18 Dec 2024 03:37:17 -0500 Subject: [PATCH] [SelectionDAG] Legalize <1 x T> vector types for atomic load `load atomic

[llvm-branch-commits] [llvm] [AtomicExpand] Add bitcasts when expanding load atomic vector (PR #120716)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120716 >From f2e8e753a20896b7db5cacbfa13b0d027ca5d9c4 Mon Sep 17 00:00:00 2001 From: jofrn Date: Fri, 20 Dec 2024 06:14:28 -0500 Subject: [PATCH] [AtomicExpand] Add bitcasts when expanding load atomic vector AtomicExpan

[llvm-branch-commits] [llvm] [SelectionDAG] Legalize <1 x T> vector types for atomic load (PR #120385)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120385 >From f5cd42bd4eb8290415b33368862485fa904f3699 Mon Sep 17 00:00:00 2001 From: jofrn Date: Wed, 18 Dec 2024 03:37:17 -0500 Subject: [PATCH] [SelectionDAG] Legalize <1 x T> vector types for atomic load `load atomic

[llvm-branch-commits] [llvm] [SelectionDAG] Widen <2 x T> vector types for atomic load (PR #120598)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120598 >From e961155a2adcf0368809e7c96cbfcb5e9f5bed12 Mon Sep 17 00:00:00 2001 From: jofrn Date: Thu, 19 Dec 2024 11:19:39 -0500 Subject: [PATCH] [SelectionDAG] Widen <2 x T> vector types for atomic load Vector types of

[llvm-branch-commits] [llvm] [X86] Add atomic vector tests for unaligned >1 sizes. (PR #120387)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120387 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-ser

[llvm-branch-commits] [llvm] [X86] Remove extra MOV after widening atomic load (PR #138635)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/138635 >From b6c4b4884018aa4cb440c273109631f1db8583c2 Mon Sep 17 00:00:00 2001 From: jofernau_amdeng Date: Tue, 6 May 2025 01:48:11 -0400 Subject: [PATCH] [X86] Remove extra MOV after widening atomic load This change ad

[llvm-branch-commits] [llvm] [X86] Manage atomic load of fp -> int promotion in DAG (PR #120386)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120386 >From 0219785c33a0d05bddd76b1059ca2d62950ffb4d Mon Sep 17 00:00:00 2001 From: jofrn Date: Wed, 18 Dec 2024 03:38:23 -0500 Subject: [PATCH] [X86] Manage atomic load of fp -> int promotion in DAG When lowering atom

[llvm-branch-commits] [llvm] [SelectionDAG] Widen <2 x T> vector types for atomic load (PR #120598)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120598 >From e961155a2adcf0368809e7c96cbfcb5e9f5bed12 Mon Sep 17 00:00:00 2001 From: jofrn Date: Thu, 19 Dec 2024 11:19:39 -0500 Subject: [PATCH] [SelectionDAG] Widen <2 x T> vector types for atomic load Vector types of

[llvm-branch-commits] [llvm] [SelectionDAG][X86] Remove unused elements from atomic vector. (PR #125432)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/125432 >From 479a22724ed7ff80ede83321955d61d00d7c4135 Mon Sep 17 00:00:00 2001 From: jofrn Date: Fri, 31 Jan 2025 13:12:56 -0500 Subject: [PATCH] [SelectionDAG][X86] Remove unused elements from atomic vector. After spl

[llvm-branch-commits] [llvm] [SelectionDAG][X86] Remove unused elements from atomic vector. (PR #125432)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/125432 >From 479a22724ed7ff80ede83321955d61d00d7c4135 Mon Sep 17 00:00:00 2001 From: jofrn Date: Fri, 31 Jan 2025 13:12:56 -0500 Subject: [PATCH] [SelectionDAG][X86] Remove unused elements from atomic vector. After spl

[llvm-branch-commits] [llvm] [AtomicExpand] Add bitcasts when expanding load atomic vector (PR #120716)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120716 >From f2e8e753a20896b7db5cacbfa13b0d027ca5d9c4 Mon Sep 17 00:00:00 2001 From: jofrn Date: Fri, 20 Dec 2024 06:14:28 -0500 Subject: [PATCH] [AtomicExpand] Add bitcasts when expanding load atomic vector AtomicExpan

[llvm-branch-commits] [llvm] [SelectionDAG] Split vector types for atomic load (PR #120640)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120640 >From 13a5e878cd1edc26db156b9cacabe6600bc37341 Mon Sep 17 00:00:00 2001 From: jofrn Date: Thu, 19 Dec 2024 16:25:55 -0500 Subject: [PATCH] [SelectionDAG] Split vector types for atomic load Vector types that aren'

[llvm-branch-commits] [llvm] [AtomicExpand] Add bitcasts when expanding load atomic vector (PR #120716)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120716 >From f2e8e753a20896b7db5cacbfa13b0d027ca5d9c4 Mon Sep 17 00:00:00 2001 From: jofrn Date: Fri, 20 Dec 2024 06:14:28 -0500 Subject: [PATCH] [AtomicExpand] Add bitcasts when expanding load atomic vector AtomicExpan

[llvm-branch-commits] [llvm] [SelectionDAG] Split vector types for atomic load (PR #120640)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120640 >From 13a5e878cd1edc26db156b9cacabe6600bc37341 Mon Sep 17 00:00:00 2001 From: jofrn Date: Thu, 19 Dec 2024 16:25:55 -0500 Subject: [PATCH] [SelectionDAG] Split vector types for atomic load Vector types that aren'

[llvm-branch-commits] [llvm] [SelectionDAG] Split vector types for atomic load (PR #120640)

2025-05-08 Thread via llvm-branch-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/120640 >From 13a5e878cd1edc26db156b9cacabe6600bc37341 Mon Sep 17 00:00:00 2001 From: jofrn Date: Thu, 19 Dec 2024 16:25:55 -0500 Subject: [PATCH] [SelectionDAG] Split vector types for atomic load Vector types that aren'

[llvm-branch-commits] [BOLT][test] Add pseudo-probe-split-func.test (PR #139171)

2025-05-08 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov created https://github.com/llvm/llvm-project/pull/139171 Test Plan: bin/llvm-lit -a tools/bolt/test/X86/pseudo-probe-split-func.test ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.ll

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add optional parameters for RootConstants (PR #138007)

2025-05-08 Thread Justin Bogner via llvm-branch-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/138007 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add parsing for RootFlags (PR #138055)

2025-05-08 Thread Justin Bogner via llvm-branch-commits
@@ -1842,5 +1842,6 @@ def err_hlsl_unexpected_end_of_params def err_hlsl_rootsig_repeat_param : Error<"specified the same parameter '%0' multiple times">; def err_hlsl_rootsig_missing_param : Error<"did not specify mandatory parameter '%0'">; def err_hlsl_number_literal_overf

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add parsing for RootFlags (PR #138055)

2025-05-08 Thread Justin Bogner via llvm-branch-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/138055 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add mandatory parameters for RootConstants (PR #138002)

2025-05-08 Thread Justin Bogner via llvm-branch-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/138002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT][test] Add pseudo-probe-split-func.test (PR #139171)

2025-05-08 Thread via llvm-branch-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c -- bolt/test/X86/Inputs/pseudo-probe-split-func.c

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Define and integrate rootsig clang attr and decl (PR #137690)

2025-05-08 Thread Justin Bogner via llvm-branch-commits
@@ -149,6 +149,29 @@ void DescriptorTableClause::dump(raw_ostream &OS) const { OS << ")"; } +// Helper struct so that we can use the overloaded notation of std::visit +template struct OverloadMethods : Ts... { + using Ts::operator()...; +}; + +template OverloadMethods(Ts.

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Define and integrate rootsig clang attr and decl (PR #137690)

2025-05-08 Thread Justin Bogner via llvm-branch-commits
@@ -149,6 +149,29 @@ void DescriptorTableClause::dump(raw_ostream &OS) const { OS << ")"; } +// Helper struct so that we can use the overloaded notation of std::visit +template struct OverloadMethods : Ts... { + using Ts::operator()...; +}; + +template OverloadMethods(Ts.

[llvm-branch-commits] [BOLT][test] Add pseudo-probe-split-func.test (PR #139171)

2025-05-08 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-bolt Author: Amir Ayupov (aaupov) Changes Test Plan: bin/llvm-lit -a tools/bolt/test/X86/pseudo-probe-split-func.test --- Full diff: https://github.com/llvm/llvm-project/pull/139171.diff 2 Files Affected: - (added) bolt/test/X86/Inputs/pseudo-prob

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add parsing for RootFlags (PR #138055)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
@@ -27,6 +27,13 @@ RootSignatureParser::RootSignatureParser(SmallVector &Elements, bool RootSignatureParser::parse() { // Iterate as many RootElements as possible do { +if (tryConsumeExpectedToken(TokenKind::kw_RootFlags)) { + auto Flags = parseRootFlags(); +

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add parsing for RootFlags (PR #138055)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
https://github.com/V-FEXrt approved this pull request. https://github.com/llvm/llvm-project/pull/138055 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add optional parameters for RootConstants (PR #138007)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
@@ -78,6 +78,13 @@ std::optional RootSignatureParser::parseRootConstants() { Constants.Reg = Params->Reg.value(); + // Fill in optional parameters + if (Params->Visibility.has_value()) V-FEXrt wrote: nit: ```suggestion if (Params->Visibility) ``` htt

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add optional parameters for RootConstants (PR #138007)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
https://github.com/V-FEXrt approved this pull request. https://github.com/llvm/llvm-project/pull/138007 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add optional parameters for RootConstants (PR #138007)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
@@ -82,6 +82,8 @@ class RootSignatureParser { struct ParsedConstantParams { std::optional Reg; std::optional Num32BitConstants; +std::optional Space; V-FEXrt wrote: Yeah I think I agree with Finn here. Seems to map more directly to the source to

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/139115 >From fa6e19481f448db273f84d270891e737ff021749 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 7 May 2025 15:32:08 -0500 Subject: [PATCH 1/5] [clang][OpenMP] Pass OpenMP version to getOpenMPDirec

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add mandatory parameters for RootConstants (PR #138002)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
@@ -57,6 +57,27 @@ std::optional RootSignatureParser::parseRootConstants() { RootConstants Constants; + auto Params = parseRootConstantParams(); + if (!Params.has_value()) V-FEXrt wrote: nit: ```suggestion if (Params) ``` https://github.com/llvm/llv

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add mandatory parameters for RootConstants (PR #138002)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
@@ -57,6 +57,27 @@ std::optional RootSignatureParser::parseRootConstants() { RootConstants Constants; + auto Params = parseRootConstantParams(); + if (!Params.has_value()) +return std::nullopt; + + // Check mandatory parameters were provided + if (!Params->Num32Bit

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add mandatory parameters for RootConstants (PR #138002)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
https://github.com/V-FEXrt approved this pull request. https://github.com/llvm/llvm-project/pull/138002 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] [HLSL][RootSignature] Add mandatory parameters for RootConstants (PR #138002)

2025-05-08 Thread Ashley Coleman via llvm-branch-commits
@@ -57,6 +57,27 @@ std::optional RootSignatureParser::parseRootConstants() { RootConstants Constants; + auto Params = parseRootConstantParams(); + if (!Params.has_value()) +return std::nullopt; + + // Check mandatory parameters were provided V-FEXrt

[llvm-branch-commits] [flang] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/139131 The OpenMP version is stored in LangOptions in SemanticsContext. Use the fallback version where SemanticsContext is unavailable (mostly in case of debug dumps). RFC: https://discourse.llvm.org/t/rfc-alternat

[llvm-branch-commits] [llvm] AMDGPU: Add minimumnum/maximumnum tests with amdgpu-ieee=0 (PR #139145)

2025-05-08 Thread Stanislav Mekhanoshin via llvm-branch-commits
https://github.com/rampitec approved this pull request. https://github.com/llvm/llvm-project/pull/139145 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Test more subtargets in minimumnum/maximumnum tests (PR #139144)

2025-05-08 Thread Stanislav Mekhanoshin via llvm-branch-commits
https://github.com/rampitec approved this pull request. https://github.com/llvm/llvm-project/pull/139144 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Form min3/max3 from minimumnum/maximumnum (PR #139137)

2025-05-08 Thread Stanislav Mekhanoshin via llvm-branch-commits
https://github.com/rampitec approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/139137 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Add minimumnum/maximumnum tests with amdgpu-ieee=0 (PR #139145)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/139145?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] AMDGPU: Test more subtargets in minimumnum/maximumnum tests (PR #139144)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/139144?utm_source=stack-comment-downstack-mergeability-warning";

[llvm-branch-commits] [llvm] AMDGPU: Add baseline tests for min3/max3 from minimumnum/maximumnum (PR #139136)

2025-05-08 Thread Stanislav Mekhanoshin via llvm-branch-commits
https://github.com/rampitec approved this pull request. https://github.com/llvm/llvm-project/pull/139136 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Test more subtargets in minimumnum/maximumnum tests (PR #139144)

2025-05-08 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes --- Patch is 137.50 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/139144.diff 2 Files Affected: - (modified) llvm/test/CodeGen/AMDGPU/maximumnum.ll

[llvm-branch-commits] [llvm] AMDGPU: Add minimumnum/maximumnum tests with amdgpu-ieee=0 (PR #139145)

2025-05-08 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Matt Arsenault (arsenm) Changes With the IEEE bit disabled, the hardware instructions have the same behavior as these operations. --- Patch is 37.84 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-p

[llvm-branch-commits] [llvm] AMDGPU: Add minimumnum/maximumnum tests with amdgpu-ieee=0 (PR #139145)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/139145 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Test more subtargets in minimumnum/maximumnum tests (PR #139144)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/139144 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Test more subtargets in minimumnum/maximumnum tests (PR #139144)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/139144 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[llvm-branch-commits] [llvm] AMDGPU: Add minimumnum/maximumnum tests with amdgpu-ieee=0 (PR #139145)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/139145 With the IEEE bit disabled, the hardware instructions have the same behavior as these operations. >From 207f1fdab531781f5bf3bf7393dd2f8011227321 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Thu, 8 May 202

[llvm-branch-commits] [llvm] AMDGPU: Handle minimumnum/maximumnum in fneg combines (PR #139133)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
@@ -2513,9 +2513,9 @@ define { float, float } @v_fneg_maximumnum_multi_use_maximumnum_f32_ieee(float % ; GCN-LABEL: v_fneg_maximumnum_multi_use_maximumnum_f32_ieee: ; GCN: ; %bb.0: ; GCN-NEXT:s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) -; GCN-NEXT:v_mul_f32_e32 v1, 1

[llvm-branch-commits] [llvm] AMDGPU: Handle minimumnum/maximumnum in fneg combines (PR #139133)

2025-05-08 Thread Stanislav Mekhanoshin via llvm-branch-commits
https://github.com/rampitec approved this pull request. LGTM, although I do not see practical improvements in the tests. https://github.com/llvm/llvm-project/pull/139133 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://li

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
@@ -94,6 +94,10 @@ struct PrintingPolicy { /// The number of spaces to use to indent each line. unsigned Indentation : 8; + /// Version of the effective OpenMP spec (used to select directive name + /// spelling). + unsigned OpenMP : 8; + kparzysz wrote:

[llvm-branch-commits] [llvm] [NFC] Refactoring MCDXBC to support out of order storage of root parameters (PR #137284)

2025-05-08 Thread Finn Plummer via llvm-branch-commits
@@ -274,27 +274,37 @@ void DXContainerWriter::writeParts(raw_ostream &OS) { RS.StaticSamplersOffset = P.RootSignature->StaticSamplersOffset; for (const auto &Param : P.RootSignature->Parameters) { -mcdxbc::RootParameter NewParam; -NewParam.Header =

[llvm-branch-commits] [flang] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/139131 >From 9566bf6fd60d2b4f1dac86f6646002b2541e6736 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 7 May 2025 15:32:28 -0500 Subject: [PATCH 1/2] [flang][OpenMP] Pass OpenMP version to getOpenMPDirec

[llvm-branch-commits] [flang] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-08 Thread via llvm-branch-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- flang/examples/FlangOmpReport/FlangOmpReportVisitor

[llvm-branch-commits] [flang] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/139131 >From 9566bf6fd60d2b4f1dac86f6646002b2541e6736 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 7 May 2025 15:32:28 -0500 Subject: [PATCH 1/4] [flang][OpenMP] Pass OpenMP version to getOpenMPDirec

[llvm-branch-commits] [flang] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/139131 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[llvm-branch-commits] [flang] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-08 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-flang-semantics Author: Krzysztof Parzyszek (kparzysz) Changes The OpenMP version is stored in LangOptions in SemanticsContext. Use the fallback version where SemanticsContext is unavailable (mostly in case of debug dumps). RFC: https://discourse.llv

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/139115 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Alexey Bataev via llvm-branch-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/139115 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
@@ -73,13 +73,16 @@ namespace { PrintingPolicy Policy; std::string NL; const ASTContext *Context; +unsigned Version; kparzysz wrote: Oops, you're right. Removed. https://github.com/llvm/llvm-project/pull/139115 ___

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/139115 >From fa6e19481f448db273f84d270891e737ff021749 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 7 May 2025 15:32:08 -0500 Subject: [PATCH 1/6] [clang][OpenMP] Pass OpenMP version to getOpenMPDirec

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/139115 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
@@ -965,13 +965,13 @@ void StmtPrinter::VisitOMPTeamsDirective(OMPTeamsDirective *Node) { void StmtPrinter::VisitOMPCancellationPointDirective( OMPCancellationPointDirective *Node) { Indent() << "#pragma omp cancellation point " - << getOpenMPDirectiveName(Node

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/139115 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[llvm-branch-commits] [lld] release/20.x: [wasm-ld] Refactor WasmSym from static globals to per-link context (#134970) (PR #137620)

2025-05-08 Thread Sam Clegg via llvm-branch-commits
sbc100 wrote: > > > Do you not build llvm from source in your project? Can't you therefore > > > build from tip-of-tree? > > > > > > Hi, yes I think the latest changes on the release/latest_version.x branch > > is being used for https://github.com/compiler-research/CppInterOp > > (@vgvassile

[llvm-branch-commits] [clang] clang: Remove dest LangAS argument from performAddrSpaceCast (PR #138866)

2025-05-08 Thread John McCall via llvm-branch-commits
rjmccall wrote: I would like to continue to traffic in LangAS, if for no other reason than that it promotes better habits within CodeGen. Otherwise, I think we will end up with a lot of code that immediately lowers address spaces, and that will make it very difficult to treat address spaces as

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/139115 >From fa6e19481f448db273f84d270891e737ff021749 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 7 May 2025 15:32:08 -0500 Subject: [PATCH 1/2] [clang][OpenMP] Pass OpenMP version to getOpenMPDirec

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Alexey Bataev via llvm-branch-commits
@@ -94,6 +94,10 @@ struct PrintingPolicy { /// The number of spaces to use to indent each line. unsigned Indentation : 8; + /// Version of the effective OpenMP spec (used to select directive name + /// spelling). + unsigned OpenMP : 8; + alexey-bataev w

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Alexey Bataev via llvm-branch-commits
@@ -965,13 +965,13 @@ void StmtPrinter::VisitOMPTeamsDirective(OMPTeamsDirective *Node) { void StmtPrinter::VisitOMPCancellationPointDirective( OMPCancellationPointDirective *Node) { Indent() << "#pragma omp cancellation point " - << getOpenMPDirectiveName(Node

[llvm-branch-commits] [clang] [clang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139115)

2025-05-08 Thread Erich Keane via llvm-branch-commits
https://github.com/erichkeane commented: This seems to be reasonable as far as I can tell. I DO wonder if `getOpenMPDirectiveName` should lose non-version overload though, so we make sure we get this right everywhere. https://github.com/llvm/llvm-project/pull/139115 _

[llvm-branch-commits] [llvm] [GOFF] Add writing of text records (PR #137235)

2025-05-08 Thread Kai Nacke via llvm-branch-commits
@@ -571,7 +571,6 @@ void MCObjectFileInfo::initGOFFMCObjectFileInfo(const Triple &T) { GOFF::ESD_LB_Initial, GOFF::ESD_RQ_0, GOFF::ESD_ALIGN_Doubleword, 0}, RootSDSection); - redstar wrote: Fixed. https://github.co

[llvm-branch-commits] [llvm] [GOFF] Add writing of text records (PR #137235)

2025-05-08 Thread Kai Nacke via llvm-branch-commits
https://github.com/redstar updated https://github.com/llvm/llvm-project/pull/137235 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[llvm-branch-commits] [llvm] [NFC] Refactoring MCDXBC to support out of order storage of root parameters (PR #137284)

2025-05-08 Thread Finn Plummer via llvm-branch-commits
@@ -274,27 +274,37 @@ void DXContainerWriter::writeParts(raw_ostream &OS) { RS.StaticSamplersOffset = P.RootSignature->StaticSamplersOffset; for (const auto &Param : P.RootSignature->Parameters) { -mcdxbc::RootParameter NewParam; -NewParam.Header =

[llvm-branch-commits] [llvm] [NFC] Refactoring MCDXBC to support out of order storage of root parameters (PR #137284)

2025-05-08 Thread via llvm-branch-commits
@@ -274,27 +274,37 @@ void DXContainerWriter::writeParts(raw_ostream &OS) { RS.StaticSamplersOffset = P.RootSignature->StaticSamplersOffset; for (const auto &Param : P.RootSignature->Parameters) { -mcdxbc::RootParameter NewParam; -NewParam.Header =

[llvm-branch-commits] [llvm] [NFC] Refactoring MCDXBC to support out of order storage of root parameters (PR #137284)

2025-05-08 Thread Finn Plummer via llvm-branch-commits
@@ -274,27 +274,37 @@ void DXContainerWriter::writeParts(raw_ostream &OS) { RS.StaticSamplersOffset = P.RootSignature->StaticSamplersOffset; for (const auto &Param : P.RootSignature->Parameters) { -mcdxbc::RootParameter NewParam; -NewParam.Header =

[llvm-branch-commits] [llvm] [NFC] Refactoring MCDXBC to support out of order storage of root parameters (PR #137284)

2025-05-08 Thread Finn Plummer via llvm-branch-commits
@@ -6,21 +6,87 @@ // //===--===// +#include "llvm/ADT/STLForwardCompat.h" #include "llvm/BinaryFormat/DXContainer.h" +#include inbelic wrote: nit: to check that all these headers are requi

[llvm-branch-commits] [llvm] IR: Remove redundant UseList check in addUse (PR #138676)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/138676 >From dedd3209ffec0129ff862ff8808eacbf13c15688 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Tue, 6 May 2025 12:06:17 +0200 Subject: [PATCH] IR: Remove redundant UseList check in addUse Not sure if this di

[llvm-branch-commits] [llvm] IR: Remove redundant UseList check in addUse (PR #138676)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/138676 >From dedd3209ffec0129ff862ff8808eacbf13c15688 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Tue, 6 May 2025 12:06:17 +0200 Subject: [PATCH] IR: Remove redundant UseList check in addUse Not sure if this di

[llvm-branch-commits] [lld] release/20.x: [wasm-ld] Refactor WasmSym from static globals to per-link context (#134970) (PR #137620)

2025-05-08 Thread Anutosh Bhat via llvm-branch-commits
anutosh491 wrote: > If this patch is needed to run your emscripten tests, how did they pass prior > to the llvm 20 upgrade? Hey @sbc100 Not sure you remember but we did disucss a good chunk of this in the issue I had raised https://github.com/llvm/llvm-project/issues/134809 This is exactly

[llvm-branch-commits] [llvm] AMDGPU/GlobalISel: add RegBankLegalize rules for extends and trunc (PR #132383)

2025-05-08 Thread Petar Avramovic via llvm-branch-commits
https://github.com/petar-avramovic updated https://github.com/llvm/llvm-project/pull/132383 >From 915bee3729c66b327885838c6384d14f92c2af2d Mon Sep 17 00:00:00 2001 From: Petar Avramovic Date: Thu, 8 May 2025 12:03:28 +0200 Subject: [PATCH] AMDGPU/GlobalISel: add RegBankLegalize rules for extend

[llvm-branch-commits] [llvm] [ObjC] Support objc_claimAutoreleasedReturnValue (PR #138696)

2025-05-08 Thread Marina Taylor via llvm-branch-commits
citymarina wrote: Thanks for the feedback, I'm working on an update to address the comments, but currently juggling too many tasks. https://github.com/llvm/llvm-project/pull/138696 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.or

[llvm-branch-commits] [llvm] [SelectionDAG][X86] Remove unused elements from atomic vector. (PR #125432)

2025-05-08 Thread Matt Arsenault via llvm-branch-commits
@@ -7230,6 +7234,20 @@ static bool findEltLoadSrc(SDValue Elt, LoadSDNode *&Ld, int64_t &ByteOffset) { } } break; + case ISD::EXTRACT_ELEMENT: +if (auto *IdxC = dyn_cast(Elt.getOperand(1))) { arsenm wrote: > If it isn't a constant, shall we

  1   2   >