https://github.com/skc7 updated https://github.com/llvm/llvm-project/pull/171825
>From 1bb03fd2b7580f3a8c35bb37857a982947eb3f0a Mon Sep 17 00:00:00 2001
From: skc7
Date: Tue, 16 Dec 2025 13:15:43 +0530
Subject: [PATCH 1/4] allow one dimsValues to be present for verifier
---
mlir/lib/Dialect/Op
https://github.com/evelez7 updated
https://github.com/llvm/llvm-project/pull/171900
>From 320d1f49f291e4cf147f86b95a48785a7f922352 Mon Sep 17 00:00:00 2001
From: Erick Velez
Date: Tue, 9 Dec 2025 09:41:28 -0800
Subject: [PATCH] [clang-doc] Add a "Home" link to navbar
This patch removes the old
https://github.com/evelez7 updated
https://github.com/llvm/llvm-project/pull/171900
>From 320d1f49f291e4cf147f86b95a48785a7f922352 Mon Sep 17 00:00:00 2001
From: Erick Velez
Date: Tue, 9 Dec 2025 09:41:28 -0800
Subject: [PATCH] [clang-doc] Add a "Home" link to navbar
This patch removes the old
https://github.com/rampitec approved this pull request.
https://github.com/llvm/llvm-project/pull/172553
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/172553
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.com/github/pr/llvm/llvm-project/172553?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/172553
If the sign bit of the denominator is known 0, do not emit the fabs.
Also, extend this to handle min/max with fabs inputs.
I originally tried to do this as the general combine on fabs, but
it proved to be too muc
https://github.com/Xazax-hun approved this pull request.
https://github.com/llvm/llvm-project/pull/172547
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: David Stone (davidstone)
Changes
`CFGStmtMap::Build` accepts pointers and returns a pointer to dynamically
allocated memory. In the one location where the type is actually constructed,
the pointers are guaranteed to be non-null.
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: David Stone (davidstone)
Changes
`CFGStmtMap::Build` accepts pointers and returns a pointer to dynamically
allocated memory. In the one location where the type is actually constructed,
the pointers are guaranteed to be n
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: David Stone (davidstone)
Changes
`CFGStmtMap::Build` accepts pointers and returns a pointer to dynamically
allocated memory. In the one location where the type is actually constructed,
the pointers are guaranteed to be non-null. By accept
https://github.com/davidstone created
https://github.com/llvm/llvm-project/pull/172530
`CFGStmtMap::Build` accepts pointers and returns a pointer to dynamically
allocated memory. In the one location where the type is actually constructed,
the pointers are guaranteed to be non-null. By acceptin
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: David Stone (davidstone)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/172529.diff
7 Files Affected:
- (modified) clang/include/clang/Analysis/AnalysisDeclContext.h (+1-1)
- (modified) clang/include/clang/A
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: David Stone (davidstone)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/172529.diff
7 Files Affected:
- (modified) clang/include/clang/Analysis/AnalysisDeclContext.h (+1-1)
- (modified) clang/includ
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: David Stone (davidstone)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/172529.diff
7 Files Affected:
- (modified) clang/include/clang/Analysis/AnalysisDeclContext.h (+1-1)
- (modified) clang/include/clang/Analysis/C
https://github.com/davidstone created
https://github.com/llvm/llvm-project/pull/172529
None
>From 34fdb92ec425776892a78ec8ca2d49070ea397d2 Mon Sep 17 00:00:00 2001
From: David Stone
Date: Mon, 15 Dec 2025 15:22:47 -0700
Subject: [PATCH] [clang][NFC] Make `CFGStmtMap` `const`-correct
---
clan
https://github.com/arsenm closed
https://github.com/llvm/llvm-project/pull/172496
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/mjklemm approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/171684
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> > If the source cannot be -inf, the result cannot be +0.
>
> Surely exp(-99) would be zero?
Ugh yes. My original version of this depended on a giant patch to do exponent
range analysis which I was hoping to avoid needing to resurrect
https://github.com/llvm/llvm-project/p
jayfoad wrote:
> If the source cannot be -inf, the result cannot be +0.
Surely exp(-99) would be zero?
https://github.com/llvm/llvm-project/pull/172496
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/
jayfoad wrote:
Pre-existing, but this seems wrong since the cases below affect more than fcNan.
https://github.com/llvm/llvm-project/pull/172496
___
llvm-branch-commits mailing list
[email protected]
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
@llvm/pr-subscribers-llvm-analysis
Author: Matt Arsenault (arsenm)
Changes
If the source cannot be -inf, the result cannot be +0.
---
Patch is 34.91 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/p
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/172496
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -8,6 +8,7 @@ set(LLVM_LINK_COMPONENTS
CodeGen
CodeGenTypes
Core
+ Extensions
aengelke wrote:
Rebased, spr artifacts should be gone now.
https://github.com/llvm/llvm-project/pull/172478
___
llvm-branch-comm
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/171872
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/171872
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/171868
>From 7169c9eef2da43c0e9d79dad32c55797ef31ac27 Mon Sep 17 00:00:00 2001
From: Alexis Engelke
Date: Fri, 12 Dec 2025 10:57:24 +
Subject: [PATCH 1/2] load plugins in FrontendTool to avoid CodeGen
dependencie
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/171868
>From 7169c9eef2da43c0e9d79dad32c55797ef31ac27 Mon Sep 17 00:00:00 2001
From: Alexis Engelke
Date: Fri, 12 Dec 2025 10:57:24 +
Subject: [PATCH 1/2] load plugins in FrontendTool to avoid CodeGen
dependencie
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/172478
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/172478
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -131,6 +132,9 @@ class CompilerInstance : public ModuleLoader {
/// The semantic analysis object.
std::unique_ptr TheSema;
+ /// Back-end pass plugins.
+ std::vector PassPlugins;
aengelke wrote:
See the lengthy discussion above obsolete now.
htt
llvmbot wrote:
@llvm/pr-subscribers-libc
Author: Connector Switch (c8ef)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/172498.diff
2 Files Affected:
- (modified) libc/include/llvm-libc-macros/netinet-in-macros.h (+3)
- (modified) libc/test/include/netinet_in_test.c
@@ -233,6 +234,20 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
Clang->LoadRequestedPlugins();
+ // Load and store pass plugins for the back-end. Store the loaded pass
plugins
+ // here and store references to these in CodeGenOpts to avoid pulling in the
+
@@ -233,6 +234,20 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
Clang->LoadRequestedPlugins();
+ // Load and store pass plugins for the back-end. Store the loaded pass
plugins
+ // here and store references to these in CodeGenOpts to avoid pulling in the
+
https://github.com/c8ef ready_for_review
https://github.com/llvm/llvm-project/pull/172498
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -233,6 +234,20 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
Clang->LoadRequestedPlugins();
+ // Load and store pass plugins for the back-end. Store the loaded pass
plugins
+ // here and store references to these in CodeGenOpts to avoid pulling in the
+
c8ef wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.com/github/pr/llvm/llvm-project/172498?utm_source=stack-comment-downstack-mergeability-warning";
>
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/172498
None
>From 8e34a2da81601b39d5ae78d51e0e45be7067d00c Mon Sep 17 00:00:00 2001
From: c8ef
Date: Tue, 16 Dec 2025 23:11:31 +0800
Subject: [PATCH] [libc] Add `IN6_IS_ADDR_MULTICAST`
---
libc/include/llvm-libc-macros/
@@ -233,6 +234,20 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
Clang->LoadRequestedPlugins();
+ // Load and store pass plugins for the back-end. Store the loaded pass
plugins
+ // here and store references to these in CodeGenOpts to avoid pulling in the
+
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/171868
>From 7169c9eef2da43c0e9d79dad32c55797ef31ac27 Mon Sep 17 00:00:00 2001
From: Alexis Engelke
Date: Fri, 12 Dec 2025 10:57:24 +
Subject: [PATCH 1/2] load plugins in FrontendTool to avoid CodeGen
dependencie
https://github.com/aengelke updated
https://github.com/llvm/llvm-project/pull/171868
>From 7169c9eef2da43c0e9d79dad32c55797ef31ac27 Mon Sep 17 00:00:00 2001
From: Alexis Engelke
Date: Fri, 12 Dec 2025 10:57:24 +
Subject: [PATCH 1/2] load plugins in FrontendTool to avoid CodeGen
dependencie
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
The base exp handling looks pretty incomplete.
---
Full diff: https://github.com/llvm/llvm-project/pull/172495.diff
2 Files Affected:
- (modified) llvm/lib/Analysis/ValueTracking.cpp (+6-1)
- (m
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/172495
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.com/github/pr/llvm/llvm-project/172496?utm_source=stack-comment-downstack-mergeability-warning";
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.com/github/pr/llvm/llvm-project/172495?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/172496
If the source cannot be -inf, the result cannot be +0.
>From 47281a6505a94caec8ba58574603ab63f8ea0d84 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Tue, 16 Dec 2025 15:35:12 +0100
Subject: [PATCH] ValueTra
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/172495
The base exp handling looks pretty incomplete.
>From 2da01fc71bb84a4cfb3d01c8b199158597aaed78 Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Tue, 16 Dec 2025 15:23:36 +0100
Subject: [PATCH] ValueTracking: H
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/172492.diff
2 Files Affected:
- (modified) llvm/lib/Analysis/ValueTracking.cpp (+7-4)
- (modified) llvm/test/Transforms/Attributor/AMDGP
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/172492
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/172492
None
>From 2895e7970cb405a8cacb452be813835a673054bc Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Tue, 16 Dec 2025 15:18:31 +0100
Subject: [PATCH] ValueTracking: Handle amdgcn_log in computeKnownFPClass
-
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.com/github/pr/llvm/llvm-project/172492?utm_source=stack-comment-downstack-mergeability-warning";
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Matt Arsenault (arsenm)
Changes
---
Patch is 30.13 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/172490.diff
2 Files Affected:
- (modified) llvm/lib/Analysis/ValueTracking.cpp (+3
https://github.com/arsenm ready_for_review
https://github.com/llvm/llvm-project/pull/172490
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
arsenm wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.com/github/pr/llvm/llvm-project/172490?utm_source=stack-comment-downstack-mergeability-warning";
https://github.com/arsenm created
https://github.com/llvm/llvm-project/pull/172490
None
>From 329426b566e8325a5b9093ffd2b66d7b8431c73f Mon Sep 17 00:00:00 2001
From: Matt Arsenault
Date: Tue, 16 Dec 2025 14:47:12 +0100
Subject: [PATCH] AMDGPU: Handle amdgcn_rcp in computeKnownFPClass
---
llv
@@ -605,15 +608,117 @@ static Value *emitRsqIEEE1ULP(IRBuilder<> &Builder,
Value *Src,
return Builder.CreateFMul(Rsq, OutputScaleFactor);
}
+/// Emit inverse sqrt expansion for f64 with a correction sequence on top of
+/// v_rsq_f64. This should give a 1ulp result.
+Value *
@@ -644,6 +648,12 @@ class CompilerInstance : public ModuleLoader {
/// the compiler instance takes ownership of \p Value.
void setCodeCompletionConsumer(CodeCompleteConsumer *Value);
+ /// }
+ /// @name Back-end Pass Plugins
+ /// @{
+
+ std::vector &getPassPlugins()
@@ -233,6 +234,20 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
Clang->LoadRequestedPlugins();
+ // Load and store pass plugins for the back-end. Store the loaded pass
plugins
+ // here and store references to these in CodeGenOpts to avoid pulling in the
+
@@ -131,6 +132,9 @@ class CompilerInstance : public ModuleLoader {
/// The semantic analysis object.
std::unique_ptr TheSema;
+ /// Back-end pass plugins.
+ std::vector PassPlugins;
tarunprabhu wrote:
Why does the CompilerInstance not own the loaded `ll
@@ -233,6 +234,20 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
Clang->LoadRequestedPlugins();
+ // Load and store pass plugins for the back-end. Store the loaded pass
plugins
+ // here and store references to these in CodeGenOpts to avoid pulling in the
+
@@ -233,6 +234,20 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
Clang->LoadRequestedPlugins();
+ // Load and store pass plugins for the back-end. Store the loaded pass
plugins
+ // here and store references to these in CodeGenOpts to avoid pulling in the
+
hansangbae wrote:
Addressed comments.
https://github.com/llvm/llvm-project/pull/171684
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/hansangbae updated
https://github.com/llvm/llvm-project/pull/171684
>From dfd1abdd8caeb29a484092abd686036c8d0dd554 Mon Sep 17 00:00:00 2001
From: Hansang Bae
Date: Wed, 10 Dec 2025 13:21:41 -0600
Subject: [PATCH 1/3] [Offload] Debug message update part 3
Update debug message
aengelke wrote:
> The option addition to llc is not the NFC this commit is meant to be
This is just a spr artifact. Note that the PR is not intended to be merged
against main as-is. The PR diff view shows the accurate changes:
https://github.com/llvm/llvm-project/pull/172478/files
https://git
@@ -8,6 +8,7 @@ set(LLVM_LINK_COMPONENTS
CodeGen
CodeGenTypes
Core
+ Extensions
aengelke wrote:
I stacked this PR on #170846, which I'm going to land as soon as I have time to
rebase and retest that (I'm currently on travel) to avoid missing spots when
@@ -4,6 +4,7 @@ set(LLVM_LINK_COMPONENTS
Core
BinaryFormat
MC
+ Extensions
aengelke wrote:
There is? ClangLinkerWrapper.cpp:1300
https://github.com/llvm/llvm-project/pull/172478
___
llvm-branch-commits mailin
@@ -8,6 +8,7 @@ set(LLVM_LINK_COMPONENTS
CodeGen
CodeGenTypes
Core
+ Extensions
serge-sans-paille wrote:
Same here
https://github.com/llvm/llvm-project/pull/172478
___
llvm-branch-commits mailing list
llvm-br
https://github.com/serge-sans-paille requested changes to this pull request.
The option addition to llc is not the NFC this commit is meant to be ^^!
I assume some leftover for a commit split?
https://github.com/llvm/llvm-project/pull/172478
___
llvm-b
@@ -4,6 +4,7 @@ set(LLVM_LINK_COMPONENTS
Core
BinaryFormat
MC
+ Extensions
serge-sans-paille wrote:
I don't see PassPlugin here, I bet you addded Extensions there because it fixed
a linkage error, but why?
https://github.com/llvm/llvm-project/pull/172
https://github.com/serge-sans-paille edited
https://github.com/llvm/llvm-project/pull/172478
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
nikic wrote:
Makes sense to move the PassPlugin support out of Passes.
If I understand correctly, the current role of the Extensions component is to
link in statically linked plugins. I guess moving PassPlugin there makes sense
in that it would ensure that any tool that supports plugins also l
@@ -1452,15 +1452,53 @@ class OpenMP_ThreadLimitClauseSkip<
> : OpenMP_Clause {
let arguments = (ins
+ConfinedAttr, [IntPositive]>:$thread_limit_num_dims,
+Variadic:$thread_limit_dims_values,
Optional:$thread_limit
skc7 wrote:
Initial idea was
https://github.com/aengelke edited
https://github.com/llvm/llvm-project/pull/172478
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
llvmbot wrote:
@llvm/pr-subscribers-flang-driver
Author: Alexis Engelke (aengelke)
Changes
This avoid pulling in the entire Passes library with all passes as
dependencies when just referring to PassPlugin, which is in fact
independent of the Passes themselves.
Reviwwers: nikic, vgvassilev
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Alexis Engelke (aengelke)
Changes
This avoid pulling in the entire Passes library with all passes as
dependencies when just referring to PassPlugin, which is in fact
independent of the Passes themselves.
Reviwwers: nikic, vgvassile
@@ -233,6 +234,20 @@ bool ExecuteCompilerInvocation(CompilerInstance *Clang) {
Clang->LoadRequestedPlugins();
+ // Load and store pass plugins for the back-end. Store the loaded pass
plugins
+ // here and store references to these in CodeGenOpts to avoid pulling in the
+
https://github.com/aengelke created
https://github.com/llvm/llvm-project/pull/172478
This avoid pulling in the entire Passes library with all passes as
dependencies when just referring to PassPlugin, which is in fact
independent of the Passes themselves.
Reviwwers: nikic, vgvassilev, serge-sans
https://github.com/luporl closed
https://github.com/llvm/llvm-project/pull/172303
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
Author: Balázs Benics
Date: 2025-12-16T12:02:09Z
New Revision: 75ae4cd157eb022249f459cd3fe981377104c40e
URL:
https://github.com/llvm/llvm-project/commit/75ae4cd157eb022249f459cd3fe981377104c40e
DIFF:
https://github.com/llvm/llvm-project/commit/75ae4cd157eb022249f459cd3fe981377104c40e.diff
LOG:
Meinersbur wrote:
@petrhosek I would appreciate if we can make progress in this PR. The original
PR has already been approved by others.
https://github.com/llvm/llvm-project/pull/171515
___
llvm-branch-commits mailing list
[email protected]
kasuga-fj wrote:
> APInt has several routines that deal determine overflow, e.g. sadd_ov,
> ssub_ov, etc. So, as a very minimum, if we need a convenience wrapper, we
> should first use those routines?
This is exactly a wrapper for those routines. I defined the wrapper for
readability. For exa
@@ -158,6 +158,16 @@ def get_failures(junit_objects) -> dict[str,
list[tuple[str, str]]]:
return failures
+def are_all_failures_explained(
+failures: list[tuple[str, str]], failure_explanations: dict[str,
FailureExplanation]
+) -> bool:
+for failure in failures:
@@ -158,6 +158,16 @@ def get_failures(junit_objects) -> dict[str,
list[tuple[str, str]]]:
return failures
+def are_all_failures_explained(
+failures: list[tuple[str, str]], failure_explanations: dict[str,
FailureExplanation]
+) -> bool:
+for failure in failures:
@@ -263,7 +283,11 @@ def plural(num_tests):
# No tests failed but the build was in a failed state. Bring this to
the user's
# attention.
ninja_failures = find_failure_in_ninja_logs(ninja_logs)
+all_failures_explained &= are_all_failures_explaine
84 matches
Mail list logo
