andrey-golubev wrote:
> Hi @EugeneZelenko (or anyone else). If you would like to add a note about
> this fix in the release notes (completely optional). Please reply to this
> comment with a one or two sentence description of the fix.
hi! @tstellar I don't think it's worth it: this is a tiny n
andrey-golubev wrote:
Aha, so, apparently, I cannot even close a PR (lack of commit write access) :/
Could someone close this one as we don't plan on merging it? Not urgent anyway.
https://github.com/llvm/llvm-project/pull/83971
___
llvm-branch-commit
andrey-golubev wrote:
> I think it's an ABI change (but I could be wrong), because some of the
> implicit constructors are being deleted. What happens if a user of the
> library was using these deleted constructors?
I see your point. In this specific case, the special member functions were
im
andrey-golubev wrote:
> > Do we have any ABI stability guarantees for LLVM C++ APIs? I would think
> > that a lot of back ports can break the C++ ABI of LLVM in general?
>
> Yes, we always try to keep the C++ API stable in point releases.
Fair enough. Let's not backport it then.
btw,
> I thi
andrey-golubev wrote:
ping @joker-eph: do you mind (back)porting this change to 18.x? if yes, let's
close this, alternatively, please approve / merge, thank you!
https://github.com/llvm/llvm-project/pull/83971
___
llvm-branch-commits mailing list
llvm
andrey-golubev wrote:
> Here we have to wait for the build bots, as they are mandatory.
Finished, so asking for someone to press the merge button. Thanks in advance!
https://github.com/llvm/llvm-project/pull/79603
___
llvm-branch-commits mailing list
andrey-golubev wrote:
LGTM. But surely we need someone with commit access (sigh). CC @Dinistro
@zero9178
https://github.com/llvm/llvm-project/pull/79603
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi
