[llvm-branch-commits] [clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #139909)

2025-05-14 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: I already amended the patch to add this fix to the release notes of clang. That's the only change I made to the picked commit. https://github.com/llvm/llvm-project/pull/139909 ___ llvm-branch-commits mailing list llvm-branch-commits@li

[llvm-branch-commits] [clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #139909)

2025-05-14 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/139909 As reported in #135665, C++20 parenthesis initializer list expressions are not handled correctly and were causing crashes. This commit attempts to fix the issue by handing parenthesis initializer lists along s

[llvm-branch-commits] [clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #139909)

2025-05-14 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/139909 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer] Workaround for slowdown spikes (unintended scope increase) (#136720) (PR #139597)

2025-05-12 Thread Balazs Benics via llvm-branch-commits
@@ -0,0 +1,200 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -verify=expected,default %s +// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -analyzer-config inline-functions-with-ambiguous-loops=true -verify=expected,enabled %s

[llvm-branch-commits] [clang] [analyzer] Workaround for slowdown spikes (unintended scope increase) (#136720) (PR #139597)

2025-05-12 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: This is a manual backport of #136720. https://github.com/llvm/llvm-project/pull/139597 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer] Workaround for slowdown spikes (unintended scope increase) (#136720) (PR #139597)

2025-05-12 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/139597 Recently some users reported that they observed large increases of runtime (up to +600% on some translation units) when they upgraded to a more recent (slightly patched, internal) clang version. Bisection reve

[llvm-branch-commits] [clang] [analyzer] Workaround for slowdown spikes (unintended scope increase) (#136720) (PR #139597)

2025-05-12 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/139597 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][analysis] Fix flaky clang/test/Analysis/live-stmts.cpp test (2nd attempt) (#127406) (PR #139591)

2025-05-12 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: We decided to backport in https://github.com/llvm/llvm-project/pull/127406#issuecomment-2683679225 https://github.com/llvm/llvm-project/pull/139591 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.l

[llvm-branch-commits] [clang] [clang][analysis] Fix flaky clang/test/Analysis/live-stmts.cpp test (2nd attempt) (#127406) (PR #139591)

2025-05-12 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/139591 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][analysis] Fix flaky clang/test/Analysis/live-stmts.cpp test (2nd attempt) (#127406) (PR #139591)

2025-05-12 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/139591 In my previous attempt (#126913) of fixing the flaky case was on a good track when I used the begin locations as a stable ordering. However, I forgot to consider the case when the begin locations are the same

[llvm-branch-commits] [clang] Backport to 20.x "[clang][analyzer] Fix error path of builtin overflow (#136345)" (PR #136589)

2025-04-23 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/136589 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport to 20.x "[clang][analyzer] Fix error path of builtin overflow (#136345)" (PR #136589)

2025-04-23 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/136589 >From 66feeb003ccf9f6009d739d3d076f62cf54859e6 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Sun, 20 Apr 2025 10:14:41 -0400 Subject: [PATCH] [clang][analyzer] Fix error path of builtin overflow (#136345

[llvm-branch-commits] [clang] Backport to 20.x "[clang][analyzer] Fix error path of builtin overflow (#136345)" (PR #136589)

2025-04-23 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: I've updated the commit description to have the desired cherry pick marker line, referring to the commit hash picked. It's ready to go now. https://github.com/llvm/llvm-project/pull/136589 ___ llvm-branch-commits mailing list llvm-bran

[llvm-branch-commits] [clang] Backport to 20.x "[clang][analyzer] Fix error path of builtin overflow (#136345)" (PR #136589)

2025-04-23 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: Since I did the update to this PR the way I wanted, I invite another code owner to approve. /cc @Xazax-hun https://github.com/llvm/llvm-project/pull/136589 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https:

[llvm-branch-commits] [clang] Backport to 20.x "[clang][analyzer] Fix error path of builtin overflow (#136345)" (PR #136589)

2025-04-23 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/136589 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport to 20.x "[clang][analyzer] Fix error path of builtin overflow (#136345)" (PR #136589)

2025-04-21 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: Make sure after the force push you sync zhe PR summary with the commit message. https://github.com/llvm/llvm-project/pull/136589 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[llvm-branch-commits] [clang] Backport to 20.x "[clang][analyzer] Fix error path of builtin overflow (#136345)" (PR #136589)

2025-04-21 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: Please checkout the release branch, reset hard to reset to that one. Then issue the "git cherry-pick -x HASH" command and force push to your branch. This should get us a nice cherry picked from comment in the message. I think only the release manager can accept merges, so its no

[llvm-branch-commits] [clang] [analyzer][docs] CSA release notes for clang-20 (PR #124798)

2025-01-29 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/124798 >From 65f0bce634bce28430fa2c722ee0a396a8935bba Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Tue, 28 Jan 2025 18:26:37 +0100 Subject: [PATCH 1/2] [analyzer][docs] Release notes for clang-20 The commits we

[llvm-branch-commits] [clang] [analyzer][docs] CSA release notes for clang-20 (PR #124798)

2025-01-29 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: Rebased to target the recently split release/20.x. No changes were made to the content of the PR. https://github.com/llvm/llvm-project/pull/124798 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llv

[llvm-branch-commits] [clang] [analyzer][docs] CSA release notes for clang-20 (PR #124798)

2025-01-29 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/124798 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate {SymInt, IntSym}Expr to use APSIntPtr (4/4) (PR #120438)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120438 >From 9bd5b4a297899aeae6bd6ce6373319e1933fc7d8 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:59:23 +0100 Subject: [PATCH] [analyzer][NFC] Migrate {SymInt,IntSym}Expr to use APSIntPtr (

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate {SymInt, IntSym}Expr to use APSIntPtr (4/4) (PR #120438)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120438 >From 1f31cdcbf265be767ef5ae4a44f1e28002faba8f Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:59:23 +0100 Subject: [PATCH] [analyzer][NFC] Migrate {SymInt,IntSym}Expr to use APSIntPtr (

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4) (PR #120437)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120437 >From e82a47f0efe7cba42891b14889ac41a4140b Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:57:26 +0100 Subject: [PATCH] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate {SymInt, IntSym}Expr to use APSIntPtr (4/4) (PR #120438)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120438 >From d9346f24cbc8930baefb8f17bb88745bc63f0e7e Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:59:23 +0100 Subject: [PATCH] [analyzer][NFC] Migrate {SymInt,IntSym}Expr to use APSIntPtr (

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4) (PR #120437)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120437 >From 0daf63ef3f8607dcc9f290c94db210cf462cc75f Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:57:26 +0100 Subject: [PATCH] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120436 >From 09aa29dd6cb4e22e5541ed7c1aaeb715772c3393 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:55:27 +0100 Subject: [PATCH] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate {SymInt, IntSym}Expr to use APSIntPtr (4/4) (PR #120438)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120438 >From 45c13070865e7474a13f1d843d13f5eb4ceafa29 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:59:23 +0100 Subject: [PATCH] [analyzer][NFC] Migrate {SymInt,IntSym}Expr to use APSIntPtr (

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120436 >From d9ce18fd77617480703c677ad7053516fb2c68f9 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:55:27 +0100 Subject: [PATCH] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4) (PR #120437)

2024-12-19 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/120437 >From 9841a76e62ad9d9bcdea3ff8c066c19f113c2615 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:57:26 +0100 Subject: [PATCH] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4) (PR #120437)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
@@ -514,9 +514,12 @@ class MemRegionVal : public Loc { class ConcreteInt : public Loc { public: - explicit ConcreteInt(const llvm::APSInt &V) : Loc(ConcreteIntKind, &V) {} + explicit ConcreteInt(APSIntPtr V) : Loc(ConcreteIntKind, V.get()) {} steakhal wrote:

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
@@ -298,9 +299,12 @@ class SymbolVal : public NonLoc { /// Value representing integer constant. class ConcreteInt : public NonLoc { public: - explicit ConcreteInt(const llvm::APSInt &V) : NonLoc(ConcreteIntKind, &V) {} + explicit ConcreteInt(APSIntPtr V) : NonLoc(ConcreteIntK

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/120436 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
@@ -298,9 +299,12 @@ class SymbolVal : public NonLoc { /// Value representing integer constant. class ConcreteInt : public NonLoc { public: - explicit ConcreteInt(const llvm::APSInt &V) : NonLoc(ConcreteIntKind, &V) {} + explicit ConcreteInt(APSIntPtr V) : NonLoc(ConcreteIntK

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
@@ -298,9 +299,12 @@ class SymbolVal : public NonLoc { /// Value representing integer constant. class ConcreteInt : public NonLoc { public: - explicit ConcreteInt(const llvm::APSInt &V) : NonLoc(ConcreteIntKind, &V) {} + explicit ConcreteInt(APSIntPtr V) : NonLoc(ConcreteIntK

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4) (PR #120437)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
@@ -514,9 +514,12 @@ class MemRegionVal : public Loc { class ConcreteInt : public Loc { public: - explicit ConcreteInt(const llvm::APSInt &V) : Loc(ConcreteIntKind, &V) {} + explicit ConcreteInt(APSIntPtr V) : Loc(ConcreteIntKind, V.get()) {} steakhal wrote:

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
@@ -298,9 +299,12 @@ class SymbolVal : public NonLoc { /// Value representing integer constant. class ConcreteInt : public NonLoc { public: - explicit ConcreteInt(const llvm::APSInt &V) : NonLoc(ConcreteIntKind, &V) {} + explicit ConcreteInt(APSIntPtr V) : NonLoc(ConcreteIntK

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal ready_for_review https://github.com/llvm/llvm-project/pull/120436 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate {SymInt, IntSym}Expr to use APSIntPtr (4/4) (PR #120438)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal ready_for_review https://github.com/llvm/llvm-project/pull/120438 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4) (PR #120437)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal ready_for_review https://github.com/llvm/llvm-project/pull/120437 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate {SymInt, IntSym}Expr to use APSIntPtr (4/4) (PR #120438)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/120438?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4) (PR #120437)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/120437?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate {SymInt, IntSym}Expr to use APSIntPtr (4/4) (PR #120438)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/120438 None >From ffda1054d5a3e8f4ce42c3bedfc29cc8a0c69df1 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:59:23 +0100 Subject: [PATCH] [analyzer][NFC] Migrate {SymInt,IntSym}Expr to use APSInt

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/120436?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr (3/4) (PR #120437)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/120437 None >From 81c7a2837ca2da2436613f4411e3b3cd37289051 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:57:26 +0100 Subject: [PATCH] [analyzer][NFC] Migrate loc::ConcreteInt to use APSIntPtr

[llvm-branch-commits] [clang] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSIntPtr (2/4) (PR #120436)

2024-12-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/120436 None >From bda84413e146d2e39a704a73694fb777249be799 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 18 Dec 2024 15:55:27 +0100 Subject: [PATCH] [analyzer][NFC] Migrate nonloc::ConcreteInt to use APSInt

[llvm-branch-commits] [clang] Backport "[clang][analyzer] Fix #embed crash (#107764)" (PR #107841)

2024-09-09 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: There is no need to update the release notes as `#embed` is a new feature, so the crash is not a regression that needs to be highlighted. https://github.com/llvm/llvm-project/pull/107841 ___ llvm-branch-commits mailing list llvm-branch

[llvm-branch-commits] [clang] Backport "[clang][analyzer] Fix #embed crash (#107764)" (PR #107841)

2024-09-09 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/107841 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport "[clang][analyzer] Fix #embed crash (#107764)" (PR #107841)

2024-09-09 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/107841 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport "[clang][analyzer] Fix #embed crash (#107764)" (PR #107841)

2024-09-09 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/107841 Backports the fix for #107724. (cherry picked from commit d84d9559bdc7aeb4ce14c251f6a3490c66db8d3a) >From f791ef134479616ced3d90c5321ecb878c5b6efc Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Mon,

[llvm-branch-commits] [clang] Backport taint analysis slowdown regression fix (PR #105516)

2024-08-26 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: @Xazax-hun https://github.com/llvm/llvm-project/pull/105516 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport taint analysis slowdown regression fix (PR #105516)

2024-08-21 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/105516 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport taint analysis slowdown regression fix (PR #105516)

2024-08-21 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/105516 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport taint analysis slowdown regression fix (PR #105516)

2024-08-21 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/105516 Same as the cherry-picked commit + the release notes. >From 1d10df6937e914e610da9c5818ba09ff711beb05 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 21 Aug 2024 14:24:56 +0200 Subject: [PATCH 1/2] [ana

[llvm-branch-commits] [clang] Backport "[analyzer] Fix crash on using `bitcast(, )` as array subscript" (PR #101684)

2024-08-02 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: Cherrypick + added release notes as this crash was present in clang-18 too. https://github.com/llvm/llvm-project/pull/101684 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[llvm-branch-commits] [clang] Backport "[analyzer] Fix crash on using `bitcast(, )` as array subscript" (PR #101684)

2024-08-02 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/101684 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport "[analyzer] Fix crash on using `bitcast(, )` as array subscript" (PR #101684)

2024-08-02 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/101684 Current CSA logic does not expect `LazyCompoundValKind` as array index. This may happen if array is used as subscript to another, in case of bitcast to integer type. Catch such cases and return `UnknownVal`,

[llvm-branch-commits] [clang] Backport "[analyzer] Fix crash on using `bitcast(, )` as array subscript" (PR #101684)

2024-08-02 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/101684 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] 18ad020 - [analyzer] Restore recognition of mutex methods (#101511)

2024-08-02 Thread Balazs Benics via llvm-branch-commits
Author: DonĂ¡t Nagy Date: 2024-08-02T12:44:40+02:00 New Revision: 18ad0209550ed258fc1a24e710613bc5e3e220af URL: https://github.com/llvm/llvm-project/commit/18ad0209550ed258fc1a24e710613bc5e3e220af DIFF: https://github.com/llvm/llvm-project/commit/18ad0209550ed258fc1a24e710613bc5e3e220af.diff LO

[llvm-branch-commits] [clang] Backport "[analyzer] Restore recognition of mutex methods" (PR #101651)

2024-08-02 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/101651 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport "[analyzer] Restore recognition of mutex methods" (PR #101651)

2024-08-02 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/101651 Before commit 705788c the checker alpha.unix.BlockInCriticalSection "recognized" the methods `std::mutex::lock` and `std::mutex::unlock` with an extremely trivial check that accepted any function (or method) n

[llvm-branch-commits] [clang] Backport "[analyzer] Restore recognition of mutex methods" (PR #101651)

2024-08-02 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/101651 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/95129 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/95129 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-18 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: Ah, it mixed the messages... Here it is: - Removed unused `NumZ3QueriesDoneInEqClass` - Added a new `crosscheck-with-z3-eqclass-timeout-threshold` config option. - Removed misleading `// unsat` comment on return statement. - Removed unnecessary `// sat` comment on return statemen

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/95129 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-18 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/95129 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-17 Thread Balazs Benics via llvm-branch-commits
@@ -44,21 +47,43 @@ class Z3CrosscheckVisitor final : public BugReporterVisitor { /// Holds the constraints in a given path. ConstraintMap Constraints; Z3Result &Result; + const AnalyzerOptions &Opts; }; /// The oracle will decide if a report should be accepted or r

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-17 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: Ping. @NagyDonat @Xazax-hun @haoNoQ https://github.com/llvm/llvm-project/pull/95129 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-12 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: I've tested this change on 200+ projects, and the overall effect is: - 0 new issues appear - 276 issues disappear (because we drop the report eqclass) The three most affected checker categories (all of them are spread across usually 20+ projects): - null-deref-like diagnos

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-11 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/95129 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-11 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/95129 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [analyzer] Harden safeguards for Z3 query times (PR #95129)

2024-06-11 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/95129 This patch is a functional change. https://discourse.llvm.org/t/analyzer-rfc-taming-z3-query-times/79520 As a result of this patch, individual Z3 queries in refutation will be bound by 300ms. Every report equiva

[llvm-branch-commits] [clang] [analyzer] Backport performace regression fix (PR #89725)

2024-05-02 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: > Hi @steakhal (or anyone else). If you would like to add a note about this fix > in the release notes (completely optional). Please reply to this comment with > a one or two sentence description of the fix. When you are done, please add > the release:note label to this PR. I

[llvm-branch-commits] [clang] Backport fix for crash reported in #88181 (PR #89022)

2024-05-02 Thread Balazs Benics via llvm-branch-commits
steakhal wrote: > Hi @steakhal (or anyone else). If you would like to add a note about this fix > in the release notes (completely optional). Please reply to this comment with > a one or two sentence description of the fix. When you are done, please add > the release:note label to this PR. I

[llvm-branch-commits] [clang] [analyzer] Backport performace regression fix (PR #89725)

2024-04-23 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/89725 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] Backport fix for crash reported in #88181 (PR #89022)

2024-04-16 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/89022 Fixes #88181 (cherry picked from commit e096c144921daba59963f15e89d2ca6fb32d3a78) The user requested the backport [here](https://github.com/llvm/llvm-project/pull/88536#issuecomment-2052237181). >From ebe4abe

[llvm-branch-commits] [clang] Backport fix for crash reported in #88181 (PR #89022)

2024-04-16 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/89022 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [Clang] Fixes to immediate-escalating functions (#82281) (PR #82609)

2024-02-23 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/82609 >From c96211c576d13c38edb5ea39da3b44b2e0f6feed Mon Sep 17 00:00:00 2001 From: cor3ntin Date: Wed, 21 Feb 2024 20:53:44 +0100 Subject: [PATCH] [Clang] Fixes to immediate-escalating functions (#82281) * Consider

[llvm-branch-commits] [clang] [Clang] Fixes to immediate-escalating functions (#82281) (PR #82609)

2024-02-22 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/82609 * Consider that immediate escalating function can appear at global scope, fixing a crash * Lambda conversion to function pointer was sometimes not performed in an immediate function context when it should be.

[llvm-branch-commits] [clang] [Clang] Fixes to immediate-escalating functions (#82281) (PR #82609)

2024-02-22 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/82609 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][docs] Admit that the cleanup attribute is not supported (PR #81834)

2024-02-15 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/81834 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [analyzer][docs] Admit that the cleanup attribute is not supported (PR #81834)

2024-02-15 Thread Balazs Benics via llvm-branch-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/81834 In fact, the cleanup attribute is only added to the CFG, but still unhandled by CSA. I propose dropping this false "support" statement from the docs. >From 9676ef916e3617e879bb3f498472754031b3310b Mon Sep 17 00

[llvm-branch-commits] [clang] ee073c7 - [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64

2020-11-30 Thread Balazs Benics via llvm-branch-commits
Author: Balazs Benics Date: 2020-11-30T18:06:28+01:00 New Revision: ee073c798515e56b23463391a7b40d5ee6527337 URL: https://github.com/llvm/llvm-project/commit/ee073c798515e56b23463391a7b40d5ee6527337 DIFF: https://github.com/llvm/llvm-project/commit/ee073c798515e56b23463391a7b40d5ee6527337.diff