https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From 52f8f0f33fc6507e40a50dfc15bc072a20646d41 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH] [CIR] Upstream AddressSpace casting support
---
.../CIR/Diale
@@ -423,7 +423,10 @@ LogicalResult cir::CastOp::verify() {
auto resPtrTy = mlir::dyn_cast(resType);
if (srcPtrTy && resPtrTy) {
- return success();
+ if (srcPtrTy.getAddrSpace() != resPtrTy.getAddrSpace()) {
RiverDave wrote:
Good point, I've
https://github.com/RiverDave edited
https://github.com/llvm/llvm-project/pull/161212
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From e446b4723e7df94f057d20a9ad0fdc28964bb2fd Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/2] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From baaea0b9d214bd5940f4b16909d47f491918c584 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/4] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From 4d58946e6813b357d3adc0cf826066afc0bdc115 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/3] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
https://github.com/RiverDave edited
https://github.com/llvm/llvm-project/pull/161212
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From 4d58946e6813b357d3adc0cf826066afc0bdc115 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/4] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From 4d58946e6813b357d3adc0cf826066afc0bdc115 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/2] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From 4d58946e6813b357d3adc0cf826066afc0bdc115 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/3] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
https://github.com/RiverDave created
https://github.com/llvm/llvm-project/pull/161212
None
>From 22568bd8200bef8a4f6759d4bcbdecfc91a0bf3e Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH] [CIR] Upstream AddressSpace casting support
---
.../CIR
https://github.com/RiverDave edited
https://github.com/llvm/llvm-project/pull/161212
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From e446b4723e7df94f057d20a9ad0fdc28964bb2fd Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH] [CIR] Upstream AddressSpace casting support
---
.../CIR/Diale
https://github.com/RiverDave edited
https://github.com/llvm/llvm-project/pull/161212
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/RiverDave ready_for_review
https://github.com/llvm/llvm-project/pull/161212
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From e446b4723e7df94f057d20a9ad0fdc28964bb2fd Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/2] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
RiverDave wrote:
I updated this based on the recent feedback on #161028
I made a change tn the function: `performAddrSpaceCast` and I opted for getting
rid of the `LangAS` parameters for both source and destination, there’s to main
reasons:
1. They were redundant and not utilized.
2. In
[OG
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From baaea0b9d214bd5940f4b16909d47f491918c584 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/4] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From baaea0b9d214bd5940f4b16909d47f491918c584 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH 1/4] [CIR] Upstream AddressSpace casting support
---
.../CIR/D
@@ -172,28 +190,21 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl
&gd, unsigned builtinID,
builder.getUInt8Ty(), "bi_alloca", suitableAlignmentInBytes, size);
// Initialize the allocated buffer if required.
-if (builtinID != Builtin::BI__builtin_al
https://github.com/RiverDave deleted
https://github.com/llvm/llvm-project/pull/161212
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/RiverDave updated
https://github.com/llvm/llvm-project/pull/161212
>From a6313408ef8e8f9ad129e39cb0d8d0f2fb2f0ee3 Mon Sep 17 00:00:00 2001
From: David Rivera
Date: Mon, 29 Sep 2025 11:05:44 -0400
Subject: [PATCH] [CIR] Upstream AddressSpace casting support
---
.../CIR/Diale
https://github.com/RiverDave edited
https://github.com/llvm/llvm-project/pull/161212
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2283,7 +2295,10 @@ Address CIRGenFunction::createTempAlloca(mlir::Type ty,
CharUnits align,
// be different from the type defined by the language. For example,
// in C++ the auto variables are in the default address space. Therefore
// cast alloca to the default addr
RiverDave wrote:
> [!WARNING]
> This pull request is not mergeable via GitHub because a downstack PR is
> open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/161212?utm_source=stack-comment-downstack-mergeability-warning
25 matches
Mail list logo
