[llvm-branch-commits] [llvm] [Inline]Update value profile for non-call instructions (PR #83769)

2024-05-24 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: Close this. Going to update in https://github.com/llvm/llvm-project/pull/81442 https://github.com/llvm/llvm-project/pull/83769 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] [Inline]Update value profile for non-call instructions (PR #83769)

2024-05-24 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 closed https://github.com/llvm/llvm-project/pull/83769 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Inline]Update value profile for non-call instructions (PR #83769)

2024-05-24 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/83769 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [TypeProf][IndirectCallPromotion]Implement vtable-based transformation (PR #81442)

2024-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81442 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-15 Thread Mingming Liu via llvm-branch-commits
@@ -216,7 +216,8 @@ void gatherImportedSummariesForModule( StringRef ModulePath, const DenseMap , const FunctionImporter::ImportMapTy , -std::map ); +std::map , +GVSummaryPtrSet ); minglotus-6 wrote: done.

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/87600 >From 001a785f664e3a16e61d1e350ea060b829f1856c Mon Sep 17 00:00:00 2001 From: mingmingl Date: Mon, 13 May 2024 20:51:25 -0700 Subject: [PATCH 1/3] update this patch as the second one ---

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-05-14 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81378 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][BitcodeWriter] Write import type in bitcode (PR #87600)

2024-05-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO]Write import type for distributed ThinLTO (PR #87600)

2024-05-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][BitcodeWriter] Write import type in per-module combined summary (PR #87600)

2024-05-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][CallPromotionUtils]Extract a helper function versionCallSiteWithCond from versionCallSite (PR #81181)

2024-05-09 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81181 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/9] function import changes ---

[llvm-branch-commits] [llvm] [ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: https://github.com/llvm/llvm-project/pull/87600 is a functional change and the diffbase of this patch, and `llvm/test/ThinLTO/X86/import_callee_declaration.ll` should be a test case for both patches. In the [diffbase](https://github.com/llvm/llvm-project/pull/87600),

[llvm-branch-commits] [llvm] [ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/88024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: Tagging @jvoung since I cannot add you into reviewer. https://github.com/llvm/llvm-project/pull/88024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/88024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/88024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/8] function import changes ---

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/7] function import changes ---

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-02 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/5] function import changes ---

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-01 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/4] function import changes ---

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-04-17 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/3] function import changes ---

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-04-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/2] function import changes ---

[llvm-branch-commits] [compiler-rt] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-04-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81051 error: too big or took too long to generate ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-04-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC]Extract the heuristic to find vtable for an indirect call into a helper function (PR #81024)

2024-04-11 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/81024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [compiler-rt] [flang] [libc] [libcxx] [llvm] [mlir] [NFC][IndirectCallProm] Refactor function-based conditional devirtualization and indirect call value profile update in

2024-04-11 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/80762 error: too big or took too long to generate ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] [NFC][IndirectCallProm] Refactor function-based conditional devirtualization and indirect call value profile update into one helper function (PR #80762)

2024-04-11 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/80762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-04-08 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/88024 This is still working in progress. Need to update all callers of 'ComputeImportForModule' properly >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr

[llvm-branch-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [lld] [llvm] [mlir] [openmp] [ThinLTO][TypeProf] Implement vtable def import (PR #79381)

2024-04-01 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/79381 error: too big or took too long to generate ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-26 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: > The invoke instruction can have 3 different kinds of prof data > > 1. call count (if a direct call) > 2. VP profile data (if an indirect call) > 3. branch weights for landing pad. > 4. can coexist with 2) and does not need to be updated. Is there an existing > test

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-26 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/83809 >From 9575b83ea40012ecbfbf301a24ec89de0726ffd4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Mon, 4 Mar 2024 00:43:55 -0800 Subject: [PATCH] update profile for invoke instruction in caller and callee after

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-05 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: > The invoke instruction can have 3 different kinds of prof data > > 1. call count (if a direct call) > 2. VP profile data (if an indirect call) > 3. branch weights for landing pad. > 4. can coexist with 2) and does not need to be updated. thanks for the list. I get the

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -918,6 +918,18 @@ LandingPadInst *InvokeInst::getLandingPadInst() const { return cast(getUnwindDest()->getFirstNonPHI()); } +void InvokeInst::updateProfWeight(uint64_t S, uint64_t T) { minglotus-6 wrote: > Is there a reason why branch weight !prof

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -918,6 +918,18 @@ LandingPadInst *InvokeInst::getLandingPadInst() const { return cast(getUnwindDest()->getFirstNonPHI()); } +void InvokeInst::updateProfWeight(uint64_t S, uint64_t T) { minglotus-6 wrote: also from

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -918,6 +918,18 @@ LandingPadInst *InvokeInst::getLandingPadInst() const { return cast(getUnwindDest()->getFirstNonPHI()); } +void InvokeInst::updateProfWeight(uint64_t S, uint64_t T) { minglotus-6 wrote:

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-04 Thread Mingming Liu via llvm-branch-commits
@@ -918,6 +918,18 @@ LandingPadInst *InvokeInst::getLandingPadInst() const { return cast(getUnwindDest()->getFirstNonPHI()); } +void InvokeInst::updateProfWeight(uint64_t S, uint64_t T) { minglotus-6 wrote: It makes sense to move them to `CallBase`. Will

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-04 Thread Mingming Liu via llvm-branch-commits
@@ -0,0 +1,185 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4 + +; RUN: opt < %s -passes='require,cgscc(inline)' -inline-threshold=1000 -S | FileCheck %s + +target datalayout =

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-04 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/83809 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-04 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/83809 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-04 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/83809 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-04 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/83809 None >From 9575b83ea40012ecbfbf301a24ec89de0726ffd4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Mon, 4 Mar 2024 00:43:55 -0800 Subject: [PATCH] update profile for invoke instruction in caller and callee

[llvm-branch-commits] [llvm] [Inline]Update value profile for non-call instructions (PR #83769)

2024-03-03 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/83769 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Inline]Update value profile for non-call instructions (PR #83769)

2024-03-03 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/83769 None >From 04a2bca6ee0fbea6a9dc84f59e8bf4a41f8ae230 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Sun, 3 Mar 2024 22:16:03 -0800 Subject: [PATCH] [Inline]Update value profile for non-call instructions ---

[llvm-branch-commits] [llvm] [nfc][InstrProfiling]For comdat setting helper function, move comment closer to the code (PR #83757)

2024-03-03 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/83757 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][InstrProfiling]For comdat setting helper function, move comment closer to the code (PR #83757)

2024-03-03 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/83757 >From 13099c90449036731b834e27aa8fb1c238ab8669 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Sun, 3 Mar 2024 19:02:09 -0800 Subject: [PATCH 1/2] [nfc][InstrProfiling]For comdat setting helper function,

[llvm-branch-commits] [llvm] [nfc][InstrProfiling]For comdat setting helper function, move comment closer to the code (PR #83757)

2024-03-03 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/83757 None >From 13099c90449036731b834e27aa8fb1c238ab8669 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Sun, 3 Mar 2024 19:02:09 -0800 Subject: [PATCH] [nfc][InstrProfiling]For comdat setting helper function,

[llvm-branch-commits] [compiler-rt] [llvm] A copy of https://github.com/llvm/llvm-project/pull/66825. Actually this is a superset (a copy plus the thinlto-import change) (PR #80761)

2024-02-26 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80761 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [llvm] A copy of https://github.com/llvm/llvm-project/pull/66825. Actually this is a superset (a copy plus the thinlto-import change) (PR #80761)

2024-02-25 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80761 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-21 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81378 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [llvm] A copy of https://github.com/llvm/llvm-project/pull/66825. Actually this is a superset (a copy plus the thinlto-import change) (PR #80761)

2024-02-14 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80761 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [llvm] [Placeholder] (PR #80761)

2024-02-14 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80761 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-13 Thread Mingming Liu via llvm-branch-commits
@@ -479,15 +479,37 @@ Error InstrProfSymtab::create(Module , bool InLTO) { continue; Types.clear(); G.getMetadata(LLVMContext::MD_type, Types); -if (!Types.empty()) { - MD5VTableMap.emplace_back(G.getGUID(), ); -} +if (Types.empty()) +

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-13 Thread Mingming Liu via llvm-branch-commits
@@ -479,15 +479,37 @@ Error InstrProfSymtab::create(Module , bool InLTO) { continue; Types.clear(); G.getMetadata(LLVMContext::MD_type, Types); -if (!Types.empty()) { - MD5VTableMap.emplace_back(G.getGUID(), ); -} +if (Types.empty()) +

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81051 >From 66dbbfef52bdc092cbd4ed619bba38c003f6063d Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 8 Feb 2024 09:07:27 -0800 Subject: [PATCH 1/2] [InstrProf] Add vtables with type metadata into symtab to

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81051 >From 66dbbfef52bdc092cbd4ed619bba38c003f6063d Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 8 Feb 2024 09:07:27 -0800 Subject: [PATCH] [InstrProf] Add vtables with type metadata into symtab to look

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
@@ -560,35 +586,50 @@ Error InstrProfSymtab::initVTableNamesFromCompressedStrings( std::bind(::addVTableName, this, std::placeholders::_1)); } -Error InstrProfSymtab::addFuncWithName(Function , StringRef PGOFuncName) { - if (Error E = addFuncName(PGOFuncName)) -

[llvm-branch-commits] [llvm] [NFC][CallPromotionUtils]Extract a helper function versionCallSiteWithCond from versionCallSite (PR #81181)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
@@ -267,7 +264,6 @@ static void createRetBitCast(CallBase , Type *RetTy, CastInst **RetBitCast) { /// Is replaced by the following: /// /// cond_bb: -/// %cond = icmp eq i32 ()* %ptr, @func minglotus-6 wrote: done.

[llvm-branch-commits] [llvm] [NFC][CallPromotionUtils]Extract a helper function versionCallSiteWithCond from versionCallSite (PR #81181)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81181 >From 7ebae253ab1808bca328453f68af2b595d07176e Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 8 Feb 2024 11:32:50 -0800 Subject: [PATCH 1/2] [NFC][CallPromotionUtils]Extract a helper function

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: > Can you pull out the part that does the refactoring into getCanonicalName and > adds comments etc into a separate nfc patch, so that this one is just about > adding vtables? Sure! I'm thinking about doing the nfc patch into LLVM main branch given `getCanonicalName`

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81378 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81378 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/81378 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81378 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81378 >From ac5dc1bf77b67cbf0aa5e2c8fb6a7ce0080fb501 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Sat, 10 Feb 2024 12:03:25 -0800 Subject: [PATCH 1/3] [CallPromotionUtils]Implement conditional indirect call

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81378 >From ac5dc1bf77b67cbf0aa5e2c8fb6a7ce0080fb501 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Sat, 10 Feb 2024 12:03:25 -0800 Subject: [PATCH 1/2] [CallPromotionUtils]Implement conditional indirect call

[llvm-branch-commits] [llvm] [NFC][CallPromotionUtils]Extract a helper function versionCallSiteWithCond from versionCallSite (PR #81181)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81181 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][CallPromotionUtils]Extract a helper function versionCallSiteWithCond from versionCallSite (PR #81181)

2024-02-12 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/81181 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [TypeProf][IndirectCallPromotion]Implement vtable-based transformation (PR #81442)

2024-02-11 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81442 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-10 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81378 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-02-10 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/81378 None >From ac5dc1bf77b67cbf0aa5e2c8fb6a7ce0080fb501 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Sat, 10 Feb 2024 12:03:25 -0800 Subject: [PATCH] [CallPromotionUtils]Implement conditional indirect call

[llvm-branch-commits] [llvm] [NFC][CallPromotionUtils]Extract a helper function versionCallSiteWithCond from versionCallSite (PR #81181)

2024-02-08 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81181 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][CallPromotionUtils]Extract a helper function versionCallSiteWithhCond from versionCallSite (PR #81181)

2024-02-08 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/81181 The parent patch is https://github.com/llvm/llvm-project/pull/81051 >From 7ebae253ab1808bca328453f68af2b595d07176e Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 8 Feb 2024 11:32:50 -0800 Subject:

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-08 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: > > Whoops! Sorry! Please don't review this. > > Something goes wrong with my fixup. > > Let me know when it is ready for review. Thanks! This is ready for review now. * I tried to merge the [nfc](https://github.com/llvm/llvm-project/pull/81054) such that the diff of this

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-08 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-08 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81051 >From 66dbbfef52bdc092cbd4ed619bba38c003f6063d Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 8 Feb 2024 09:07:27 -0800 Subject: [PATCH] [InstrProf] Add vtables with type metadata into symtab to look

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81051 >From 58f8fdbc9d2862a2579aece6c313bd19b4329e34 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Wed, 7 Feb 2024 23:07:36 -0800 Subject: [PATCH] [InstrProf] Add vtables with type metadata into symtab to look

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81051 >From a3cb7002be9d7efe9f7678911da9dd68b561b785 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Wed, 7 Feb 2024 22:18:50 -0800 Subject: [PATCH] fixup --- llvm/include/llvm/ProfileData/InstrProf.h| 11

[llvm-branch-commits] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][IndirectCallProm] Refactor function-based conditional devirtualization and indirect call value profile update into one helper function (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][IndirectCallProm] Refactor function-based conditional devirtualization and indirect call value profile update into one helper function (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC]Extract the heuristic to find vtable for an indirect call into a helper function (PR #81024)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/81024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC] (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/80762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC] (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
@@ -287,7 +290,18 @@ uint32_t IndirectCallPromoter::tryToPromote( NumOfPGOICallPromotion++; NumPromoted++; } - return NumPromoted; + + const bool Changed = (NumPromoted != 0); minglotus-6 wrote: done.

[llvm-branch-commits] [llvm] [NFC] (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
@@ -1260,6 +1260,8 @@ void annotateValueSite(Module , Instruction , ArrayRef VDs, uint64_t Sum, InstrProfValueKind ValueKind, uint32_t MaxMDCount) { + if (VDs.empty()) minglotus-6 wrote:

[llvm-branch-commits] [llvm] [NFC] (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/80762 >From 2a03c530e775faa79d2e800a38a4228b38dfea35 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Wed, 7 Feb 2024 18:20:51 -0800 Subject: [PATCH] resolve review feedback Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm] [NFC] (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
@@ -1628,6 +1664,17 @@ TEST(SymtabTest, instr_prof_symtab_module_test) { EXPECT_EQ(StringRef(PGOName), PGOFuncName); EXPECT_THAT(PGOFuncName.str(), EndsWith(Funcs[I].str())); } + + StringRef VTables[] = {"ExternalGV", "PrivateGV"}; + for (size_t I = 0; I <

[llvm-branch-commits] [NFC][IndirectCallProm] Refactor function-based conditional devirtualization and indirect call value profile update into one helper function (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC]Extract the heuristic to find vtable for an indirect call into a helper function (PR #81024)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC]Extract the heuristic to find vtable for an indirect call into a helper function (PR #81024)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC][IndirectCallProm] Refactor function-based conditional devirtualization and indirect call value profile update into one helper function (PR #80762)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/80762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-02-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

  1   2   >