[llvm-branch-commits] [llvm] [NFC][MemProf] Add the LLVM license text and minor clean up. (PR #140504)

2025-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm approved this pull request. https://github.com/llvm/llvm-project/pull/140504 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [StaticDataLayout][PGO]Implement reader and writer change for data access profiles (PR #139997)

2025-05-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm ready_for_review https://github.com/llvm/llvm-project/pull/139997 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [StaticDataLayout][PGO]Implement reader and writer change for data access profiles (PR #139997)

2025-05-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/139997 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [StaticDataLayout][PGO]Implement reader and writer change for data access profiles (PR #139997)

2025-05-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/139997 >From 4045c943966609cc9a92693752af0e29a19e1ef9 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 15 May 2025 09:56:52 -0700 Subject: [PATCH] Support reading and writing data access profiles in memprof

[llvm-branch-commits] [llvm] [StaticDataLayout][PGO]Implement reader and writer change for data access profiles (PR #139997)

2025-05-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/139997 >From d15ae3e73589b50edeb2ab823976734eaa3806e5 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 15 May 2025 09:56:52 -0700 Subject: [PATCH] Support reading and writing data access profiles in memprof

[llvm-branch-commits] [llvm] [StaticDataLayout][PGO]Implement reader and writer change for data access profiles (PR #139997)

2025-05-14 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm created https://github.com/llvm/llvm-project/pull/139997 None >From 75878647c2c36cca00e9d003dc84bf4597e19187 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Tue, 13 May 2025 22:54:59 -0700 Subject: [PATCH] [StaticDataLayout][PGO]Implement reader and writer chan

[llvm-branch-commits] [llvm] [AArch64AsmPrinter]Place jump tables into hot/unlikely-prefixed data sections for aarch64 (PR #126018)

2025-04-14 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/126018 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-04-05 Thread Mingming Liu via llvm-branch-commits
@@ -2769,6 +2769,23 @@ namespace { } // end anonymous namespace +StringRef AsmPrinter::getConstantSectionSuffix(const Constant *C) const { + SmallString<8> SectionNameSuffix; + if (TM.Options.EnableStaticDataPartitioning) { +if (C && SDPI && PSI) { + auto Count = S

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-04-05 Thread Mingming Liu via llvm-branch-commits
@@ -0,0 +1,141 @@ +; RUN: llc -mtriple=aarch64 -enable-split-machine-functions \ +; RUN: -partition-static-data-sections=true -function-sections=true \ +; RUN: -unique-section-names=false \ +; RUN: %s -o - 2>&1 | FileCheck %s --dump-input=always + +; Repeat the RUN com

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-29 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/129781 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-26 Thread Mingming Liu via llvm-branch-commits
@@ -0,0 +1,131 @@ +target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128" +target triple = "x86_64-grtev4-linux-gnu" + +; Tests that constant pool hotness is aggregated across the module. The mingmingl-llvm wrote: G

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-26 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/129781 >From 072c44f0f9272682480cc2837196a906bd694276 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 28 Feb 2025 14:41:56 -0800 Subject: [PATCH 1/4] [CodeGen][StaticDataSplitter]Support constant pool parti

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-26 Thread Mingming Liu via llvm-branch-commits
@@ -0,0 +1,141 @@ +; RUN: llc -mtriple=aarch64 -enable-split-machine-functions \ +; RUN: -partition-static-data-sections=true -function-sections=true \ +; RUN: -unique-section-names=false \ +; RUN: %s -o - 2>&1 | FileCheck %s --dump-input=always + +; Repeat the RUN com

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-26 Thread Mingming Liu via llvm-branch-commits
@@ -0,0 +1,141 @@ +; RUN: llc -mtriple=aarch64 -enable-split-machine-functions \ mingmingl-llvm wrote: Currently in the target pass configuration, the data partitioning pass is added inside `TM->Options.EnableMachineFunctionSplitter || EnableMachineFunctionSpli

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-26 Thread Mingming Liu via llvm-branch-commits
@@ -0,0 +1,141 @@ +; RUN: llc -mtriple=aarch64 -enable-split-machine-functions \ +; RUN: -partition-static-data-sections=true -function-sections=true \ +; RUN: -unique-section-names=false \ +; RUN: %s -o - 2>&1 | FileCheck %s --dump-input=always + +; Repeat the RUN com

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-26 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/129781 >From 072c44f0f9272682480cc2837196a906bd694276 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 28 Feb 2025 14:41:56 -0800 Subject: [PATCH 1/3] [CodeGen][StaticDataSplitter]Support constant pool parti

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-24 Thread Mingming Liu via llvm-branch-commits
@@ -112,21 +117,52 @@ bool StaticDataSplitter::runOnMachineFunction(MachineFunction &MF) { return Changed; } +const Constant * +StaticDataSplitter::getConstant(const MachineOperand &Op, +const TargetMachine &TM, +

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-22 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/129781 >From 072c44f0f9272682480cc2837196a906bd694276 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 28 Feb 2025 14:41:56 -0800 Subject: [PATCH 1/2] [CodeGen][StaticDataSplitter]Support constant pool parti

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-21 Thread Mingming Liu via llvm-branch-commits
@@ -148,17 +184,9 @@ bool StaticDataSplitter::partitionStaticDataWithProfiles(MachineFunction &MF) { if (MJTI->updateJumpTableEntryHotness(JTI, Hotness)) ++NumChangedJumpTables; -} else { - // Find global variables with local linkage. -

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-21 Thread Mingming Liu via llvm-branch-commits
@@ -386,6 +386,16 @@ MCSection *TargetLoweringObjectFile::getSectionForConstant( return DataSection; } +MCSection *TargetLoweringObjectFile::getSectionForConstant( +const DataLayout &DL, SectionKind Kind, const Constant *C, Align &Alignment, +StringRef SectionPrefix

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-21 Thread Mingming Liu via llvm-branch-commits
@@ -206,14 +234,10 @@ void StaticDataSplitter::annotateStaticDataWithoutProfiles( for (const auto &MBB : MF) { for (const MachineInstr &I : MBB) { for (const MachineOperand &Op : I.operands()) { -if (!Op.isGlobal()) - continue; -const Globa

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-21 Thread Mingming Liu via llvm-branch-commits
@@ -112,21 +117,52 @@ bool StaticDataSplitter::runOnMachineFunction(MachineFunction &MF) { return Changed; } +const Constant * +StaticDataSplitter::getConstant(const MachineOperand &Op, +const TargetMachine &TM, +

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-21 Thread Mingming Liu via llvm-branch-commits
@@ -2769,6 +2769,23 @@ namespace { } // end anonymous namespace +StringRef AsmPrinter::getConstantSectionSuffix(const Constant *C) const { mingmingl-llvm wrote: done. https://github.com/llvm/llvm-project/pull/129781 _

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/129781 >From 072c44f0f9272682480cc2837196a906bd694276 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 28 Feb 2025 14:41:56 -0800 Subject: [PATCH 1/2] [CodeGen][StaticDataSplitter]Support constant pool parti

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -386,6 +386,16 @@ MCSection *TargetLoweringObjectFile::getSectionForConstant( return DataSection; } +MCSection *TargetLoweringObjectFile::getSectionForConstant( +const DataLayout &DL, SectionKind Kind, const Constant *C, Align &Alignment, +StringRef SectionPrefix

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -203,17 +218,34 @@ void StaticDataSplitter::updateStatsWithProfiles(const MachineFunction &MF) { void StaticDataSplitter::annotateStaticDataWithoutProfiles( const MachineFunction &MF) { + const MachineConstantPool *MCP = MF.getConstantPool(); for (const auto &MBB :

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -1072,6 +1072,41 @@ MCSection *TargetLoweringObjectFileELF::getSectionForConstant( return DataRelROSection; } +MCSection *TargetLoweringObjectFileELF::getSectionForConstant( +const DataLayout &DL, SectionKind Kind, const Constant *C, Align &Alignment, +StringRef

[llvm-branch-commits] [llvm] [CodeGen][StaticDataSplitter]Support constant pool partitioning (PR #129781)

2025-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -2791,8 +2791,26 @@ void AsmPrinter::emitConstantPool() { if (!CPE.isMachineConstantPoolEntry()) C = CPE.Val.ConstVal; -MCSection *S = getObjFileLowering().getSectionForConstant( -getDataLayout(), Kind, C, Alignment); +MCSection *S = nullptr; -

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Refactor AsmPrinter and AArch64AsmPrinter to prepare for jump table partitions on aarch64 (PR #125993)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/125993 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AArch64AsmPrinter]Place jump tables into hot/unlikely-prefixed data sections for aarch64 (PR #126018)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
mingmingl-llvm wrote: cc @Colibrow https://github.com/llvm/llvm-project/pull/126018 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AArch64AsmPrinter]Place jump tables into hot/unlikely-prefixed data sections for aarch64 (PR #126018)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm created https://github.com/llvm/llvm-project/pull/126018 This is a follow-up patch of https://github.com/llvm/llvm-project/pull/125993 to port jump table partitions for aarch64. >From bcd1e154c97f57a6a7c00c5f137c301805eea0c2 Mon Sep 17 00:00:00 2001 From: ming

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Refactor AsmPrinter and AArch64AsmPrinter to prepare for jump table partitions on aarch64 (PR #125993)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/125993 >From 169486b930c12eb7521fe7ce3c3e6f360824af22 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Wed, 5 Feb 2025 18:46:36 -0800 Subject: [PATCH 1/2] [nfc]asm printer jump table --- llvm/include/llvm/CodeGe

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Refactor AsmPrinter and AArch64AsmPrinter to prepare for jump table partitions on aarch64 (PR #125993)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/125993 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Refactor AsmPrinter and AArch64AsmPrinter to prepare for jump table partitions on aarch64 (PR #125993)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm ready_for_review https://github.com/llvm/llvm-project/pull/125993 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Refactor AsmPrinter and AArch64AsmPrinter to prepare for jump table partitions on aarch64 (PR #125993)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
mingmingl-llvm wrote: cc @Colibrow fyi https://github.com/llvm/llvm-project/pull/125993 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Refactor AsmPrinter and AArch64AsmPrinter to prepare for jump table partitions on aarch64 (PR #125993)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/125993 >From 169486b930c12eb7521fe7ce3c3e6f360824af22 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Wed, 5 Feb 2025 18:46:36 -0800 Subject: [PATCH 1/3] [nfc]asm printer jump table --- llvm/include/llvm/CodeGe

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Refactor AsmPrinter and AArch64AsmPrinter to prepare for jump table partitions on aarch64 (PR #125993)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/125993 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][AsmPrinter] Refactor AsmPrinter and AArch64AsmPrinter to prepare for jump table partitions on aarch64 (PR #125993)

2025-02-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/125993 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/122215 >From dd748277dff2b30ed02bfa466eeca7102aa93eb4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 10 Jan 2025 13:53:08 -0800 Subject: [PATCH 1/9] rely to upstream --- llvm/include/llvm/CodeGen/MachineF

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
@@ -2876,42 +2875,101 @@ void AsmPrinter::emitJumpTableInfo() { MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference32 || MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference64, F); + + std::vector JumpTableIndices; + if (!TM.Opti

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
@@ -2876,42 +2875,101 @@ void AsmPrinter::emitJumpTableInfo() { MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference32 || MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference64, F); + + std::vector JumpTableIndices; + if (!TM.Opti

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
@@ -2876,42 +2875,101 @@ void AsmPrinter::emitJumpTableInfo() { MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference32 || MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference64, F); + + std::vector JumpTableIndices; + if (!TM.Opti

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
@@ -2876,42 +2875,101 @@ void AsmPrinter::emitJumpTableInfo() { MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference32 || MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference64, F); + + std::vector JumpTableIndices; + if (!TM.Opti

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
@@ -2876,42 +2875,101 @@ void AsmPrinter::emitJumpTableInfo() { MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference32 || MJTI->getEntryKind() == MachineJumpTableInfo::EK_LabelDifference64, F); + + std::vector JumpTableIndices; + if (!TM.Opti

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm commented: thanks for the feedback! PTAL. https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-br

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-17 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/122215 >From dd748277dff2b30ed02bfa466eeca7102aa93eb4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 10 Jan 2025 13:53:08 -0800 Subject: [PATCH 1/7] rely to upstream --- llvm/include/llvm/CodeGen/MachineF

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-16 Thread Mingming Liu via llvm-branch-commits
mingmingl-llvm wrote: cc @Colibrow @SharonXSharon https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm ready_for_review https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/122215 >From dd748277dff2b30ed02bfa466eeca7102aa93eb4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 10 Jan 2025 13:53:08 -0800 Subject: [PATCH 1/6] rely to upstream --- llvm/include/llvm/CodeGen/MachineF

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/122215 >From dd748277dff2b30ed02bfa466eeca7102aa93eb4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 10 Jan 2025 13:53:08 -0800 Subject: [PATCH 1/5] rely to upstream --- llvm/include/llvm/CodeGen/MachineF

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables' (read-only) data sections (PR #122215)

2025-01-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables sections (PR #122215)

2025-01-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/122215 >From dd748277dff2b30ed02bfa466eeca7102aa93eb4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 10 Jan 2025 13:53:08 -0800 Subject: [PATCH 1/4] rely to upstream --- llvm/include/llvm/CodeGen/MachineF

[llvm-branch-commits] [llvm] [AsmPrinter][ELF] Support profile-guided section prefix for jump tables sections (PR #122215)

2025-01-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][TargetLowering]Place a hot jump table into a hot-suffixed section (PR #122215)

2025-01-11 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/122215 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AsmPrinter][TargetLowering]Place a hot jump table into a hot-suffixed section (PR #122215)

2025-01-10 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/122215 >From dd748277dff2b30ed02bfa466eeca7102aa93eb4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Fri, 10 Jan 2025 13:53:08 -0800 Subject: [PATCH 1/2] rely to upstream --- llvm/include/llvm/CodeGen/MachineF

[llvm-branch-commits] [llvm] [AsmPrinter][TargetLowering]Place a hot jump table into a hot-suffixed section (PR #122215)

2025-01-09 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm updated https://github.com/llvm/llvm-project/pull/122215 >From a2a6f9f5a6f7647f85a230241bf3aa39c4bd65d9 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Wed, 8 Jan 2025 16:53:45 -0800 Subject: [PATCH 1/2] [AsmPrinter][TargetLowering]Place a hot jump table into a

[llvm-branch-commits] [llvm] [AsmPrinter][TargetLowering]Place a hot jump table into a hot-suffixed section (PR #122215)

2025-01-08 Thread Mingming Liu via llvm-branch-commits
https://github.com/mingmingl-llvm created https://github.com/llvm/llvm-project/pull/122215 None >From a2a6f9f5a6f7647f85a230241bf3aa39c4bd65d9 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Wed, 8 Jan 2025 16:53:45 -0800 Subject: [PATCH] [AsmPrinter][TargetLowering]Place a hot jump table into

[llvm-branch-commits] [compiler-rt] release/19.x: [InstrProf] Remove duplicate definition of IntPtrT (PR #101061)

2024-08-05 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: @tru thanks for the fix! Sorry I didn't regularly check the PRs with me as reviewers but I should really do that. https://github.com/llvm/llvm-project/pull/101061 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm

[llvm-branch-commits] [llvm] [Inline]Update value profile for non-call instructions (PR #83769)

2024-05-24 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: Close this. Going to update in https://github.com/llvm/llvm-project/pull/81442 https://github.com/llvm/llvm-project/pull/83769 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[llvm-branch-commits] [llvm] [Inline]Update value profile for non-call instructions (PR #83769)

2024-05-24 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 closed https://github.com/llvm/llvm-project/pull/83769 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Inline]Update value profile for non-call instructions (PR #83769)

2024-05-24 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/83769 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [TypeProf][IndirectCallPromotion]Implement vtable-based transformation (PR #81442)

2024-05-19 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81442 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-15 Thread Mingming Liu via llvm-branch-commits
@@ -216,7 +216,8 @@ void gatherImportedSummariesForModule( StringRef ModulePath, const DenseMap &ModuleToDefinedGVSummaries, const FunctionImporter::ImportMapTy &ImportList, -std::map &ModuleToSummariesForIndex); +std::map &ModuleToSummariesForIndex, +GV

[llvm-branch-commits] [llvm] [ThinLTO][Bitcode] Generate import type in bitcode (PR #87600)

2024-05-15 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/87600 >From 001a785f664e3a16e61d1e350ea060b829f1856c Mon Sep 17 00:00:00 2001 From: mingmingl Date: Mon, 13 May 2024 20:51:25 -0700 Subject: [PATCH 1/3] update this patch as the second one --- llvm/include/llvm/B

[llvm-branch-commits] [llvm] [CallPromotionUtils]Implement conditional indirect call promotion with vtable-based comparison (PR #81378)

2024-05-14 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81378 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][BitcodeWriter] Write import type in bitcode (PR #87600)

2024-05-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO]Write import type for distributed ThinLTO (PR #87600)

2024-05-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO][BitcodeWriter] Write import type in per-module combined summary (PR #87600)

2024-05-13 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/87600 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [NFC][CallPromotionUtils]Extract a helper function versionCallSiteWithCond from versionCallSite (PR #81181)

2024-05-09 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81181 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-07 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/9] function import changes --- llvm/include/llvm/IR/ModuleSumma

[llvm-branch-commits] [llvm] [ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: https://github.com/llvm/llvm-project/pull/87600 is a functional change and the diffbase of this patch, and `llvm/test/ThinLTO/X86/import_callee_declaration.ll` should be a test case for both patches. In the [diffbase](https://github.com/llvm/llvm-project/pull/87600), bitco

[llvm-branch-commits] [llvm] [ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/88024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: Tagging @jvoung since I cannot add you into reviewer. https://github.com/llvm/llvm-project/pull/88024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 ready_for_review https://github.com/llvm/llvm-project/pull/88024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/88024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-06 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/8] function import changes --- llvm/include/llvm/IR/ModuleSumma

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-05 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/7] function import changes --- llvm/include/llvm/IR/ModuleSumma

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-02 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/5] function import changes --- llvm/include/llvm/IR/ModuleSumma

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-05-01 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/4] function import changes --- llvm/include/llvm/IR/ModuleSumma

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-04-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/3] function import changes --- llvm/include/llvm/IR/ModuleSumma

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-04-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/88024 >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 2024 11:54:17 -0700 Subject: [PATCH 1/2] function import changes --- llvm/include/llvm/IR/ModuleSumma

[llvm-branch-commits] [compiler-rt] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-04-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/81051 error: too big or took too long to generate ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[llvm-branch-commits] [llvm] [InstrProf] Add vtables with type metadata into symtab to look it up with GUID (PR #81051)

2024-04-16 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/81051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [NFC]Extract the heuristic to find vtable for an indirect call into a helper function (PR #81024)

2024-04-11 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/81024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [compiler-rt] [flang] [libc] [libcxx] [llvm] [mlir] [NFC][IndirectCallProm] Refactor function-based conditional devirtualization and indirect call value profile update in

2024-04-11 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/80762 error: too big or took too long to generate ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[llvm-branch-commits] [llvm] [NFC][IndirectCallProm] Refactor function-based conditional devirtualization and indirect call value profile update into one helper function (PR #80762)

2024-04-11 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 converted_to_draft https://github.com/llvm/llvm-project/pull/80762 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [nfc][ThinLTO] Generate import status in per-module combined summary (PR #88024)

2024-04-08 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/88024 This is still working in progress. Need to update all callers of 'ComputeImportForModule' properly >From cfb63d775d43a28b560d938346f1dd4b2dddc765 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Thu, 4 Apr 20

[llvm-branch-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [lld] [llvm] [mlir] [openmp] [ThinLTO][TypeProf] Implement vtable def import (PR #79381)

2024-04-01 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/79381 error: too big or took too long to generate ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-26 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: > The invoke instruction can have 3 different kinds of prof data > > 1. call count (if a direct call) > 2. VP profile data (if an indirect call) > 3. branch weights for landing pad. > 4. can coexist with 2) and does not need to be updated. Is there an existing > test coverag

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-26 Thread Mingming Liu via llvm-branch-commits
https://github.com/minglotus-6 updated https://github.com/llvm/llvm-project/pull/83809 >From 9575b83ea40012ecbfbf301a24ec89de0726ffd4 Mon Sep 17 00:00:00 2001 From: mingmingl Date: Mon, 4 Mar 2024 00:43:55 -0800 Subject: [PATCH] update profile for invoke instruction in caller and callee after

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-05 Thread Mingming Liu via llvm-branch-commits
minglotus-6 wrote: > The invoke instruction can have 3 different kinds of prof data > > 1. call count (if a direct call) > 2. VP profile data (if an indirect call) > 3. branch weights for landing pad. > 4. can coexist with 2) and does not need to be updated. thanks for the list. I get the poin

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -918,6 +918,18 @@ LandingPadInst *InvokeInst::getLandingPadInst() const { return cast(getUnwindDest()->getFirstNonPHI()); } +void InvokeInst::updateProfWeight(uint64_t S, uint64_t T) { minglotus-6 wrote: > Is there a reason why branch weight !prof cannot

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -918,6 +918,18 @@ LandingPadInst *InvokeInst::getLandingPadInst() const { return cast(getUnwindDest()->getFirstNonPHI()); } +void InvokeInst::updateProfWeight(uint64_t S, uint64_t T) { minglotus-6 wrote: also from https://news.ycombinator.com/item?id=210

[llvm-branch-commits] [llvm] [Inline][PGO] After inline, update profile for invoke instruction in both cloned instruction in the caller and original callee (PR #83809)

2024-03-05 Thread Mingming Liu via llvm-branch-commits
@@ -918,6 +918,18 @@ LandingPadInst *InvokeInst::getLandingPadInst() const { return cast(getUnwindDest()->getFirstNonPHI()); } +void InvokeInst::updateProfWeight(uint64_t S, uint64_t T) { minglotus-6 wrote: https://llvm.org/docs/BranchWeightMetadata.html#ot

  1   2   3   >