owenca wrote:
> @owenca Do you have a release note we can put in the release announcement?
Release note:
Fixes a clang-format regression (since 17.0.6) on formatting `goto` labels in
macro definitions.
https://github.com/llvm/llvm-project/pull/93494
owenca wrote:
@tstellar thanks!
> @owenca Do you have a release note we can put in the release announcement?
Release note:
Fixes clang-format (since 18.1.1) regressions on breaking before a stream
insertion operator (<<) when both operands are string literals.
owenca wrote:
@tstellar strictly speaking, this is a regression fix. (It's a churn within
18.x release cycle.)
1. Risk level: low IMO. (The other code owner @mydeveloperday approved it to be
included in 18.1.7.)
2. Last known working version: 18.1.4
owenca wrote:
@tstellar
> 1. How risky is this fix?
Very low IMO. (@mydeveloperday @HazardyKnusperkeks @rymiel can chime in if
anyone thinks otherwise.)
> 2. When was the last known working version of clang-format?
17.0.6 (regressed since 18.1.1).
owenca wrote:
@tstellar this is a regression fix as labeled by the issue the original
pr/commit fixed. :)
https://github.com/llvm/llvm-project/pull/93494
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
owenca wrote:
@tstellar can we also get this one into 18.1.7?
https://github.com/llvm/llvm-project/pull/94091
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/94091
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/94091
…ing literals (#92214)
>From 88711473d2affcb21703e7b4f78420c512192acf Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 31 May 2024 20:13:27 -0700
Subject: [PATCH] release/18.x: [clang-format] Don't always
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/93494
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
@tstellar can we get this one in if we are doing another point release?
https://github.com/llvm/llvm-project/pull/93494
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
owenca wrote:
@HazardyKnusperkeks can you approve it too?
https://github.com/llvm/llvm-project/pull/91049
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/91049
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
@tstellar below is the release notes for clang-format 18.1.5.
- Restores clang-format behavior that always breaks before a stream insertion
operator (`<<`) when both operands are string literals.
- Fixes clang-format regressions in annotating initialization list braces and
Author: Owen Pan
Date: 2024-04-25T08:31:16-07:00
New Revision: 35fea1032741526f76d7fea49794061bf3a1d3ee
URL:
https://github.com/llvm/llvm-project/commit/35fea1032741526f76d7fea49794061bf3a1d3ee
DIFF:
https://github.com/llvm/llvm-project/commit/35fea1032741526f76d7fea49794061bf3a1d3ee.diff
owenca wrote:
@tstellar is this still waiting for @HazardyKnusperkeks?
https://github.com/llvm/llvm-project/pull/89415
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
owenca wrote:
@tstellar is this waiting for @HazardyKnusperkeks?
https://github.com/llvm/llvm-project/pull/89412
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/89491
>From 35fea1032741526f76d7fea49794061bf3a1d3ee Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 23:20:47 -0700
Subject: [PATCH] release/18.x: [clang-format] Correctly annotate braces in
macros
Author: Owen Pan
Date: 2024-04-24T21:29:46-07:00
New Revision: c0b48372d82aa0adaef671788ee1a37a650ee4fd
URL:
https://github.com/llvm/llvm-project/commit/c0b48372d82aa0adaef671788ee1a37a650ee4fd
DIFF:
https://github.com/llvm/llvm-project/commit/c0b48372d82aa0adaef671788ee1a37a650ee4fd.diff
owenca wrote:
> @owenca Can you rebase this branch?
@tstellar I've rebased it.
https://github.com/llvm/llvm-project/pull/89492
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/89492
>From c0b48372d82aa0adaef671788ee1a37a650ee4fd Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 23:58:35 -0700
Subject: [PATCH] release/18.x: [clang-format] Revert breaking stream operators
to
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/89415
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/89412
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/89492
…ious default (#89016)
Backport 29ecd6d50f14
>From 7fd5c11287f10fa94f58b4c7aee293d7df17b498 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 23:58:35 -0700
Subject: [PATCH] release/18.x:
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/89492
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/89491
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/89491
…953)
Backport 58323de2e5ed
>From 042f92bcdaed5b4ba1fceddb0c2187df76b51006 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 23:20:47 -0700
Subject: [PATCH] release/18.x: [clang-format] Correctly
https://github.com/owenca milestoned
https://github.com/llvm/llvm-project/pull/89489
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/89489
…Init (#87450)
Backport 7c9c38eaa9b7
>From 497357a593a65534691091ef155e80d43d51d9c9 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 19 Apr 2024 21:59:29 -0700
Subject: [PATCH] release/18.x: [clang-format]
owenca wrote:
The only bug fix for clang-format is in the change log section of 18.1.4
release notes, so I'm not sure if it's useful to repeat it at the top of the
release notes. For 18.1.5, there will be a reversion of behavior from 18.1.1.
I'll definitely add that to the release notes.
owenca wrote:
This is just a bug fix
[requested](https://github.com/llvm/llvm-project/issues/79834#issuecomment-2030179647)
to be cherry picked, so I don't think we need to add a note about it in the
release note.
https://github.com/llvm/llvm-project/pull/87735
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/81096
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/81106
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/80593
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
> As stated in the discussion, it is an absolutely must to merge it in the
> release. In my opinion we can't just drop an option, for the next release.
Yep! See
https://github.com/llvm/llvm-project/issues/78892#issuecomment-1926009360.
owenca wrote:
@tstellar can you move this PR to Needs Merge? Thanks!
https://github.com/llvm/llvm-project/pull/80259
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/80259
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/80591
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
owenca wrote:
Replaced with #80593.
https://github.com/llvm/llvm-project/pull/80591
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
38 matches
Mail list logo
