[llvm-branch-commits] [llvm] [BOLT][test] Fix callcont-fallthru.s after #129481 (PR #135867)

2025-05-02 Thread Vladislav Khmelevsky via llvm-branch-commits
yota9 wrote: Yeah, that's right. Although maybe we need to replace nm to llvm-nm in link_fdata to be default... Up to you and @aaupov to decided.. https://github.com/llvm/llvm-project/pull/135867 ___ llvm-branch-commits mailing list llvm-branch-commi

[llvm-branch-commits] [llvm] [BOLT][test] Fix callcont-fallthru.s after #129481 (PR #135867)

2025-05-02 Thread Vladislav Khmelevsky via llvm-branch-commits
yota9 wrote: @paschalis-mpeis I realised that if would change the nm to llvm-nm that we can just mark test as xfail, as it would fail until the patch above would be submitted. https://github.com/llvm/llvm-project/pull/135867 ___ llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT][test] Fix callcont-fallthru.s after #129481 (PR #135867)

2025-05-02 Thread Vladislav Khmelevsky via llvm-branch-commits
yota9 wrote: @paschalis-mpeis Indeed, you're right. Let's wait about @aaupov decision then, it LGTM https://github.com/llvm/llvm-project/pull/135867 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[llvm-branch-commits] [llvm] [BOLT][test] Fix callcont-fallthru.s after #129481 (PR #135867)

2025-05-02 Thread Vladislav Khmelevsky via llvm-branch-commits
yota9 wrote: I've decided to add synthetic option to llvm-nm here https://github.com/llvm/llvm-project/pull/138232 . Unfortunately it would take some time, as main maintainer won't be able to review it soon, so probably for now we might just mark the test as XFAIL until then.. https://github.

[llvm-branch-commits] [llvm] [BOLT][test] Fix callcont-fallthru.s after #129481 (PR #135867)

2025-04-30 Thread Vladislav Khmelevsky via llvm-branch-commits
yota9 wrote: @paschalis-mpeis Could you please check if the binaries are identical and it is indeed nm problem? E.g. with objdump, is plt entry is there? Maybe there is problem related to the plt section type, e.g. one of the binaries has .plt.sec or .plt.got section and there is some kind of

[llvm-branch-commits] [llvm] [BOLT][test] Fix callcont-fallthru.s after #129481 (PR #135867)

2025-04-29 Thread Vladislav Khmelevsky via llvm-branch-commits
yota9 wrote: Maybe I'm missing something but why use /dev/null library hack in the first place here? There is [stub.c](https://github.com/llvm/llvm-project/blob/main/bolt/test/Inputs/stub.c) available with puts symbol already, just use it to compile so and link against it, plt entry should ap

[llvm-branch-commits] [llvm] release/19.x: [BOLT] Fix relocations handling (PR #102741)

2024-08-19 Thread Vladislav Khmelevsky via llvm-branch-commits
yota9 wrote: I hope someone can approve this, as it is a major fix https://github.com/llvm/llvm-project/pull/102741 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com

[llvm-branch-commits] [llvm] release/19.x: [BOLT] Fix relocations handling (PR #102741)

2024-08-10 Thread Vladislav Khmelevsky via llvm-branch-commits
https://github.com/yota9 created https://github.com/llvm/llvm-project/pull/102741 Backport https://github.com/llvm/llvm-project/commit/097ddd3565f830e6cb9d0bb8ca66844b7f3f3cbb >From f606ebe592885b36db9e21ee518e87bce017d2d8 Mon Sep 17 00:00:00 2001 From: Vladislav Khmelevsky Date: Sat, 27 Jul

[llvm-branch-commits] [llvm] release/19.x: [BOLT] Skip PLT search for zero-value weak reference symbols (#69136) (PR #102295)

2024-08-07 Thread Vladislav Khmelevsky via llvm-branch-commits
https://github.com/yota9 approved this pull request. Bugfix LGTM https://github.com/llvm/llvm-project/pull/102295 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commi

[llvm-branch-commits] [llvm] release/19.x: [BOLT] Support map other function entry address (#101466) (PR #102282)

2024-08-07 Thread Vladislav Khmelevsky via llvm-branch-commits
https://github.com/yota9 approved this pull request. Bugfix LGTM https://github.com/llvm/llvm-project/pull/102282 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit