[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

tstellar wrote: @nikic (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. https://github.

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/90544 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/90544 >From c5b3fa491f001e06bca9a2f0754937d3614fd9e8 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Sat, 20 Apr 2024 18:28:38 + Subject: [PATCH] Reland "[clang-repl] Keep the first llvm::Module empty to avo

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

https://github.com/lhames approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/90544 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

vgvassilev wrote: Ok, maybe we could move forward? https://github.com/llvm/llvm-project/pull/90544 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

nikic wrote: @vgvassilev My bad, I completely missed that the changed header is in the lib/ directory, not in include/. https://github.com/llvm/llvm-project/pull/90544 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lis

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

vgvassilev wrote: @nikic, I am confused. How is that an abi breaking change? https://github.com/llvm/llvm-project/pull/90544 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-br

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

nikic wrote: This looks like an ABI breaking change to me. I think the libclang-cpp.so ABI test is currently broken due to the new minor version scheme. (cc @tstellar we need something like https://github.com/llvm/llvm-project/pull/85166 for the clang ABI check) https://github.com/llvm/llvm-p

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (llvmbot) Changes Backport a3f07d36cbc9e3a0d004609d140474c1d8a25bb6 Requested by: @nikic --- Full diff: https://github.com/llvm/llvm-project/pull/90544.diff 2 Files Affected: - (modified) clang/lib/Interpreter/IncrementalParser.cp

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/90544 Backport a3f07d36cbc9e3a0d004609d140474c1d8a25bb6 Requested by: @nikic >From 7c0adaa78303cd0bccf1789159cc940e725ac700 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Sat, 20 Apr 2024 18:28:38 + Subject

[llvm-branch-commits] [clang] release/18.x: Reland "[clang-repl] Keep the first llvm::Module empty to avoid invalid memory access. (#89031)" (PR #90544)

https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/90544 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits