Author: Julian Lettner Date: 2021-01-22T12:03:03-08:00 New Revision: 975086b10a6f1ce5a9b78783f085c0da454c30bc
URL: https://github.com/llvm/llvm-project/commit/975086b10a6f1ce5a9b78783f085c0da454c30bc DIFF: https://github.com/llvm/llvm-project/commit/975086b10a6f1ce5a9b78783f085c0da454c30bc.diff LOG: Remove obsolete TODOs Remove a few of my own TODOs that I will not have time to fix from lit code. Added: Modified: llvm/utils/lit/lit/cl_arguments.py Removed: ################################################################################ diff --git a/llvm/utils/lit/lit/cl_arguments.py b/llvm/utils/lit/lit/cl_arguments.py index 591d4f9aaafb..ce49c3c48a97 100644 --- a/llvm/utils/lit/lit/cl_arguments.py +++ b/llvm/utils/lit/lit/cl_arguments.py @@ -116,7 +116,7 @@ def parse_args(): dest="maxIndividualTestTime", help="Maximum time to spend running a single test (in seconds). " "0 means no time limit. [Default: 0]", - type=_non_negative_int) # TODO(yln): --[no-]test-timeout, instead of 0 allowed + type=_non_negative_int) execution_group.add_argument("--max-failures", help="Stop execution after the given number of failures.", type=_positive_int) @@ -135,15 +135,15 @@ def parse_args(): metavar="N", help="Maximum number of tests to run", type=_positive_int) - selection_group.add_argument("--max-time", #TODO(yln): --timeout + selection_group.add_argument("--max-time", dest="timeout", metavar="N", help="Maximum time to spend testing (in seconds)", type=_positive_int) - selection_group.add_argument("--shuffle", # TODO(yln): --order=random - help="Run tests in random order", # default or 'by-path' (+ isEarlyTest()) + selection_group.add_argument("--shuffle", + help="Run tests in random order", action="store_true") - selection_group.add_argument("-i", "--incremental", # TODO(yln): --order=failing-first + selection_group.add_argument("-i", "--incremental", help="Run modified and failing tests first (updates mtimes)", action="store_true") selection_group.add_argument("--filter", @@ -151,7 +151,7 @@ def parse_args(): type=_case_insensitive_regex, help="Only run tests with paths matching the given regular expression", default=os.environ.get("LIT_FILTER", ".*")) - selection_group.add_argument("--num-shards", # TODO(yln): --shards N/M + selection_group.add_argument("--num-shards", dest="numShards", metavar="M", help="Split testsuite into M pieces and only run one", _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
