[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

nikic wrote: Given that this change has already caused two distinct bugs, I don't think we will accept a backport for it anyway, so don't worry about the release branch. https://github.com/llvm/llvm-project/pull/88818 ___ llvm-branch-commits mailing

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

DianQK wrote: > > @yingopq The patches are not reverted in main, so you can base your fix on > > top of the existing changes (or revert them as part of your PR, if that's > > easier?) > > Should it be consistent with the release branch, so that it is more > convenient to merge into the

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

yingopq wrote: > @yingopq The patches are not reverted in main, so you can base your fix on > top of the existing changes (or revert them as part of your PR, if that's > easier?) Should it be consistent with the release branch, so that it is more convenient to merge into the release branch?

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

nikic wrote: @yingopq The patches are not reverted in main, so you can base your fix on top of the existing changes (or revert them as part of your PR, if that's easier?) https://github.com/llvm/llvm-project/pull/88818 ___ llvm-branch-commits mailing

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

yingopq wrote: @nikic Hi, have you not reverted those two patches yet? I plan to submit new patch which has addressed this issue. https://github.com/llvm/llvm-project/pull/88818 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

nikic wrote: I'd also add that this fixes a regression from a previous LLVM 18 point release: > Fix regressions introduced in LLVM 18.1.3 in MIPS atomicrmw min/max codegen. https://github.com/llvm/llvm-project/pull/88818 ___ llvm-branch-commits

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

topperc wrote: > > Hi @nikic (or anyone else). If you would like to add a note about this fix > > in the release notes (completely optional). Please reply to this comment > > with a one or two sentence description of the fix. > > I'm not sure if this description is accurate: Fix the issue

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

DianQK wrote: > Hi @nikic (or anyone else). If you would like to add a note about this fix in > the release notes (completely optional). Please reply to this comment with a > one or two sentence description of the fix. I'm not sure if this description is accurate: Fix the issue where the

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/88818 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

tstellar wrote: Hi @nikic (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. https://github.com/llvm/llvm-project/pull/88818

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/88818 >From 1d3f5da4f323e0e5b33688450dc066e9651b Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Tue, 16 Apr 2024 09:10:46 +0900 Subject: [PATCH] Revert "[Mips] Fix missing sign extension in expansion of

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/88818 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

https://github.com/DianQK approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/88818 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

https://github.com/nikic created https://github.com/llvm/llvm-project/pull/88818 …omic max (#77072)" These changes caused correctness regressions observed in Rust, see https://github.com/llvm/llvm-project/pull/77072#issuecomment-2049009507 and following. Revert the incorrect changes from the

[llvm-branch-commits] [llvm] Revert "[Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072)" (PR #88818)

https://github.com/nikic milestoned https://github.com/llvm/llvm-project/pull/88818 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits