nikic wrote:
> @RalfJung Are you configuring LLVM with
> -DLLVM_VERSION_SUFFIX=-rust-1.78.0-nightly ?
Yes.
> So the problem Rust sees isn't that a ".1" was added to the version, but
> rather that the name was changed from "libLLVM-18-rust-1.78.0-nightly.so" to
> "libLLVM.so.18.1-rust-1.78.0-
RalfJung wrote:
> So the problem Rust sees isn't that a ".1" was added to the version, but
> rather that the name was changed from "libLLVM-18-rust-1.78.0-nightly.so" to
> "libLLVM.so.18.1-rust-1.78.0-nightly". (that is: all the version info
> previously went into the library name which comes
tstellar wrote:
@RalfJung Are you configuring LLVM with
-DLLVM_VERSION_SUFFIX=-rust-1.78.0-nightly ?
https://github.com/llvm/llvm-project/pull/82409
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
jyknight wrote:
So the problem Rust sees isn't that a ".1" was added to the version, but rather
that the name was changed from "libLLVM-18-rust-1.78.0-nightly.so" to
"libLLVM.so.18.1-rust-1.78.0-nightly". (that is: all the version info
previously went into the library name which comes before "
RalfJung wrote:
Yeah, I linked to it: https://github.com/rust-lang/rust/issues/121889.
I'm not a linker expert, but it seems that now symlinks are required to link
against the LLVM .so file, but we can't ship symlinks in our artifacts because
of Windows. The old approach we used of just shippi
tstellar wrote:
@RalfJung The intention was that the change would be backwards compatible. Is
there a specific problem you see? We can still fix this in the release/18.x
branch if necessary.
https://github.com/llvm/llvm-project/pull/82409
___
llvm-
RalfJung wrote:
Making such a fundamental change to the .so file so late in the release was
probably a bad idea... a bunch of downstream projects will have to adjust the
way they link with LLVM and that's [not always
easy](https://github.com/rust-lang/rust/issues/121889).
https://github.com/l
https://github.com/tstellar closed
https://github.com/llvm/llvm-project/pull/82409
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/llvmbot updated
https://github.com/llvm/llvm-project/pull/82409
>From 235306ba1f89eb1b9f9724edec5eacb295f8198f Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Mon, 19 Feb 2024 16:46:16 -0800
Subject: [PATCH 1/2] [cmake] Add minor version to library SONAME (#79376)
We need
https://github.com/llvmbot updated
https://github.com/llvm/llvm-project/pull/82409
>From 1d4de7556e20621245bbc32fca97544ea18cb6c5 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Mon, 19 Feb 2024 16:46:16 -0800
Subject: [PATCH 1/2] [cmake] Add minor version to library SONAME (#79376)
We need
llvmbot wrote:
@jyknight What do you think about merging this PR to the release branch?
https://github.com/llvm/llvm-project/pull/82409
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/82409
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/82409
Backport 91a384621e5b762d9c173ffd247cfeadd5f436a2
Requested by: @tstellar
>From 4f49c058f52996c02b791106d73b841cd8552d2c Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Mon, 19 Feb 2024 16:46:16 -0800
Subject
13 matches
Mail list logo