[llvm-branch-commits] [llvm] [EarlyIfCvt] Take branch probablities into consideration (PR #97808)

2024-07-10 Thread Pengcheng Wang via llvm-branch-commits
wangpc-pp wrote: > > [EarlyIfCvt] Take branch probablities into consideration > > It looks like this MR is only adding a target hook, so this title doesn't > make sense to me I was planning to add support to RISCV target, but it depends on your early if-conversion patch. I will hold this PR u

[llvm-branch-commits] [llvm] [EarlyIfCvt] Take branch probablities into consideration (PR #97808)

2024-07-10 Thread Pengcheng Wang via llvm-branch-commits
@@ -913,6 +913,10 @@ class TargetInstrInfo : public MCInstrInfo { return false; } + /// Return true if the target will always try to convert predictable branches + /// to selects. + virtual bool shouldConvertPredictableBranches() const { return true; } + -

[llvm-branch-commits] [llvm] [BOLT][AArch64] Fix static binary patching for ELF. (PR #97710)

2024-07-10 Thread Paschalis Mpeis via llvm-branch-commits
https://github.com/paschalis-mpeis edited https://github.com/llvm/llvm-project/pull/97710 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT][AArch64] Fix static binary patching for ELF. (PR #97710)

2024-07-10 Thread Paschalis Mpeis via llvm-branch-commits
https://github.com/paschalis-mpeis edited https://github.com/llvm/llvm-project/pull/97710 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT][AArch64] Fix static binary patching for ELF. (PR #97710)

2024-07-10 Thread Paschalis Mpeis via llvm-branch-commits
https://github.com/paschalis-mpeis edited https://github.com/llvm/llvm-project/pull/97710 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT][AArch64] Fix static binary patching for ELF. (PR #97710)

2024-07-10 Thread Paschalis Mpeis via llvm-branch-commits
https://github.com/paschalis-mpeis edited https://github.com/llvm/llvm-project/pull/97710 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] 74eff4d - Revert "[llvm][ARM][AArch64] Add attributes to synthetic functions. (#83153)"

2024-07-10 Thread via llvm-branch-commits
Author: Daniel Kiss Date: 2024-07-10T10:21:33+02:00 New Revision: 74eff4df1d9a050718ebdbce5a71a119282035ae URL: https://github.com/llvm/llvm-project/commit/74eff4df1d9a050718ebdbce5a71a119282035ae DIFF: https://github.com/llvm/llvm-project/commit/74eff4df1d9a050718ebdbce5a71a119282035ae.diff L

[llvm-branch-commits] [llvm] 74e9e20 - Revert "[Clang][ARM][AArch64] Alway emit protection attributes for functions.…"

2024-07-10 Thread via llvm-branch-commits
Author: Daniel Kiss Date: 2024-07-10T10:21:36+02:00 New Revision: 74e9e20f0338824eecea0f27d9c1336676a60d3d URL: https://github.com/llvm/llvm-project/commit/74e9e20f0338824eecea0f27d9c1336676a60d3d DIFF: https://github.com/llvm/llvm-project/commit/74e9e20f0338824eecea0f27d9c1336676a60d3d.diff L

[llvm-branch-commits] [flang] [Flang][OpenMP] Derived type explicit allocatable member mapping (PR #96266)

2024-07-10 Thread via llvm-branch-commits
agozillon wrote: Small ping for some reviewer attention on this PR stack if at all possible, it would be greatly appreciated! https://github.com/llvm/llvm-project/pull/96266 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https

[llvm-branch-commits] [clang] [Serialization] Introduce OnDiskHashTable for specializations (PR #83233)

2024-07-10 Thread Chuanqi Xu via llvm-branch-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/83233 >From 2bf5a6ca8bde003b7acf0a9ab7c6e69cc3109e02 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 28 Feb 2024 11:41:53 +0800 Subject: [PATCH] [Serialization] Introduce OnDiskHashTable for specializations Fo

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-07-10 Thread Chuanqi Xu via llvm-branch-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/83237 >From f2e53e44eebab4720a1dbade24fcb14d698fb03f Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 28 Feb 2024 11:41:53 +0800 Subject: [PATCH] [Serialization] Code cleanups and polish 83233 --- clang/includ

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-07-10 Thread Chuanqi Xu via llvm-branch-commits
ChuanqiXu9 wrote: @ilya-biryukov I've fixed the crash occured in the reproducer. The root reason is that, previously, I wouldn't load all the specializations for paritial specializations. But this is not safe. I think you can test it again. https://github.com/llvm/llvm-project/pull/83237 _

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-07-10 Thread Chuanqi Xu via llvm-branch-commits
ChuanqiXu9 wrote: @vgvassilev In the newest version, I introduced a new hasher TemplateArgumentHasher and use this new hasher to calculate the hash value for template arguments. We thought this may be harder. But I just realized, we don't have to provide a very precise results at first. Since

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-07-10 Thread Chuanqi Xu via llvm-branch-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/83237 >From f2e53e44eebab4720a1dbade24fcb14d698fb03f Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 28 Feb 2024 11:41:53 +0800 Subject: [PATCH 1/2] [Serialization] Code cleanups and polish 83233 --- clang/in

[llvm-branch-commits] [llvm] 2b9ea35 - Revert "[LowerMemIntrinsics] Use correct alignment in residual loop for varia…"

2024-07-10 Thread via llvm-branch-commits
Author: Fabian Ritter Date: 2024-07-10T12:12:19+02:00 New Revision: 2b9ea3555e7f5996393e304d3810e704ea5feeeb URL: https://github.com/llvm/llvm-project/commit/2b9ea3555e7f5996393e304d3810e704ea5feeeb DIFF: https://github.com/llvm/llvm-project/commit/2b9ea3555e7f5996393e304d3810e704ea5feeeb.diff

[llvm-branch-commits] [llvm] [EarlyIfCvt] Take branch probablities into consideration (PR #97808)

2024-07-10 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: Needs target + test? https://github.com/llvm/llvm-project/pull/97808 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [llvm] AMDGPU: Handle remote/fine-grained memory in atomicrmw fmin/fmax lowering (PR #96759)

2024-07-10 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ping https://github.com/llvm/llvm-project/pull/96759 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] AMDGPU: Add subtarget feature for global atomic fadd denormal support (PR #96443)

2024-07-10 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **Jul 10, 8:37 AM EDT**: @arsenm started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/96443). https://github.com/llvm/llvm-project/pull/96443 __

[llvm-branch-commits] [llvm] AMDGPU: Add subtarget feature for memory atomic fadd f64 (PR #96444)

2024-07-10 Thread Matt Arsenault via llvm-branch-commits
arsenm wrote: ### Merge activity * **Jul 10, 8:37 AM EDT**: @arsenm started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/96444). https://github.com/llvm/llvm-project/pull/96444 __

[llvm-branch-commits] [llvm] [AMDGPU][SILoadStoreOptimizer] Merge constrained sloads (PR #96162)

2024-07-10 Thread Christudasan Devadasan via llvm-branch-commits
cdevadas wrote: Ping https://github.com/llvm/llvm-project/pull/96162 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AMDGPU] Codegen support for constrained multi-dword sloads (PR #96163)

2024-07-10 Thread Christudasan Devadasan via llvm-branch-commits
cdevadas wrote: Ping https://github.com/llvm/llvm-project/pull/96163 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AMDGPU][SILoadStoreOptimizer] Merge constrained sloads (PR #96162)

2024-07-10 Thread Jay Foad via llvm-branch-commits
@@ -658,17 +658,17 @@ define amdgpu_kernel void @image_bvh_intersect_ray_nsa_reassign(ptr %p_node_ptr, ; ; GFX1013-LABEL: image_bvh_intersect_ray_nsa_reassign: ; GFX1013: ; %bb.0: -; GFX1013-NEXT:s_load_dwordx8 s[0:7], s[0:1], 0x24 +; GFX1013-NEXT:s_load_dwordx8

[llvm-branch-commits] [llvm] [AMDGPU][SILoadStoreOptimizer] Merge constrained sloads (PR #96162)

2024-07-10 Thread Jay Foad via llvm-branch-commits
@@ -1212,8 +1228,14 @@ void SILoadStoreOptimizer::copyToDestRegs( // Copy to the old destination registers. const MCInstrDesc &CopyDesc = TII->get(TargetOpcode::COPY); - const auto *Dest0 = TII->getNamedOperand(*CI.I, OpName); - const auto *Dest1 = TII->getNamedOperand(*

[llvm-branch-commits] [llvm] [AMDGPU] Codegen support for constrained multi-dword sloads (PR #96163)

2024-07-10 Thread Jay Foad via llvm-branch-commits
@@ -866,13 +866,61 @@ def SMRDBufferImm : ComplexPattern; def SMRDBufferImm32 : ComplexPattern; def SMRDBufferSgprImm : ComplexPattern; +class SMRDAlignedLoadPat : PatFrag <(ops node:$ptr), (Op node:$ptr), [{ + // Ignore the alignment check if XNACK support is disabled. +

[llvm-branch-commits] [llvm] [AMDGPU][SILoadStoreOptimizer] Merge constrained sloads (PR #96162)

2024-07-10 Thread Christudasan Devadasan via llvm-branch-commits
@@ -658,17 +658,17 @@ define amdgpu_kernel void @image_bvh_intersect_ray_nsa_reassign(ptr %p_node_ptr, ; ; GFX1013-LABEL: image_bvh_intersect_ray_nsa_reassign: ; GFX1013: ; %bb.0: -; GFX1013-NEXT:s_load_dwordx8 s[0:7], s[0:1], 0x24 +; GFX1013-NEXT:s_load_dwordx8

[llvm-branch-commits] [llvm] [AMDGPU][SILoadStoreOptimizer] Merge constrained sloads (PR #96162)

2024-07-10 Thread Christudasan Devadasan via llvm-branch-commits
https://github.com/cdevadas edited https://github.com/llvm/llvm-project/pull/96162 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] f1f8d87 - Revert "[RISCV] Enable TTI::shouldDropLSRSolutionIfLessProfitable by default …"

2024-07-10 Thread via llvm-branch-commits
Author: Alex Bradbury Date: 2024-07-10T15:28:18+01:00 New Revision: f1f8d8789af2627fd04a0e98203189f6da14a261 URL: https://github.com/llvm/llvm-project/commit/f1f8d8789af2627fd04a0e98203189f6da14a261 DIFF: https://github.com/llvm/llvm-project/commit/f1f8d8789af2627fd04a0e98203189f6da14a261.diff

[llvm-branch-commits] [llvm] [SPARC][IAS] Reject unknown/unavailable mnemonics early in ParseInstruction (PR #96021)

2024-07-10 Thread via llvm-branch-commits
https://github.com/koachan updated https://github.com/llvm/llvm-project/pull/96021 >From dbd8f1f421b397a4907af3811937a7815900876a Mon Sep 17 00:00:00 2001 From: Koakuma Date: Wed, 10 Jul 2024 23:57:01 +0700 Subject: [PATCH] Don't use ParseForAllFeatures, validate all mnemonics up front instead

[llvm-branch-commits] [llvm] [SPARC][IAS] Reject unknown/unavailable mnemonics early in ParseInstruction (PR #96021)

2024-07-10 Thread via llvm-branch-commits
https://github.com/koachan edited https://github.com/llvm/llvm-project/pull/96021 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [SPARC][IAS] Reject unknown/unavailable mnemonics early in ParseInstruction (PR #96021)

2024-07-10 Thread via llvm-branch-commits
koachan wrote: Hmmm, so, change of approach - I decided to follow what the MIPS backend does and validate all mnemonics early in ParseInstruction, before any operand parsing is done. This gets IAS to emit the correct error message for missing instructions. The misuse of ParseStatus returns sti

[llvm-branch-commits] [llvm] [SPARC][IAS] Reject unknown/unavailable mnemonics early in ParseInstruction (PR #96021)

2024-07-10 Thread via llvm-branch-commits
https://github.com/koachan updated https://github.com/llvm/llvm-project/pull/96021 >From dbd8f1f421b397a4907af3811937a7815900876a Mon Sep 17 00:00:00 2001 From: Koakuma Date: Wed, 10 Jul 2024 23:57:01 +0700 Subject: [PATCH 1/2] Don't use ParseForAllFeatures, validate all mnemonics up front ins

[llvm-branch-commits] [llvm] [SPARC][IAS] Reject unknown/unavailable mnemonics early in ParseInstruction (PR #96021)

2024-07-10 Thread Sergei Barannikov via llvm-branch-commits
https://github.com/s-barannikov approved this pull request. The downside of this approach is that you lose the ability to report the missing features (unless you implement it yourself, which would be a code duplication), that would allow to produce instead better diagnostics like "instruction

[llvm-branch-commits] [llvm] [SPARC][IAS] Reject unknown/unavailable mnemonics early in ParseInstruction (PR #96021)

2024-07-10 Thread Sergei Barannikov via llvm-branch-commits
https://github.com/s-barannikov edited https://github.com/llvm/llvm-project/pull/96021 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match blocks with calls as anchors (PR #96596)

2024-07-10 Thread Shaw Young via llvm-branch-commits
https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/96596 >From 05d59574d6260b98a469921eb2fccf5398bfafb6 Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Mon, 24 Jun 2024 23:00:59 -0700 Subject: [PATCH 01/18] Added call to matchWithCallsAsAnchors Created using spr 1.

[llvm-branch-commits] [llvm] [BOLT] Match blocks with calls as anchors (PR #96596)

2024-07-10 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/96596 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [BOLT] Match blocks with calls as anchors (PR #96596)

2024-07-10 Thread Amir Ayupov via llvm-branch-commits
@@ -63,8 +63,8 @@ class NameResolver { } // Removes a suffix from a function name. - static StringRef removeSuffix(StringRef Name, StringRef Suffix) { -const size_t Pos = Name.find(Suffix); + static StringRef unify(StringRef Name) { aaupov wrote: Le

[llvm-branch-commits] [llvm] [BOLT] Match blocks with calls as anchors (PR #96596)

2024-07-10 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov commented: Thanks, LG with one nit. https://github.com/llvm/llvm-project/pull/96596 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-10 Thread Krzysztof Parzyszek via llvm-branch-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/98387 Express the constraints via constituent directives. >From 263c2357cd686e63b5b78985d3c8c6f3635e69cc Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 10 Jul 2024 09:35:56 -0500 Subject: [PATCH] [clan

[llvm-branch-commits] [clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-10 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) Changes Express the constraints via constituent directives. --- Full diff: https://github.com/llvm/llvm-project/pull/98387.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaOpenMP.cpp (+53-54)

[llvm-branch-commits] [BOLT] Match blocks with calls as anchors (PR #98390)

2024-07-10 Thread Shaw Young via llvm-branch-commits
https://github.com/shawbyoung created https://github.com/llvm/llvm-project/pull/98390 Expands the scope of possible block matches by hashing blocks by their lexicographically ordered function names to provide a looser level of matching past opcode hash matching in StaleProfileMatching. Test Pla

[llvm-branch-commits] [BOLT] Match blocks with calls as anchors (PR #98390)

2024-07-10 Thread Shaw Young via llvm-branch-commits
https://github.com/shawbyoung closed https://github.com/llvm/llvm-project/pull/98390 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [BOLT] Match blocks with calls as anchors (PR #98390)

2024-07-10 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-bolt Author: Shaw Young (shawbyoung) Changes Expands the scope of possible block matches by hashing blocks by their lexicographically ordered function names to provide a looser level of matching past opcode hash matching in StaleProfileMatching. Test Pl

[llvm-branch-commits] [llvm] [BOLT] Match blocks with calls as anchors (PR #96596)

2024-07-10 Thread Shaw Young via llvm-branch-commits
https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/96596 >From 05d59574d6260b98a469921eb2fccf5398bfafb6 Mon Sep 17 00:00:00 2001 From: shawbyoung Date: Mon, 24 Jun 2024 23:00:59 -0700 Subject: [PATCH 01/19] Added call to matchWithCallsAsAnchors Created using spr 1.

[llvm-branch-commits] [clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-10 Thread Alexey Bataev via llvm-branch-commits
@@ -4828,26 +4835,28 @@ static bool checkNestingOfRegions(Sema &SemaRef, const DSAStackTy *Stack, << (SemaRef.LangOpts.OpenMP >= 50 ? 1 : 0); return CurrentRegion != OMPD_simd; } - if (ParentRegion == OMPD_atomic) { + + if (EnclosingConstruct == OMPD_atomic) {

[llvm-branch-commits] [clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-10 Thread Alexey Bataev via llvm-branch-commits
@@ -4805,6 +4811,7 @@ static bool checkNestingOfRegions(Sema &SemaRef, const DSAStackTy *Stack, << getOpenMPDirectiveName(CurrentRegion); return true; } + alexey-bataev wrote: Remove this extra line https://github.com/llvm/llvm-project/pull/983

[llvm-branch-commits] [compiler-rt] ccefcec - Revert "Revert "[compiler-rt] Remove redundant COMPILER_RT_HAS_*SAN checks" (…"

2024-07-10 Thread via llvm-branch-commits
Author: Vitaly Buka Date: 2024-07-10T14:33:59-07:00 New Revision: ccefcec4403ec838a62dd944a2a7bd51e061dddf URL: https://github.com/llvm/llvm-project/commit/ccefcec4403ec838a62dd944a2a7bd51e061dddf DIFF: https://github.com/llvm/llvm-project/commit/ccefcec4403ec838a62dd944a2a7bd51e061dddf.diff L

[llvm-branch-commits] [llvm] [BOLT] Match blocks with calls as anchors (PR #96596)

2024-07-10 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov approved this pull request. https://github.com/llvm/llvm-project/pull/96596 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] 88144b6 - Revert "[RISCV] Expand vp.stride.load to splat of a scalar load. (#98140)"

2024-07-10 Thread via llvm-branch-commits
Author: Nico Weber Date: 2024-07-10T20:54:15-04:00 New Revision: 88144b639d4c256e0540ae2754321a487528c77c URL: https://github.com/llvm/llvm-project/commit/88144b639d4c256e0540ae2754321a487528c77c DIFF: https://github.com/llvm/llvm-project/commit/88144b639d4c256e0540ae2754321a487528c77c.diff LO

[llvm-branch-commits] [llvm] [SPARC][IAS] Reject unknown/unavailable mnemonics early in ParseInstruction (PR #96021)

2024-07-10 Thread via llvm-branch-commits
koachan wrote: Merging this for now, but to clarify a little: > The downside of this approach is that you lose the ability to report the > missing features (unless you implement it yourself, which would be a code > duplication), that would allow to produce better diagnostics like > "instructi

[llvm-branch-commits] [clang] 9a74d06 - Revert "[NFC][Clang] Move functions of BranchProtectionInfo out of line (#98329)"

2024-07-10 Thread via llvm-branch-commits
Author: Daniel Kiss Date: 2024-07-11T08:37:25+02:00 New Revision: 9a74d0613287e7ae86c305b0250e188e3c3de6c3 URL: https://github.com/llvm/llvm-project/commit/9a74d0613287e7ae86c305b0250e188e3c3de6c3 DIFF: https://github.com/llvm/llvm-project/commit/9a74d0613287e7ae86c305b0250e188e3c3de6c3.diff L