https://github.com/ivanradanov created
https://github.com/llvm/llvm-project/pull/101444
2/4
>From 8068d6036fe84f6c0f22f2c877366eef184292e3 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov created
https://github.com/llvm/llvm-project/pull/101445
3/4
>From c2cbd7779dc118c6bad507b6babeb7200262caff Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH] [flang] Introduce ws loop nest generation for HLF
https://github.com/ivanradanov created
https://github.com/llvm/llvm-project/pull/101446
4/4
There are two points which need some discussion in this PR:
1. We need to make a value computed in a omp.single accessible in all threads
of the omp.parallel region. This is achieved by allocating tem
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101444
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101445
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101446
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101446
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101445
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101444
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ivanradanov wrote:
Should we have a `-use-experimental-workshare` or similar flag to facilitate
some temporary in-tree development as this may require more moving pieces.
https://github.com/llvm/llvm-project/pull/101444
___
llvm-branch-commits mailing
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101445
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ivanradanov wrote:
I am debating introducing a new operation workshare_loop_container which exists
only to "contain" a omp.loop_nest between lowering an elemental to lowering the
omp.workshare it is contained in.
so we would have this state:
```
omp.workshare {
omp.workshare_loop_container
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From 9a51b404ab47c5dd0b27c3f957ee6cefd1470c25 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:44:31 +0900
Subject: [PATCH] [flang] Lower omp.workshare to other omp constructs
-
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 4da93bb2a99ac1d59d4924c518503c94ec81c659 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH] [flang] Introduce ws loop nest generation for HLFIR lo
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From 26d0051179dec85eb6aee2b48db54964bf042a87 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:44:31 +0900
Subject: [PATCH] [flang] Lower omp.workshare to other omp constructs
-
ivanradanov wrote:
> Thank you for your work so far. This is a great start.
>
> What is the plan for transforming do loops generated by lowering (e.g. that
> do not become hlfir.elemental operations and are not generated by hlfir
> bufferization)?
I am looking at [this](https://www.openmp.org
@@ -2,3 +2,4 @@ add_subdirectory(CodeGen)
add_subdirectory(Dialect)
add_subdirectory(HLFIR)
add_subdirectory(Transforms)
+add_subdirectory(OpenMP)
ivanradanov wrote:
Thank you, I missed those passes, I guess I will make a separate PR for
creating the OpenMP p
@@ -792,7 +793,8 @@ struct ElementalOpConversion
// Generate a loop nest looping around the fir.elemental shape and clone
// fir.elemental region inside the inner loop.
hlfir::LoopNest loopNest =
-hlfir::genLoopNest(loc, builder, extents, !elemental.isOrdere
@@ -0,0 +1,259 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,259 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,259 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101446
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From 62057f90e1e6e9e89df1bb666a3676421e2e52ac Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Fri, 2 Aug 2024 16:10:25 +0900
Subject: [PATCH 1/9] Add custom omp loop wrapper
---
mlir/include/mlir
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 14878e80f5bcf8dac5100951de803ce584a33b25 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH] [flang][omp] Emit omp.workshare in frontend
---
flan
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 16f7146a45ee9b31c00d9d54be4859df312dcb1b Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/2] [flang] Introduce ws loop nest generation for HLFI
@@ -0,0 +1,259 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 7422985144525359db3d95c58b2b477872c73d54 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/2] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 14878e80f5bcf8dac5100951de803ce584a33b25 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From b26c03dab1104a13d47b3a5124a31f4a83dbd320 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/2] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 97cd498c0819f1a15464d742915534499739a0b4 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From b26c03dab1104a13d47b3a5124a31f4a83dbd320 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/3] [flang] Introduce ws loop nest generation for HLFI
@@ -0,0 +1,259 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,259 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -792,7 +793,8 @@ struct ElementalOpConversion
// Generate a loop nest looping around the fir.elemental shape and clone
// fir.elemental region inside the inner loop.
hlfir::LoopNest loopNest =
-hlfir::genLoopNest(loc, builder, extents, !elemental.isOrdere
@@ -0,0 +1,259 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,259 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
ivanradanov wrote:
@kiranchandramohan @tblah
I think this warrants another look if you have some time.
I have reiterated a bit and opted to have a omp loop nest wrapper op which
signals to the workshare lowering which specific loops need to be parallelized
(i.e. converted to wsloop { loop_ne
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 1ecd832151fab1cd9b977f0e4b960294cfdc2d12 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 0287ff3626883d09e364210e83a652a6328835dd Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/3] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From aea7da1492e9ad122b3b17f07b8f91b7c6eac777 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From cca8588b2b2d1c4275b9eaf22c7bd017942f06d9 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/3] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 2b23c8b52d3b5b680bbcf090fd8c08de6d86fe62 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/3] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 0eae392538510f736b630d93b14d46644d042e4f Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101443
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 69e85558ec78c7a74be9168b4227bb262f67225e Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101443
>From e453738aaa1bd74e2462025075ea4ac12868caac Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:09:09 +0900
Subject: [PATCH 1/7] [MLIR][omp] Add omp.workshare op
---
.../Dialect
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 38c581c8defc81105160a69bb46a9e489b56f10e Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/3] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101445
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 38c581c8defc81105160a69bb46a9e489b56f10e Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/4] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov created
https://github.com/llvm/llvm-project/pull/104748
WIP I will be adding unit tests and I am considering if we should have
integrations tests for the entire omp.workshare pipeline.
>From 793ae50dd00c4347bea78ca6ecd33783c69de354 Mon Sep 17 00:00:00 2001
From:
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/104748
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101446
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov ready_for_review
https://github.com/llvm/llvm-project/pull/101443
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov ready_for_review
https://github.com/llvm/llvm-project/pull/101444
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov ready_for_review
https://github.com/llvm/llvm-project/pull/101445
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101445
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov ready_for_review
https://github.com/llvm/llvm-project/pull/101446
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2,3 +2,4 @@ add_subdirectory(CodeGen)
add_subdirectory(Dialect)
add_subdirectory(HLFIR)
add_subdirectory(Transforms)
+add_subdirectory(OpenMP)
ivanradanov wrote:
PR for this up here https://github.com/llvm/llvm-project/pull/104732
https://github.com/llvm/
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 5e470922405b735d63b4aded76450cc52e94e003 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/4] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 63d49e4dcd128b470ee77006c594673203dd2df2 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101443
>From 604b0293e0574e9d697d4071c2b853a5a27af1e1 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:09:09 +0900
Subject: [PATCH 1/7] [MLIR][omp] Add omp.workshare op
---
.../Dialect
@@ -344,6 +345,7 @@ inline void createHLFIRToFIRPassPipeline(
pm.addPass(hlfir::createLowerHLFIRIntrinsics());
pm.addPass(hlfir::createBufferizeHLFIR());
pm.addPass(hlfir::createConvertHLFIRtoFIR());
+ pm.addPass(flangomp::createLowerWorkshare());
ivanra
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/104748
>From bf0e09f9cfc3159517b1ebec9d39e1143fa935b9 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Tue, 20 Aug 2024 09:28:15 +0900
Subject: [PATCH 1/7] Iterate backwards to find all trivially dead ops
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/104748
>From a45ef32ecf6483bdb65954c4283ea493494cea77 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Tue, 20 Aug 2024 16:57:25 +0900
Subject: [PATCH 1/6] Update test
---
.../Transforms/OpenMP/lower-work
https://github.com/ivanradanov closed
https://github.com/llvm/llvm-project/pull/101443
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov reopened
https://github.com/llvm/llvm-project/pull/101443
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/104748
>From 4b1c15bf4dcd753e35ec5c1118b107ea058c58df Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Sun, 4 Aug 2024 17:33:52 +0900
Subject: [PATCH 1/5] Add workshare loop wrapper lowerings
---
.../lib/
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 3d1258582adc0ec506a23dc3efdba371c29612ca Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 451a9d2f26cfd8cb770d1ae35d834c63fce56b79 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/4] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
error: too big or took too long to generate
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From e5789180a3dd1fd8c46a5d7dfc446921110642ca Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From 81606df746e9862c330681ed8ae9113a43e577a2 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH 1/4] [flang] Introduce ws loop nest generation for HLFI
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/104748
>From d343f3a86f56864757ccdf889fd6897d9d9507e9 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:09:09 +0900
Subject: [PATCH 1/6] [MLIR][omp] Add omp.workshare op
Add custom omp l
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From d343f3a86f56864757ccdf889fd6897d9d9507e9 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:09:09 +0900
Subject: [PATCH 1/5] [MLIR][omp] Add omp.workshare op
Add custom omp l
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From d4310a06639c6cd1565aac2d2bbfebffcf9e175d Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
Fix l
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From c3ec4f1bd4a51139a10b1450e3e194a9270b7362 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:12:34 +0900
Subject: [PATCH] [flang] Introduce ws loop nest generation for HLFIR lo
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/104748
>From 45a5069b5b783e0e1cd5fa0ba8f8098a980eb94e Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Thu, 22 Aug 2024 18:05:31 +0900
Subject: [PATCH 1/6] wrong replace
---
mlir/test/Dialect/OpenMP/ops.m
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From 45a5069b5b783e0e1cd5fa0ba8f8098a980eb94e Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Thu, 22 Aug 2024 18:05:31 +0900
Subject: [PATCH 1/5] wrong replace
---
mlir/test/Dialect/OpenMP/ops.m
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101445
>From d5fbe9c7482b87be295be03aafd5917dd7c17859 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Thu, 22 Aug 2024 18:07:05 +0900
Subject: [PATCH] [flang] Introduce ws loop nest generation for HLFIR lo
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101444
>From 0984407c261496c9dc53fdd2d4d5c2431dd90359 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Wed, 31 Jul 2024 14:11:47 +0900
Subject: [PATCH 1/2] [flang][omp] Emit omp.workshare in frontend
Fix l
ivanradanov wrote:
@skatrak
I considered that as well, however, I did not like it because the semantics of
the block that the operation is contained in is different. wsloop expects its
parent block to be a parallel block which all threads will execute and all of
those threads will share the w
@@ -0,0 +1,446 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
https://github.com/ivanradanov edited
https://github.com/llvm/llvm-project/pull/101446
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,446 @@
+//===- LowerWorkshare.cpp - special cases for bufferization ---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
ivanradanov wrote:
> Maybe support for this operation could be just based on changes to how the
> MLIR representation is built in the first place, what do you think?
This is partly what this implementation aims to do. In fact, after the pass
that lowers the omp.workshare operation we are left
ivanradanov wrote:
No you are right, sorry for the back and forth, as you said, since a wsloop can
only be nested in a omp.parallel it is immediately obvious that it binds to the
omp.parallel threads so that makes sense.
My only concern was that at some point some transformation (perhaps in th
ivanradanov wrote:
> ... However, they would work if they ran after the pass lowering
> `omp.workshare` to a set of `omp.single` for the code in between
> `omp.wsloop`s. That way we would not have to introduce a new loop wrapper and
> also we could create passes assuming the parent of region
ivanradanov wrote:
> Can you share a case where this would happen? I agree that we wouldn't want
> to produce some IR that doesn't keep consistent semantics for a given
> operation across the pipeline. In that case, adding another operation might
> indeed be the right solution.
I was under t
ivanradanov wrote:
@kiranchandramohan @tblah @skatrak I have a question to people more familiar
with Fortran and the entire Flang pipeline - is it possible that we would have
CFG (multiple blocks) in the IR generated in the workshare statement at this
point in the pipeline (immediately after l
ivanradanov wrote:
Ah yes, I meant `scf.execute_region`. But when I tried creating that and it was
not registered so I thought it was a deliberate decision to not pull in the scf
dialect so I opted not to go for that lowering. I was wondering if there is
some op that is like `scf.execute_regio
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/104748
>From c5b5369be3d0db31d9ded0eeeb8e28e03d25bd9e Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Fri, 4 Oct 2024 22:45:09 +0900
Subject: [PATCH 1/6] Fix bug and add better clarification comments
---
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From e56dbd6a0625890fd9a3d6a62675e864ca94a8f5 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Sun, 4 Aug 2024 22:06:55 +0900
Subject: [PATCH 01/10] [flang] Lower omp.workshare to other omp construc
ivanradanov wrote:
@Thirumalai-Shaktivel Thank you very much. Fixed.
`forall` is actually a case which we do not handle yet. You can give it a shot
if you would like.
https://github.com/llvm/llvm-project/pull/104748
___
llvm-branch-commits mailing l
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From e56dbd6a0625890fd9a3d6a62675e864ca94a8f5 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Sun, 4 Aug 2024 22:06:55 +0900
Subject: [PATCH 01/11] [flang] Lower omp.workshare to other omp construc
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/104748
>From 8d0651ff644fa6821e0d0fbc4c47fee36802a15c Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Fri, 4 Oct 2024 22:48:42 +0900
Subject: [PATCH 1/6] Fix message
---
flang/lib/Optimizer/OpenMP/LowerW
ivanradanov wrote:
@Thirumalai-Shaktivel Fixed, it was a very stupid mistake with the argument
order of the copyprivate copy function. Thank you.
https://github.com/llvm/llvm-project/pull/104748
___
llvm-branch-commits mailing list
llvm-branch-commits
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/104748
>From 07a9eb3581f480c47ce4de3de00c7cef15df3cdc Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Fri, 4 Oct 2024 14:21:14 +0900
Subject: [PATCH 1/7] Fix dst src in copy function
---
flang/lib/Optimi
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From e56dbd6a0625890fd9a3d6a62675e864ca94a8f5 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Sun, 4 Aug 2024 22:06:55 +0900
Subject: [PATCH 1/8] [flang] Lower omp.workshare to other omp constructs
https://github.com/ivanradanov updated
https://github.com/llvm/llvm-project/pull/101446
>From e56dbd6a0625890fd9a3d6a62675e864ca94a8f5 Mon Sep 17 00:00:00 2001
From: Ivan Radanov Ivanov
Date: Sun, 4 Aug 2024 22:06:55 +0900
Subject: [PATCH 1/9] [flang] Lower omp.workshare to other omp constructs
ivanradanov wrote:
> My concern with the TODO message is that some code that previously compiled
> using the lowering of WORKSHARE as SINGLE will now hit this TODO. This is
> okay with me so long as it is fixed soon (before LLVM 20). Otherwise, could
> these cases continued to be lowered as SI
1 - 100 of 133 matches
Mail list logo
