[llvm-branch-commits] [clang] [flang] [lld] [llvm] [Flang] LLVM_ENABLE_RUNTIMES=FortranRuntime (PR #110217)

jplehr wrote: I tested this locally and it appears that it requires are more modern CMake version than what was installed (`3.22`). According to the LLVM docs (https://releases.llvm.org/12.0.0/docs/GettingStarted.html#id8) currently CMake 3.20 is the minimum required version. https://github.c

[llvm-branch-commits] [llvm] release/20.x: [Offload] Properly guard modifications to the RPC device array (#126790) (PR #126795)

https://github.com/jplehr approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/126795 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [Flang] Introduce FortranSupport (PR #122069)

https://github.com/jplehr approved this pull request. I did not find issues when running this through a couple of configurations I typically use. https://github.com/llvm/llvm-project/pull/122069 ___ llvm-branch-commits mailing list llvm-branch-commits

[llvm-branch-commits] [llvm] [AMDGPU][Attributor] Rework update of `AAAMDWavesPerEU` (PR #123995)

jplehr wrote: Out of curiosity: I believe this is case three, why would we not want to use the user-provided values? https://github.com/llvm/llvm-project/pull/123995 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists

[llvm-branch-commits] [llvm] [Offload] Add GenericPluginTy::get_mem_info (PR #157484)

@@ -1567,6 +1576,10 @@ struct GenericPluginTy { /// object and return immediately. int32_t async_barrier(omp_interop_val_t *Interop); + /// Given a pointer previously allocated by GenericDeviceTy::Allocate, return + /// information about that allocation + virtual Expect

[llvm-branch-commits] [llvm] [Offload] Add GenericPluginTy::get_mem_info (PR #157484)

@@ -1612,8 +1533,141 @@ struct CUDAPluginTy final : public GenericPluginTy { // revision. return Major == ImageMajor && Minor >= ImageMinor; } + + Expected get_memory_info(const void *TgtPtr) override { jplehr wrote: ```suggestion Expected getMemo

[llvm-branch-commits] [llvm] [Offload] Add GenericPluginTy::get_mem_info (PR #157484)

https://github.com/jplehr edited https://github.com/llvm/llvm-project/pull/157484 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Offload] Add GenericPluginTy::get_mem_info (PR #157484)

https://github.com/jplehr commented: I thought that the allocation would be done via the `MemoryManager` thing but I can be completely wrong. https://github.com/llvm/llvm-project/pull/157484 ___ llvm-branch-commits mailing list llvm-branch-commits@lis

[llvm-branch-commits] [llvm] [Offload] Add GenericPluginTy::get_mem_info (PR #157484)

@@ -517,6 +517,11 @@ struct GenELF64PluginTy final : public GenericPluginTy { #endif } + Expected get_memory_info(const void *TgtPtr) override { jplehr wrote: ```suggestion Expected getMemoryInfo(const void *TgtPtr) override { ``` https://github.com/llv

[llvm-branch-commits] [llvm] [Offload] Add GenericPluginTy::get_mem_info (PR #157484)

@@ -3561,6 +3564,26 @@ struct AMDGPUPluginTy final : public GenericPluginTy { return KernelAgents; } + Expected get_memory_info(const void *TgtPtr) override { jplehr wrote: ```suggestion Expected getMemoryInfo(const void *TgtPtr) override { ``` http

[llvm-branch-commits] [llvm] [Offload] Add GenericPluginTy::get_mem_info (PR #157484)

@@ -3561,6 +3564,28 @@ struct AMDGPUPluginTy final : public GenericPluginTy { return KernelAgents; } + Expected getMemoryInfo(const void *TgtPtr) override { jplehr wrote: The code in `OffloadImpl` and the code in the NVidia case had/have `std::lock_gu