[llvm-branch-commits] [clang-tools-extra] [clang] [llvm] [compiler-rt] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info ilovepi wrote: oh, nevermind I missed

[llvm-branch-commits] [clang-tools-extra] [llvm] [compiler-rt] [clang] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info +// COM: to do offline symbolization we only check that the current module is correctly symbolized +// REQUIRES: linux

[llvm-branch-commits] [clang-tools-extra] [llvm] [clang] [compiler-rt] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info ilovepi wrote: `COM:` I assume is for comment? I don't recall seeing this in `lit` tests anywhere,

[llvm-branch-commits] [clang-tools-extra] [clang] [llvm] [compiler-rt] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info +// COM: to do offline symbolization we only check that the current module is correctly symbolized +// REQUIRES: linux

[llvm-branch-commits] [llvm] [compiler-rt] [clang-tools-extra] [clang] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info +// COM: to do offline symbolization we only check that the current module is correctly symbolized +// REQUIRES: linux

[llvm-branch-commits] [llvm] [compiler-rt] [clang] [clang-tools-extra] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,57 @@ +// REQUIRES: linux +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t.main +// RUN: mkdir -p %t/.build-id/12 +// RUN: cp %t.main %t/.build-id/12/345678.debug +// RUN:

[llvm-branch-commits] [clang] [compiler-rt] [clang-tools-extra] [llvm] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info +// COM: to do offline symbolization we only check that the current module is correctly symbolized +// REQUIRES: linux

[llvm-branch-commits] [compiler-rt] [clang-tools-extra] [llvm] [clang] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info +// COM: to do offline symbolization we only check that the current module is correctly symbolized +// REQUIRES: linux

[llvm-branch-commits] [clang-tools-extra] [compiler-rt] [llvm] [clang] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info +// COM: to do offline symbolization we only check that the current module is correctly symbolized +// REQUIRES: linux

[llvm-branch-commits] [compiler-rt] [llvm] [clang] [clang-tools-extra] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,57 @@ +// REQUIRES: linux +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t.main +// RUN: mkdir -p %t/.build-id/12 +// RUN: cp %t.main %t/.build-id/12/345678.debug +// RUN:

[llvm-branch-commits] [compiler-rt] [llvm] [clang-tools-extra] [clang] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// REQUIRES: linux +// RUN: rm -rf %t +// RUN: mkdir -p %t/.build-id/12 +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t/main +//

[llvm-branch-commits] [compiler-rt] [clang-tools-extra] [clang] [llvm] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: https://github.com/ilovepi approved this pull request. This is mostly good IMO, modulo a few small nits in the FileCheck directives that should be applied to both files as

[llvm-branch-commits] [compiler-rt] [clang-tools-extra] [clang] [llvm] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// REQUIRES: linux +// RUN: rm -rf %t +// RUN: mkdir -p %t/.build-id/12 +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t/main +//

[llvm-branch-commits] [compiler-rt] [clang] [llvm] [clang-tools-extra] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// REQUIRES: linux +// RUN: rm -rf %t +// RUN: mkdir -p %t/.build-id/12 +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t/main +//

[llvm-branch-commits] [clang-tools-extra] [compiler-rt] [clang] [llvm] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// REQUIRES: linux +// RUN: rm -rf %t +// RUN: mkdir -p %t/.build-id/12 +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t/main +//

[llvm-branch-commits] [llvm] [clang] [clang-tools-extra] [compiler-rt] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// REQUIRES: linux +// RUN: rm -rf %t +// RUN: mkdir -p %t/.build-id/12 +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t/main +//

[llvm-branch-commits] [llvm] [clang-tools-extra] [compiler-rt] [clang] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/77702 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [llvm] [compiler-rt] [clang-tools-extra] [clang] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,33 @@ +// COM: End to end test for the sanitizer symbolizer markup. Since it uses debug info ilovepi wrote: The current use is fine. It just isn't something I've seen much(TBH, not at all).

[llvm-branch-commits] [clang] [clang-tools-extra] [llvm] [compiler-rt] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// REQUIRES: linux +// RUN: rm -rf %t +// RUN: mkdir -p %t/.build-id/12 +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t/main +//

[llvm-branch-commits] [clang-tools-extra] [clang] [llvm] [compiler-rt] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// REQUIRES: linux +// RUN: rm -rf %t +// RUN: mkdir -p %t/.build-id/12 +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t/main +//

[llvm-branch-commits] [clang] [clang-tools-extra] [llvm] [compiler-rt] [sanitizer_symbolizer] Add end to end test for symbolizer markup. (PR #77702)

=?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas , =?utf-8?q?Andrés?= Villegas Message-ID: In-Reply-To: @@ -0,0 +1,58 @@ +// REQUIRES: linux +// RUN: rm -rf %t +// RUN: mkdir -p %t/.build-id/12 +// RUN: %clangxx_tsan %s -Wl,--build-id=0x12345678 -O1 -o %t/main +//

[llvm-branch-commits] [lld] [llvm] [RISCV] Support RISC-V TLSDESC in LLD (PR #77516)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/77516 This patch adds support for RISC-V TLSDESC relocations, as described in https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/373. It does not attempt to handle relaxation for these cases, which will be

[llvm-branch-commits] [lld] [llvm] [RISCV] Support RISC-V TLSDESC in LLD (PR #77516)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/77516 >From ed9f0c9de1e8f75acdae90ef714323147539d215 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 9 Jan 2024 22:50:19 + Subject: [PATCH] Add checks for both local and global accesses Created using spr

[llvm-branch-commits] [clang] [llvm] PR for llvm/llvm-project#79632 (PR #79633)

https://github.com/ilovepi approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/79633 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [lld] [RISCV] Support RISC-V TLSDESC in LLD (PR #77516)

ilovepi wrote: Abandon in favor of https://github.com/llvm/llvm-project/pull/79239 https://github.com/llvm/llvm-project/pull/77516 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] [lld] [RISCV] Support RISC-V TLSDESC in LLD (PR #77516)

https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/77516 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] ReleaseNotes: mention -mtls-dialect=desc (PR #82731)

https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/82731 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][dfa-jump-threading] Add option to allow DFAJumpThreading when (PR #83049)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/83049 optimizing for size ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/83049 >From fc2e672d474442ef83e90c7a41265d6433651b63 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 26 Feb 2024 21:42:24 + Subject: [PATCH 1/2] Refactor option names, and update test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/83049 >From fc2e672d474442ef83e90c7a41265d6433651b63 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 26 Feb 2024 21:42:24 + Subject: [PATCH] Refactor option names, and update test Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/83049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

@@ -222,6 +222,11 @@ static cl::opt EnableDFAJumpThreading("enable-dfa-jump-thread", cl::desc("Enable DFA jump threading"), cl::init(false), cl::Hidden); +static cl::opt +

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

ilovepi wrote: > Can we have a more principled approach to determine when to allow this pass > to run than a `cl::opt`? For example, change the `CostThreshold` in the pass > depending on whether or not the function has `optsize`. Sure. I can take a look at doing it that way instead. it will

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

ilovepi wrote: cc: @petrhosek @PiJoules since I think they're interested. https://github.com/llvm/llvm-project/pull/83049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

ilovepi wrote: > This pass is not part of the default pipeline -- do you enable this pass > downstream, or do you want to add options for _all_ uses of minsize, even if > there is no evidence of usefulness? We’d like to see if this can be useful to some of our size constrained users in the

[llvm-branch-commits] [llvm] Remove pipeline checks for optsize for DFAJumpThreadingPass (PR #83188)

https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/83188 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi ready_for_review https://github.com/llvm/llvm-project/pull/83049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Remove pipeline checks for optsize for DFAJumpThreadingPass (PR #83188)

ilovepi wrote: huh, not sure why spr merged this into a branch, but I'll need to fix that. https://github.com/llvm/llvm-project/pull/83188 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

ilovepi wrote: > Can we have a more principled approach to determine when to allow this pass > to run than a `cl::opt`? For example, change the `CostThreshold` in the pass > depending on whether or not the function has `optsize`. So, I've experimented with this, and I'm not sure this is the

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/83049 >From fc2e672d474442ef83e90c7a41265d6433651b63 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 26 Feb 2024 21:42:24 + Subject: [PATCH 1/3] Refactor option names, and update test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/83049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/83049 >From fc2e672d474442ef83e90c7a41265d6433651b63 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 26 Feb 2024 21:42:24 + Subject: [PATCH 1/3] Refactor option names, and update test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

ilovepi wrote: So, if DFAJumpThreading is ever on by default, then I think its pretty simple to repurpose `-enable-dfa-jump-thread` to enable the behavior in the pass, and we can drop `-enable-dfa-jump-optsize` @aeubanks, does that sound like a better plan?

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/83049 >From fc2e672d474442ef83e90c7a41265d6433651b63 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 26 Feb 2024 21:42:24 + Subject: [PATCH 1/2] Refactor option names, and update test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/83049 >From fc2e672d474442ef83e90c7a41265d6433651b63 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 26 Feb 2024 21:42:24 + Subject: [PATCH 1/2] Refactor option names, and update test Created using spr 1.3.4

[llvm-branch-commits] [llvm] Remove pipeline checks for optsize for DFAJumpThreadingPass (PR #83188)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/83188 The pass itself checks whether to apply the optimization based on the minsize attribute, so there isn't much functional benefit to preventing the pass from being added. Gating the pass gets added to the pass

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/83049 >From fc2e672d474442ef83e90c7a41265d6433651b63 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 26 Feb 2024 21:42:24 + Subject: [PATCH 1/3] Refactor option names, and update test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

ilovepi wrote: > also, we should remove pipeline checks for "optsize" and move those checks > into the passes themselves done in https://github.com/llvm/llvm-project/pull/83188 https://github.com/llvm/llvm-project/pull/83049 ___ llvm-branch-commits

[llvm-branch-commits] [clang][x86] Support -mtls-dialect for x86_64 targets (PR #84086)

https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/84086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang][x86] Support -mtls-dialect for x86_64 targets (PR #84086)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/84086 This patch allows -mtls-dialect= to take `desc`, `trad`, `gnu` and `gnu2` options. `desc` and `gnu2` can be used for TLSDESC code generation, while `trad` and `gnu` maintain the existing TLS behavior.

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH] Update callsite parameter Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH] Update callsite parameter Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH] Update callsite parameter Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

@@ -520,3 +520,8 @@ define i8 @atomic_load_i8_seq_cst(ptr %a) nounwind { ; A6S: .attribute 14, 2 ; A6C: .attribute 14, 1 } + ilovepi wrote: Sorry, I'm a little stuck on how to infer the attribute. This function will get a test once I have that figured out.

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [cmake] Reenable FatLTO for Fuchsia toolchains (PR #85709)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/85709 We can reenable this now that FatLTO won't be enabled for Mac platforms ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [cmake] Reenable FatLTO for Fuchsia toolchains (PR #85709)

ilovepi wrote: Note this is stacked on top of #85708 https://github.com/llvm/llvm-project/pull/85709 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

@@ -1280,7 +1280,6 @@ static unsigned handleTlsRelocation(RelType type, Symbol , if (config->emachine == EM_MIPS) return handleMipsTlsRelocation(type, sym, c, offset, addend, expr); bool isRISCV = config->emachine == EM_RISCV; - ilovepi wrote: will

[llvm-branch-commits] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/85817 When adding fixups for RISCV_TLSDESC_ADD_LO and RISCV_TLSDESC_LOAD_LO, the local label added for RISCV TLSDESC relocations have STT_TLS set, which is incorrect. Instead, these labels should have `STT_NOTYPE`.

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH] Update callsite parameter Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH] Update callsite parameter Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

@@ -1135,11 +1135,34 @@ static void mergeAtomic(DenseMap::iterator it, }; } +static void mergeX3RegUse(DenseMap::iterator it, + const InputSectionBase *oldSection, + const InputSectionBase *newSection, +

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

ilovepi wrote: I've tried to use SubtargetFeatures to model the behavior here, but I don't really love the approach. It feels to me like I've chosen the wrong construct, but I'm not sure what that would be. There are obviously still some changes that would be required in the Clang driver to

[llvm-branch-commits] [cmake] Reenable FatLTO for Fuchsia toolchains (PR #85709)

https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/85709 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

ilovepi wrote: Well, since I'm not going to have time to work on this in the near future, and it will be quite a while before I can roll out an experimental toolchain to partners, I'm going to close this for now. Its easy enough to re-open when we have better feeling for its value, but I do

[llvm-branch-commits] [llvm] [llvm][dfa-jump-threading] Allow DFAJumpThreading with optsize (PR #83049)

https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/83049 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/84598 This patch adds basic support for the Tag_RISCV_x3_reg_usage attribute specified in: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/blob/master/riscv-elf.adoc#tag_riscv_x3_reg_usage-16-uleb128value It adds

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

@@ -24,6 +24,9 @@ .attribute priv_spec_revision, 0 # CHECK: attribute 12, 0 + ilovepi wrote: Thank you. There is a good chance that is the case. https://github.com/llvm/llvm-project/pull/84598 ___

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

@@ -1136,11 +1136,35 @@ static void mergeAtomic(DenseMap , }; } +static void mergeX3RegUse(DenseMap , + const InputSectionBase *oldSection, + const InputSectionBase *newSection, + unsigned int

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

ilovepi wrote: I forgot to mention that I'm still trying to figure out how to add the attribute. I know mechanically how, but AFAIK there isn't a target feature or anything we set when enabling SCS(except for Zcfiscs), so if there is an obvious way, a pointer would be welcome. I think that's

[llvm-branch-commits] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

@@ -47,6 +48,15 @@ enum AtomicABI : unsigned { }; } // namespace RISCVAtomicAbiTag +namespace RISCVX3RegUse { +enum X3RegUsage : unsigned { + UNKNOWN = 0, + GP = 0, ilovepi wrote: ugh, you are correct. I haven't tested this properly yet, since I'm not 100%

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH 1/2] Update callsite parameter Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [RISCV][lld] Set the type of TLSDESC relocation's referenced local symbol to STT_NOTYPE (PR #85817)

https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/85817 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [lld] [RISCV][lld] Set the type of TLSDESC relocation's referenced local symbol to STT_NOTYPE (PR #85817)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/85817 >From 123c0bdd085169ce7d63c96fc3c62cf6c0bc6d45 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 19 Mar 2024 16:50:05 + Subject: [PATCH 1/2] Remove unrelated whitespace change Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH] Update callsite parameter Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH] Update callsite parameter Created using spr 1.3.4 ---

[llvm-branch-commits] [lld] [lld] Fix handling of RISCV TLSDESC relocations (PR #85817)

@@ -30,10 +30,10 @@ # RUN: llvm-objdump --no-show-raw-insn -M no-aliases -h -d a.32.ie | FileCheck %s --check-prefix=IE32 # RUN: llvm-mc -triple=riscv64 -filetype=obj d.s -o d.64.o -# RUN: not ld.lld -shared -soname=d.64.so -o d.64.so d.64.o 2>&1 | FileCheck %s

[llvm-branch-commits] [llvm][NFC] Document cl::opt variable and fix typo (PR #86608)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/86608 None ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm][IR] Extend BranchWeightMetadata to track provenance of weights (PR #86609)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/86609 This patch implements the changes to LLVM IR discussed in https://discourse.llvm.org/t/rfc-update-branch-weights-metadata-to-allow-tracking-branch-weight-origins/75032 In this patch, we add an optional field to

[llvm-branch-commits] [llvm][misexpect] Update MisExpect to use provenance tracking metadata (PR #86610)

https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/86610 With the IR extension added to MD_prof branch weights, we can now easily destinguish between weights added by `llvm.expect*` intrinsics and weights from other sources. This patch re-enables the assert checking

[llvm-branch-commits] [lld] [llvm] [llvm][lld][RISCV] Support x3_reg_usage (PR #84598)

https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/84598 >From 7c9298eea6d8239f9afedc3d6aabb1ec0f71e273 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Mon, 11 Mar 2024 15:35:59 -0700 Subject: [PATCH 1/3] Update callsite parameter Created using spr 1.3.4 ---

  1   2   >