[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
https://github.com/jprotze approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/194046 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/194046 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/194046 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
jtb20 wrote: Test adjustments are handled by a later PR in the stack, https://github.com/llvm/llvm-project/pull/194055. It's maybe not entirely ideal to leave them in flux in the meantime, but it would probably be harmless in practice (apart from auto-tester noise, I suppose). Alternatively the test-removal parts of that PR could be folded into this one, if that'd be better? https://github.com/llvm/llvm-project/pull/194046 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/194046 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/194046 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/194046 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/194046 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff origin/main HEAD --extensions cpp,h --
openmp/runtime/src/kmp.h openmp/runtime/src/kmp_global.cpp
openmp/runtime/src/kmp_settings.cpp openmp/runtime/src/kmp_taskdeps.cpp
openmp/runtime/src/kmp_taskdeps.h openmp/runtime/src/kmp_tasking.cpp
--diff_from_common_commit
``
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
View the diff from clang-format here.
``diff
diff --git a/openmp/runtime/src/kmp_taskdeps.h
b/openmp/runtime/src/kmp_taskdeps.h
index b30565b8c..71e8e69d4 100644
--- a/openmp/runtime/src/kmp_taskdeps.h
+++ b/openmp/runtime/src/kmp_taskdeps.h
@@ -123,8 +123,8 @@ static inline void __kmp_release_deps(kmp_int32 gtid,
kmp_taskdata_t *task) {
gtid, task));
KMP_ACQUIRE_DEPNODE(gtid, node);
-node->dn.task =
-NULL; // mark this task as finished, so no new dependencies are
generated
+ node->dn.task =
+ NULL; // mark this task as finished, so no new dependencies are generated
KMP_RELEASE_DEPNODE(gtid, node);
kmp_depnode_list_t *next;
diff --git a/openmp/runtime/src/kmp_tasking.cpp
b/openmp/runtime/src/kmp_tasking.cpp
index 26a2785c5..7e4668dad 100644
--- a/openmp/runtime/src/kmp_tasking.cpp
+++ b/openmp/runtime/src/kmp_tasking.cpp
@@ -778,7 +778,6 @@ static void __kmp_task_finish(kmp_int32 gtid, kmp_task_t
*task,
KMP_DEBUG_ASSERT(taskdata->td_flags.tasktype == TASK_EXPLICIT);
-
if (UNLIKELY(taskdata->td_flags.tiedness == TASK_UNTIED)) {
// untied task needs to check the counter so that the task structure is not
// freed prematurely
@@ -2263,9 +2262,8 @@ Initialize task reduction for the taskgroup.
Note: this entry supposes the optional compiler-generated initializer routine
has two parameters, pointer to object to be initialized and pointer to omp_orig
*/
-void *__kmpc_taskred_init(int gtid, int num, void *data) {
- }
- return __kmp_task_reduction_init(gtid, num, (kmp_taskred_input_t *)data);
+void *__kmpc_taskred_init(int gtid, int num, void *data) {}
+return __kmp_task_reduction_init(gtid, num, (kmp_taskred_input_t *)data);
}
// Copy task reduction data (except for shared pointers).
``
https://github.com/llvm/llvm-project/pull/194046
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
[llvm-branch-commits] [OpenMP] Mostly remove experimental taskgraph support from runtime (PR #194046)
https://github.com/jtb20 created https://github.com/llvm/llvm-project/pull/194046 Because the changes to runtime support for taskgraph record/replay are quite extensive, they will likely be more comprehensible if the existing parts are removed before the new parts are added. This is the removal part. commit-id:ebbd0706 ___ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
