[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-04-01 Thread Sergio Afonso via llvm-branch-commits 

https://github.com/skatrak approved this pull request.

LGTM, thank you!

https://github.com/llvm/llvm-project/pull/188071
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-25 Thread Tom Eccles via llvm-branch-commits 

https://github.com/tblah updated 
https://github.com/llvm/llvm-project/pull/188071

>From faec719716ef1da5dbd29fb7a295cd4891be8885 Mon Sep 17 00:00:00 2001
From: Tom Eccles 
Date: Mon, 23 Mar 2026 11:10:30 +
Subject: [PATCH 1/4] [mlir][OpenMP] Rename TaskloopOp/omp.taskloop to
 TaskloopWrapperOp/omp.taskloop.wrapper

Rename the loop wrapper operation to better distinguish it from the
context op (omp.taskloop.context), which handles outlining and runtime calls.
The new name makes the role of each operation clearer at a glance.

RFC: 
https://discourse.llvm.org/t/rfc-openmp-alloca-placement-for-openmp-loop-wrappers/89512/7

Patch 3/3

Assisted-by: Copilot, Claude Sonnet 4.6
---
 .../lib/Lower/OpenMP/DataSharingProcessor.cpp |  2 +-
 flang/lib/Lower/OpenMP/OpenMP.cpp |  6 +-
 .../OpenMP/taskloop-alloca-placement.f90  |  2 +-
 flang/test/Lower/OpenMP/if-clause.f90 |  6 +-
 flang/test/Lower/OpenMP/implicit-dsa.f90  | 10 +--
 flang/test/Lower/OpenMP/masked_taskloop.f90   |  2 +-
 .../Lower/OpenMP/parallel-masked-taskloop.f90 |  2 +-
 flang/test/Lower/OpenMP/taskloop-cancel.f90   |  2 +-
 flang/test/Lower/OpenMP/taskloop-collapse.f90 |  2 +-
 .../test/Lower/OpenMP/taskloop-grainsize.f90  |  4 +-
 .../Lower/OpenMP/taskloop-inreduction.f90 |  2 +-
 flang/test/Lower/OpenMP/taskloop-numtasks.f90 |  4 +-
 .../test/Lower/OpenMP/taskloop-reduction.f90  |  2 +-
 flang/test/Lower/OpenMP/taskloop.f90  | 20 ++---
 mlir/docs/Dialects/OpenMPDialect/_index.md|  6 +-
 .../mlir/Dialect/OpenMP/OpenMPDialect.h   |  2 +-
 mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td | 18 ++---
 mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp  | 29 
 .../OpenMP/OpenMPToLLVMIRTranslation.cpp  | 25 ---
 .../OpenMPToLLVM/convert-to-llvmir.mlir   |  4 +-
 mlir/test/Dialect/OpenMP/invalid.mlir | 42 +--
 mlir/test/Dialect/OpenMP/ops.mlir | 74 +--
 .../Target/LLVMIR/openmp-taskloop-cancel.mlir | 18 ++---
 .../openmp-taskloop-cancellation-point.mlir   | 12 +--
 .../LLVMIR/openmp-taskloop-collapse.mlir  | 12 +--
 .../openmp-taskloop-context-alloca.mlir   |  6 +-
 .../Target/LLVMIR/openmp-taskloop-final.mlir  |  2 +-
 .../LLVMIR/openmp-taskloop-grainsize.mlir |  2 +-
 .../Target/LLVMIR/openmp-taskloop-if.mlir |  2 +-
 .../LLVMIR/openmp-taskloop-mergeable.mlir |  2 +-
 .../openmp-taskloop-no-context-struct.mlir|  6 +-
 .../LLVMIR/openmp-taskloop-nogroup.mlir   |  2 +-
 .../LLVMIR/openmp-taskloop-num_tasks.mlir |  2 +-
 .../LLVMIR/openmp-taskloop-priority.mlir  |  2 +-
 .../Target/LLVMIR/openmp-taskloop-untied.mlir |  4 +-
 mlir/test/Target/LLVMIR/openmp-taskloop.mlir  |  6 +-
 mlir/test/Target/LLVMIR/openmp-todo.mlir  |  6 +-
 37 files changed, 176 insertions(+), 174 deletions(-)

diff --git a/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp 
b/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
index 30ac20efa81a8..9dd299d1cdf7e 100644
--- a/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
+++ b/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
@@ -345,7 +345,7 @@ void 
DataSharingProcessor::insertLastPrivateCompare(mlir::Operation *op) {
 return;
 
   if (mlir::isa(op) || mlir::isa(op) ||
-  mlir::isa(op)) {
+  mlir::isa(op)) {
 mlir::omp::LoopRelatedClauseOps result;
 llvm::SmallVector iv;
 collectLoopRelatedInfo(converter, converter.getCurrentLocation(), eval,
diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp 
b/flang/lib/Lower/OpenMP/OpenMP.cpp
index 5f9d00ea3de4c..5708929e12841 100644
--- a/flang/lib/Lower/OpenMP/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP/OpenMP.cpp
@@ -3285,8 +3285,8 @@ static mlir::omp::TaskloopContextOp genStandaloneTaskloop(
 
   mlir::OpBuilder::InsertionGuard guard(firOpBuilder);
   
firOpBuilder.setInsertionPointToStart(&taskLoopContextOp.getRegion().front());
-  mlir::omp::TaskloopOperands wrapperClauseOps;
-  auto taskLoopOp = genWrapperOp(
+  mlir::omp::TaskloopWrapperOperands wrapperClauseOps;
+  auto taskLoopOp = genWrapperOp(
   converter, loc, wrapperClauseOps, taskloopArgs);
 
   genLoopNestOp(converter, symTable, semaCtx, eval, loc, queue, item,
@@ -3587,7 +3587,7 @@ static mlir::omp::WsloopOp genCompositeDoSimd(
   return wsloopOp;
 }
 
-static mlir::omp::TaskloopOp genCompositeTaskloopSimd(
+static mlir::omp::TaskloopWrapperOp genCompositeTaskloopSimd(
 lower::AbstractConverter &converter, lower::SymMap &symTable,
 lower::StatementContext &stmtCtx, semantics::SemanticsContext &semaCtx,
 lower::pft::Evaluation &eval, mlir::Location loc,
diff --git a/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90 
b/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
index f8ccc3f02edf1..b46cbc8a2fa4f 100644
--- a/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
+++ b/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
@@ -20,7 +20,7 @@ subroutine test_taskloop(lb,ub,step,a)
   !$omp taskloop shared(a)
 ! CHECK: o

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-25 Thread Tom Eccles via llvm-branch-commits 

https://github.com/tblah updated 
https://github.com/llvm/llvm-project/pull/188071

>From faec719716ef1da5dbd29fb7a295cd4891be8885 Mon Sep 17 00:00:00 2001
From: Tom Eccles 
Date: Mon, 23 Mar 2026 11:10:30 +
Subject: [PATCH 1/3] [mlir][OpenMP] Rename TaskloopOp/omp.taskloop to
 TaskloopWrapperOp/omp.taskloop.wrapper

Rename the loop wrapper operation to better distinguish it from the
context op (omp.taskloop.context), which handles outlining and runtime calls.
The new name makes the role of each operation clearer at a glance.

RFC: 
https://discourse.llvm.org/t/rfc-openmp-alloca-placement-for-openmp-loop-wrappers/89512/7

Patch 3/3

Assisted-by: Copilot, Claude Sonnet 4.6
---
 .../lib/Lower/OpenMP/DataSharingProcessor.cpp |  2 +-
 flang/lib/Lower/OpenMP/OpenMP.cpp |  6 +-
 .../OpenMP/taskloop-alloca-placement.f90  |  2 +-
 flang/test/Lower/OpenMP/if-clause.f90 |  6 +-
 flang/test/Lower/OpenMP/implicit-dsa.f90  | 10 +--
 flang/test/Lower/OpenMP/masked_taskloop.f90   |  2 +-
 .../Lower/OpenMP/parallel-masked-taskloop.f90 |  2 +-
 flang/test/Lower/OpenMP/taskloop-cancel.f90   |  2 +-
 flang/test/Lower/OpenMP/taskloop-collapse.f90 |  2 +-
 .../test/Lower/OpenMP/taskloop-grainsize.f90  |  4 +-
 .../Lower/OpenMP/taskloop-inreduction.f90 |  2 +-
 flang/test/Lower/OpenMP/taskloop-numtasks.f90 |  4 +-
 .../test/Lower/OpenMP/taskloop-reduction.f90  |  2 +-
 flang/test/Lower/OpenMP/taskloop.f90  | 20 ++---
 mlir/docs/Dialects/OpenMPDialect/_index.md|  6 +-
 .../mlir/Dialect/OpenMP/OpenMPDialect.h   |  2 +-
 mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td | 18 ++---
 mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp  | 29 
 .../OpenMP/OpenMPToLLVMIRTranslation.cpp  | 25 ---
 .../OpenMPToLLVM/convert-to-llvmir.mlir   |  4 +-
 mlir/test/Dialect/OpenMP/invalid.mlir | 42 +--
 mlir/test/Dialect/OpenMP/ops.mlir | 74 +--
 .../Target/LLVMIR/openmp-taskloop-cancel.mlir | 18 ++---
 .../openmp-taskloop-cancellation-point.mlir   | 12 +--
 .../LLVMIR/openmp-taskloop-collapse.mlir  | 12 +--
 .../openmp-taskloop-context-alloca.mlir   |  6 +-
 .../Target/LLVMIR/openmp-taskloop-final.mlir  |  2 +-
 .../LLVMIR/openmp-taskloop-grainsize.mlir |  2 +-
 .../Target/LLVMIR/openmp-taskloop-if.mlir |  2 +-
 .../LLVMIR/openmp-taskloop-mergeable.mlir |  2 +-
 .../openmp-taskloop-no-context-struct.mlir|  6 +-
 .../LLVMIR/openmp-taskloop-nogroup.mlir   |  2 +-
 .../LLVMIR/openmp-taskloop-num_tasks.mlir |  2 +-
 .../LLVMIR/openmp-taskloop-priority.mlir  |  2 +-
 .../Target/LLVMIR/openmp-taskloop-untied.mlir |  4 +-
 mlir/test/Target/LLVMIR/openmp-taskloop.mlir  |  6 +-
 mlir/test/Target/LLVMIR/openmp-todo.mlir  |  6 +-
 37 files changed, 176 insertions(+), 174 deletions(-)

diff --git a/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp 
b/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
index 30ac20efa81a8..9dd299d1cdf7e 100644
--- a/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
+++ b/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
@@ -345,7 +345,7 @@ void 
DataSharingProcessor::insertLastPrivateCompare(mlir::Operation *op) {
 return;
 
   if (mlir::isa(op) || mlir::isa(op) ||
-  mlir::isa(op)) {
+  mlir::isa(op)) {
 mlir::omp::LoopRelatedClauseOps result;
 llvm::SmallVector iv;
 collectLoopRelatedInfo(converter, converter.getCurrentLocation(), eval,
diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp 
b/flang/lib/Lower/OpenMP/OpenMP.cpp
index 5f9d00ea3de4c..5708929e12841 100644
--- a/flang/lib/Lower/OpenMP/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP/OpenMP.cpp
@@ -3285,8 +3285,8 @@ static mlir::omp::TaskloopContextOp genStandaloneTaskloop(
 
   mlir::OpBuilder::InsertionGuard guard(firOpBuilder);
   
firOpBuilder.setInsertionPointToStart(&taskLoopContextOp.getRegion().front());
-  mlir::omp::TaskloopOperands wrapperClauseOps;
-  auto taskLoopOp = genWrapperOp(
+  mlir::omp::TaskloopWrapperOperands wrapperClauseOps;
+  auto taskLoopOp = genWrapperOp(
   converter, loc, wrapperClauseOps, taskloopArgs);
 
   genLoopNestOp(converter, symTable, semaCtx, eval, loc, queue, item,
@@ -3587,7 +3587,7 @@ static mlir::omp::WsloopOp genCompositeDoSimd(
   return wsloopOp;
 }
 
-static mlir::omp::TaskloopOp genCompositeTaskloopSimd(
+static mlir::omp::TaskloopWrapperOp genCompositeTaskloopSimd(
 lower::AbstractConverter &converter, lower::SymMap &symTable,
 lower::StatementContext &stmtCtx, semantics::SemanticsContext &semaCtx,
 lower::pft::Evaluation &eval, mlir::Location loc,
diff --git a/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90 
b/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
index f8ccc3f02edf1..b46cbc8a2fa4f 100644
--- a/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
+++ b/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
@@ -20,7 +20,7 @@ subroutine test_taskloop(lb,ub,step,a)
   !$omp taskloop shared(a)
 ! CHECK: o

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-25 Thread via llvm-branch-commits 

github-actions[bot] wrote:




:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:



You can test this locally with the following command:


``bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- 
flang/lib/Lower/OpenMP/DataSharingProcessor.cpp 
flang/lib/Lower/OpenMP/OpenMP.cpp 
mlir/include/mlir/Dialect/OpenMP/OpenMPDialect.h 
mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp 
mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp 
--diff_from_common_commit
``

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:





View the diff from clang-format here.


``diff
diff --git a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp 
b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
index b576378c2..e8df18231 100644
--- a/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
+++ b/mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
@@ -3298,9 +3298,10 @@ LogicalResult TaskloopContextOp::verifyRegions() {
 return isa(op);
   });
   if (count != 1)
-return emitOpError() << "expected exactly 1 TaskloopWrapperOp directly 
nested in "
-"the region, but "
- << count << " were found";
+return emitOpError()
+   << "expected exactly 1 TaskloopWrapperOp directly nested in "
+  "the region, but "
+   << count << " were found";
 
   return success();
 }

``




https://github.com/llvm/llvm-project/pull/188071
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-25 Thread Tom Eccles via llvm-branch-commits 

https://github.com/tblah updated 
https://github.com/llvm/llvm-project/pull/188071

>From 315afd613c6d89b9e41dce8a8a4f34e7bf768243 Mon Sep 17 00:00:00 2001
From: Tom Eccles 
Date: Mon, 23 Mar 2026 11:10:30 +
Subject: [PATCH 1/2] [mlir][OpenMP] Rename TaskloopOp/omp.taskloop to
 TaskloopWrapperOp/omp.taskloop.wrapper

Rename the loop wrapper operation to better distinguish it from the
context op (omp.taskloop.context), which handles outlining and runtime calls.
The new name makes the role of each operation clearer at a glance.

RFC: 
https://discourse.llvm.org/t/rfc-openmp-alloca-placement-for-openmp-loop-wrappers/89512/7

Patch 3/3

Assisted-by: Copilot, Claude Sonnet 4.6
---
 .../lib/Lower/OpenMP/DataSharingProcessor.cpp |  2 +-
 flang/lib/Lower/OpenMP/OpenMP.cpp |  6 +-
 .../OpenMP/taskloop-alloca-placement.f90  |  2 +-
 flang/test/Lower/OpenMP/if-clause.f90 |  6 +-
 flang/test/Lower/OpenMP/implicit-dsa.f90  | 10 +--
 flang/test/Lower/OpenMP/masked_taskloop.f90   |  2 +-
 .../Lower/OpenMP/parallel-masked-taskloop.f90 |  2 +-
 flang/test/Lower/OpenMP/taskloop-cancel.f90   |  2 +-
 flang/test/Lower/OpenMP/taskloop-collapse.f90 |  2 +-
 .../test/Lower/OpenMP/taskloop-grainsize.f90  |  4 +-
 .../Lower/OpenMP/taskloop-inreduction.f90 |  2 +-
 flang/test/Lower/OpenMP/taskloop-numtasks.f90 |  4 +-
 .../test/Lower/OpenMP/taskloop-reduction.f90  |  2 +-
 flang/test/Lower/OpenMP/taskloop.f90  | 20 ++---
 mlir/docs/Dialects/OpenMPDialect/_index.md|  6 +-
 .../mlir/Dialect/OpenMP/OpenMPDialect.h   |  2 +-
 mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td | 18 ++---
 mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp  | 29 
 .../OpenMP/OpenMPToLLVMIRTranslation.cpp  | 25 ---
 .../OpenMPToLLVM/convert-to-llvmir.mlir   |  4 +-
 mlir/test/Dialect/OpenMP/invalid.mlir | 42 +--
 mlir/test/Dialect/OpenMP/ops.mlir | 74 +--
 .../Target/LLVMIR/openmp-taskloop-cancel.mlir | 18 ++---
 .../openmp-taskloop-cancellation-point.mlir   | 12 +--
 .../LLVMIR/openmp-taskloop-collapse.mlir  | 12 +--
 .../openmp-taskloop-context-alloca.mlir   |  6 +-
 .../Target/LLVMIR/openmp-taskloop-final.mlir  |  2 +-
 .../LLVMIR/openmp-taskloop-grainsize.mlir |  2 +-
 .../Target/LLVMIR/openmp-taskloop-if.mlir |  2 +-
 .../LLVMIR/openmp-taskloop-mergeable.mlir |  2 +-
 .../openmp-taskloop-no-context-struct.mlir|  6 +-
 .../LLVMIR/openmp-taskloop-nogroup.mlir   |  2 +-
 .../LLVMIR/openmp-taskloop-num_tasks.mlir |  2 +-
 .../LLVMIR/openmp-taskloop-priority.mlir  |  2 +-
 .../Target/LLVMIR/openmp-taskloop-untied.mlir |  4 +-
 mlir/test/Target/LLVMIR/openmp-taskloop.mlir  |  6 +-
 mlir/test/Target/LLVMIR/openmp-todo.mlir  |  6 +-
 37 files changed, 176 insertions(+), 174 deletions(-)

diff --git a/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp 
b/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
index fcf2ae9337295..5e75c0efaa2ed 100644
--- a/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
+++ b/flang/lib/Lower/OpenMP/DataSharingProcessor.cpp
@@ -343,7 +343,7 @@ void 
DataSharingProcessor::insertLastPrivateCompare(mlir::Operation *op) {
 return;
 
   if (mlir::isa(op) || mlir::isa(op) ||
-  mlir::isa(op)) {
+  mlir::isa(op)) {
 mlir::omp::LoopRelatedClauseOps result;
 llvm::SmallVector iv;
 collectLoopRelatedInfo(converter, converter.getCurrentLocation(), eval,
diff --git a/flang/lib/Lower/OpenMP/OpenMP.cpp 
b/flang/lib/Lower/OpenMP/OpenMP.cpp
index df66c8833394b..e8cd2640c1412 100644
--- a/flang/lib/Lower/OpenMP/OpenMP.cpp
+++ b/flang/lib/Lower/OpenMP/OpenMP.cpp
@@ -3282,8 +3282,8 @@ static mlir::omp::TaskloopContextOp genStandaloneTaskloop(
 
   mlir::OpBuilder::InsertionGuard guard(firOpBuilder);
   
firOpBuilder.setInsertionPointToStart(&taskLoopContextOp.getRegion().front());
-  mlir::omp::TaskloopOperands wrapperClauseOps;
-  auto taskLoopOp = genWrapperOp(
+  mlir::omp::TaskloopWrapperOperands wrapperClauseOps;
+  auto taskLoopOp = genWrapperOp(
   converter, loc, wrapperClauseOps, taskloopArgs);
 
   genLoopNestOp(converter, symTable, semaCtx, eval, loc, queue, item,
@@ -3584,7 +3584,7 @@ static mlir::omp::WsloopOp genCompositeDoSimd(
   return wsloopOp;
 }
 
-static mlir::omp::TaskloopOp genCompositeTaskloopSimd(
+static mlir::omp::TaskloopWrapperOp genCompositeTaskloopSimd(
 lower::AbstractConverter &converter, lower::SymMap &symTable,
 lower::StatementContext &stmtCtx, semantics::SemanticsContext &semaCtx,
 lower::pft::Evaluation &eval, mlir::Location loc,
diff --git a/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90 
b/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
index f8ccc3f02edf1..b46cbc8a2fa4f 100644
--- a/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
+++ b/flang/test/Integration/OpenMP/taskloop-alloca-placement.f90
@@ -20,7 +20,7 @@ subroutine test_taskloop(lb,ub,step,a)
   !$omp taskloop shared(a)
 ! CHECK: o

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-24 Thread Kaviya Rajendiran via llvm-branch-commits 


@@ -3253,9 +3253,9 @@ void TaskloopContextOp::build(OpBuilder &builder, 
OperationState &state,
   makeArrayAttr(ctx, clauses.reductionSyms), clauses.untied);
 }
 
-TaskloopOp TaskloopContextOp::getLoopOp() {
+TaskloopWrapperOp TaskloopContextOp::getLoopOp() {
   for (mlir::Operation &op : getRegion().front())
-if (auto taskloopOp = dyn_cast(&op))
+if (auto taskloopOp = dyn_cast(&op))

kaviya2510 wrote:

NIT: Above comments apply here as well.
```suggestion
if (auto taskloopWrapperOp = dyn_cast(&op))
```

https://github.com/llvm/llvm-project/pull/188071
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-24 Thread Kaviya Rajendiran via llvm-branch-commits 

https://github.com/kaviya2510 approved this pull request.

Thankyou for the work @tblah. 
LGTM, with minor nits.

https://github.com/llvm/llvm-project/pull/188071
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-24 Thread Kaviya Rajendiran via llvm-branch-commits 


@@ -3283,7 +3283,7 @@ static mlir::omp::TaskloopContextOp genStandaloneTaskloop(
 
   mlir::OpBuilder::InsertionGuard guard(firOpBuilder);
   
firOpBuilder.setInsertionPointToStart(&taskLoopContextOp.getRegion().front());
-  auto taskLoopOp = genWrapperOp(
+  auto taskLoopOp = genWrapperOp(

kaviya2510 wrote:

NIT: Please consider renaming `taskLoopOp` to `taskLoopWrapperOp` for better 
clarity
```suggestion
  auto taskLoopWrapperOp = genWrapperOp(
```

https://github.com/llvm/llvm-project/pull/188071
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-24 Thread Kaviya Rajendiran via llvm-branch-commits 

https://github.com/kaviya2510 edited 
https://github.com/llvm/llvm-project/pull/188071
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-24 Thread Jack Styles via llvm-branch-commits 

https://github.com/Stylie777 approved this pull request.

LGTM

https://github.com/llvm/llvm-project/pull/188071
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [mlir] [mlir][OpenMP] Rename omp.taskloop to omp.taskloop.wrapper (PR #188071)

2026-03-23 Thread Tom Eccles via llvm-branch-commits 

tblah wrote:

Patch series:

https://github.com/llvm/llvm-project/pull/188068
https://github.com/llvm/llvm-project/pull/188070
https://github.com/llvm/llvm-project/pull/188071

https://github.com/llvm/llvm-project/pull/188071
___
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits