[llvm-bugs] [Bug 30806] Wrong code generation at -O2 leading to division by zero
https://bugs.llvm.org/show_bug.cgi?id=30806 Warren Ristow changed: What|Removed |Added Status|REOPENED|RESOLVED Fixed By Commit(s)||r356392 Resolution|--- |FIXED --- Comment #18 from Warren Ristow --- (In reply to Warren Ristow from comment #17) > I'm re-opening, as this patch was reverted at: > https://reviews.llvm.org/rL348426 > > The problem is SEGVs in PHINode simplification in instcombine, as described > in the llvm-commits thread for r347934. An updated patch was proposed at: https://reviews.llvm.org/D57428 and that has landed (and stuck so far) as: https://reviews.llvm.org/rL356392 -- You are receiving this mail because: You are on the CC list for the bug.___ llvm-bugs mailing list llvm-bugs@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
[llvm-bugs] [Bug 30806] Wrong code generation at -O2 leading to division by zero
https://bugs.llvm.org/show_bug.cgi?id=30806 Warren Ristow changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Fixed By Commit(s)|r347934 | --- Comment #17 from Warren Ristow --- (In reply to Warren Ristow from comment #16) > > The patch has landed: > https://reviews.llvm.org/rL347934 I'm re-opening, as this patch was reverted at: https://reviews.llvm.org/rL348426 The problem is SEGVs in PHINode simplification in instcombine, as described in the llvm-commits thread for r347934. - As an aside, as discussed in the review: https://reviews.llvm.org/D55232 (for a related patch, to fix bug 38697), in studying the history of the code in this area, I noticed that a similar fix was made about a year ago at r289412. But that year-old fix was reverted at r289453, with the following note: Reverts r289412. It caused an OOB PHI operand access in instcombine when ASan is enabled. Reduction in progress. It may be that the SEGVs in PHINode simplification that motivated the revert for the new patch are rooted in the same problem that motivated the revert that was done a year ago. -- You are receiving this mail because: You are on the CC list for the bug.___ llvm-bugs mailing list llvm-bugs@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
[llvm-bugs] [Bug 30806] Wrong code generation at -O2 leading to division by zero
https://bugs.llvm.org/show_bug.cgi?id=30806 Warren Ristow changed: What|Removed |Added Fixed By Commit(s)||r347934 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #16 from Warren Ristow --- (In reply to Warren Ristow from comment #13) > Proposed fix posted at: > https://reviews.llvm.org/D54713 The patch has landed: https://reviews.llvm.org/rL347934 -- You are receiving this mail because: You are on the CC list for the bug.___ llvm-bugs mailing list llvm-bugs@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
