[llvm-bugs] [Bug 36280] [SLPVectorizer] 2-way parallel vectorization hurts perf on x86

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=36280

Sanjay Patel  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
 Fixed By Commit(s)|325515  |326133

--- Comment #22 from Sanjay Patel  ---
We can close this bug again because we changed the costs for all recent x86
with:
https://reviews.llvm.org/rL326133

I'm still confused how any of this works as seen in:
https://reviews.llvm.org/D43769

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

[llvm-bugs] [Bug 36280] [SLPVectorizer] 2-way parallel vectorization hurts perf on x86

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=36280

Sanjay Patel  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #11 from Sanjay Patel  ---
Had to revert, so reopening:
https://reviews.llvm.org/rL325658

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

[llvm-bugs] [Bug 36280] [SLPVectorizer] 2-way parallel vectorization hurts perf on x86

[via llvm-bugs]

https://bugs.llvm.org/show_bug.cgi?id=36280

Sanjay Patel  changed:

   What|Removed |Added

 Fixed By Commit(s)||325515
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Sanjay Patel  ---
To summarize some of the discussion in:
https://reviews.llvm.org/D43079
https://reviews.llvm.org/D42981

The SLP vectorizer is not calculating cost by summing uops, so my analysis in
comment 4 is wrong. Why the SLP vectorizer is calculating cost as it does is
another question. 

https://reviews.llvm.org/rL325515

This commit fixes the problem accidentally, but we have a regression test to
verify that the motivating case for this bug does not regress.

...so resolving as fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs