https://bugs.llvm.org/show_bug.cgi?id=41155
Bug ID: 41155
Summary: dsymutil prints needless "Warning: request a
ThreadPool with 1 threads, but LLVM_ENABLE_THREADS has
been turned off" with LLVM_ENABLE_THREADS=OFF
Product: tools
Version: trunk
Hardware: PC
OS: All
Status: NEW
Severity: enhancement
Priority: P
Component: llvm-dsymutil
Assignee: unassignedb...@nondot.org
Reporter: nicolaswe...@gmx.de
CC: apra...@apple.com, fr...@apple.com,
jdevliegh...@apple.com, llvm-bugs@lists.llvm.org
We (mostly accidentally) built dsymutil with LLVM_ENABLE_THREADS=OFF. Since we
don't have any fat binaries, dsymutil defaults to using a thread pool with 1
thread, so there isn't a performance hit from this.
I can see why llvm's thread pool warns if the thread count is > 0 not > 1 (what
if the thread owning the pool does any work other than .Wait() – this might
even be a deadlock), but maybe it should have a setting that tells it to only
warn on > 1 threads, or dsymutil could check for LLVM_ENABLE_THREADS=OFF
directly.
(Also, dsymutil currently calls llvm::thread::hardware_concurrency() when it
should call llvm::hardware_concurrency() -- I think the former form calls the
stdlib method instead of the wrapper in llvm that handles
LLVM_ENABLE_THREADS=OFF.)
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
