[llvm-commits] [llvm] r46500 - /llvm/trunk/docs/LangRef.html

2008-01-28 Thread Chris Lattner
Author: lattner Date: Tue Jan 29 01:00:44 2008 New Revision: 46500 URL: http://llvm.org/viewvc/llvm-project?rev=46500&view=rev Log: llvm.sqrt(-0.0) is defined. Modified: llvm/trunk/docs/LangRef.html Modified: llvm/trunk/docs/LangRef.html URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/d

Re: [llvm-commits] [llvm] r46499 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/zero-point-zero-add.ll

2008-01-28 Thread Chris Lattner
On Jan 28, 2008, at 10:56 PM, Nick Lewycky wrote: > Chris Lattner wrote: >> +if (const IntrinsicInst *II = dyn_cast(I)) >> + if (II->getIntrinsicID() == Intrinsic::sqrt) >> +return CannotBeNegativeZero(II->getOperand(1)); > > "Unlike sqrt in libm, however, llvm.sqrt has undefined

Re: [llvm-commits] [llvm] r46497 - /llvm/trunk/test/Transforms/DeadStoreElimination/memcpy.ll

2008-01-28 Thread Chris Lattner
On Jan 28, 2008, at 10:40 PM, Owen Anderson wrote: > Author: resistor > Date: Tue Jan 29 00:40:32 2008 > New Revision: 46497 > > URL: http://llvm.org/viewvc/llvm-project?rev=46497&view=rev > Log: > Add a testcase for eliminating memcpy's at the end of functions. > Forgot to commit this with my

Re: [llvm-commits] [llvm] r46499 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/zero-point-zero-add.ll

2008-01-28 Thread Nick Lewycky
Chris Lattner wrote: > +if (const IntrinsicInst *II = dyn_cast(I)) > + if (II->getIntrinsicID() == Intrinsic::sqrt) > +return CannotBeNegativeZero(II->getOperand(1)); "Unlike sqrt in libm, however, llvm.sqrt has undefined behavior for negative numbers (which allows for better opt

[llvm-commits] [llvm] r46499 - in /llvm/trunk: lib/Transforms/Scalar/InstructionCombining.cpp test/Transforms/InstCombine/zero-point-zero-add.ll

2008-01-28 Thread Chris Lattner
Author: lattner Date: Tue Jan 29 00:52:45 2008 New Revision: 46499 URL: http://llvm.org/viewvc/llvm-project?rev=46499&view=rev Log: eliminate additions of 0.0 when they are obviously dead. This has to be careful to avoid turning -0.0 + 0.0 -> -0.0 which is incorrect. Added: llvm/trunk/test/

[llvm-commits] [test-suite] r46498 - /test-suite/trunk/SingleSource/Regression/C++/2008-01-29-ParamAliasesReturn.cpp

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Tue Jan 29 00:46:44 2008 New Revision: 46498 URL: http://llvm.org/viewvc/llvm-project?rev=46498&view=rev Log: Test for PR1942. Added: test-suite/trunk/SingleSource/Regression/C++/2008-01-29-ParamAliasesReturn.cpp Added: test-suite/trunk/SingleSource/Regression/C++/20

[llvm-commits] [llvm] r46497 - /llvm/trunk/test/Transforms/DeadStoreElimination/memcpy.ll

2008-01-28 Thread Owen Anderson
Author: resistor Date: Tue Jan 29 00:40:32 2008 New Revision: 46497 URL: http://llvm.org/viewvc/llvm-project?rev=46497&view=rev Log: Add a testcase for eliminating memcpy's at the end of functions. Forgot to commit this with my last commit. Added: llvm/trunk/test/Transforms/DeadStoreElimina

Re: [llvm-commits] [llvm] r46494 - /llvm/trunk/lib/Transforms/Scalar/DeadStoreElimination.cpp

2008-01-28 Thread Chris Lattner
On Jan 28, 2008, at 10:18 PM, Owen Anderson wrote: > Author: resistor > Date: Tue Jan 29 00:18:36 2008 > New Revision: 46494 > URL: http://llvm.org/viewvc/llvm-project?rev=46494&view=rev > Log: > Add support for eliminating memcpy's at the end of functions. Also > fix some errors I noticed in >

[llvm-commits] [llvm] r46496 - in /llvm/trunk/test/CodeGen: PowerPC/2008-01-25-EmptyFunction.ll X86/2008-01-25-EmptyFunction.ll

2008-01-28 Thread Chris Lattner
Author: lattner Date: Tue Jan 29 00:26:07 2008 New Revision: 46496 URL: http://llvm.org/viewvc/llvm-project?rev=46496&view=rev Log: Add target triples to these so they don't fail on linux. Modified: llvm/trunk/test/CodeGen/PowerPC/2008-01-25-EmptyFunction.ll llvm/trunk/test/CodeGen/X86/20

[llvm-commits] [llvm] r46495 - in /llvm/trunk: include/llvm/Target/TargetData.h lib/CodeGen/ELFWriter.cpp lib/CodeGen/MachOWriter.cpp lib/ExecutionEngine/JIT/JIT.cpp lib/Target/IA64/IA64AsmPrinter.cpp

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Tue Jan 29 00:23:44 2008 New Revision: 46495 URL: http://llvm.org/viewvc/llvm-project?rev=46495&view=rev Log: Use getPreferredAlignmentLog or getPreferredAlignment to get the alignment of global variables, rather than using hand-made versions. Modified: llvm/trunk/inclu

[llvm-commits] [llvm] r46494 - /llvm/trunk/lib/Transforms/Scalar/DeadStoreElimination.cpp

2008-01-28 Thread Owen Anderson
Author: resistor Date: Tue Jan 29 00:18:36 2008 New Revision: 46494 URL: http://llvm.org/viewvc/llvm-project?rev=46494&view=rev Log: Add support for eliminating memcpy's at the end of functions. Also fix some errors I noticed in the handling of eliminating stores to byval arguments. Modified:

[llvm-commits] [llvm] r46493 - /llvm/trunk/test/C++Frontend/2008-01-25-ResultIsParam.cpp

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Tue Jan 29 00:04:54 2008 New Revision: 46493 URL: http://llvm.org/viewvc/llvm-project?rev=46493&view=rev Log: This would be better done as an executable test. Removed: llvm/trunk/test/C++Frontend/2008-01-25-ResultIsParam.cpp Removed: llvm/trunk/test/C++Frontend/2008-01

Re: [llvm-commits] [llvm] r46451 - /llvm/trunk/test/CFrontend/2008-01-26-ReadOnlyByVal.c

2008-01-28 Thread Duncan Sands
> This fails with 4.0 on darwin x86. I've removed it. With recent changes needed for byval correctness, it became too hard for the optimizers. I've added it to PR452 instead. Ciao, Duncan. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://

[llvm-commits] [llvm] r46492 - /llvm/trunk/test/CFrontend/2008-01-26-ReadOnlyByVal.c

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Mon Jan 28 23:57:23 2008 New Revision: 46492 URL: http://llvm.org/viewvc/llvm-project?rev=46492&view=rev Log: After recent changes we fail to optimize this test sufficiently to have it pass. I'm removing it from the testsuite and adding it to PR452 instead. Removed: ll

Re: [llvm-commits] [llvm] r46485 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/CodeGen/AsmPrinter.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/CodeGen/SelectionDAG/TargetLowering

2008-01-28 Thread Chris Lattner
On Jan 28, 2008, at 9:24 PM, Dale Johannesen wrote: >> Can this be done in llvm-gcc? It seems better to only expose >> 'simplified' constraints to the llvm code generator. This means the >> target hooks would become wonderful macros in i386.h for example, but >> that seems tolerable. > > Sure, b

Re: [llvm-commits] [llvm] r46485 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/CodeGen/AsmPrinter.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/CodeGen/SelectionDAG/TargetLowering

2008-01-28 Thread Dale Johannesen
On Jan 28, 2008, at 8:29 PM, Chris Lattner wrote: > > On Jan 28, 2008, at 6:21 PM, Dale Johannesen wrote: > >> Author: johannes >> Date: Mon Jan 28 20:21:21 2008 >> New Revision: 46485 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=46485&view=rev >> Log: >> Handle 'X' constraint in asm's bett

Re: [llvm-commits] [llvm] r46483 - in /llvm/trunk: lib/Target/CellSPU/ test/CodeGen/CellSPU/

2008-01-28 Thread Chris Lattner
On Jan 28, 2008, at 6:31 PM, Owen Anderson wrote: > I'm getting a build failure after this commit: > > llvm[3]: Compiling SPUISelDAGToDAG.cpp for Release build > SPUGenDAGISel.inc: In member function ‘llvm::SDNode* > SPUDAGToDAGISel::Emit_5(const llvm::SDOperand&, unsigned int, > unsigned int,

Re: [llvm-commits] [llvm] r46485 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/CodeGen/AsmPrinter.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/CodeGen/SelectionDAG/TargetLowering

2008-01-28 Thread Chris Lattner
On Jan 28, 2008, at 6:21 PM, Dale Johannesen wrote: > Author: johannes > Date: Mon Jan 28 20:21:21 2008 > New Revision: 46485 > > URL: http://llvm.org/viewvc/llvm-project?rev=46485&view=rev > Log: > Handle 'X' constraint in asm's better. Hey Dale, Can this be done in llvm-gcc? It seems better

[llvm-commits] [llvm] r46488 - /llvm/trunk/lib/CodeGen/RegAllocBigBlock.cpp

2008-01-28 Thread Owen Anderson
Author: resistor Date: Mon Jan 28 20:32:13 2008 New Revision: 46488 URL: http://llvm.org/viewvc/llvm-project?rev=46488&view=rev Log: RegAllocBigBlock doesn't need LiveVariables either. Modified: llvm/trunk/lib/CodeGen/RegAllocBigBlock.cpp Modified: llvm/trunk/lib/CodeGen/RegAllocBigBlock.cpp

[llvm-commits] [llvm] r46487 - /llvm/trunk/utils/TableGen/DAGISelEmitter.cpp

2008-01-28 Thread Scott Michel
Author: pingbak Date: Mon Jan 28 20:29:31 2008 New Revision: 46487 URL: http://llvm.org/viewvc/llvm-project?rev=46487&view=rev Log: Fix to bug 1951: tblgen gratuitously renames variables when no temporary was generated. This feature would only show up in fairly complex patterns, such as this one i

[llvm-commits] [llvm] r46486 - /llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

2008-01-28 Thread Nate Begeman
Author: sampo Date: Mon Jan 28 20:24:00 2008 New Revision: 46486 URL: http://llvm.org/viewvc/llvm-project?rev=46486&view=rev Log: Properly expand extract-element for non-power-of-2 codegen Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp Modified: llvm/trunk/lib/CodeGen/Selectio

[llvm-commits] [llvm] r46485 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/CodeGen/AsmPrinter.cpp lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp lib/CodeGen/SelectionDAG/TargetLowering.cpp

2008-01-28 Thread Dale Johannesen
Author: johannes Date: Mon Jan 28 20:21:21 2008 New Revision: 46485 URL: http://llvm.org/viewvc/llvm-project?rev=46485&view=rev Log: Handle 'X' constraint in asm's better. Modified: llvm/trunk/include/llvm/Target/TargetLowering.h llvm/trunk/lib/CodeGen/AsmPrinter.cpp llvm/trunk/lib/C

[llvm-commits] [llvm] r46484 - in /llvm/trunk: lib/Transforms/Scalar/LoopIndexSplit.cpp test/Transforms/LoopIndexSplit/2008-01-28-IndDecrement.ll

2008-01-28 Thread Devang Patel
Author: dpatel Date: Mon Jan 28 20:20:41 2008 New Revision: 46484 URL: http://llvm.org/viewvc/llvm-project?rev=46484&view=rev Log: Filter loops that subtract induction variables. These loops are not yet handled. Fix PR 1912. Added: llvm/trunk/test/Transforms/LoopIndexSplit/2008-01-28-IndDecr

[llvm-commits] [llvm] r46479 - /llvm/trunk/test/CFrontend/2008-01-28-UnionSize.c

2008-01-28 Thread Devang Patel
Author: dpatel Date: Mon Jan 28 19:10:04 2008 New Revision: 46479 URL: http://llvm.org/viewvc/llvm-project?rev=46479&view=rev Log: New test. Added: llvm/trunk/test/CFrontend/2008-01-28-UnionSize.c Added: llvm/trunk/test/CFrontend/2008-01-28-UnionSize.c URL: http://llvm.org/viewvc/llvm-proje

[llvm-commits] [llvm-gcc-4.2] r46478 - /llvm-gcc-4.2/trunk/gcc/llvm-types.cpp

2008-01-28 Thread Devang Patel
Author: dpatel Date: Mon Jan 28 19:09:18 2008 New Revision: 46478 URL: http://llvm.org/viewvc/llvm-project?rev=46478&view=rev Log: Fix PR1861 While selecting union size, select larger field size irrespective of whether field is packed or not. Modified: llvm-gcc-4.2/trunk/gcc/llvm-types.cpp

[llvm-commits] [llvm] r46476 - /llvm/trunk/test/CFrontend/2008-01-28-PragmaMark.c

2008-01-28 Thread Bill Wendling
Author: void Date: Mon Jan 28 18:41:29 2008 New Revision: 46476 URL: http://llvm.org/viewvc/llvm-project?rev=46476&view=rev Log: Add test to make sure that #pragma mark/error doesn't error if there are unbalanced quotes. Added: llvm/trunk/test/CFrontend/2008-01-28-PragmaMark.c Added: llvm/tr

[llvm-commits] [llvm-gcc-4.2] r46474 - /llvm-gcc-4.2/tags/Apple/llvmgcc42-2013/

2008-01-28 Thread Bill Wendling
Author: void Date: Mon Jan 28 18:18:49 2008 New Revision: 46474 URL: http://llvm.org/viewvc/llvm-project?rev=46474&view=rev Log: Creating llvmgcc42-2013 branch Added: llvm-gcc-4.2/tags/Apple/llvmgcc42-2013/ - copied from r46473, llvm-gcc-4.2/trunk/ _

[llvm-commits] [llvm] r46473 - /llvm/tags/Apple/llvmCore-2013/

2008-01-28 Thread Bill Wendling
Author: void Date: Mon Jan 28 18:18:43 2008 New Revision: 46473 URL: http://llvm.org/viewvc/llvm-project?rev=46473&view=rev Log: Creating llvmCore-2013 branch Added: llvm/tags/Apple/llvmCore-2013/ - copied from r46472, llvm/trunk/ ___ llvm-co

Re: [llvm-commits] [llvm] r46382 - /llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c

2008-01-28 Thread Tanya Lattner
On Jan 28, 2008, at 11:35 AM, Chris Lattner wrote: > On Jan 28, 2008, at 11:15 AM, Tanya Lattner wrote: >> This test is failing for me. llvm-gcc-4.0 on x86/darwin8. >> >> ../../src/gcc/llvm-types.cpp:1426: failed assertion `0 && "Could not >> find field!"' > > How long should we continue to suppo

[llvm-commits] [llvm-gcc-4.2] r46469 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

2008-01-28 Thread Evan Cheng
Author: evancheng Date: Mon Jan 28 16:28:50 2008 New Revision: 46469 URL: http://llvm.org/viewvc/llvm-project?rev=46469&view=rev Log: Debug info for byval parameter. First attempt, unclear if it is right. But at least it tells gdb there is a parameter. Modified: llvm-gcc-4.2/trunk/gcc/llvm-c

[llvm-commits] [llvm] r46465 - /llvm/trunk/include/llvm/ADT/FoldingSet.h

2008-01-28 Thread Ted Kremenek
Author: kremenek Date: Mon Jan 28 16:05:23 2008 New Revision: 46465 URL: http://llvm.org/viewvc/llvm-project?rev=46465&view=rev Log: Added destructor for template class FoldingSetNodeWrapper. Added getValue() to FoldingSetNodeWrapper. Modified: llvm/trunk/include/llvm/ADT/FoldingSet.h Modifi

[llvm-commits] [llvm-gcc-4.2] r46463 - in /llvm-gcc-4.2/trunk: gcc/config/darwin.h libcpp/directives.c libcpp/internal.h libcpp/lex.c

2008-01-28 Thread Bill Wendling
Author: void Date: Mon Jan 28 15:47:12 2008 New Revision: 46463 URL: http://llvm.org/viewvc/llvm-project?rev=46463&view=rev Log: This program: $ cat testcase.c #pragma mark Mike's world #ifdef DO_ERROR #error Mike's world #endif int i; Gives us these warnings: pragma-2.c:1:18: warning: missing

Re: [llvm-commits] [llvm] r46382 - /llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c

2008-01-28 Thread Duncan Sands
> How long should we continue to support 4.0? I thought 2.2 was the > last release for it? Does 4.0 do anything better than 4.2? I'm all for dropping it like a hot potato if not. Ciao, Duncan. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu

[llvm-commits] [llvm] r46461 - /llvm/tags/Apple/llvmCore-2012/Makefile.rules

2008-01-28 Thread Devang Patel
Author: dpatel Date: Mon Jan 28 15:01:04 2008 New Revision: 46461 URL: http://llvm.org/viewvc/llvm-project?rev=46461&view=rev Log: Fix build failure. Backport patch from trunk. Modified: llvm/tags/Apple/llvmCore-2012/Makefile.rules Modified: llvm/tags/Apple/llvmCore-2012/Makefile.rules URL:

[llvm-commits] [llvm-gcc-4.2] r46460 - in /llvm-gcc-4.2/trunk/gcc: llvm-convert.cpp llvm-internal.h

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Mon Jan 28 14:57:24 2008 New Revision: 46460 URL: http://llvm.org/viewvc/llvm-project?rev=46460&view=rev Log: Fix PR1942 differently, by having the caller take care of making a copy of the aggregate return value rather than the callee (the previous fix). This is better adap

[llvm-commits] [llvm-gcc-4.2] r46459 - /llvm-gcc-4.2/trunk/gcc/llvm-abi.h

2008-01-28 Thread Evan Cheng
Author: evancheng Date: Mon Jan 28 14:55:32 2008 New Revision: 46459 URL: http://llvm.org/viewvc/llvm-project?rev=46459&view=rev Log: QUAL_UNION_TYPE is just like UNION_TYPE. Modified: llvm-gcc-4.2/trunk/gcc/llvm-abi.h Modified: llvm-gcc-4.2/trunk/gcc/llvm-abi.h URL: http://llvm.org/viewvc/

[llvm-commits] [llvm] r46458 - /llvm/trunk/lib/Support/FileUtilities.cpp

2008-01-28 Thread Lauro Ramos Venancio
Author: laurov Date: Mon Jan 28 14:02:51 2008 New Revision: 46458 URL: http://llvm.org/viewvc/llvm-project?rev=46458&view=rev Log: Simplify the code and fix a typo. Modified: llvm/trunk/lib/Support/FileUtilities.cpp Modified: llvm/trunk/lib/Support/FileUtilities.cpp URL: http://llvm.org/vi

Re: [llvm-commits] [llvm-gcc-4.2] r46450 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal.h llvm-types.cpp

2008-01-28 Thread Duncan Sands
Hi Evan, > > You should let QUAL_UNION through here as well. And what about size- > > zero > > arrays? Or for that matter, zero size anything? > > What exactly is QUAL_UNION? I am pretty sure other cases (especially > zero sized arrays) are handled differently. QUAL_UNION is a union with an

Re: [llvm-commits] [llvm] r46372 - /llvm/trunk/test/CFrontend/2008-01-25-ByValReadNone.c

2008-01-28 Thread Duncan Sands
Hi Tanya, > This test is failing for me. llvm-gcc-4.0, x86 darwin8. it should be better now. It needed tweaking for a policy change on byval+const/pure. Also, a patch had not been backported from 4.2 to 4.0. Ciao, Duncan. ___ llvm-commits mailing li

[llvm-commits] [llvm-gcc-4.0] r46457 - /llvm-gcc-4.0/trunk/gcc/llvm-types.cpp

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Mon Jan 28 13:57:01 2008 New Revision: 46457 URL: http://llvm.org/viewvc/llvm-project?rev=46457&view=rev Log: Backport the patch turning off readnone/readonly when there is a byval parameter from 4.2. Modified: llvm-gcc-4.0/trunk/gcc/llvm-types.cpp Modified: llvm-gcc-4

Re: [llvm-commits] [llvm-gcc-4.2] r46450 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal.h llvm-types.cpp

2008-01-28 Thread Duncan Sands
Hi Evan, > > This is probably safe (not completely clear), but why do you need to > > do it at all? > > Because they are skipped earlier when we did the type translation. I see - this was orthogonal to the rest of your patch. I have a different fix for this issue which I like better, but that

Re: [llvm-commits] [llvm] r46382 - /llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c

2008-01-28 Thread Evan Cheng
I'll merge in all the ABI related changes from 4.2. Evan On Jan 28, 2008, at 11:15 AM, Tanya Lattner wrote: > This test is failing for me. llvm-gcc-4.0 on x86/darwin8. > > ../../src/gcc/llvm-types.cpp:1426: failed assertion `0 && "Could not > find field!"' > > -Tanya > > On Jan 25, 2008, at 4:35

Re: [llvm-commits] [llvm] r46455 - /llvm/trunk/lib/Support/FileUtilities.cpp

2008-01-28 Thread Chris Lattner
On Jan 28, 2008, at 10:56 AM, Evan Cheng wrote: >> URL: http://llvm.org/viewvc/llvm-project?rev=46455&view=rev >> Log: >> Fix fpcmp infinite loop when comparing "29-266" with "29-268". >> +static bool isExpoentChar(char C) { Also, typo: Expoent -> Exponent. Thanks Lauro, -Chris

Re: [llvm-commits] [llvm] r46382 - /llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c

2008-01-28 Thread Chris Lattner
On Jan 28, 2008, at 11:15 AM, Tanya Lattner wrote: > This test is failing for me. llvm-gcc-4.0 on x86/darwin8. > > ../../src/gcc/llvm-types.cpp:1426: failed assertion `0 && "Could not > find field!"' How long should we continue to support 4.0? I thought 2.2 was the last release for it? -Chris

[llvm-commits] [llvm] r46456 - /llvm/trunk/test/CFrontend/2008-01-25-ByValReadNone.c

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Mon Jan 28 13:25:47 2008 New Revision: 46456 URL: http://llvm.org/viewvc/llvm-project?rev=46456&view=rev Log: Pure/const functions with ByVal parameters cannot be marked readonly either. Modified: llvm/trunk/test/CFrontend/2008-01-25-ByValReadNone.c Modified: llvm/trun

Re: [llvm-commits] [llvm-gcc-4.2] r46450 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal. h llvm-types.cpp

2008-01-28 Thread Duncan Sands
Hi Devang, > >> +// Skip 'int:0', which just affects layout. > >> +unsigned FieldSizeInBits = > >> TREE_INT_CST_LOW(DECL_SIZE(Field)); > >> +if (FieldSizeInBits == 0) > >> + continue; > > > > This is probably safe (not completely clear), but why do you need to

Re: [llvm-commits] [llvm] r46382 - /llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c

2008-01-28 Thread Tanya Lattner
This test is failing for me. llvm-gcc-4.0 on x86/darwin8. ../../src/gcc/llvm-types.cpp:1426: failed assertion `0 && "Could not find field!"' -Tanya On Jan 25, 2008, at 4:35 PM, Evan Cheng wrote: > Author: evancheng > Date: Fri Jan 25 18:35:43 2008 > New Revision: 46382 > > URL: http://llvm.or

Re: [llvm-commits] [llvm] r46372 - /llvm/trunk/test/CFrontend/2008-01-25-ByValReadNone.c

2008-01-28 Thread Tanya Lattner
This test is failing for me. llvm-gcc-4.0, x86 darwin8. -Tanya On Jan 25, 2008, at 2:36 PM, Chris Lattner wrote: > Author: lattner > Date: Fri Jan 25 16:36:24 2008 > New Revision: 46372 > > URL: http://llvm.org/viewvc/llvm-project?rev=46372&view=rev > Log: > add a testcase for a bug Duncan point

Re: [llvm-commits] [llvm] r46451 - /llvm/trunk/test/CFrontend/2008-01-26-ReadOnlyByVal.c

2008-01-28 Thread Tanya Lattner
This fails with 4.0 on darwin x86. -Tanya On Jan 28, 2008, at 2:35 AM, Duncan Sands wrote: > Author: baldrick > Date: Mon Jan 28 04:35:11 2008 > New Revision: 46451 > > URL: http://llvm.org/viewvc/llvm-project?rev=46451&view=rev > Log: > Make this more likely to be passed byval. > > Modified: >

Re: [llvm-commits] [llvm-gcc-4.2] r46450 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal.h llvm-types.cpp

2008-01-28 Thread Evan Cheng
On Jan 28, 2008, at 2:14 AM, Duncan Sands wrote: > Hi Evan, thanks for doing this. > >> +static bool isZeroSizedStructOrUnion(tree type) { >> + if (TREE_CODE(type) != RECORD_TYPE && TREE_CODE(type) != >> UNION_TYPE) > > You should let QUAL_UNION through here as well. And what about size- > z

Re: [llvm-commits] [llvm] r46419 - /llvm/trunk/include/llvm/CodeGen/BreakCriticalMachineEdge.h

2008-01-28 Thread Evan Cheng
On Jan 27, 2008, at 11:51 AM, Owen Anderson wrote: > Author: resistor > Date: Sun Jan 27 13:51:03 2008 > New Revision: 46419 > > URL: http://llvm.org/viewvc/llvm-project?rev=46419&view=rev > Log: > Fixes for BreakCriticalMachineCodeEdge by Fernando. > > Modified: >llvm/trunk/include/llvm/Code

Re: [llvm-commits] [llvm] r46455 - /llvm/trunk/lib/Support/FileUtilities.cpp

2008-01-28 Thread Evan Cheng
On Jan 28, 2008, at 10:23 AM, Lauro Ramos Venancio wrote: > Author: laurov > Date: Mon Jan 28 12:23:23 2008 > New Revision: 46455 > > URL: http://llvm.org/viewvc/llvm-project?rev=46455&view=rev > Log: > Fix fpcmp infinite loop when comparing "29-266" with "29-268". > > > Modified: >llvm/trunk

[llvm-commits] [llvm] r46455 - /llvm/trunk/lib/Support/FileUtilities.cpp

2008-01-28 Thread Lauro Ramos Venancio
Author: laurov Date: Mon Jan 28 12:23:23 2008 New Revision: 46455 URL: http://llvm.org/viewvc/llvm-project?rev=46455&view=rev Log: Fix fpcmp infinite loop when comparing "29-266" with "29-268". Modified: llvm/trunk/lib/Support/FileUtilities.cpp Modified: llvm/trunk/lib/Support/FileUtilities

Re: [llvm-commits] [llvm] r46432 - /llvm/trunk/Makefile.rules

2008-01-28 Thread Duncan Sands
> > This breaks the build when the objects directory is different to the > > source directory. > > I'm very sorry about this. The attached patch will fix it. Indeed it does, so I've applied it. Thanks for the quick fix! Best wishes, Duncan. ___ llvm

[llvm-commits] [llvm] r46454 - /llvm/trunk/test/Transforms/InstCombine/2007-01-13-ExtCompareMiscompile.ll

2008-01-28 Thread Chris Lattner
Author: lattner Date: Mon Jan 28 11:38:46 2008 New Revision: 46454 URL: http://llvm.org/viewvc/llvm-project?rev=46454&view=rev Log: this test is now compiled into the right thing. Modified: llvm/trunk/test/Transforms/InstCombine/2007-01-13-ExtCompareMiscompile.ll Modified: llvm/trunk/test/T

[llvm-commits] [llvm] r46453 - /llvm/trunk/Makefile.rules

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Mon Jan 28 11:38:30 2008 New Revision: 46453 URL: http://llvm.org/viewvc/llvm-project?rev=46453&view=rev Log: Unbreak builds with differing object and source directories. Patch by Sam Bishop. Modified: llvm/trunk/Makefile.rules Modified: llvm/trunk/Makefile.rules URL:

Re: [llvm-commits] [llvm-gcc-4.2] r46450 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal.h llvm-types.cpp

2008-01-28 Thread Devang Patel
Hi Duncan, On Jan 28, 2008, at 2:14 AM, Duncan Sands wrote: +// Skip 'int:0', which just affects layout. +unsigned FieldSizeInBits = TREE_INT_CST_LOW(DECL_SIZE(Field)); +if (FieldSizeInBits == 0) + continue; This is probably safe (not completely clear), but

[llvm-commits] [llvm] r46452 - /llvm/tags/Apple/llvmCore-2012/

2008-01-28 Thread Devang Patel
Author: dpatel Date: Mon Jan 28 10:59:48 2008 New Revision: 46452 URL: http://llvm.org/viewvc/llvm-project?rev=46452&view=rev Log: Tag llvmCore-2012 Added: llvm/tags/Apple/llvmCore-2012/ - copied from r46439, llvm/trunk/ ___ llvm-commits mail

Re: [llvm-commits] [llvm] r46432 - /llvm/trunk/Makefile.rules

2008-01-28 Thread Sam Bishop
Hi, Duncan. On Mon, January 28, 2008 6:48 am, Duncan Sands wrote: > This breaks the build when the objects directory is different to the > source directory. I'm very sorry about this. The attached patch will fix it. Thanks, Sam Bishop Makefile.rules.patch Description: Binary data _

Re: [llvm-commits] [llvm] r46432 - /llvm/trunk/Makefile.rules

2008-01-28 Thread Duncan Sands
> Author: lattner > Date: Sun Jan 27 22:18:41 2008 > New Revision: 46432 > > URL: http://llvm.org/viewvc/llvm-project?rev=46432&view=rev > Log: > reduce duplicate -I flags passed to the compiler, cleaning up the VERBOSE > output. Patch contributed by Sam Bishop! This breaks the build when the obj

[llvm-commits] [llvm] r46451 - /llvm/trunk/test/CFrontend/2008-01-26-ReadOnlyByVal.c

2008-01-28 Thread Duncan Sands
Author: baldrick Date: Mon Jan 28 04:35:11 2008 New Revision: 46451 URL: http://llvm.org/viewvc/llvm-project?rev=46451&view=rev Log: Make this more likely to be passed byval. Modified: llvm/trunk/test/CFrontend/2008-01-26-ReadOnlyByVal.c Modified: llvm/trunk/test/CFrontend/2008-01-26-ReadOnl

Re: [llvm-commits] [llvm-gcc-4.2] r46450 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal.h llvm-types.cpp

2008-01-28 Thread Duncan Sands
Hi Evan, thanks for doing this. > +static bool isZeroSizedStructOrUnion(tree type) { > + if (TREE_CODE(type) != RECORD_TYPE && TREE_CODE(type) != UNION_TYPE) You should let QUAL_UNION through here as well. And what about size-zero arrays? Or for that matter, zero size anything? > +//

Re: [llvm-commits] [llvm-gcc-4.2] r46381 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal.h llvm-types.cpp

2008-01-28 Thread Evan Cheng
Hopefully this patch fixed it: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080128/057665.html Please verify. Thanks. Evan On Jan 28, 2008, at 1:02 AM, Duncan Sands wrote: > Hi Evan, > >> I did check in two test cases in a subsequent commit. Those used to >&

[llvm-commits] [llvm-gcc-4.2] r46450 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal.h llvm-types.cpp

2008-01-28 Thread Evan Cheng
Author: evancheng Date: Mon Jan 28 03:49:51 2008 New Revision: 46450 URL: http://llvm.org/viewvc/llvm-project?rev=46450&view=rev Log: 1. Only skip over zero sized bit fields which just affects layout, not all zero-sized aggregates. 2. Do not pass zero sized struct and union parameters. Modified:

[llvm-commits] [llvm] r46449 - /llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp

2008-01-28 Thread Bill Wendling
Author: void Date: Mon Jan 28 03:15:03 2008 New Revision: 46449 URL: http://llvm.org/viewvc/llvm-project?rev=46449&view=rev Log: If the function has no machine instructions, then emit a "nop" so that the function label isn't associated with something it shouldn't be. Modified: llvm/trunk/lib/

Re: [llvm-commits] [llvm-gcc-4.2] r46381 - in /llvm-gcc-4.2/trunk/gcc: llvm-abi.h llvm-internal.h llvm-types.cpp

2008-01-28 Thread Duncan Sands
Hi Evan, > I did check in two test cases in a subsequent commit. Those used to > choke llvm-gcc. I'll look at this today. It's obvious not all zero > sized aggregates are not created equal. I guess you mean this: http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080121/057572.html