Re: [llvm-commits] [PATCH] partial codgen support for ByVal arguments

2007-08-10 Thread Rafael Espindola
I think this patch is looking very good. As it can only affect things marked 'byval', please feel free to commit what you have. done. As a next step, it would be good to implement passing of a struct into a call by-val. I Agree :-) -Chris Cheers, -- Rafael Avila de Espindola Google

[llvm-commits] [PATCH] partial codgen support for ByVal arguments

2007-08-03 Thread Rafael Espindola
The attached patch implements code generation of byval arguments on the callee. For now only the case were the struct is in the stack is handle correctly. With the patch, the function --- %struct.s = type { i64, i64, i64 } define i64 @f(%struct.s*

Re: [llvm-commits] [PATCH] partial codgen support for ByVal arguments

2007-08-03 Thread Chris Lattner
On Aug 3, 2007, at 9:22 AM, Rafael Espindola wrote: The attached patch implements code generation of byval arguments on the callee. For now only the case were the struct is in the stack is handle correctly. I think this patch is looking very good. As it can only affect things marked