Author: rafael
Date: Fri Sep 28 07:53:01 2007
New Revision: 42433
URL: http://llvm.org/viewvc/llvm-project?rev=42433view=rev
Log:
Refactor the memcpy lowering for the x86 target.
The only generated code difference is that now we call memcpy when
the size of the array is unknown. This matches GCC
Hi Rafael,
Are you sure this is better? Did you do any measurement? Our goal
isn't to match gcc output. :)
Perhaps you can add some unit tests to llvm-test?
Thanks,
Evan
On Sep 28, 2007, at 5:53 AM, Rafael Espindola [EMAIL PROTECTED]
wrote:
Author: rafael
Date: Fri Sep 28 07:53:01
On Sep 28, 2007, at 8:36 AM, Evan Cheng wrote:
Are you sure this is better? Did you do any measurement? Our goal
isn't to match gcc output. :)
I think this behavior makes sense. If the size is variable, it could
be arbitrarily large. We should assume that memcpy (the library
I think this behavior makes sense. If the size is variable, it could
be arbitrarily large. We should assume that memcpy (the library
implementation) is tuned as best as possible for handling the unknown
size case.
Yes, we know that libc memcpy is better for big values and that inline
is
