How about changing it to FLT_ROUND (no s) or something else? Using a
trailing '_' seems silly.
Thanks,
Evan
On Jan 30, 2008, at 4:41 PM, Dan Gohman wrote:
Author: djg
Date: Wed Jan 30 18:41:03 2008
New Revision: 46587
URL: http://llvm.org/viewvc/llvm-project?rev=46587view=rev
Log:
How about changing it to FLT_ROUND (no s) or something else? Using a
trailing '_' seems silly.
FLT_ROUNDS is a specific standard macro, and the opcode in question
is for implementing it. I'd prefer to not change any letters in the
spelling. FWIW, it's consistent with PIC_.
Dan
--
Dan
Hello, Everyone
FLT_ROUNDS is a specific standard macro, and the opcode in question
is for implementing it. I'd prefer to not change any letters in the
spelling. FWIW, it's consistent with PIC_.
I'm for FLT_ROUNDS_
--
With best regards, Anton Korobeynikov.
Faculty of Mathematics Mechanics,
Author: djg
Date: Wed Jan 30 18:41:03 2008
New Revision: 46587
URL: http://llvm.org/viewvc/llvm-project?rev=46587view=rev
Log:
Rename ISD::FLT_ROUNDS to ISD::FLT_ROUNDS_ to avoid conflicting
with the real FLT_ROUNDS (defined in float.h).
Modified: