Re: [llvm-commits] CVS: llvm/lib/Bytecode/Reader/Reader.cpp

2007-02-12 Thread Chris Lattner
On Mon, 12 Feb 2007, Reid Spencer wrote: >> - Result = new CallInst(F, Params); >> + Result = new CallInst(F, &Params[0], Params.size()); > > I don't see why this series of changes is better for performance. It isn't. > Is there something I'm missing here? Nope, it's just an API cleanu

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Reader/Reader.cpp

2007-02-12 Thread Reid Spencer
Chris, I have a question .. On Mon, 2007-02-12 at 19:54 -0600, Chris Lattner wrote: > > Changes in directory llvm/lib/Bytecode/Reader: > > Reader.cpp updated: 1.236 -> 1.237 > --- > Log message: > > stop passing vector into ctors > > > --- > Diffs of the changes: (+2 -2) > > Reader.cpp |

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Reader/Reader.cpp Reader.h

2007-01-12 Thread Chris Lattner
> + case Type::IntegerTyID: { > +const IntegerType *IT = cast(Ty); > +if (IT->getBitWidth() <= 32) { > + uint32_t Val = read_vbr_uint(); > + if (IT->getBitWidth() == 1) { > +if (Val != 0 && Val != 1) > + error("Invalid boolean value read."); > +Result = C

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Reader/Reader.cpp

2006-12-11 Thread Chris Lattner
On Dec 11, 2006, at 3:56 PM, Reid Spencer wrote: > On Mon, 2006-12-11 at 15:23 -0800, Chris Lattner wrote: >>> Create the cast constant expression that was read instead of >>> attempting >>> to infer the cast from its operand and type. This fixes: >>> test/Regression/Bytecode/2006-12-11-Cast-Cons

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Reader/Reader.cpp

2006-12-11 Thread Reid Spencer
On Mon, 2006-12-11 at 15:23 -0800, Chris Lattner wrote: > > Create the cast constant expression that was read instead of > > attempting > > to infer the cast from its operand and type. This fixes: > > test/Regression/Bytecode/2006-12-11-Cast-ConstExpr.ll > > Is there any hope that that getCast m

Re: [llvm-commits] CVS: llvm/lib/Bytecode/Reader/Reader.cpp

2006-12-11 Thread Chris Lattner
> Create the cast constant expression that was read instead of > attempting > to infer the cast from its operand and type. This fixes: > test/Regression/Bytecode/2006-12-11-Cast-ConstExpr.ll Is there any hope that that getCast method will go away soon? -Chris > > --- > Diffs of the changes: (