Re: [llvm-commits] CVS: llvm/lib/CodeGen/BranchFolding.cpp

2007-06-07 Thread Chris Lattner
BranchFolding.cpp updated: 1.65 - 1.66 --- Log message: Throttle tail merging; handling blocks with large numbers of predecessors is too slow. Thanks Dale, Please make this a hidden command line option like loop-unswitch- threshold. -Chris --- Diffs of the changes: (+6 -2)

Re: [llvm-commits] CVS: llvm/lib/CodeGen/BranchFolding.cpp

2007-06-01 Thread Duncan Sands
Hi Dale, Arrange for only 1 of multiple branches to landing pad to be kept. you seem to assume that there is at most one landing pad block for a given MBB, i.e. that all invokes in the MBB unwind to the same landing pad. Are you sure that's true? Ciao, Duncan.

Re: [llvm-commits] CVS: llvm/lib/CodeGen/BranchFolding.cpp

2007-06-01 Thread Duncan Sands
Hi Dale, Arrange for only 1 of multiple branches to landing pad to be kept. it struck me that this patch seems to assume that if a successor is a landing pad then it is necessarily a landing pad for the current MBB. But couldn't it be the landing pad for some other MBB, and simply a normal

Re: [llvm-commits] CVS: llvm/lib/CodeGen/BranchFolding.cpp

2007-06-01 Thread Dale Johannesen
On Jun 1, 2007, at 12:56 PM, Duncan Sands wrote: Hi Dale, Arrange for only 1 of multiple branches to landing pad to be kept. That should be successors, not branches, but you've gotten past that it struck me that this patch seems to assume that if a successor is a landing pad then it

Re: [llvm-commits] CVS: llvm/lib/CodeGen/BranchFolding.cpp

2007-06-01 Thread Duncan Sands
Hi Dale, it struck me that this patch seems to assume that if a successor is a landing pad then it is necessarily a landing pad for the current MBB. I wasn't intending to assume that; how so? But couldn't it be the landing pad for some other MBB, and simply a normal successor for

Re: [llvm-commits] CVS: llvm/lib/CodeGen/BranchFolding.cpp

2007-06-01 Thread Dale Johannesen
On Jun 1, 2007, at 1:24 PM, Duncan Sands wrote: Suppose a successor S1 has isLandingPad true because it is a landing pad for some other MBB, and some later successor (S2) has isLandingPad true because it is the landing pad for this MBB. What will happen? When we get to S1 foundPad is set to

Re: [llvm-commits] CVS: llvm/lib/CodeGen/BranchFolding.cpp

2007-06-01 Thread Dale Johannesen
On Jun 1, 2007, at 1:28 PM, Dale Johannesen wrote: On Jun 1, 2007, at 1:24 PM, Duncan Sands wrote: Suppose a successor S1 has isLandingPad true because it is a landing pad for some other MBB, and some later successor (S2) has isLandingPad true because it is the landing pad for this MBB.