Re: [llvm-commits] [llvm] r46587 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/CodeGen/SelectionDAG/

2008-01-31 Thread Evan Cheng
How about changing it to FLT_ROUND (no s) or something else? Using a trailing '_' seems silly. Thanks, Evan On Jan 30, 2008, at 4:41 PM, Dan Gohman wrote: Author: djg Date: Wed Jan 30 18:41:03 2008 New Revision: 46587 URL: http://llvm.org/viewvc/llvm-project?rev=46587view=rev Log:

[llvm-commits] [test-suite] r46608 - in /test-suite/trunk/MultiSource/Applications/ClamAV: Makefile clamscan_clamscan.c inputs/clamdoc.pdf inputs/clamdoc.tar.gz

2008-01-31 Thread Evan Cheng
Author: evancheng Date: Thu Jan 31 02:14:31 2008 New Revision: 46608 URL: http://llvm.org/viewvc/llvm-project?rev=46608view=rev Log: Slightly shrinkify inputs, slightly increase test size. Added: test-suite/trunk/MultiSource/Applications/ClamAV/inputs/clamdoc.tar.gz (with props) Removed:

Re: [llvm-commits] [test-suite] r46573 [1/3] - in /test-suite/trunk/MultiSource/Applications: ./ ClamAV/ ClamAV/dbdir/ ClamAV/inputs/ ClamAV/inputs/rtf-test/ ClamAV/scripts/

2008-01-31 Thread Evan Cheng
On Jan 30, 2008, at 4:59 PM, Chris Lattner wrote: On Jan 30, 2008, at 1:17 PM, Evan Cheng wrote: Author: evancheng Date: Wed Jan 30 15:17:10 2008 New Revision: 46573 URL: http://llvm.org/viewvc/llvm-project?rev=46573view=rev Log: Add new benchmark ClamAV. Cool. Can we shrink the

[llvm-commits] [llvm] r46609 - in /llvm/trunk: include/llvm/CodeGen/ lib/CodeGen/ lib/CodeGen/SelectionDAG/ lib/Target/ lib/Target/CellSPU/ lib/Target/PowerPC/ lib/Target/X86/ utils/TableGen/

2008-01-31 Thread Evan Cheng
Author: evancheng Date: Thu Jan 31 03:59:15 2008 New Revision: 46609 URL: http://llvm.org/viewvc/llvm-project?rev=46609view=rev Log: Add an extra operand to LABEL nodes which distinguishes between debug, EH, or misc labels. This fixes the EH breakage. However I am not convinced this is *the*

[llvm-commits] [llvm] r46610 - /llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAG.cpp

2008-01-31 Thread Evan Cheng
Author: evancheng Date: Thu Jan 31 04:05:13 2008 New Revision: 46610 URL: http://llvm.org/viewvc/llvm-project?rev=46610view=rev Log: Add a comment for a nasty short term hack. Modified: llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAG.cpp Modified:

[llvm-commits] [llvm] r46612 - /llvm/trunk/include/llvm/ADT/StringMap.h

2008-01-31 Thread Anton Korobeynikov
Author: asl Date: Thu Jan 31 06:30:40 2008 New Revision: 46612 URL: http://llvm.org/viewvc/llvm-project?rev=46612view=rev Log: Make StringMap to be more STL'ish. Patch by Mikhail Glushenkov! Modified: llvm/trunk/include/llvm/ADT/StringMap.h Modified: llvm/trunk/include/llvm/ADT/StringMap.h

[llvm-commits] [llvm] r46611 - /llvm/trunk/include/llvm/ADT/StringMap.h

2008-01-31 Thread Anton Korobeynikov
Author: asl Date: Thu Jan 31 06:10:41 2008 New Revision: 46611 URL: http://llvm.org/viewvc/llvm-project?rev=46611view=rev Log: Whitespace cleanup Modified: llvm/trunk/include/llvm/ADT/StringMap.h Modified: llvm/trunk/include/llvm/ADT/StringMap.h URL:

[llvm-commits] [llvm] r46615 - /llvm/trunk/include/llvm/ADT/StringMap.h

2008-01-31 Thread Anton Korobeynikov
Author: asl Date: Thu Jan 31 11:43:25 2008 New Revision: 46615 URL: http://llvm.org/viewvc/llvm-project?rev=46615view=rev Log: Reapply the patch with fix. Modified: llvm/trunk/include/llvm/ADT/StringMap.h Modified: llvm/trunk/include/llvm/ADT/StringMap.h URL:

Re: [llvm-commits] [llvm] r46565 - in /llvm/trunk: lib/CodeGen/MachineModuleInfo.cpp test/DebugInfo/globalGetElementPtr.ll

2008-01-31 Thread Duncan Sands
Hi Dale, maybe you could use IntrinsicInst::StripPointerCasts instead? Didn't know about this, thanks. It recurses and I don't think that's what I want in this case. I did, however, steal its looping code:) Are you sure you don't want it to be recursive? I can take a global variable,

Re: [llvm-commits] [llvm] r46565 - in /llvm/trunk: lib/CodeGen/MachineModuleInfo.cpp test/DebugInfo/globalGetElementPtr.ll

2008-01-31 Thread Dale Johannesen
On Jan 31, 2008, at 9:55 AM, Duncan Sands wrote: Hi Dale, maybe you could use IntrinsicInst::StripPointerCasts instead? Didn't know about this, thanks. It recurses and I don't think that's what I want in this case. I did, however, steal its looping code:) Are you sure you don't want

[llvm-commits] [llvm] r46617 - /llvm/trunk/lib/Support/APFloat.cpp

2008-01-31 Thread Dale Johannesen
Author: johannes Date: Thu Jan 31 12:34:01 2008 New Revision: 46617 URL: http://llvm.org/viewvc/llvm-project?rev=46617view=rev Log: Chris' change to print an approximation to long doubles exposed a bug in APFloat's long double-double conversion of NaNs. Broke several things in the ieee part of

Re: [llvm-commits] [llvm] r46617 - /llvm/trunk/lib/Support/APFloat.cpp

2008-01-31 Thread Chris Lattner
On Jan 31, 2008, at 10:34 AM, Dale Johannesen wrote: Author: johannes Date: Thu Jan 31 12:34:01 2008 New Revision: 46617 URL: http://llvm.org/viewvc/llvm-project?rev=46617view=rev Log: Chris' change to print an approximation to long doubles exposed a bug in APFloat's long double-double

Re: [llvm-commits] [test-suite] r46573 [1/3] - in /test-suite/trunk/MultiSource/Applications: ./ ClamAV/ ClamAV/dbdir/ ClamAV/inputs/ ClamAV/inputs/rtf-test/ ClamAV/scripts/

2008-01-31 Thread Chris Lattner
On Jan 31, 2008, at 12:15 AM, Evan Cheng wrote: Doc22.rtf (with props) test-suite/trunk/MultiSource/Applications/ClamAV/inputs/rtf-test/ doc3.rtf (with props) test-suite/trunk/MultiSource/Applications/ClamAV/inputs/rtf-test/ docCLAMexe.rtf (with props)

Re: [llvm-commits] [llvm] r46565 - in /llvm/trunk: lib/CodeGen/MachineModuleInfo.cpp test/DebugInfo/globalGetElementPtr.ll

2008-01-31 Thread Chris Lattner
On Jan 31, 2008, at 10:46 AM, Dale Johannesen wrote: No I'm not sure, but I know of no case where this is useful or desirable. The code in question is handling the debug info for global variables, specifically the part that points to the global variable itself. That's under the control of

Re: [llvm-commits] [llvm] r46565 - in /llvm/trunk: lib/CodeGen/MachineModuleInfo.cpp test/DebugInfo/globalGetElementPtr.ll

2008-01-31 Thread Duncan Sands
Hi Dale, maybe you could use IntrinsicInst::StripPointerCasts instead? Didn't know about this, thanks. It recurses and I don't think that's what I want in this case. I did, however, steal its looping code:) Are you sure you don't want it to be recursive? I can take a global

Re: [llvm-commits] [llvm] r46556 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h include/llvm/Value.h lib/CodeGen/PseudoSourceValue.cpp

2008-01-31 Thread Chris Lattner
On Jan 31, 2008, at 11:44 AM, Evan Cheng wrote: This is a static initializer, so it can't assume Type::Int8Ty has been initialized at this point. Can you take a look? Thanks. A good way to fix this is to replace direct use of the objects with simple accessors. This is how

Re: [llvm-commits] [llvm] r46625 - /llvm/trunk/include/llvm/ADT/StringMap.h

2008-01-31 Thread Chris Lattner
URL: http://llvm.org/viewvc/llvm-project?rev=46625view=rev Log: Add convenient std::string helpers to StringMap. Patch by Mikhail Glushenkov! Cool. Before David chimes in :) , I'll point out: + iterator find(const std::string Key) { +const char* key_start = Key[0]; +return

Re: [llvm-commits] [test-suite] r46573 [1/3] - in /test-suite/trunk/MultiSource/Applications: ./ ClamAV/ ClamAV/dbdir/ ClamAV/inputs/ ClamAV/inputs/rtf-test/ ClamAV/scripts/

2008-01-31 Thread Chris Lattner
On Jan 31, 2008, at 11:37 AM, Evan Cheng wrote: All the Windows file are actually pretty tiny. The only big one is clamdoc.tar.gz. Perhaps we should take Edwin's advice and add links to test data from other benchmarks? I removed them because I thought they were left in by mistake. Ok, if

Re: [llvm-commits] [llvm] r46556 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h include/llvm/Value.h lib/CodeGen/PseudoSourceValue.cpp

2008-01-31 Thread Dan Gohman
This is a static initializer, so it can't assume Type::Int8Ty has been initialized at this point. Can you take a look? Thanks. A good way to fix this is to replace direct use of the objects with simple accessors. This is how ConstantInt::getTrue() handle's the 'i1 1' singleton

Re: [llvm-commits] [llvm] r46625 - /llvm/trunk/include/llvm/ADT/StringMap.h

2008-01-31 Thread Anton Korobeynikov
Hello, Chris This sort of thing won't work when the string is empty and checking is enabled. Maybe something like this is enough: if (Key.empty()) return find(0,0); Will find() operate sane in such case (supplying NULL pointer as input)? -- With best regards, Anton Korobeynikov.

[llvm-commits] [llvm] r46625 - /llvm/trunk/include/llvm/ADT/StringMap.h

2008-01-31 Thread Anton Korobeynikov
Author: asl Date: Thu Jan 31 17:02:33 2008 New Revision: 46625 URL: http://llvm.org/viewvc/llvm-project?rev=46625view=rev Log: Add convenient std::string helpers to StringMap. Patch by Mikhail Glushenkov! Modified: llvm/trunk/include/llvm/ADT/StringMap.h Modified:

Re: [llvm-commits] [llvm-gcc-4.2] r43913 [33/80] - in

2008-01-31 Thread Bill Wendling
Hi John, My name is John Brumbelow, and I am a developer of OptiDoc. I am trying to make a reader/magnifier for our software to read text from any application, including Java Applets, into our C++/VB/C# programs. To explain this need. We have customers who are visually impared, but need to

Re: [llvm-commits] [llvm] r46587 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/CodeGen/SelectionDAG/

2008-01-31 Thread Dan Gohman
How about changing it to FLT_ROUND (no s) or something else? Using a trailing '_' seems silly. FLT_ROUNDS is a specific standard macro, and the opcode in question is for implementing it. I'd prefer to not change any letters in the spelling. FWIW, it's consistent with PIC_. Dan -- Dan

Re: [llvm-commits] [llvm] r46587 - in /llvm/trunk: include/llvm/CodeGen/SelectionDAGNodes.h lib/CodeGen/SelectionDAG/LegalizeDAG.cpp lib/CodeGen/SelectionDAG/SelectionDAG.cpp lib/CodeGen/SelectionDAG/

2008-01-31 Thread Anton Korobeynikov
Hello, Everyone FLT_ROUNDS is a specific standard macro, and the opcode in question is for implementing it. I'd prefer to not change any letters in the spelling. FWIW, it's consistent with PIC_. I'm for FLT_ROUNDS_ -- With best regards, Anton Korobeynikov. Faculty of Mathematics Mechanics,

[llvm-commits] [llvm] r46628 - in /llvm/trunk: include/llvm/CodeGen/MachineModuleInfo.h lib/CodeGen/MachineModuleInfo.cpp lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

2008-01-31 Thread Evan Cheng
Author: evancheng Date: Thu Jan 31 20:05:57 2008 New Revision: 46628 URL: http://llvm.org/viewvc/llvm-project?rev=46628view=rev Log: Rename RecordLabel to RecordSourceLine because that's what it is doing. Modified: llvm/trunk/include/llvm/CodeGen/MachineModuleInfo.h

Re: [llvm-commits] [llvm] r46625 - /llvm/trunk/include/llvm/ADT/StringMap.h

2008-01-31 Thread Chris Lattner
On Jan 31, 2008, at 3:32 PM, Anton Korobeynikov wrote: Hello, Chris This sort of thing won't work when the string is empty and checking is enabled. Maybe something like this is enough: if (Key.empty()) return find(0,0); Will find() operate sane in such case (supplying NULL pointer as