Re: [llvm-commits] Priority-Based Coloring Approach to Register Allocation

2006-11-17 Thread Evan Cheng
Hi Bill, It's great to have a graph coloring regalloc to compare the current implement against. Thanks! Comments: 1. INode NeighborList is a std::setINode* which is very slow. Please use a more efficient data structure. You may have to wrap LiveIntervals in something else and give each

Re: [llvm-commits] Priority-Based

2006-11-15 Thread Chris Lattner
On Nov 15, 2006, at 5:03 PM, Bill Wendling wrote: Hi all, This is meant for a code review and NOT for submission (just yet). This is my implementation of Chow Hennesey's Priority-Based Coloring Approach to Register Allocation. It's still in the experimental stages (though it

Re: [llvm-commits] Priority-Based

2006-11-15 Thread Bill Wendling
On Nov 15, 2006, at 6:04 PM, Chris Lattner wrote: The patch looks good, but please: 1. Change CreateNewLiveInterval to take LRs by const reference. This will require changing the iterators to be const_iterator instead of just iterator's. Will do. 2. Please change int* X to int *X to