[llvm-commits] [126543] Clean up this macro to only eval each argument once.

2007-04-25 Thread clattner
Revision: 126543 Author: clattner Date: 2007-04-25 09:52:59 -0700 (Wed, 25 Apr 2007) Log Message: --- Clean up this macro to only eval each argument once. Modified Paths: -- apple-local/branches/llvm/gcc/expr.c Modified: apple-local/branches/llvm/gcc/expr.c

Re: [llvm-commits] [126543] Clean up this macro to only eval each argument once.

2007-04-25 Thread Bill
On 4/25/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: #undef MOVE_BY_PIECES_P -#define MOVE_BY_PIECES_P(SIZE, ALIGN) ((SIZE-SIZE)+(ALIGN-ALIGN)) +#define MOVE_BY_PIECES_P(SIZE, ALIGN) (0*(SIZE)*(ALIGN)) Why not just make it: #define MOVE_BY_PIECES_P(SIZE, ALIGN) 0 ? -bw

Re: [llvm-commits] [126543] Clean up this macro to only eval each argument once.

2007-04-25 Thread Chris Lattner
On Apr 25, 2007, at 9:56 AM, Bill wrote: On 4/25/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: #undef MOVE_BY_PIECES_P -#define MOVE_BY_PIECES_P(SIZE, ALIGN) ((SIZE-SIZE)+(ALIGN-ALIGN)) +#define MOVE_BY_PIECES_P(SIZE, ALIGN) (0*(SIZE)*(ALIGN)) Why not just make it: #define

Re: [llvm-commits] [126543] Clean up this macro to only eval each argument once.

2007-04-25 Thread Bill
On 4/25/07, Chris Lattner [EMAIL PROTECTED] wrote: On Apr 25, 2007, at 9:56 AM, Bill wrote: On 4/25/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: #undef MOVE_BY_PIECES_P -#define MOVE_BY_PIECES_P(SIZE, ALIGN) ((SIZE-SIZE)+(ALIGN-ALIGN)) +#define MOVE_BY_PIECES_P(SIZE, ALIGN)