The attached patch passes a make check. I haven't committed yet
because I am going on vacations and will be a bit slow to respond. I
will still have Internet access and can commit if there is positive
feedback.
One ugly hack in the CL in to make Subtarget and BaseSubtarget
independent fields that
Hi Rafael,
The attached patch passes a make check. I haven't committed yet
because I am going on vacations and will be a bit slow to respond. I
will still have Internet access and can commit if there is positive
feedback.
Index: include/llvm/Target/TargetLowering.h
You probably can get away with forward declaring the TargetSubtarget
class instead of #including here.
Good catch. Will try that.
If you're going to do this, why not just get rid of Subtarget
altogether and just use BaseSubtarget? It can be set to 0 for targets
that don't use it. Then
On 11/5/07, Rafael Espindola [EMAIL PROTECTED] wrote:
If you're going to do this, why not just get rid of Subtarget
altogether and just use BaseSubtarget? It can be set to 0 for targets
that don't use it. Then again, it might not be a bad idea to use
virtual getter/setters here. It already
