Re: [llvm-commits] [llvm] r46556 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h include/llvm/Value.h lib/CodeGen/PseudoSourceValue.cpp

2008-02-05 Thread Dan Gohman
Some comments on the patch: + + // Save loads/stores matched by a pattern. + if (!N-isLeaf() N-getName().empty() + ((N-getOperator()-getName() == ld) || + (N-getOperator()-getName() == st) || + (N-getOperator()-getName() == ist))) { + LSI.push_back(RootName); + } + I am

Re: [llvm-commits] [llvm] r46556 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h include/llvm/Value.h lib/CodeGen/PseudoSourceValue.cpp

2008-02-01 Thread Evan Cheng
Sorry, I forgot to reply last night. The patch tested out ok. Thanks! Evan On Jan 31, 2008, at 6:08 PM, Dan Gohman wrote: Attached is an updated version of this change (46556 and 46585) with what I believe is a fix for the static initializer problem, but I don't have access to a system where

Re: [llvm-commits] [llvm] r46556 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h include/llvm/Value.h lib/CodeGen/PseudoSourceValue.cpp

2008-02-01 Thread Evan Cheng
Some comments on the patch: + +// Save loads/stores matched by a pattern. +if (!N-isLeaf() N-getName().empty() +((N-getOperator()-getName() == ld) || + (N-getOperator()-getName() == st) || + (N-getOperator()-getName() == ist))) { + LSI.push_back(RootName);

Re: [llvm-commits] [llvm] r46556 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h include/llvm/Value.h lib/CodeGen/PseudoSourceValue.cpp

2008-01-31 Thread Chris Lattner
On Jan 31, 2008, at 11:44 AM, Evan Cheng wrote: This is a static initializer, so it can't assume Type::Int8Ty has been initialized at this point. Can you take a look? Thanks. A good way to fix this is to replace direct use of the objects with simple accessors. This is how

Re: [llvm-commits] [llvm] r46556 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h include/llvm/Value.h lib/CodeGen/PseudoSourceValue.cpp

2008-01-31 Thread Dan Gohman
This is a static initializer, so it can't assume Type::Int8Ty has been initialized at this point. Can you take a look? Thanks. A good way to fix this is to replace direct use of the objects with simple accessors. This is how ConstantInt::getTrue() handle's the 'i1 1' singleton

[llvm-commits] [llvm] r46556 - in /llvm/trunk: include/llvm/CodeGen/PseudoSourceValue.h include/llvm/Value.h lib/CodeGen/PseudoSourceValue.cpp

2008-01-30 Thread Dan Gohman
Author: djg Date: Wed Jan 30 10:35:31 2008 New Revision: 46556 URL: http://llvm.org/viewvc/llvm-project?rev=46556view=rev Log: Add a new PseudoSourceValue class, which will be used to help track memory reference information in the backend. Most of this was written by Florian Brander, cleanup and