Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-23 Thread Tres Finocchiaro
stable-1.1 please. -- Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integra

Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-23 Thread midi-pascal
Nice! Do I push the fix (3 lines of code!) in the master branch? Pascal On 14-11-23 10:53 AM, Tres Finocchiaro wrote: If the patch breaks OSX, I can add the ifdef in. From what I'm observing, the behavior should be identical, since the bug exists there too... Inline image 1 -Tres ​

Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-23 Thread Tres Finocchiaro
If the patch breaks OSX, I can add the ifdef in. From what I'm observing, the behavior should be identical, since the bug exists there too... [image: Inline image 1] -Tres ​ -- Download BIRT iHub F-Type - The Free Enter

Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-23 Thread midi-pascal
I have now a working fix for this bug. It works well under Linux and Windows *but* I am not sure if it will work under Os X since I have no access to a Mac box and I do not even know if Mac apps have a system menu in their dialogs. The fact is the system menu options of the dialogs can be accesse

Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-21 Thread Tres Finocchiaro
> By the way, you're really helpful :-) > Thanks! Thanks. I'm not great with C++, but I've debugged a few issues to completion which has helped me discover quite a bit of the codebase. These small issues I find particularly interesting because they add an element of polish to the interface yet g

Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-21 Thread midi-pascal
Yep. This is exactly the place I was looking at. Since the instrument dialogs are fixed size (I tried them all) I think the Maximize option in their context menu should be disabled - and the Size option too -. I will give Lmms a debug run with some breakpoints to be sure it is the rigth place t

Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-21 Thread Tres Finocchiaro
Yes, same behavior then. From what I can observe, every single QMdiArea child dialog in the software behaves this way. The modal dialogs render their title bar from the OS window manager and do not suffer this bug. I'm not sure if this is the same thing we are looking at, might shed some light:

Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-21 Thread midi-pascal
Perhaps the way I described the problem was not this clear :-) Yes I was speaking about the "Maximize" option in the context menu (there is no maximize button on the window). Do you mean the context menu icon and the Close an Minimize buttons are working after you clicked the Maximize from the c

Re: [LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-21 Thread Tres Finocchiaro
That is very strange. I've never encountered it before, so it may be a bug specific to the QT version you are using (or perhaps the TDE desktop environment). I took a look at the instrument windows and they certainly have the option to maximize via context-menu, but not via the window corner. Cl

[LMMS-devel] Strange SF2 Instrument window behaviour

2014-11-21 Thread midi-pascal
Hi Lmms crew, I just noticed a somewhat bad behaviour of the SF2 instrument windows in version stable-1.1. If you click on the window menu icon and choose the "Maximize" option, the window is simply moved to coordinates (0,0) of the Lmms workspace (however it is not resized, which is ok) Then,