Re: [LMMS-devel] cpplint

2014-04-21 Thread Jonathan Aquilina
Do what you gotta do. They would be an ideal basis to have something like an adaptation of cpplint to run to ensure all code follows those guidelines. On Mon, Apr 21, 2014 at 4:23 PM, Vesa wrote: > On 04/21/2014 05:08 PM, Lukas W. wrote: > > If you're looking for them, they are located in the G

Re: [LMMS-devel] cpplint

2014-04-21 Thread Vesa
On 04/21/2014 05:08 PM, Lukas W. wrote: > If you're looking for them, they are located in the GitHub wiki. ;-) Speaking of the guidelines, I'm going to add a short bit to them about the header guards, if that's ok. -- St

Re: [LMMS-devel] cpplint

2014-04-21 Thread Jonathan Aquilina
Just saw them now. I think adapting that cpplint script and even potentially getting it to run only when compiled from source by running something like make check woudl be great. On Mon, Apr 21, 2014 at 4:12 PM, Vesa wrote: > On 04/21/2014 04:48 PM, Jonathan Aquilina wrote: > > If we have codin

Re: [LMMS-devel] cpplint

2014-04-21 Thread Vesa
On 04/21/2014 04:48 PM, Jonathan Aquilina wrote: > If we have coding guidelines I have not seen them. I will answer it > shortly. We do have them. -- Start Your Social Network Today - Download eXo Platform Build your Ente

Re: [LMMS-devel] cpplint

2014-04-21 Thread Jonathan Aquilina
Thanks for that lukas. I wonder how hard it would be thinking about it to actually port the cpplint script to c++ and have it run when building or if you do something like make check it runs the lint script. On Mon, Apr 21, 2014 at 4:08 PM, Lukas W. wrote: > If you're looking for them, they are

Re: [LMMS-devel] cpplint

2014-04-21 Thread Lukas W.
If you're looking for them, they are located in the GitHub wiki. ;-) 2014-04-21 15:48 GMT+02:00 Jonathan Aquilina : > If we have coding guidelines I have not seen them. I will answer it shortly. > > > On Mon, Apr 21, 2014 at 3:47 PM, Lukas W. wrote: >> >> Jonathan, you know we do have coding guid

Re: [LMMS-devel] cpplint

2014-04-21 Thread Jonathan Aquilina
If we have coding guidelines I have not seen them. I will answer it shortly. On Mon, Apr 21, 2014 at 3:47 PM, Lukas W. wrote: > Jonathan, you know we do have coding guidelines? Or have I misunderstood > you? > > Off-Topic: Could you please answer my mail in the "Website updates" > thread if you

Re: [LMMS-devel] cpplint

2014-04-21 Thread Lukas W.
Jonathan, you know we do have coding guidelines? Or have I misunderstood you? Off-Topic: Could you please answer my mail in the "Website updates" thread if you haven't seen it yet? 2014-04-21 15:38 GMT+02:00 Jonathan Aquilina : > would be great as well at this stage to get cppunit framework in pl

Re: [LMMS-devel] cpplint

2014-04-21 Thread Jonathan Aquilina
would be great as well at this stage to get cppunit framework in place and adapted to our needs as well if need be. Any chance at this point Vesa you could draft up some sample coding standards and then we can send them to toby for approval and adaptation of the cpplint python script. On Mon, Apr

Re: [LMMS-devel] cpplint

2014-04-21 Thread Vesa
On 04/21/2014 04:33 PM, Jonathan Aquilina wrote: > It seems like that is something coded by google that checks the source > code to make sure it complies with googles code styling guidelines. Oh ok, then it probably doesn't suit us. > > I am wondering if we should setup our own guidelines and ada

[LMMS-devel] cpplint

2014-04-21 Thread Jonathan Aquilina
It seems like that is something coded by google that checks the source code to make sure it complies with googles code styling guidelines. I am wondering if we should setup our own guidelines and adapt cpplint? -- Jonathan Aquilina