Re: [LMMS-devel] ZynAddSubFX update

2014-05-13 Thread David Gerard
On 12 May 2014 19:06, Tobias Doerffel wrote: > In order to build the current master branch I recommend to do a clean > clone as otherwise you have to deinit and remove the ZynAddSubFX > submodule manually. Note: remember to do "git checkout master", as a checkout defaults to stable-1.0 branch!

Re: [LMMS-devel] ZynAddSubFX update

2014-05-13 Thread David Gerard
On 13 May 2014 11:18, Vesa wrote: > On 05/13/2014 09:12 AM, Lukas W. wrote: >> Good to hear you drop the submodule. However, launchpad's PPA bzr >> import will still be broken. As far as I know, it doesn't work with >> any projects that have used submodules in their history… >> So if we want that

Re: [LMMS-devel] ZynAddSubFX update

2014-05-13 Thread Vesa
On 05/13/2014 09:12 AM, Lukas W. wrote: > @Toby > > Good to hear you drop the submodule. However, launchpad's PPA bzr > import will still be broken. As far as I know, it doesn't work with > any projects that have used submodules in their history… > So if we want that to work again, we'll have to ch

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Lukas W.
@Toby Good to hear you drop the submodule. However, launchpad's PPA bzr import will still be broken. As far as I know, it doesn't work with any projects that have used submodules in their history… So if we want that to work again, we'll have to cherry-pick all commits except the submodule ones out

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Tres Finocchiaro
The maintainer of Zyn responded about the theme support. Details in the bug tracker, issue 713 . Jonathan, are you still categorizing these? 1.0.0 has brought many new enhancement requests and bug requests and could probably benefit from some basic organi

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Tres Finocchiaro
> > Well, if the new Zyn supports themes, why don't we instead dress it up > to fit the new LMMS theme? We could really make it look like a part of > the software... shouldn't be that hard as we can probably reuse a lot of > the graphics we already have. That would be great although I do like the

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Israel
That is incredible looking theme! to me, it seems like most of those are some sort of image file. So, I would guess that this stuff is all included in the current Zyn... FLTK is a very basic GUI toolkit. They may have put an image inside a knob and colored all the Gui elements within the code, e

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Vesa
On 05/12/2014 09:32 PM, Tres Finocchiaro wrote: > > > I see an issue however on 12.04 with the "Instrument Edit" screen: > http://i.imgur.com/aVX1JBS.png > (can anyone else confirm?) I can confirm that, it kind of seems like there's a skin or background image missing and it just vomits out whateve

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Vesa
Well, it seems I managed to get it sorted by manually removing zynaddsubfx, stashing that change and then rebasing on upstream... just in case anyone else runs into the same problem. -- "Accelerate Dev Cycles with Automat

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Vesa
On 05/12/2014 09:10 PM, Vesa wrote: > On 05/12/2014 09:06 PM, Tobias Doerffel wrote: >> In order to build the current master branch I recommend to do a clean >> clone as otherwise you have to deinit and remove the ZynAddSubFX >> submodule manually. > What about forks? I mainly use my own fork for

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Tres Finocchiaro
Great news Toby, thanks for sharing! I just followed your instructions and they worked well. http://i.imgur.com/Kv9DBb0.png I see an issue however on 12.04 with the "Instrument Edit" screen: http://i.imgur.com/aVX1JBS.png (can anyone else confirm?) Slightly off topic, but I noticed the ZASFX te

Re: [LMMS-devel] ZynAddSubFX update

2014-05-12 Thread Vesa
On 05/12/2014 09:06 PM, Tobias Doerffel wrote: > In order to build the current master branch I recommend to do a clean > clone as otherwise you have to deinit and remove the ZynAddSubFX > submodule manually. What about forks? I mainly use my own fork for building master, since it's more convenien