Hi Ola,
I can confirm this problem with latest linaro-4.9-branch build. However, this
is target-independent problem (reproducible on, at least, x86 and aarch64), so
it is best to be tracked and addressed via upstream bugzilla.
Would you submit a PR on http://gcc.gnu.org/bugzilla ?
Thank you,
Hi,
I agree with Victor's concern, implementation needs a mechanism to know
what is the amount of valid memory available in the mac_addr pointer.
If I am not wrong the idea of defining the ODP_PKTIO_MAC_ADDR_MAX_LEN was
initially discussed but the same was dropped as there were concerns since
From: Alexandru Badicioiu alexandru.badici...@linaro.org
Signed-off-by: Alexandru Badicioiu alexandru.badici...@linaro.org
---
test/validation/Makefile.am |1 +
test/validation/crypto/odp_crypto_test_rng.c | 30 ++
From: Alexandru Badicioiu alexandru.badici...@linaro.org
Signed-off-by: Alexandru Badicioiu alexandru.badici...@linaro.org
---
test/validation/crypto/odp_crypto_test_async_inp.h |2 +-
test/validation/crypto/odp_crypto_test_sync_inp.h |2 +-
2 files changed, 2 insertions(+), 2
On 11/26/2014 07:11 PM, Mike Holmes wrote:
On 26 November 2014 at 12:03, Taras Kondratiuk
taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote:
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
mailto:taras.kondrat...@linaro.org
---
queue_to_qentry doesn't do any validation of the queue handle so will
never return NULL and ends up returning an invalid pointer if passed
ODP_QUEUE_INVALID.
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
platform/linux-generic/odp_packet_io.c | 6 --
1 file changed, 4 insertions(+),
On 11/26/2014 10:13 PM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
api_guide_lines.dox | 6 ++
1 file changed, 6 insertions(+)
diff --git a/api_guide_lines.dox b/api_guide_lines.dox
index be23e9a..1f83c53 100644
--- a/api_guide_lines.dox
+++
On 27 November 2014 at 12:16, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Thanks Maxim,
Yes I should do that. I also intend to make the code used to reproduce
the problem smaller.
One of my worries was that GCC considered the loop without side
effects (ignoring the inline assembler in
Debian things has to go to separate debian chapter. For OE all this
things are not needed.
Maxim.
On 11/26/2014 07:07 PM, Zoltan Kiss wrote:
Now it's easier to read the text and with DEB_HOST_ARCH properly set the
package files are correctly named. Unfortunately dpkg-gencontrol insist to use
Thanks,
Merged,
Maxim.
On 11/25/2014 10:40 PM, Shmulik Ladkani wrote:
Per-worker 'thread_tbl[i]' instance should be initialized
by 'odph_linux_pthread_create()'.
However, 'thread_tbl' (the array itself) was accidentally passed to
'odph_linux_pthread_create', re-initializing 'thread_tbl[0]' on
Merged this patch.
Maxim.
On 11/26/2014 12:59 PM, Balasubramanian Manoharan wrote:
This patch removes Classification APIs which have been deferred from ODP v1.0
The following is the list of the deferred APIs
* odp_cos_set_queue_group
* odp_cos_set_pool
* odp_cos_set_headroom
* odp_cos_flow_set
Nit: I think you menat odp_barrier.c and not .h in the message right
On 2014-11-25 23:37, Ola Liljedahl wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Use definitions from odp_atomic_internal.h.
platform/linux-generic/odp_barrier.c | 5 +++--
1 file changed, 3
On 26 November 2014 at 19:12, Bill Fischofer bill.fischo...@linaro.org
wrote:
Running under Linux these tests are redundant since the OS takes care of
it. On SoCs the I/O HW will normally flag runt packets anyway so again
this is unnecessary. It will be deleted along with the parser changes
On 2014-11-25 23:37, Ola Liljedahl wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
Use definitions from odp_atomic_internal.h.
platform/linux-generic/include/api/odp_rwlock.h | 4 ++-
platform/linux-generic/odp_rwlock.c | 35
-
2
On Thu, Nov 27, 2014 at 7:49 AM, Bala Manoharan
bala.manoha...@linaro.org wrote:
Ping
One thing, I'm trying to build but odp_classification_datamodel.h is
missing. Is that in another patch or you forgot to add it here?
On 26 November 2014 at 11:07, Bala Manoharan bala.manoha...@linaro.org
Hi,
I think this is what we talked on the call yesterday.
/**
* Get the default MAC address of a packet IO interface.
*
* @param[in] id ODP packet IO handle.
* @param[out] mac_addr Storage for MAC address of the packet IO interface.
* @param[in] addr_size Storage size for the
On 11/26/2014 08:31 PM, Maxim Uvarov wrote:
To have compatibility with other compilers define custom
booalen type for odp.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_std_types.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
This series adds a default weak odp_override_log() function which can
be replaced by application.
v3: Rebased and fixed conflicts with merged patches.
v2: Fixed missed comma in ODP_UNIMPLEMENTED() macro.
Taras Kondratiuk (2):
platform: debug: replace fprintf() with odp_override_log()
Move additional functionality out of ODP_LOG. Move abort() call to
odp_override_log(), so application will be able to implement custom
abort handling.
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/api/odp_debug.h | 38
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
This patch introduces the odp_atomic_internal.h header file and changes some
lock and synchronization components to use this API instead of using GCC
__atomic builtins directly. The goal is to wrap
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Use definitions from odp_atomic_internal.h.
platform/linux-generic/odp_barrier.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Operations (including exchange and compare-and-exchange) with specified
C11-based memory models on odp_atomic_u32_t and odp_atomic_u64_t.
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Use definitions from odp_atomic_internal.h.
platform/linux-generic/include/api/odp_rwlock.h | 4 ++-
platform/linux-generic/odp_rwlock.c
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Use definitions from odp_atomic_internal.h.
platform/linux-generic/include/api/odp_ticketlock.h | 2 +-
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Use definitions from odp_atomic_internal.h.
platform/linux-generic/include/api/odp_spinlock.h | 2 +-
This is already in a separate chapter, see the previous patch for
INSTALL.ODP
Zoli
On 27/11/14 11:09, Maxim Uvarov wrote:
Debian things has to go to separate debian chapter. For OE all this
things are not needed.
Maxim.
On 11/26/2014 07:07 PM, Zoltan Kiss wrote:
Now it's easier to read the
On 27 November 2014 at 16:36, Ciprian Barbu ciprian.ba...@linaro.org wrote:
On Thu, Nov 27, 2014 at 3:40 PM, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/27/2014 04:28 PM, Savolainen, Petri (NSN - FI/Espoo) wrote:
Hi,
I think this is what we talked on the call yesterday.
/**
* Get
On 27 November 2014 at 14:28, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
Hi,
I think this is what we talked on the call yesterday.
/**
* Get the default MAC address of a packet IO interface.
*
* @param[in] id ODP packet IO handle.
* @param[out]
On Thu, Nov 27, 2014 at 5:49 PM, Ciprian Barbu ciprian.ba...@linaro.org wrote:
On Wed, Nov 26, 2014 at 7:03 PM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/odp_queue.c | 17 +
1
On 11/27/2014 06:48 PM, Ola Liljedahl wrote:
This is simple and should in practice cover all situations. MAC
addresses are not of extremely variable size. In practice, only 48-bit
and 64-bit MAC addresses (EUI - Extended Unique Identifier) are used
AFAIK.
Can linux on ioctl(sockfd,
On 11/27/2014 05:57 PM, Ciprian Barbu wrote:
On Thu, Nov 27, 2014 at 5:49 PM, Ciprian Barbu ciprian.ba...@linaro.org wrote:
On Wed, Nov 26, 2014 at 7:03 PM, Taras Kondratiuk
taras.kondrat...@linaro.org wrote:
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
On 27 November 2014 at 17:10, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/27/2014 06:48 PM, Ola Liljedahl wrote:
This is simple and should in practice cover all situations. MAC
addresses are not of extremely variable size. In practice, only 48-bit
and 64-bit MAC addresses (EUI -
This patch contains classification implementation for ODP v1.0.
The salient features of this classification version are as follows:
* Attaches PMR, PMR_SET to a Pktio entry
* Attaches CoS values for L2 and L3 QoS to a Pktio entry
* Selects ClassOfService for a packet based on PMR, L2 QoS and L3
Attempts to enq to a pktin queue or deq from a pktout queue are
programming errors, so abort.
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
(This code contribution is provided under the terms of agreement LES-LTM-21309)
platform/linux-generic/odp_packet_io.c | 22 ++
On 27 November 2014 at 17:56, Stuart Haslam stuart.has...@arm.com wrote:
Attempts to enq to a pktin queue or deq from a pktout queue are
programming errors, so abort.
Are there more cases of such programming errors where we should
specify the API semantics to be undefined instead of having to
thanks Ola for explanation, will account that in new version.
Maxim.
On 27 November 2014 at 19:47, Ola Liljedahl ola.liljed...@linaro.org
wrote:
On 27 November 2014 at 14:37, Maxim Uvarov maxim.uva...@linaro.org
wrote:
On 11/26/2014 08:31 PM, Maxim Uvarov wrote:
To have compatibility
I agree. This type is supposed to be just documentation so
typedef int odp_bool_t;
is simplest and best.
Bill
On Thursday, November 27, 2014, Ola Liljedahl ola.liljed...@linaro.org
wrote:
On 27 November 2014 at 14:37, Maxim Uvarov maxim.uva...@linaro.org
javascript:; wrote:
On 11/26/2014
On Thu, Nov 27, 2014 at 05:43:57AM -0500, Yan Sonming wrote:
Add odp_cunit_common.c for common cunit function and add the cunit
test for the api in odp_share_memory.h which include the new api
implement odp_shm_free.
Signed-off-by: Yan Songming yan.songm...@linaro.org
---
v4 change the
Define API and implement promisc functions for linux-generic.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 24 +++
platform/linux-generic/odp_packet_io.c | 74 ++
2 files changed, 98 insertions(+)
Define API for mac address change and implement linux-generic version.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 26
platform/linux-generic/odp_packet_io.c | 74 ++
2 files changed, 100
To have compatibility with other compilers define custom
booalen type for odp.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_std_types.h | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
v2:
In that version I tried to account all comments together. Boolean,
loop, API changes and etc.
Maxim.
Maxim Uvarov (8):
API: implement odp_bool type
API: promisc mode manipulation functions
API: pktio: mac addr functions
cunit: pktio: mtu and promisc mode
cunit: add
Implement pktio device loop device suitable for testing.
Note: lo0 can not be used. Instead of it first upped device
is used.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 60 ++
1 file changed, 60 insertions(+)
Mac address unit test.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/odp_pktio.c | 53 +
1 file changed, 53 insertions(+)
diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c
index 56fece9..87b55a0 100644
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 164
2 files changed, 167 insertions(+), 1 deletion(-)
create mode 100644
Define special name for loop back interface. That interface
can be used mostly for testing. Each implementation can interpret
that loop to any other device.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 4
1 file changed, 4
Use special device for cunit tests. Named as loop odp pktio dev.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/odp_pktio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c
index
On Thu, Nov 27, 2014 at 05:09:06PM +, Ola Liljedahl wrote:
On 27 November 2014 at 17:56, Stuart Haslam stuart.has...@arm.com wrote:
Attempts to enq to a pktin queue or deq from a pktout queue are
programming errors, so abort.
Are there more cases of such programming errors where we
On 11/27/2014 08:46 PM, Bala Manoharan wrote:
I agree the #defines are bit verbose in this patch but I tried to
create the hash defines to be compatible with the current syntax in
ODP header files.
Also we had a discussion today in ODP API scrum regarding including
/usr/include/linux/tcp.h
On 11/27/2014 07:20 PM, Ola Liljedahl wrote:
On 27 November 2014 at 17:10, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/27/2014 06:48 PM, Ola Liljedahl wrote:
This is simple and should in practice cover all situations. MAC
addresses are not of extremely variable size. In practice, only
On Wed, Nov 26, 2014 at 07:11:33PM +, Shmulik Ladkani wrote:
This is unnecessary for linux, as HW and OS take care of it.
Removing the validation allows to process frames arriving at virtual
interfaces (e.g. frames originated by host network stack).
Signed-off-by: Shmulik Ladkani
Hi,
I'm trying to exhaust a buffer pool but I suspect something is wrong here:
https://git.linaro.org/lng/odp.git/blob/945e8be94ea2779f55cc2fe91d3098361589bcb0:/platform/linux-generic/odp_buffer_pool.c#l456
Can you help me understand what is the expected behavior here? I get a
crash because
The existing buffer pool code has a number of issues. A patch to address
these will be posted this weekend after I get back from holiday travel.
Bill
On Thursday, November 27, 2014, Ciprian Barbu ciprian.ba...@linaro.org
wrote:
Hi,
I'm trying to exhaust a buffer pool but I suspect something
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
The new timer API as previously discussed. A simple API that supports both
system defined and user defined timeout buffers. Timer cancel returns whether
the operation succeeded or the timer had
ssize_t (and size_t) are only 4 bytes on 32-bit systems, so they won't fit
on those systems.
For return codes what's the problem with simple a int as we've used
elsewhere?
Bill
On Thu, Nov 27, 2014 at 3:18 PM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
On 27 November 2014 at 19:18, Maxim
Whatever we use, it needs to be able to reference the TCP header length
field.
On Thu, Nov 27, 2014 at 1:11 PM, Maxim Uvarov maxim.uva...@linaro.org
wrote:
On 11/27/2014 08:46 PM, Bala Manoharan wrote:
I agree the #defines are bit verbose in this patch but I tried to create
the hash defines
On Thu, Nov 27, 2014 at 12:51 PM, Maxim Uvarov maxim.uva...@linaro.org
wrote:
To have compatibility with other compilers define custom
booalen type for odp.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
Add odp_cunit_common.c for common cunit function and add the cunit
test for the api in odp_share_memory.h which include the new api implement
odp_shm_free
Signed-off-by: Yan Songming yan.songm...@linaro.org
---
v5 fix the problem which Jerin and Taras found.
v4 change the style of cunit test.
v3
Worrying about the performance of functions like promiscuous enabling is
misplaced since this routine would hardly be used in a performance path.
The real issue is the syntax. Has Petri defined what he wants for these
yet? This seems like a simply attribute on the API odp_pktio_t object.
Either
You cannot gracefully destroy a queue without some sort of quiesce function
that prohibits further enqueues to the queue while allowing items on the
queue to be dequeued until the queue is empty. To position for this, I'd
include a check that rejects the destroy attempt if the queue is not
empty.
Hi Stuart/Petri,
I couldn't find odp_pktio_recv/send in recent pktio design doc. Are we
deprecating these API's? Are we deprecating the burst mode that is
currently supported in pktio/l2fwd applications?.
Thanks,
Venkatesh.
___
lng-odp mailing list
61 matches
Mail list logo
