Some comments inline.
Alex
On 5 December 2014 at 17:45, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
On 12/05/2014 04:16 PM, Alexandru Badicioiu wrote:
Hi ,
what this patch wants to accomplish can be done with the actual API this
way : if the implementation really cannot reuse the
When I try to create a the repo https://git.linaro.org/lng/odp-d01.git.
I use this config in git:
[remote lng-d01]
url = ssh://g...@git.linaro.org/lng/odp-d01.git
fetch = +refs/heads/*:refs/remotes/lava/*
When I do git push, It says:
FATAL: W any lng/odp-d01 weilong.chen DENIED by fallthru
On Mon, Dec 8, 2014 at 11:22 AM, Weilong Chen weilong.c...@linaro.org wrote:
When I try to create a the repo https://git.linaro.org/lng/odp-d01.git.
I use this config in git:
[remote lng-d01]
url = ssh://g...@git.linaro.org/lng/odp-d01.git
fetch = +refs/heads/*:refs/remotes/lava/*
On 12/08/2014 10:58 AM, Alexandru Badicioiu wrote:
Some comments inline.
Alex
On 5 December 2014 at 17:45, Taras Kondratiuk
taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote:
On 12/05/2014 04:16 PM, Alexandru Badicioiu wrote:
Hi ,
what this patch wants
Hi,
My original todo list slides said:
“Move internal macros (marked with @internal) into odp_align_internal.h”
That line just didn’t get copied correctly to the delta doc…
-Petri
From: ext Mike Holmes [mailto:mike.hol...@linaro.org]
Sent: Friday, December 05, 2014 4:25 PM
To: Taras
On 5 December 2014 at 17:20, Maxim Uvarov maxim.uva...@linaro.org wrote:
Define API to get MAC address for specific packet i/o and
implement linux-generic version.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 12 +++
On 5 December 2014 at 17:11, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 12/01/2014 09:17 PM, Zoltan Kiss wrote:
On 01/12/14 16:15, Maxim Uvarov wrote:
Define API and implement promisc functions for linux-generic.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl
Sent: Monday, December 08, 2014 1:08 PM
To: Maxim Uvarov
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [PATCHv6 4/6] linux-generic:
On Friday 05 December 2014 10:16 PM, Taras Kondratiuk wrote:
On 12/05/2014 04:38 PM, Bala Manoharan wrote:
Hi,
In case of synchronous crypto operation the completion event is need
only in case of an error hence the application can check the return code
for failure and get info from completion
After typo/style corrections:
Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Maxim Uvarov
Sent: Friday, December 05, 2014 6:20 PM
To:
Moves static inline access functions in pktio module to header file.
This changes is required as these functions are accessed by classification
module
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
.../linux-generic/include/odp_packet_io_internal.h | 17 ++
Adds TCP header description struct odph_tcphdr_t in helper directory.
This structure is used for accessing TCP header information from the packet
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
V6: Incoporates review comments from Bill
helper/include/odph_tcp.h
The following features are implemented in this classification implementation:
* Attaches PMR, PMR_SET to a Pktio entry
* Adds classifier object to pktio entry
* Attaches CoS values for L2 and L3 QoS to a Pktio entry
* Selects ClassOfService for a packet based on PMR, L2 QoS and L3 QoS values
*
On 12/08/2014 01:30 PM, Bala wrote:
On Friday 05 December 2014 10:16 PM, Taras Kondratiuk wrote:
On 12/05/2014 04:38 PM, Bala Manoharan wrote:
Hi,
In case of synchronous crypto operation the completion event is need
only in case of an error hence the application can check the return code
for
commit f158b205eb531646 broke cross compiling.
Signed-off-by: Anders Roxell anders.rox...@linaro.org
---
platform/linux-generic/odp_time.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/platform/linux-generic/odp_time.c
b/platform/linux-generic/odp_time.c
index 1695f04..9eaacc0 100644
---
On 8 December 2014 at 13:11, Anders Roxell anders.rox...@linaro.org wrote:
commit f158b205eb531646 broke cross compiling.
Signed-off-by: Anders Roxell anders.rox...@linaro.org
---
platform/linux-generic/odp_time.c | 1 +
1 file changed, 1 insertion(+)
diff --git
-Original Message-
From: ext Victor Kamensky [mailto:victor.kamen...@linaro.org]
Sent: Friday, December 05, 2014 7:25 PM
To: Ola Liljedahl
Cc: Savolainen, Petri (NSN - FI/Espoo); lng-odp@lists.linaro.org
Subject: Re: [lng-odp] odp_ticketlock_trylock declared but not implemented
Define API and implement promisc functions for linux-generic.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
Reviewed-by: Petri Savolainen petri.savolai...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 22 ++
platform/linux-generic/odp_packet_io.c | 84
v7: - fix typos and loop dev selection;
v6:
- mac addr fun change from char* to void*;
- doxygen correct to promisc mode retval;
- check from -1 to = 0.
v5: - add lock entries;
- fix checks and loop0 - loop rename from previous version;
- git
Add cunit tests for new pktio api:
- MAC address get;
- Promisc mode set / test;
- MTU value set / get;
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/.gitignore | 3 +-
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 155
We need to add the following to odp/doc/doxygen.cfg
PROJECT_NUMBER = 0.4.0
In odp/configure.ac we need the following update
AC_INIT([OpenDataPlane], [0.4.0], [lng-odp@lists.linaro.org])
On 8 December 2014 at 10:10, Maxim Uvarov maxim.uva...@linaro.org wrote:
Signed-off-by: Maxim
On 8 December 2014 at 04:41, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
-Original Message-
From: ext Victor Kamensky [mailto:victor.kamen...@linaro.org]
Sent: Friday, December 05, 2014 7:25 PM
To: Ola Liljedahl
Cc: Savolainen, Petri (NSN - FI/Espoo);
Didn't review the implementation.
-Original Message-
From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp-
boun...@lists.linaro.org] On Behalf Of ext Bill Fischofer
Sent: Monday, December 08, 2014 1:24 AM
To: lng-odp@lists.linaro.org
Subject: [lng-odp] [RFC PATCH] RFC: Implement
Merged!
Maxim.
On 12/08/2014 07:27 PM, Mike Holmes wrote:
On 8 December 2014 at 11:25, Maxim Uvarov maxim.uva...@linaro.org
mailto:maxim.uva...@linaro.org wrote:
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
mailto:maxim.uva...@linaro.org
Reviewed-by: Mike Holmes
Bala and I had a hangout earlier to discuss his comments. See inline
responses for Petri's.
On Mon, Dec 8, 2014 at 10:38 AM, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
Didn't review the implementation.
-Original Message-
From:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
A new cunit test program test/validation/odp_timer.c for the updated timer API.
test/validation/.gitignore | 1 +
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
The timer API is updated according to
https://docs.google.com/a/linaro.org/document/d/1bfY_J8ecLJPsFTmYftb0NVmGnB9qkEc_NpcJ87yfaD8
A major change is that timers are allocated and freed separately
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v2 of this patch incorporates comments from Bala and Petri.
In particular:
- buf_size and buf_align in odp_buffer_pool_param_t are now uint32_t
- odp_buffer_pool_info_t has been changed to add the shm
- odp_buffer_pool_info() has been
This patch will need rework to be compatible with the buffer pool API
changes. Since the plan is for that to merge ahead of timers you can
rebase either before or after that happens. Latest buffer pool patch is
https://patches.linaro.org/42027/
On Mon, Dec 8, 2014 at 4:49 PM, Ola Liljedahl
29 matches
Mail list logo
