[lng-odp] [Bug 1203] New: Clang build now fails with _ODP_STATIC_ASSERT

2015-02-03 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1203 Bug ID: 1203 Summary: Clang build now fails with _ODP_STATIC_ASSERT Product: OpenDataPlane Version: 0.10 Hardware: Other OS: Linux Status: UNCONFIRMED

Re: [lng-odp] [PATCH v2 1/4] api: cpu: Added cpu.h

2015-02-03 Thread Savolainen, Petri (NSN - FI/Espoo)
Sorry about top posting … just cannot reply cleanly on HTML mails. Mike, I have seen same thing happening on your patches. On a patch series, one patch modifies a file in one direction and another patch modifies the same in other direction, but as long as the end result is OK - I have not

Re: [lng-odp] [PATCHv5 00/19] Add Strong Typing for ODP Abstract Types

2015-02-03 Thread Mike Holmes
I think we need to add unit tests for the new APIs introduced On 2 February 2015 at 23:44, Bill Fischofer bill.fischo...@linaro.org wrote: This patch series adds strong typing support for ODP abstract types. This prevents incorrect types from being used with ODP APIs. Misuse of types will

[lng-odp] classification tests scheduled queues

2015-02-03 Thread Radu-Andrei Bulie
Hi, I have a comment regarding the scheduling approach in the classification validation tests (this also can be extended to other tests which use the same pattern). The schedule function should be called in context of a data path thread that is bound to a known core (the same model as in pktio

[lng-odp] [PATCHv4 13/18] api: odp_schedule.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv4 16/18] api: odp_timer.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Documented API calls which are guaranteed to handle invalid/stale handles. Removed unnecessary warnings of undefined behavior. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org

[lng-odp] [PATCHv4 10/18] api: odp_packet_flags.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv4 15/18] api: odp_thread.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv4 18/18] api: odp_crypto.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv4 17/18] api: odp_cpumask.h: updated descriptions, added const

2015-02-03 Thread Ola Liljedahl
Updated function, parameter and return descriptions. Added const to some input parameters passed by reference. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/cpumask.h

[lng-odp] [PATCHv4 11/18] api: odp_packet_io.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] UberConference Reminder

2015-02-03 Thread UberConference
UberConference Reminder___ lng-odp mailing list lng-odp@lists.linaro.org http://lists.linaro.org/mailman/listinfo/lng-odp

[lng-odp] [PATCHv4 12/18] api: odp_queue.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/queue.h

[lng-odp] [PATCHv4 00/18] Cleanup return semantics and descriptions

2015-02-03 Thread Ola Liljedahl
Changes since version 3: Removed unnecessary braces from odp_cpumask.c in patch #1. Changes since version 2: Rebased, e.g. due to API restructuring. Split two patches, separating documentation updates from API changes. Reordered patches, all serious API changes are now contained in patches 1-4.

[lng-odp] [PATCHv4 03/18] api: odp_crypto.h: odp_hw_random_get(): return number of bytes written

2015-02-03 Thread Ola Liljedahl
odp_hw_random_get() takes output buffer size as input and returns number of bytes written (on success), 0 on failure. Updated the implementation. Updated all usages in example and test programs. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is

[lng-odp] [PATCHv4 01/18] api: odp_cpumask.h: odp_cpumask_to_str() return chars written or error

2015-02-03 Thread Ola Liljedahl
Add define ODP_CPUMASK_BUFSIZE for minimum output buffer size for odp_cpumask_to_str(). odp_cpumask_to_str() takes output buffer size as input and returns number of chars written (on success), 0 on failure. Updated the implementation. Updated all usages in example and test programs.

[lng-odp] [PATCHv4 02/18] api: odp_pktio.h: odp_pktio_mac_addr() return chars written or error

2015-02-03 Thread Ola Liljedahl
Added define ODP_PKTIO_MACADDRSIZE which specifies the recommended output buffer size for odp_pktio_mac_addr(). odp_pktio_mac_addr() takes output buffer size as input and returns number of chars written (on success), 0 on failure. Updated the implementation. Updated all usages in example and test

[lng-odp] [PATCHv4 07/18] api: odp_classification.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv4 09/18] api: odp_packet.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv4 05/18] api: odp_buffer.h: undefined behavior description

2015-02-03 Thread Ola Liljedahl
Documented API calls which are guaranteed to handle invalid/stale handles. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/buffer.h | 4 +++- 1 file changed, 3

[lng-odp] [PATCHv4 08/18] api: odp_init.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/init.h

[lng-odp] [PATCH] api: fix odp_version_api_str()

2015-02-03 Thread Maxim Uvarov
odp_version_api_str() has to be in API header while odp_version_impl_str() should be in linux-generic. That change fixes: https://bugs.linaro.org/show_bug.cgi?id=1194 Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- include/odp/api/version.h| 29

Re: [lng-odp] [PATCHv5 00/19] Add Strong Typing for ODP Abstract Types

2015-02-03 Thread Mike Holmes
Agreed on call to add tests in 1.1, taking API change now for 1.0 On 3 February 2015 at 09:55, Savolainen, Petri (NSN - FI/Espoo) petri.savolai...@nsn.com wrote: APIs OK. Reviewed-by: Petri Savolainen petri.savolai...@linaro.org -Original Message- From:

Re: [lng-odp] [PATCH v2 0/5] Add replaceable odp abort mechanism

2015-02-03 Thread Maxim Uvarov
Merged! Maxim. On 02/03/2015 03:17 PM, Taras Kondratiuk wrote: On 02/03/2015 01:35 PM, Mike Holmes wrote: v2 just splits the test out to its own executable, forcing an abort is a problem but the replace mechanism is tested Mike Holmes (5): api: odp_hints: Add ODP_NORETURN api: abort:

Re: [lng-odp] [PATCHv5 00/19] Add Strong Typing for ODP Abstract Types

2015-02-03 Thread Savolainen, Petri (NSN - FI/Espoo)
APIs OK. Reviewed-by: Petri Savolainen petri.savolai...@linaro.org -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- boun...@lists.linaro.org] On Behalf Of ext Bill Fischofer Sent: Tuesday, February 03, 2015 6:45 AM To: lng-odp@lists.linaro.org Subject:

Re: [lng-odp] [PATCH] api: packet_flags: Removed odp_packet_override_l4_chksum

2015-02-03 Thread Maxim Uvarov
Bill, you wanted to review that patch. Maxim. On 02/03/2015 04:13 PM, Petri Savolainen wrote: This is currently the only output side packet flag. It's removed now and re-defined later with all other output side control flags. Signed-off-by: Petri Savolainen petri.savolai...@linaro.org ---

Re: [lng-odp] [PATCH] api: odp_event.h: remove ODP_EVENT_TYPE_INVALID

2015-02-03 Thread Ola Liljedahl
On 3 February 2015 at 09:15, Savolainen, Petri (NSN - FI/Espoo) petri.savolai...@nsn.com wrote: -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl Sent: Monday, February 02, 2015 6:01 PM To:

Re: [lng-odp] [PATCH] api: odp_event.h: remove ODP_EVENT_TYPE_INVALID

2015-02-03 Thread Savolainen, Petri (NSN - FI/Espoo)
-Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl Sent: Monday, February 02, 2015 6:01 PM To: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH] api: odp_event.h: remove ODP_EVENT_TYPE_INVALID

[lng-odp] [PATCH v2] api: classification: pmr statistics counter API removal

2015-02-03 Thread bala . manoharan
From: Balasubramanian Manoharan bala.manoha...@linaro.org odp_pmr_match_count() API related to statistics count of PMR has been moved out of ODP 1.0 version and the same will be incorporated once an ODP level common statistics counter design has been achieved. Signed-off-by: Balasubramanian

Re: [lng-odp] [PATCH v2 1/4] api: cpu: Added cpu.h

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 01:07 PM, Ola Liljedahl wrote: On 3 February 2015 at 11:59, Petri Savolainen petri.savolai...@linaro.org wrote: This file contains cpu related API calls. The calls are renames from odp_thread_cpu() and odp_sys_cpu_count(). Signed-off-by: Petri Savolainen

Re: [lng-odp] [PATCH v2] api: classification: pmr statistics counter API removal

2015-02-03 Thread Mike Holmes
On 3 February 2015 at 03:42, bala.manoha...@linaro.org wrote: From: Balasubramanian Manoharan bala.manoha...@linaro.org odp_pmr_match_count() API related to statistics count of PMR has been moved out of ODP 1.0 version and the same will be incorporated once an ODP level common statistics

Re: [lng-odp] [PATCH v2 1/4] api: cpu: Added cpu.h

2015-02-03 Thread Savolainen, Petri (NSN - FI/Espoo)
-Original Message- From: ext Taras Kondratiuk [mailto:taras.kondrat...@linaro.org] Sent: Tuesday, February 03, 2015 1:19 PM To: Ola Liljedahl; Petri Savolainen Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [PATCH v2 1/4] api: cpu: Added cpu.h On 02/03/2015 01:07 PM, Ola

[lng-odp] [PATCH v2 1/5] api: odp_hints: Add ODP_NORETURN

2015-02-03 Thread Mike Holmes
Add the ability to mark a function as never returning to the caller. Signed-off-by: Mike Holmes mike.hol...@linaro.org --- include/odp/api/hints.h | 4 1 file changed, 4 insertions(+) diff --git a/include/odp/api/hints.h b/include/odp/api/hints.h index 7f04886..a7aa90e 100644 ---

[lng-odp] [PATCH v2 3/5] api: abort: use globaly stored abort function

2015-02-03 Thread Mike Holmes
Use the abort function stored in the global data structure. Signed-off-by: Mike Holmes mike.hol...@linaro.org --- include/odp/api/init.h | 3 +++ platform/linux-generic/include/odp_debug_internal.h | 4 ++-- platform/linux-generic/include/odp_internal.h | 1 +

[lng-odp] [PATCH v2 2/5] api: abort: add weak replacement for abort

2015-02-03 Thread Mike Holmes
Introduce replaceable abort function using weak symbols. Signed-off-by: Mike Holmes mike.hol...@linaro.org --- include/odp/api/init.h | 16 platform/linux-generic/include/odp_debug_internal.h | 4 ++-- platform/linux-generic/odp_weak.c

[lng-odp] [PATCH v2 4/5] api: init_global: allow abort fn to be overidden

2015-02-03 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- include/odp/api/init.h| 14 ++ platform/linux-generic/odp_init.c | 2 ++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/include/odp/api/init.h b/include/odp/api/init.h index c5b4e9b..6af032d 100644 ---

[lng-odp] [PATCH v2 5/5] validation: init: add test for replace abort

2015-02-03 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- test/validation/.gitignore | 1 + test/validation/Makefile.am | 5 ++-- test/validation/odp_init_abort.c | 62 3 files changed, 66 insertions(+), 2 deletions(-) create mode 100644

Re: [lng-odp] classification tests scheduled queues

2015-02-03 Thread Radu-Andrei Bulie
Hi, I think it's a good approach. One could see the functional test behavior using either poll or schedule on the classification path. -Original Message- From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] Sent: Tuesday, February 03, 2015 3:29 PM To: Bulie Radu-Andrei-B37577

Re: [lng-odp] [PATCHv5 00/19] Add Strong Typing for ODP Abstract Types

2015-02-03 Thread Bill Fischofer
That can be done as a separate patch as this one is large enough already. Three of them (odp_pool_to_u64(), odp_pktio_to_u64(), and odp_queue_to_u64()) are already exercised as part of the examples. These are trivial conversion APIs so I'm not worried about the linux-generic implementation of the

Re: [lng-odp] [PATCH v2] api: classification: pmr statistics counter API removal

2015-02-03 Thread Maxim Uvarov
Merged! Maxim. On 02/03/2015 02:17 PM, Mike Holmes wrote: On 3 February 2015 at 03:42, bala.manoha...@linaro.org mailto:bala.manoha...@linaro.org wrote: From: Balasubramanian Manoharan bala.manoha...@linaro.org mailto:bala.manoha...@linaro.org odp_pmr_match_count() API

Re: [lng-odp] [PATCHv4 6/6] validation: odp_timer.c: run at least one thread

2015-02-03 Thread Ola Liljedahl
On 3 February 2015 at 22:42, Anders Roxell anders.rox...@linaro.org wrote: On 2015-02-03 16:44, Ola Liljedahl wrote: Ensure we run at least one worker thread. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org Reviewed-by: Anders Roxell anders.rox...@linaro.org Fabulous! Have you reviewed

Re: [lng-odp] [PATCH v2 1/4] api: cpu: Added cpu.h

2015-02-03 Thread Bill Fischofer
My review simply says I'm happy with it. Others can NAK it if they choose. On Tue, Feb 3, 2015 at 3:54 PM, Anders Roxell anders.rox...@linaro.org wrote: On 2015-02-03 11:16, Bill Fischofer wrote: For this series: Reviewed-by: Bill Fischofer bill.fischo...@linaro.org On Tue, Feb 3,

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 11:50 PM, Bill Fischofer wrote: The changes here are to platform/linux-generic/include/odp/plat/type_types.h. This is where the strong typing is actually implemented for each ODP type in linux-generic. The converter functions are part of that implementation, and are also

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 11:57 PM, Ola Liljedahl wrote: The re-org has make it easier for the implementors of ODP. However, its a bit harder to follow the structure now maybe. static inline functions should go into: platform/linux-generic/include/odp/*.h and typedefs, defines, enums, and structs that

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Ola Liljedahl
On 3 February 2015 at 23:24, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 02/03/2015 11:57 PM, Ola Liljedahl wrote: The re-org has make it easier for the implementors of ODP. However, its a bit harder to follow the structure now maybe. static inline functions should go into:

[lng-odp] [PATCHv5 01/18] api: odp_cpumask.h: odp_cpumask_to_str() return chars written or error

2015-02-03 Thread Ola Liljedahl
Add define ODP_CPUMASK_BUFSIZE for minimum output buffer size for odp_cpumask_to_str(). odp_cpumask_to_str() takes output buffer size as input and returns number of chars written (on success), 0 on failure. Updated the implementation. Updated all usages in example and test programs.

[lng-odp] [PATCHv5 02/18] api: odp_pktio.h: odp_pktio_mac_addr() return chars written or error

2015-02-03 Thread Ola Liljedahl
Added define ODP_PKTIO_MACADDRSIZE which specifies the recommended output buffer size for odp_pktio_mac_addr(). odp_pktio_mac_addr() takes output buffer size as input and returns number of chars written (on success), 0 on failure. Updated the implementation. Updated all usages in example and test

[lng-odp] [PATCHv5 05/18] api: odp_buffer.h: undefined behavior description

2015-02-03 Thread Ola Liljedahl
Documented API calls which are guaranteed to handle invalid/stale handles. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/buffer.h | 4 +++- 1 file changed, 3

[lng-odp] [PATCHv5 12/18] api: odp_queue.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/queue.h

[lng-odp] [PATCHv5 10/18] api: odp_packet_flags.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv5 11/18] api: odp_packet_io.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv5 08/18] api: odp_init.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/init.h

[lng-odp] [PATCHv5 03/18] api: odp_crypto.h: odp_hw_random_get(): return number of bytes written

2015-02-03 Thread Ola Liljedahl
odp_hw_random_get() takes output buffer size as input and returns number of bytes written (on success), 0 on failure. Updated the implementation. Updated all usages in example and test programs. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is

Re: [lng-odp] [PATCH] api: odp_timer.h: move definitions to plat/timer_types.h

2015-02-03 Thread Bill Fischofer
We should consider making these strong types to be consistent with the rest of the ODP types. In linux-generic to do that you'd just change the current uint32_t typedefs to: typedef odp_handle_t odp_timer_t; typedef odp_handle_t odp_timeout_t; If there is a need to display odp_timer_t and

[lng-odp] [PATCHv4 5/6] validation: odp_timer.c: remove usage of perror/abort

2015-02-03 Thread Ola Liljedahl
Replace usage of perror and abort with CU_FAIL_FATAL in order for fatal errors not to disturb the overall validation flow. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv4 2/6] validation: odp_timer.c: avoid dereferencing ptr after NULL check

2015-02-03 Thread Ola Liljedahl
Don't dereference pointer after successful check for NULL as this makes Coverity complain. (Coverity CID 85397, https://bugs.linaro.org/show_bug.cgi?id=1056) Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of

[lng-odp] [PATCHv4 0/6] validation: odp_timer.c updates

2015-02-03 Thread Ola Liljedahl
Changes since version 3: Split patch #4 into new patch #6. Patch #1: Don't report late timeouts using CU_FAIL as this interferes with the cunit test framework. Just count and report the number of late timeouts. Patch #2: Don't dereference pointer after successful check for NULL as this makes

Re: [lng-odp] [PATCHv4 01/18] api: odp_cpumask.h: odp_cpumask_to_str() return chars written or error

2015-02-03 Thread Ola Liljedahl
On 3 February 2015 at 16:40, Savolainen, Petri (NSN - FI/Espoo) petri.savolai...@nsn.com wrote: -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl Sent: Tuesday, February 03, 2015 4:53 PM To:

Re: [lng-odp] [PATCH] api: packet_flags: Removed odp_packet_override_l4_chksum

2015-02-03 Thread Bill Fischofer
On Tue, Feb 3, 2015 at 7:13 AM, Petri Savolainen petri.savolai...@linaro.org wrote: This is currently the only output side packet flag. It's removed now and re-defined later with all other output side control flags. Signed-off-by: Petri Savolainen petri.savolai...@linaro.org Reviewed-by:

[lng-odp] [PATCHv4 4/6] validation: odp_timer.c: cunit cleanup

2015-02-03 Thread Ola Liljedahl
Use CU_ASSERT_FATAL instead of plain assert so to work better with the cunit test framework. Use LOG_DBG instead of printf. Remove some unnecessary printouts. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of

Re: [lng-odp] [PATCHv4 00/18] Cleanup return semantics and descriptions

2015-02-03 Thread Bill Fischofer
For this series: Reviewed-by: Bill Fischofer bill.fischo...@linaro.org On Tue, Feb 3, 2015 at 8:53 AM, Ola Liljedahl ola.liljed...@linaro.org wrote: Changes since version 3: Removed unnecessary braces from odp_cpumask.c in patch #1. Changes since version 2: Rebased, e.g. due to API

[lng-odp] [PATCHv5 14/18] api: odp_shared_memory.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Documented API calls which are guaranteed to handle invalid/stale handles. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is

[lng-odp] [PATCHv5 13/18] api: odp_schedule.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv5 07/18] api: odp_classification.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv5 18/18] api: odp_crypto.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv5 06/18] api: odp_byteorder.h: updated comment

2015-02-03 Thread Ola Liljedahl
Rephrased a comment for better language. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/byteorder.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[lng-odp] [PATCHv5 16/18] api: odp_timer.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. Documented API calls which are guaranteed to handle invalid/stale handles. Removed unnecessary warnings of undefined behavior. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org

[lng-odp] [PATCHv5 09/18] api: odp_packet.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv5 15/18] api: odp_thread.h: updated return descriptions

2015-02-03 Thread Ola Liljedahl
Updated doxygen descriptions, particularly the @return/@retval descriptions. No change of implementation necessary. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309)

[lng-odp] [PATCHv5 17/18] api: odp_cpumask.h: updated descriptions, added const

2015-02-03 Thread Ola Liljedahl
Updated function, parameter and return descriptions. Added const to some input parameters passed by reference. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) include/odp/api/cpumask.h

Re: [lng-odp] [PATCHv4 00/18] Cleanup return semantics and descriptions

2015-02-03 Thread Ola Liljedahl
On 3 February 2015 at 17:26, Bill Fischofer bill.fischo...@linaro.org wrote: For this series: Reviewed-by: Bill Fischofer bill.fischo...@linaro.org There is a version 5 now: Changes since version 4: Restored parameter names of odp_cpumask_to_str(), odp_pktio_mac_addr() and odp_hw_random_get().

[lng-odp] [PATCHv4 1/6] validation: odp_timer.c: avoid cunit warnings for late timeouts

2015-02-03 Thread Ola Liljedahl
Don't report late timeouts using CU_FAIL as this interferes with the cunit test framework. Just count and report the number of late timeouts. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org Suggested-by: Mike Holmes mike.hol...@linaro.org --- (This document/code contribution attached is

[lng-odp] [PATCHv4 6/6] validation: odp_timer.c: run at least one thread

2015-02-03 Thread Ola Liljedahl
Ensure we run at least one worker thread. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org --- (This document/code contribution attached is provided under the terms of agreement LES-LTM-21309) test/validation/odp_timer.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

Re: [lng-odp] [PATCH] api: fix odp_version_api_str()

2015-02-03 Thread Mike Holmes
On 3 February 2015 at 10:24, Maxim Uvarov maxim.uva...@linaro.org wrote: odp_version_api_str() has to be in API header while odp_version_impl_str() should be in linux-generic. That change fixes: https://bugs.linaro.org/show_bug.cgi?id=1194 Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org

[lng-odp] [PATCHv2] api: fix odp_version_api_str()

2015-02-03 Thread Maxim Uvarov
odp_version_api_str() has to be in API header while odp_version_impl_str() should be in linux-generic. That change fixes: https://bugs.linaro.org/show_bug.cgi?id=1194 Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org --- v2: remove version_types.h include/odp/api/version.h

Re: [lng-odp] [PATCHv4 00/18] Cleanup return semantics and descriptions

2015-02-03 Thread Bill Fischofer
Ok, I'll take a look at v5. Thanks. On Tue, Feb 3, 2015 at 10:49 AM, Ola Liljedahl ola.liljed...@linaro.org wrote: On 3 February 2015 at 17:26, Bill Fischofer bill.fischo...@linaro.org wrote: For this series: Reviewed-by: Bill Fischofer bill.fischo...@linaro.org There is a version 5

Re: [lng-odp] [PATCHv2] api: odp_event.h: remove ODP_EVENT_TYPE_INVALID

2015-02-03 Thread Maxim Uvarov
Merged, Thanks. On 02/03/2015 02:36 PM, Savolainen, Petri (NSN - FI/Espoo) wrote: Reviewed-by: Petri Savolainen petri.savolai...@linaro.org -Original Message- From: lng-odp-boun...@lists.linaro.org [mailto:lng-odp- boun...@lists.linaro.org] On Behalf Of ext Ola Liljedahl Sent:

Re: [lng-odp] [PATCH v2 1/3] api: pool: Added packet pool parameters

2015-02-03 Thread Ola Liljedahl
On 3 February 2015 at 13:59, Petri Savolainen petri.savolai...@linaro.org wrote: Completed odp_pool_param_t definition with packet pool parameters. Parameter definition is close to what we are using already. * seg_len: Defines minimum segment buffer length. With this parameter user

Re: [lng-odp] [PATCH 2/2] api: random: Renamed odp_hw_random_get

2015-02-03 Thread Ola Liljedahl
On 3 February 2015 at 14:44, Petri Savolainen petri.savolai...@linaro.org wrote: Renamed odp_hw_random_get() to odp_random_data(). Random number API is now separated from crypto API. Why is this separation desired? Cryptographically strong random number generation can be considered a natural

Re: [lng-odp] [PATCH v2] validation: init: split cases into executables

2015-02-03 Thread Maxim Uvarov
On 02/03/2015 04:15 PM, Taras Kondratiuk wrote: On 02/03/2015 03:12 PM, Maxim Uvarov wrote: Patch applied with small correction. You deleted odp_classification from the list which is obvious error, no need to do that. Hmm. Where is it removed? Skip that message please. I think I wrongly

Re: [lng-odp] classification tests scheduled queues

2015-02-03 Thread Ola Liljedahl
Wouldn't it be better to modify the validation program to make sure scheduling is always performed on a data path thread? We want to promote usage of the scheduler, HW-accelerated classification and scheduling are some of the differentiators of ODP. On 3 February 2015 at 13:53, Radu-Andrei Bulie

[lng-odp] [PATCH 2/2] api: random: Renamed odp_hw_random_get

2015-02-03 Thread Petri Savolainen
Renamed odp_hw_random_get() to odp_random_data(). Random number API is now separated from crypto API. Signed-off-by: Petri Savolainen petri.savolai...@linaro.org --- example/ipsec/odp_ipsec_cache.c | 2 +- include/odp/api/crypto.h | 14 --

Re: [lng-odp] [PATCH v2] validation: init: split cases into executables

2015-02-03 Thread Maxim Uvarov
Patch applied with small correction. You deleted odp_classification from the list which is obvious error, no need to do that. Thanks, Maxim. On 02/03/2015 01:02 AM, Mike Holmes wrote: init_global can only be called once per executable, split the init_global testing into multiple

Re: [lng-odp] classification tests scheduled queues

2015-02-03 Thread Jerin Jacob
On Tue, Feb 03, 2015 at 01:07:15PM +, Radu-Andrei Bulie wrote: As I said in my comment we could use two approaches.(poll or data path thread). How about the scheme(#define IPSEC_POLL_QUEUES) followed in existing example/ipsec to abstract polled vs schedule mode ? The one you mentioned

[lng-odp] [PATCH 1/2] api: random: Added random.h

2015-02-03 Thread Petri Savolainen
Added random number API. The only API call is moved and renamed from crypto.h. Signed-off-by: Petri Savolainen petri.savolai...@linaro.org --- include/odp.h | 1 + include/odp/api/random.h| 48 +

[lng-odp] [PATCH v2 2/3] api: pool: Move from buffer to packet pool parameters

2015-02-03 Thread Petri Savolainen
Change implementation, examples and test to use the new packet pool parameters with ODP_POOL_PACKET type pools (instead of using buffer pool parameters). Signed-off-by: Petri Savolainen petri.savolai...@linaro.org --- example/generator/odp_generator.c | 8 ++---

[lng-odp] [PATCH v2 3/3] api: config: Renamed ODP_CONFIG_PACKET_BUF_LEN_MIN

2015-02-03 Thread Petri Savolainen
Renamed ODP_CONFIG_PACKET_BUF_LEN_MIN to ODP_CONFIG_PACKET_SEG_LEN_MIN. The packet pool parameter pkt.seg_len is rounded up into this value. Added ODP_CONFIG_PACKET_SEG_LEN_MAX to define the maximum segment length supported by the implementation. This is the maximum valid value for pkt.seg_len.

[lng-odp] [PATCH] api: packet_flags: Removed odp_packet_override_l4_chksum

2015-02-03 Thread Petri Savolainen
This is currently the only output side packet flag. It's removed now and re-defined later with all other output side control flags. Signed-off-by: Petri Savolainen petri.savolai...@linaro.org --- include/odp/api/packet_flags.h| 7 --- platform/linux-generic/odp_packet_flags.c | 7

Re: [lng-odp] [PATCH v2] validation: init: split cases into executables

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 03:12 PM, Maxim Uvarov wrote: Patch applied with small correction. You deleted odp_classification from the list which is obvious error, no need to do that. Hmm. Where is it removed? ___ lng-odp mailing list lng-odp@lists.linaro.org

Re: [lng-odp] [PATCH v2 0/5] Add replaceable odp abort mechanism

2015-02-03 Thread Taras Kondratiuk
On 02/03/2015 01:35 PM, Mike Holmes wrote: v2 just splits the test out to its own executable, forcing an abort is a problem but the replace mechanism is tested Mike Holmes (5): api: odp_hints: Add ODP_NORETURN api: abort: add weak replacement for abort api: abort: use globaly stored

Re: [lng-odp] [PATCH 2/2] api: random: Renamed odp_hw_random_get

2015-02-03 Thread Bill Fischofer
This patch should require Robbie's review since these APIs originated from the crypto design sprint. I agree with Ola that it is unnecessary. The reason hw is specified here is that cryptographically you have two different types of randoms. HW randoms are used for seed values which is why in

Re: [lng-odp] [PATCH 1/2] api: random: Added random.h

2015-02-03 Thread Bill Fischofer
See previous comment. Not relevant to v1.0 and in any event should require Robbie's review. On Tue, Feb 3, 2015 at 7:44 AM, Petri Savolainen petri.savolai...@linaro.org wrote: Added random number API. The only API call is moved and renamed from crypto.h. Signed-off-by: Petri Savolainen

Re: [lng-odp] [PATCH odp-ovs 0/5] odp-ovs fixes ODP v0.8

2015-02-03 Thread Zoltan Kiss
Acked and merged: Zoltan Kiss zoltan.k...@linaro.org On 22/01/15 16:11, Ciprian Barbu wrote: This patch series contains some fixes and workarounds for some problems found while testing odp-ovs on keystone2 with ODP v0.8. First two patches are required because of the changes introduced in

Re: [lng-odp] [PATCH odp-ovs 0/5] odp-ovs fixes ODP v0.8

2015-02-03 Thread Mike Holmes
On 3 February 2015 at 14:18, Zoltan Kiss zoltan.k...@linaro.org wrote: Acked and merged: Zoltan Kiss zoltan.k...@linaro.org On 22/01/15 16:11, Ciprian Barbu wrote: This patch series contains some fixes and workarounds for some problems found while testing odp-ovs on keystone2 with ODP

Re: [lng-odp] [PATCH v2 1/4] api: cpu: Added cpu.h

2015-02-03 Thread Mike Holmes
On 3 February 2015 at 17:10, Bill Fischofer bill.fischo...@linaro.org wrote: My review simply says I'm happy with it. Others can NAK it if they choose. On Tue, Feb 3, 2015 at 3:54 PM, Anders Roxell anders.rox...@linaro.org wrote: On 2015-02-03 11:16, Bill Fischofer wrote: For this

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Taras Kondratiuk
On 02/04/2015 12:42 AM, Mike Holmes wrote: On 3 February 2015 at 17:16, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: On 02/03/2015 11:50 PM, Bill Fischofer wrote: The changes here are to

Re: [lng-odp] [PATCHv2] api: fix odp_version_api_str()

2015-02-03 Thread Anders Roxell
On 2015-02-03 11:28, Mike Holmes wrote: On 3 February 2015 at 11:12, Maxim Uvarov maxim.uva...@linaro.org wrote: odp_version_api_str() has to be in API header while odp_version_impl_str() should be in linux-generic. That change fixes: https://bugs.linaro.org/show_bug.cgi?id=1194

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Mike Holmes
On 3 February 2015 at 17:28, Ola Liljedahl ola.liljed...@linaro.org wrote: On 3 February 2015 at 23:24, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 02/03/2015 11:57 PM, Ola Liljedahl wrote: The re-org has make it easier for the implementors of ODP. However, its a bit harder to

Re: [lng-odp] [PATCHv5 11/19] linux-generic: buffers: add strong typing support

2015-02-03 Thread Mike Holmes
On 3 February 2015 at 17:16, Taras Kondratiuk taras.kondrat...@linaro.org wrote: On 02/03/2015 11:50 PM, Bill Fischofer wrote: The changes here are to platform/linux-generic/include/odp/plat/type_types.h. This is where the strong typing is actually implemented for each ODP type in

Re: [lng-odp] [PATCHv4 6/6] validation: odp_timer.c: run at least one thread

2015-02-03 Thread Anders Roxell
On 2015-02-03 23:09, Ola Liljedahl wrote: On 3 February 2015 at 22:42, Anders Roxell anders.rox...@linaro.org wrote: On 2015-02-03 16:44, Ola Liljedahl wrote: Ensure we run at least one worker thread. Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org Reviewed-by: Anders Roxell

  1   2   >