[lng-odp] [PATCH] validation: timer: save expected expiration tick only on success

2015-06-05 Thread Jerin Jacob
otherwise tt[i].tick in handle_tmo will be a wrong value in case timer set failed due to ODP_TIMER_NOEVENT(failed to cancel the outstanding timer). some hardware timer implementations needs at least two ticks gap between current tick and future tick to cancel the outstanding active timer.

Re: [lng-odp] [API-NEXT PATCH] api: codespell: correct spelling

2015-06-05 Thread Maxim Uvarov
why this is for api-next? Patch fixes only spelling in doxygen description. It does not modify API. It has to go to master. Maxim. On 06/05/15 06:17, Bill Fischofer wrote: On Thu, Jun 4, 2015 at 12:18 PM, Mike Holmes mike.hol...@linaro.org mailto:mike.hol...@linaro.org wrote:

Re: [lng-odp] [PATCH 1/2] codespell: fix spelling

2015-06-05 Thread Maxim Uvarov
Merged. Maxim. On 06/04/15 20:42, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org --- configure.ac| 2 +- doc/api_guide_lines.dox | 4 ++-- example/generator/odp_generator.c | 2 +- example/ipsec/odp_ipsec_sa_db.h | 4 ++--

[lng-odp] [PATCH] configure: remove extra result message

2015-06-05 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 89b0846..ed74b4a 100644 --- a/configure.ac +++ b/configure.ac @@ -229,7 +229,7 @@

[lng-odp] [API-NEXT PATCH v2 2/3] api: cpumask: added default masks

2015-06-05 Thread Petri Savolainen
Added default cpumask functions for worker and control threads. These will replace odph_linux_cpumask_default() helper. CPU masks and IDs are system specific, API is generic. Signed-off-by: Petri Savolainen petri.savolai...@nokia.com --- include/odp/api/cpumask.h| 24

[lng-odp] [API-NEXT PATCH v2 3/3] api: helper: deleted odph_linux_cpumask_default

2015-06-05 Thread Petri Savolainen
The linux specific helper was replaced by default cpumask calls (odp_cpumask_def_worker()) in the cpumask API. Signed-off-by: Petri Savolainen petri.savolai...@nokia.com --- example/classifier/odp_classifier.c | 7 ++- example/generator/odp_generator.c | 7 ++-

[lng-odp] [API-NEXT PATCH v2 9/9] queue: handle return value of odp_queue_enq_multi()

2015-06-05 Thread Zoltan Kiss
Unsent packet has to be released. If the event type is obvious from the context, use directly the relevant release functions, otherwise odp_event(free). Wider error handling is attempted, but this patch can't fix all the flaws in the many calling functions of odp_queue_enq() Signed-off-by: Zoltan

[lng-odp] [Bug 1617] New: Build fails on api-next branch

2015-06-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1617 Bug ID: 1617 Summary: Build fails on api-next branch Product: OpenDataPlane Version: 1.0 Hardware: Other OS: Linux Status: UNCONFIRMED Severity: enhancement

[lng-odp] [API-NEXT PATCH v2 1/3] api: cpumask: added cpumask_setall

2015-06-05 Thread Petri Savolainen
The call sets all possible CPUs in the mask. It's system specific which CPUs are actually available to the application. Signed-off-by: Petri Savolainen petri.savolai...@nokia.com --- include/odp/api/cpumask.h| 15 +-- platform/linux-generic/odp_cpumask.c | 8 2

[lng-odp] [API-NEXT PATCH v2 0/9]

2015-06-05 Thread Zoltan Kiss
This series clarifies what happens when not all packets were sent, whether in odp_pktio_send() or odp_queue_enq*(). It also introduces odp_event_free() to make it easier the release of an event with not obvious type. It also fixes the many places in the examples and tests where this issue were not

[lng-odp] [Bug 1617] Build fails on api-next branch

2015-06-05 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1617 --- Comment #1 from Petri Savolainen petri.savolai...@linaro.org --- Also Git log documents a merge conflict commit 0da7ce4d558dfe63e9f42ace43e61b7fcdd56b09 Merge: 03181a7 1da1a0d Author: Maxim Uvarov maxim.uva...@linaro.org Date: Thu Jun 4 20:14:58

[lng-odp] [API-NEXT PATCH v2 4/9] event: define odp_event_free()

2015-06-05 Thread Zoltan Kiss
We need a convenient function which calls the right type-depending free() function. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- include/odp/api/event.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/odp/api/event.h b/include/odp/api/event.h index

[lng-odp] [API-NEXT PATCH v2 6/9] odp_timer_test: remove redundant free function

2015-06-05 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- example/timer/odp_timer_test.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/example/timer/odp_timer_test.c b/example/timer/odp_timer_test.c index 5e4306e..735c4c6 100644 ---

[lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

2015-06-05 Thread Nicolas Morey-Chaisemartin
Signed-off-by: Nicolas Morey-Chaisemartin nmo...@kalray.eu --- doc/doxygen.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg index 6283387..213a903 100644 --- a/doc/doxygen.cfg +++ b/doc/doxygen.cfg @@ -13,7 +13,6 @@ WARN_NO_PARAMDOC = YES INPUT =

[lng-odp] [API-NEXT PATCH v2 2/9] packet_socket: do not release packets in odp_pktio_send

2015-06-05 Thread Zoltan Kiss
It happens with ODP_PKTIO_TYPE_SOCKET_BASIC. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- platform/linux-generic/odp_packet_socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/odp_packet_socket.c

[lng-odp] [API-NEXT PATCH v2 8/9] queue: handle return value of odp_queue_enq()

2015-06-05 Thread Zoltan Kiss
Unsent packet has to be released. If the event type is obvious from the context, use directly the relevant release functions, otherwise odp_event(free). Wider error handling is attempted, but this patch can't fix all the flaws in the many calling functions of odp_queue_enq() Signed-off-by: Zoltan

Re: [lng-odp] [API-NEXT PATCH v2 7/9] event: replace complicated buffer releases with odp_event_free()

2015-06-05 Thread Bill Fischofer
This patch doesn't apply to me to either the tip or to the api-next branch of odp.git On Fri, Jun 5, 2015 at 6:53 AM, Zoltan Kiss zoltan.k...@linaro.org wrote: Instead of converting types let odp_event_free() to do the right thing. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org ---

Re: [lng-odp] [API-NEXT PATCH v2 7/9] event: replace complicated buffer releases with odp_event_free()

2015-06-05 Thread Zoltan Kiss
I've fixed that in a new series On 05/06/15 16:40, Bill Fischofer wrote: This patch doesn't apply to me to either the tip or to the api-next branch of odp.git On Fri, Jun 5, 2015 at 6:53 AM, Zoltan Kiss zoltan.k...@linaro.org mailto:zoltan.k...@linaro.org wrote: Instead of converting

Re: [lng-odp] [PATCHv3 0/8] pktio test move to platform side

2015-06-05 Thread Stuart Haslam
On Thu, Jun 04, 2015 at 08:06:52PM +0200, Christophe Milard wrote: since v2: -history rewritten regarding PRE_LDADD -missing .gitignore added -correction for finding pktio_main in different cases -patch 8 added, removing obsolete test environment variables in validation For the series

[lng-odp] [API-NEXT PATCH v3 1/9] api: packet_io: clarify what happens when not all packets are sent

2015-06-05 Thread Zoltan Kiss
Currently our examples are not handling this situation as well. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- include/odp/api/packet_io.h | 4 +++- include/odp/api/queue.h | 7 +-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/include/odp/api/packet_io.h

[lng-odp] [API-NEXT PATCH v3 2/9] packet_socket: do not release packets in odp_pktio_send

2015-06-05 Thread Zoltan Kiss
It happens with ODP_PKTIO_TYPE_SOCKET_BASIC. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- platform/linux-generic/odp_packet_socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/odp_packet_socket.c

Re: [lng-odp] [API-NEXT PATCH v2 1/9] packet_io: clarify what happens when not all packets are sent

2015-06-05 Thread Zoltan Kiss
I've fixed that in a new series On 05/06/15 17:27, Mike Holmes wrote: This touches the api b/include/odp/api/packet_io.h so the subject should add api: like this api: packet_io: clarify what happens when not all packets are sent Generally for ODP the approximate path to the code is in the

Re: [lng-odp] [API-NEXT PATCH v3 0/9] Handle unsent packets

2015-06-05 Thread Bill Fischofer
This series applies and builds fine, however with check-odp I'm seeing consistent failures on the odp_pktio tests. I double checked and am seeing the same with the base odp.git code so not sure what changed (don't think these patches really changed anything in that regard). On Fri, Jun 5, 2015

[lng-odp] [API-NEXT PATCH v3 5/9] event: implement odp_event_free()

2015-06-05 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- platform/linux-generic/odp_event.c | 24 1 file changed, 24 insertions(+) diff --git a/platform/linux-generic/odp_event.c b/platform/linux-generic/odp_event.c index 17f4f43..e93dfca 100644 ---

[lng-odp] [API-NEXT PATCH v3 6/9] odp_timer_test: remove redundant free function

2015-06-05 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- example/timer/odp_timer_test.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/example/timer/odp_timer_test.c b/example/timer/odp_timer_test.c index 5e4306e..735c4c6 100644 ---

[lng-odp] [API-NEXT PATCH v3 4/9] api: event: define odp_event_free()

2015-06-05 Thread Zoltan Kiss
We need a convenient function which calls the right type-depending free() function. Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- include/odp/api/event.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/odp/api/event.h b/include/odp/api/event.h index

[lng-odp] [API-NEXT PATCH v3 3/9] packet_io: release unsent packets after odp_pktio_send()

2015-06-05 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- example/packet/odp_pktio.c | 10 +- test/performance/odp_l2fwd.c | 12 ++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/example/packet/odp_pktio.c b/example/packet/odp_pktio.c index f08d9f4..0b4a8f1 100644

[lng-odp] [API-NEXT PATCH v3 0/9] Handle unsent packets

2015-06-05 Thread Zoltan Kiss
This series clarifies what happens when not all packets were sent, whether in odp_pktio_send() or odp_queue_enq*(). It also introduces odp_event_free() to make it easier the release of an event with not obvious type. It also fixes the many places in the examples and tests where this issue were not

[lng-odp] [API-NEXT PATCH v3 8/9] queue: handle return value of odp_queue_enq()

2015-06-05 Thread Zoltan Kiss
Unsent packet has to be released. If the event type is obvious from the context, use directly the relevant release functions, otherwise odp_event(free). Wider error handling is attempted, but this patch can't fix all the flaws in the many calling functions of odp_queue_enq() Signed-off-by: Zoltan

[lng-odp] [API-NEXT PATCH v3 9/9] queue: handle return value of odp_queue_enq_multi()

2015-06-05 Thread Zoltan Kiss
Unsent packet has to be released. If the event type is obvious from the context, use directly the relevant release functions, otherwise odp_event(free). Wider error handling is attempted, but this patch can't fix all the flaws in the many calling functions of odp_queue_enq() Signed-off-by: Zoltan

Re: [lng-odp] [API-NEXT PATCH v2 1/9] packet_io: clarify what happens when not all packets are sent

2015-06-05 Thread Mike Holmes
This touches the api b/include/odp/api/packet_io.h so the subject should add api: like this api: packet_io: clarify what happens when not all packets are sent Generally for ODP the approximate path to the code is in the subject include/odp/api/packet_io.h becomes include/odp/api -- api: then

Re: [lng-odp] [API-NEXT PATCH] api: codespell: correct spelling

2015-06-05 Thread Mike Holmes
On 5 June 2015 at 04:26, Maxim Uvarov maxim.uva...@linaro.org wrote: why this is for api-next? Patch fixes only spelling in doxygen description. It does not modify API. It has to go to master. All changes in the include directory go into api-next, every time we try a short cut we open

Re: [lng-odp] [API-NEXT PATCH] api: codespell: correct spelling

2015-06-05 Thread Maxim Uvarov
OK. Merged, Maxim. On 06/05/15 13:52, Mike Holmes wrote: On 5 June 2015 at 04:26, Maxim Uvarov maxim.uva...@linaro.org mailto:maxim.uva...@linaro.org wrote: why this is for api-next? Patch fixes only spelling in doxygen description. It does not modify API. It has to go to

[lng-odp] [API-NEXT PATCH v2 5/9] event: implement odp_event_free()

2015-06-05 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- platform/linux-generic/odp_event.c | 24 1 file changed, 24 insertions(+) diff --git a/platform/linux-generic/odp_event.c b/platform/linux-generic/odp_event.c index 17f4f43..e93dfca 100644 ---

[lng-odp] [API-NEXT PATCH v2 3/9] packet_io: release unsent packets after odp_pktio_send()

2015-06-05 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss zoltan.k...@linaro.org --- example/packet/odp_pktio.c | 10 +- test/performance/odp_l2fwd.c | 12 ++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/example/packet/odp_pktio.c b/example/packet/odp_pktio.c index f08d9f4..0b4a8f1 100644

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

2015-06-05 Thread Mike Holmes
This works for linux-generic, but derived platforms such as odp-dpdk depend on this link back to linux-generic becasue they inherit from it. Having this in linux-generic makes it simpler for the derived works, but I could also see the argument that it should be removed in linux-generic and added

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

2015-06-05 Thread Bill Fischofer
The linux-generic platform is indeed used as a base class however given this it would seem that the include order should be reversed so that $(WITH_PLATFORM) is first. This would have the effect of allowing it to override any linux-generic include files of the same name. On Fri, Jun 5, 2015 at